olde_code_finder 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 024cfb48a1a1c3d945b162387c8ddc55047361e1
-  data.tar.gz: 3a42572139ec44e254c1f61adcadd1b9f9fe17ee
+  metadata.gz: c120f362e2baec2817818015fc8018335efbffd9
+  data.tar.gz: ea8381dd41766942e9c4eb6404e20e1cc6c0055f
 SHA512:
-  metadata.gz: 76cb36fb48b903b9e6be35477650a4f9fb523294e42f3a1d9b0d4206b14de626e5351a033a174ae9aeadc793fcd1804fbbedc3583129f59c4bc54a1ffbd41376
-  data.tar.gz: 5a136df3f5b3a37728b7668437559f1514907d76071c671be54cd11807c1b345c4a1a7ea48ade7f6e9eb00b7eef2e7be8c59f7e862a03ffef35568b4fbeae193
+  metadata.gz: 8a767acc5f4b4052efe0b0d273de3fdc6b77711917b430d32c3f0c6c95ba54512fde9ed7817461bf735f495729f302b3a755beb09280835385c44923563ec07a
+  data.tar.gz: 6c73c453675c6151bfdea4dc28d9214ed97747b155956e6829b20427564069b8ef96e3c92619963009191cc2cd26636314715ca815c14f6089beefdd8f7cf5d6

data/CHANGELOG.md

@@ -1,2 +1,5 @@
-??, 2014: 0.0.1
+Sep 20, 2014: 0.0.2
+New task to support find old code by date, not by authors - thanks to Jonathan Rochkind for the idea!
+
+Sep 17, 2014: 0.0.1
 Initial release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    olde_code_finder (0.0.1)
+    olde_code_finder (0.0.2)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -1,7 +1,8 @@
 # OldeCodeFinder
 
-OldeCodeFinder finds files which were mostly written by a particular person.  So if Fred left the company 3 years ago,
-files which consist mostly of lines which were written by him made be worth revisiting.
+OldeCodeFinder finds old code.  This means files which are largely older than a specific date.
+
+It can also find files which were mostly written by a particular person.  So if Fred left the company 3 years ago, files which consist mostly of lines which were written by him may be worth revisiting.
 
 ## Installation
 
@@ -25,28 +26,32 @@ Or install it yourself as:
 
 See if more than 80% of `app/models/foo.rb` was written by Benjamin Franklin:
 
-    bundle exec rake olde_code_finder:find['app/models/foo.rb','Benjamin Franklin','80']
+    bundle exec rake olde_code_finder:find_by_author['app/models/foo.rb','Benjamin Franklin','80']
 
 Or you can use a glob:
 
-    bundle exec rake olde_code_finder:find['app/models/*.rb','Benjamin Franklin','80']
+    bundle exec rake olde_code_finder:find_by_author['app/models/*.rb','Benjamin Franklin','80']
 
 Or you can specify a lower percentage threshold:
 
-    bundle exec rake olde_code_finder:find['app/models/*.rb','Benjamin Franklin','60']
+    bundle exec rake olde_code_finder:find_by_author['app/models/*.rb','Benjamin Franklin','60']
 
 The author name is a regex, so this will find 'Benjamin Franklin' as well as 'Ben Franklin':
 
-    bundle exec rake olde_code_finder:find['app/models/*.rb','Frank','80']
+    bundle exec rake olde_code_finder:find_by_author['app/models/*.rb','Frank','80']
+
+Or you can run a different task and find code older than a certain date instead:    
+
+    bundle exec rake olde_code_finder:find_by_date['app/models/*.rb','4 years','80']
 
 The output will be a list of files that meet the criteria:
 
-    foo> $ bundle exec rake olde_code_finder:find['app/models/*.rb','Benjamin Franklin','80']
+    foo> $ bundle exec rake olde_code_finder:find_by_author['app/models/*.rb','Benjamin Franklin','80']
     More than 80% of app/models/foobar.rb was written by Benjamin Franklin
 
 ## How does it work?
 
-It uses `git blame` to see who last touched each line of a file.
+It uses `git blame` to see who last touched each line of a file and when.
 
 ## Contributing
 

data/lib/olde_code_finder/finder.rb

@@ -0,0 +1,37 @@
+require 'date'
+
+module OldeCodeFinder
+  class Finder
+
+    attr_accessor :file, :pctg
+
+    def initialize(file, pctg)
+      @file = file
+      @pctg = pctg
+    end
+
+    def check_by_author(author)
+      total_lines = git_blame_output.size
+      author_lines = git_blame_output.grep(/#{author}/).size
+      if (author_lines / total_lines.to_f) > (pctg.to_f / 100.0)
+        puts "More than #{pctg}% of #{file} was written by #{author}"
+      end
+    end
+
+    def check_by_date(date_string)
+      years_ago = date_string.match(/^(\d+)/)[1].to_i
+      date_threshold = (Date.today - (years_ago*365))
+      total_lines = git_blame_output.size
+      older_lines = git_blame_output.select {|line| Date.strptime(line.match(/.*(\d{4}-\d{2}-\d{2})/)[1]) < date_threshold }.size
+      if (older_lines / total_lines.to_f) > (pctg.to_f / 100.0)
+        puts "More than #{pctg}% of #{file} was written more than #{years_ago} years ago"
+      end
+    end
+
+    private
+
+    def git_blame_output
+      @git_blame_output ||= `git blame --date=short #{file}`.split("\n")
+    end
+  end
+end

data/lib/olde_code_finder/tasks.rb

@@ -1,19 +1,16 @@
 namespace :olde_code_finder do
 
-  def checkit(file, author, pctg)
-    blame_output = `git blame #{file}`.split("\n")
-    total_lines = blame_output.size
-    author_lines = blame_output.grep(/#{author}/).size
-    if (author_lines / total_lines.to_f) > (pctg.to_f / 100.0)
-      puts "More than #{pctg}% of #{file} was written by #{author}"
+  desc "Find code that's mostly by a particular person"
+  task :find_by_author, [:glob, :author, :pctg] => :environment do |task, args|
+    Dir[args[:glob]].each do |file|
+      OldeCodeFinder::Finder.new(file, args[:pctg]).check_by_author(args[:author])
     end
   end
 
-  # e.g., bundle exec rake olde_code_finder:find['app/models/partner*','Ben Franklin','80']
-  desc "Find old code by a particular person"
-  task :find, [:glob, :author, :pctg] => :environment do |task, args|
+  desc "Find code older than a particular date"
+  task :find_by_date, [:glob, :date_string, :pctg] => :environment do |task, args|
     Dir[args[:glob]].each do |file|
-      checkit(file, args[:author], args[:pctg])
+      OldeCodeFinder::Finder.new(file, args[:pctg]).check_by_date(args[:date_string])
     end
   end
 end

data/lib/olde_code_finder/version.rb

@@ -1,3 +1,3 @@
 module OldeCodeFinder
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/olde_code_finder.rb

@@ -1,2 +1,3 @@
 require 'olde_code_finder/version'
-require 'olde_code_finder/tasks'
+require 'olde_code_finder/tasks'
+require 'olde_code_finder/finder'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: olde_code_finder
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Tom Copeland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-18 00:00:00.000000000 Z
+date: 2014-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -53,6 +53,7 @@ files:
 - README.md
 - Rakefile
 - lib/olde_code_finder.rb
+- lib/olde_code_finder/finder.rb
 - lib/olde_code_finder/tasks.rb
 - lib/olde_code_finder/version.rb
 - olde_code_finder.gemspec