okcomputer 0.7.1 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6156e73e1c89ea69f5fabf39f4de0fb1dd1c1cdd
-  data.tar.gz: d2b95792fb610387123fc0e2959c032fe5c79b9a
+  metadata.gz: 6fed0ca2f50d8a090b2264bd27f7908d7263b68b
+  data.tar.gz: f2ccdd2c93336ee08c8e1195be27e79679995659
 SHA512:
-  metadata.gz: f90e47d7333941a0338d75f4e9d7f33653a47c3941b9abf03b820079ae013aa8ba9c5685d2289f2411313d0727ca0f11e8933589061ce22acec19513ff84ab96
-  data.tar.gz: 7b9a87257b583e127ace648920630a82bde370c26eab12bfb50135ba93f6e14b7ffb2db1ac6eb53ce8cfe4e1f9ff3d10be4f9ac9460a5991446f0f424802d46b
+  metadata.gz: 3989f82168e393cfbe1baaaaad2ecfe6f393ec1c85585e44a87576b485e9b08c7e149b0a8df85af8a43868c0cf05b1baa59fdd4ac3f177ab2ccd775627561a3d
+  data.tar.gz: 8e13747aba25230218b07627f16880d37cbad822e71f07501c1178a74db1f7762b11b538395b4fc5483204916911b341b5315d40b2fb48507df6a60fce9b347e

data/README.markdown

@@ -173,10 +173,8 @@ example:
 #### Deprecation of Check#call
 
 Versions before 0.2.0 implemented a "#call" method which returned the message.
-This has been deprecated and will be removed in a future version. Please
-define a #check method which calls `mark_failure` and `mark_message` as
-appropriate. In the meantime, OkComputer displays a warning and uses the result
-of the #call method as the message.
+This was deprecated at the time and removed in 1.0.0. Please define a #check
+method which calls `mark_failure` and `mark_message` as appropriate.
 
 ## Contributing
 

data/lib/ok_computer/built_in_checks/delayed_job_backed_up_check.rb

@@ -2,10 +2,11 @@ module OkComputer
   class DelayedJobBackedUpCheck < SizeThresholdCheck
     attr_accessor :priority
     attr_accessor :threshold
+    attr_accessor :greater_than_priority
 
     # Public: Initialize a check for backed-up Delayed Job jobs
     #
-    # priority - Which priority (or greater) to check for
+    # priority - Which priority to check for
     # threshold - An Integer to compare the jobs count against
     #   to consider it backed up
     #
@@ -14,19 +15,22 @@ module OkComputer
     #   # => The check will look for jobs with priority between
     #   # 0 and 10, considering the jobs as backed up if there
     #   # are more than 50 of them
-    def initialize(priority, threshold)
+    def initialize(priority, threshold, options = {})
       self.priority = Integer(priority)
       self.threshold = Integer(threshold)
-      self.name = "Delayed Jobs within priority '#{priority}'"
+      self.greater_than_priority = !!options[:greater_than_priority]
+      self.name = greater_than_priority ? "Delayed Jobs with priority higher than '#{priority}'" : "Delayed Jobs with priority lower than '#{priority}'"
     end
 
     # Public: How many delayed jobs are pending within the given priority
     def size
       if defined?(::Delayed::Backend::Mongoid::Job) && Delayed::Worker.backend == Delayed::Backend::Mongoid::Job
-        Delayed::Job.lte(priority: priority).where(:locked_at => nil, :last_error => nil).count
+        query = greater_than_priority ? Delayed::Job.gte(priority: priority) : Delayed::Job.lte(priority: priority)
       else
-        Delayed::Job.where("priority <= ?", priority).where(:locked_at => nil, :last_error => nil).count
+        operator = greater_than_priority ? ">=" : "<="
+        query = Delayed::Job.where("priority #{operator} ?", priority)
       end
+      query.where(:locked_at => nil, :last_error => nil).count
     end
   end
 end

data/lib/ok_computer/built_in_checks/size_threshold_check.rb

@@ -29,7 +29,7 @@ module OkComputer
       # expensive operation from happening more than once
       size = self.size
       if size <= threshold
-        mark_message " #{name} at reasonable level (#{size})"
+        mark_message "#{name} at reasonable level (#{size})"
       else
         mark_failure
         mark_message "#{name} is #{size - threshold} over threshold! (#{size})"

data/lib/ok_computer/check.rb

@@ -1,7 +1,5 @@
 module OkComputer
   class Check
-    CALL_DEPRECATION_MESSAGE = "Deprecation warning: Please define #check rather than defining #call"
-
     # to be set by Registry upon registration
     attr_accessor :registrant_name
     # nil by default, only set to true if the check deems itself failed
@@ -20,13 +18,7 @@ module OkComputer
     # Your subclass of Check must define its own #check method. This method
     # must return the string to render when performing the check.
     def check
-      if respond_to? :call
-        warn CALL_DEPRECATION_MESSAGE
-        # The old #call methods returned the message, so use that to set the message output
-        mark_message call
-      else
-        raise(CheckNotDefined, "Your subclass must define its own #check.")
-      end
+      raise(CheckNotDefined, "Your subclass must define its own #check.")
     end
     private :check
 

data/lib/ok_computer/version.rb

@@ -1,3 +1,3 @@
 module OkComputer
-  VERSION = "0.7.1"
+  VERSION = "0.7.3"
 end

data/lib/okcomputer.rb

@@ -15,12 +15,5 @@ require "ok_computer/built_in_checks/delayed_job_backed_up_check"
 require "ok_computer/built_in_checks/ruby_version_check"
 require "ok_computer/built_in_checks/cache_check"
 
-# Remove the following code in version 1.0.0
-module OKComputer
-  def self.method_missing(*args)
-    raise 'Please replace all usages of `OKComputer` with `OkComputer` (lowercase `k`)'
-  end
-end
-
 OkComputer::Registry.register "default", OkComputer::DefaultCheck.new
 OkComputer::Registry.register "database", OkComputer::ActiveRecordCheck.new

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: okcomputer
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.3
 platform: ruby
 authors:
 - Patrick Byrne
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-18 00:00:00.000000000 Z
+date: 2014-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sqlite3
@@ -28,16 +28,16 @@ dependencies:
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement