ojad 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a9bd49fd888f3b51311edb1024c3ac1214157467236ebf97bfb693a886622216
-  data.tar.gz: a3c0c676cb31c63e606023258d3b6b31a494195d2ed5d6379aa61b9b1aadf9ce
+  metadata.gz: f60eabada133af27007812427975c8dcc7eac8f0f1c74ee0e42dff5b968c20ee
+  data.tar.gz: d409aa62676e1603fc437eeca502ea6bbc98673dc09c48d57f81bd0ad6aa9d6c
 SHA512:
-  metadata.gz: 7f6cff41db7d42e6d3d48925a279763e578eff4526b0838a0e1255cd4b93d4bf2938e1254cb4637199267495a61dc5c1c0c6c26a8ea20780b88abe244fa1bd21
-  data.tar.gz: f517b184df1cf232c049e8d288794f8e1416c3bb32afffc4a0e523de7cb5c236be2c7027ba0955ef94cf8b28bb9f19100029edb5499d279bca480e08b334577e
+  metadata.gz: c87627a5d3772cb2fd370d45db729f8ec7b67cb6169e0e071e6a945a1dc5be1466d7e06131faa55aed865fba90642ca244b1b60722f38916b9e8cdc052bd4db1
+  data.tar.gz: adc0d0c23b2fde8a5135b82afa48349e6880aee730ab1e6f71a31a96d4ff8b6d18b343a367dc9172606857fc744134257589ee10b12b28f7d0e57018ca6c0c0a

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # CHANGELOG
 
+## 0.0.2
+
+- Improve output
+- Fix nokogiri require in wrong place
+
 ## 0.0.1
 
 First release.

data/README.md

@@ -7,7 +7,7 @@ A Ruby Client to interact with [OJAD][ojad].
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'ojad'
+gem "ojad"
 ```
 
 And then execute:
@@ -21,9 +21,20 @@ Or install it yourself as:
 ## Usage
 
 ```
-ojad search くる
-
-来る・来ます くる きます きて きた こない こなかった くれば こさせる こられる こい こられる こよう
+$ ojad くる
+Group: 来る・来ます
+Dictionary: くる
+Polite: きます
+Te: きて
+Ta: きた
+Negative: こない
+Past negative: こなかった
+Ba: くれば
+Causative: こさせる
+Passive: こられる
+Imperative: こい
+Potential: こられる
+Volitional: こよう
 ```
 
 ## Development

data/lib/ojad/cli.rb

@@ -14,13 +14,17 @@ module OJAD
     end
 
     def start
-      Result.new(response).to_human
+      $stdout.puts(result_for_human)
     end
 
     private
 
     attr_reader :arguments
 
+    def result_for_human
+      Result.new(response).to_human
+    end
+
     def response
       Client.call(arguments.first)
     end

data/lib/ojad/result.rb

@@ -10,10 +10,7 @@ module OJAD
 
     def to_human
       if response.success?
-        verbs.each do |verb|
-          verb.to_human
-          puts "-"*80
-        end
+        verbs_for_human
       else
         error_message
       end
@@ -23,17 +20,23 @@ module OJAD
 
     attr_reader :response
 
+    LINE = "-"*80
+
     def html
       @_response_string ||= response.body.to_s
     end
 
+    def verbs_for_human
+      verbs.map(&:to_human).join(LINE)
+    end
+
     def verbs
       Verbs.new(html).to_a
     end
 
     def error_message
       "An error occurred. Please try again later.\n\n" \
-      "Response body:\n\n#{response.body.to_s}" \
+      "Response body:\n\n#{response.body.to_s}"
     end
   end
 end

data/lib/ojad/{verb_presenter.rb → verb.rb}

@@ -1,27 +1,25 @@
 # frozen_string_literal: true
 
-require "nokogiri"
-
 module OJAD
-  class VerbPresenter
+  class Verb
     def initialize(document)
       @document = document
     end
 
     def to_human
-      puts "Group: #{group}"
-      puts "Dictionary: #{dictionary}"
-      puts "Polite: #{polite}"
-      puts "Te: #{te}"
-      puts "Ta: #{ta}"
-      puts "Negative: #{negative}"
-      puts "Past negative: #{past_negative}"
-      puts "Ba: #{ba}"
-      puts "Causative: #{causative}"
-      puts "Passive: #{passive}"
-      puts "Imperative: #{imperative}"
-      puts "Potential: #{potential}"
-      puts "Volitional: #{volitional}"
+      "Group: #{group}\n" \
+      "Dictionary: #{dictionary}\n" \
+      "Polite: #{polite}\n" \
+      "Te: #{te}\n" \
+      "Ta: #{ta}\n" \
+      "Negative: #{negative}\n" \
+      "Past negative: #{past_negative}\n" \
+      "Ba: #{ba}\n" \
+      "Causative: #{causative}\n" \
+      "Passive: #{passive}\n" \
+      "Imperative: #{imperative}\n" \
+      "Potential: #{potential}\n" \
+      "Volitional: #{volitional}\n"
     end
 
     private

data/lib/ojad/verbs.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
-require_relative "verb_presenter"
+require "nokogiri"
+
+require_relative "verb"
 
 module OJAD
   class Verbs
@@ -10,7 +12,7 @@ module OJAD
 
     def to_a
       verbs.map do |verb_document|
-        VerbPresenter.new(verb_document)
+        Verb.new(verb_document)
       end
     end
 

data/lib/ojad/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OJAD
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ojad
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Juanito Fatas
@@ -119,7 +119,7 @@ files:
 - lib/ojad/client.rb
 - lib/ojad/response.rb
 - lib/ojad/result.rb
-- lib/ojad/verb_presenter.rb
+- lib/ojad/verb.rb
 - lib/ojad/verbs.rb
 - lib/ojad/version.rb
 - ojad.gemspec