ohm 3.0.2 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4d772d265943ece2cb2474ffffe91ca507ea015
-  data.tar.gz: e12bcab718e57af58ecd4084db153d22bc17158a
+  metadata.gz: 94a422b709084441dabd2d9c04a38014ec6ddbef
+  data.tar.gz: 8549e0842a0737e65a5d459f483b1002e8914ecf
 SHA512:
-  metadata.gz: e64574ab2442f7bce423f4545fe2e07bf029533e8e6a10eb56d2f86642d48e94d0b36e9f076f9658adc57fda1f9f9cf803b88209b8c5cdce63182238cfb85eea
-  data.tar.gz: 2e9378f29c6f884c8b28f19d94ca208188a06b1324898d2bec0d2a63da2d14c8e85224a5aec34be90e7c0007ee59080fdbf827e2434cd7325efd3ef2ef51890e
+  metadata.gz: 404357ab09aa51976a53ddc7fe43a31b29030f6067386daca0787fe8cd7d6cb1dbb80fabaee8c839aa23d576f9772dc66584df17e27c37317392aed7ac7f1927
+  data.tar.gz: 5cffd617b9e7e3119d1dc2d1f241a1107bafd7bdb7b53d4e78745e9d7f1570ceb1c887d488353c9d15782da0c27b750987299c321bb770e0e2eaf34326fb4d84

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 3.0.3
+
+- Fix bug that gave false positives for unique indices.
+
+  Uniques were indexed for nil values as empty strings. This
+  release fixes that issue.
+
 ## 3.0.2
 
 - Fix bug created the wrong keys when indexing floats.

data/lib/ohm.rb

@@ -1334,10 +1334,16 @@ module Ohm
     #
     def save
       indices = {}
-      model.indices.each { |field| indices[field] = Array(send(field)).map(&:to_s) }
+      model.indices.each do |field|
+        next unless (value = send(field))
+        indices[field] = Array(value).map(&:to_s)
+      end
 
       uniques = {}
-      model.uniques.each { |field| uniques[field] = send(field).to_s }
+      model.uniques.each do |field|
+        next unless (value = send(field))
+        uniques[field] = value.to_s
+      end
 
       features = {
         "name" => model.name
@@ -1367,7 +1373,10 @@ module Ohm
     #
     def delete
       uniques = {}
-      model.uniques.each { |field| uniques[field] = send(field) }
+      model.uniques.each do |field|
+        next unless (value = send(field))
+        uniques[field] = value.to_s
+      end
 
       script(LUA_DELETE, 0,
         { "name" => model.name,

data/ohm.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "ohm"
-  s.version = "3.0.2"
+  s.version = "3.0.3"
   s.summary = %{Object-hash mapping library for Redis.}
   s.description = %Q{Ohm is a library that allows to store an object in Redis, a persistent key-value database. It has very good performance.}
   s.authors = ["Michel Martens", "Damian Janowski", "Cyril David"]

data/test/uniques.rb

@@ -96,3 +96,13 @@ test "unique virtual attribute" do
     User.create(:email => "baz@yahoo.com")
   end
 end
+
+test "nil doesn't count for uniques" do
+  u1 = User.create
+  u2 = User.create
+  
+  assert u1.id
+  assert u2.id
+  
+  assert u1.id != u2.id
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ohm
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
 platform: ruby
 authors:
 - Michel Martens
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-22 00:00:00.000000000 Z
+date: 2016-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redic