ogone 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bec0a5e938c818872281ccd8fb3b33005b67234e
-  data.tar.gz: 7a28120c828924c4656abf5b562047720c5a76a3
+SHA256:
+  metadata.gz: 85185bca3d62a4d0a260d9c09ee46faed5ff3d1ca5e87d5ea20eeba08f71e5b7
+  data.tar.gz: f752b6492f9c12a5647379ccad4e2d67a98566e67f0ce21e902ee6deb64daf43
 SHA512:
-  metadata.gz: 6b26d16f4c5741fb7eb0a7037b57ebcbd958d52e65a125d8d81d3fbb1ef559bdb941673e6ff98dbf3d6670a3dd4d2c4538fa97e08e8200bd9f86d1f1f10ebfd1
-  data.tar.gz: a55ebdc4b42f54fb82ee78b44cf95775a74123b8e7cc56f639188cb67ea6aa963361d1bf1cc2b1860f1ef51f5762aeca015681acec13579d9e04143c691d4f54
+  metadata.gz: 4c46e65d211f33026882c61807ce45bd69950139778097d7e82f7ecc3465bd10c55633b9d14866e7f19f7327f6f12395ae0a567affcd86ad57d07cad7b307e6d
+  data.tar.gz: e6a008fa16cae177fc94b12b6a41823601a2dda9114bbe9ecbec7056963b9bab610bf62c8c3dd089150e80fc6ddfc70915c41d4696efdea9419663b57d28d89f

data/.rubocop.yml

@@ -0,0 +1,12 @@
+Metrics/LineLength:
+  Max: 120
+Metrics/BlockLength:
+  CountComments: false
+  Max: 25
+  Exclude:
+    - 'Rakefile'
+    - 'spec/**/*.rb'
+Documentation:
+  Enabled: false
+Style/Lambda:
+  Enabled: false

data/README.md

@@ -5,6 +5,8 @@ your users to the ogone ecommerce form where they can pay. This gem is flexible
 as it does not rely on a hard-coded configuration to be used. Therefore you can
 dynamically handle several PSPIDs.
 
+You can also use Flexcheckout combined with direct order (see Flexcheckout and direct order).
+
 ## Usage
 
 In your controller,
@@ -84,6 +86,48 @@ class PaymentController
 end
 ```
 
+## Flexcheckout and direct order
+
+```ruby
+@ogone = Ogone::Flexcheckout.new opts # same options than Ogone::Ecommerce
+
+@ogone.add_parameters(
+  'CARD.PAYMENTMETHOD' => 'CreditCard',
+  'PARAMETERS.ACCEPTURL' => 'http://my_app/ogone_flexcheckout_success',
+  'PARAMETERS.EXCEPTIONURL' => 'http://my_app/ogone_flexcheckout_failure',
+  'LANGUAGE' => 'en_US',
+)
+
+@ogone.form_url # this is the URL with the Flexcheckout form, you shoudl redirect_to it
+```
+
+Once you fill the form, Ogone will redirect to the `ACCEPTURL` or `EXCEPTIONURL`. If you go to the `ACCEPTURL`,
+you can proceed with the order :
+
+```ruby
+# first ensure sha_out matches
+@ogone = Ogone::Flexcheckout.new opts # same options than Ogone::Ecommerce
+@ogone.check_shasign_out!(params)
+
+# ok sha_out matches proceed to the order
+@ogone = Ogone::OrderDirect.new opts # same options than Ogone::Ecommerce
+
+@ogone.add_parameters(
+  'ORDERID' => params['Alias.OrderId'],
+  'AMOUNT' => 10 * 100,
+  'CURRENCY' => 'EUR',
+  'ALIAS' => params['Alias.AliasId'], # comes from the HTTP params set in the flexcheckout redirect
+  'USERID' => 'my_api_user', # you need to have an API user https://payment-services.ingenico.com/int/en/ogone/support/guides/integration%20guides/directlink
+  'PSWD' => 'super_secret@',
+  'OPERATION' => 'RES'
+  # extra parameters may be set for 3D Secure : https://payment-services.ingenico.com/int/en/ogone/support/guides/integration%20guides/directlink-3-d/3-d-transaction-flow-via-directlink#comments
+)
+
+result = @ogone.perform_order
+
+# handle result
+```
+
 ## Contributing
 
 1. Fork it

data/Rakefile

@@ -1 +1 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'

data/lib/ogone.rb

@@ -1,3 +1,5 @@
-require "ogone/version"
-require "ogone/status"
-require "ogone/ecommerce"
+require 'ogone/version'
+require 'ogone/status'
+require 'ogone/ecommerce'
+require 'ogone/flexcheckout'
+require 'ogone/order_direct'

data/lib/ogone/base.rb

@@ -0,0 +1,98 @@
+require 'digest'
+
+module Ogone
+  class Base
+    VALID_ENVIRONMENTS = %w[test prod].freeze unless const_defined? :VALID_ENVIRONMENTS
+    SIGNING_ALGORITHMS = %w[SHA1 SHA256 SHA512].freeze unless const_defined? :SIGNING_ALGORITHMS
+
+    class ConfigurationError < StandardError; end
+    class MandatoryParameterMissing < StandardError; end
+    class OutboundSignatureMismatch < StandardError; end
+
+    attr_accessor :sha_in, :sha_out
+
+    def initialize(options = {})
+      @parameters = {}
+      %i[sha_algo environment pspid sha_in sha_out].each do |config|
+        send :"#{config}=", options[config] unless options[config].nil?
+      end
+    end
+
+    def sha_algo=(sha_algo)
+      raise ArgumentError, "Unsupported signature algorithm: #{sha_algo}" unless SIGNING_ALGORITHMS.include?(sha_algo)
+      @sha_algo = sha_algo
+    end
+
+    def environment=(environment)
+      unless VALID_ENVIRONMENTS.include? environment.to_s
+        raise ArgumentError, "Unsupported Ogone environment: #{environment}"
+      end
+      @environment = environment
+    end
+
+    def pspid=(pspid)
+      raise ArgumentError, 'PSPID cannot be empty' if pspid.nil? || pspid == ''
+      @pspid = pspid
+    end
+
+    def add_parameters(parameters)
+      @parameters.merge! parameters
+    end
+
+    def fields_for_payment(parameters = {}, shasign_key = 'SHASIGN')
+      add_parameters(parameters || {})
+      check_mandatory_parameters!
+
+      upcase_keys(@parameters).merge(shasign_key.to_sym => sha_in_sign)
+    end
+
+    def check_shasign_out!(params)
+      params = upcase_keys(params)
+      raise OutboundSignatureMismatch if sha_out_sign(params) != params[:SHASIGN]
+    end
+
+    def upcase_keys(hash)
+      hash.each_with_object({}) { |(k, v), h| h[k.upcase.to_sym] = v; }
+    end
+
+    protected
+
+    def ogone_host
+      @environment == 'test' ? 'ogone.test.v-psp.com' : 'secure.ogone.com'
+    end
+
+    private
+
+    def sha_in_sign
+      to_hash = sorted_upcased_parameters.each_with_object([]) do |(k, v), a|
+        a << "#{k}=#{v}#{@sha_in}" unless v.nil? || v == ''
+      end.join
+      sign to_hash
+    end
+
+    def sha_out_sign(params)
+      to_hash = self.class.const_get('OUTBOUND_SIGNATURE_PARAMETERS').each_with_object([]) do |p, a|
+        a << "#{p}=#{params[p]}#{@sha_out}" unless params[p].nil? || params[p] == ''
+      end.join
+      sign to_hash
+    end
+
+    def sign(to_hash)
+      unless SIGNING_ALGORITHMS.include?(@sha_algo)
+        raise ArgumentError, "Unsupported signature algorithm: '#{@sha_algo}'"
+      end
+      Digest.const_get(@sha_algo).hexdigest(to_hash).upcase
+    end
+
+    def sorted_upcased_parameters
+      upcase_keys(@parameters).sort
+    end
+
+    def check_mandatory_parameters!
+      keys = @parameters.keys.map(&:to_sym)
+      self.class.const_get('MANDATORY_PARAMETERS').each do |parameter|
+        raise MandatoryParameterMissing, parameter unless keys.include? parameter.to_sym
+      end
+    end
+  end
+end

data/lib/ogone/ecommerce.rb

@@ -1,120 +1,75 @@
-module Ogone
-  class Ecommerce
-    VALID_ENVIRONMENTS = %w(test prod) unless const_defined? :VALID_ENVIRONMENTS
-    SIGNING_ALGORITHMS = %w(SHA1 SHA256 SHA512) unless const_defined? :SIGNING_ALGORITHMS
-
-    class ConfigurationError < StandardError; end
-
-    MANDATORY_PARAMETERS = %w(PSPID ORDERID AMOUNT CURRENCY LANGUAGE) unless const_defined? :MANDATORY_PARAMETERS
-    class MandatoryParameterMissing < StandardError; end
-
-    OUTBOUND_SIGNATURE_PARAMETERS = %w(AAVADDRESS AAVCHECK AAVZIP ACCEPTANCE ALIAS AMOUNT BIN \
-                                       BRAND CARDNO CCCTY CN COMPLUS CREATION_STATUS CURRENCY \
-                                       CVCCHECK DCC_COMMPERCENTAGE DCC_CONVAMOUNT DCC_CONVCCY \
-                                       DCC_EXCHRATE DCC_EXCHRATESOURCE DCC_EXCHRATETS DCC_INDICATOR \
-                                       DCC_MARGINPERCENTAGE DCC_VALIDHOURS DIGESTCARDNO ECI ED \
-                                       ENCCARDNO FXAMOUNT FXCURRENCY IP IPCTY NBREMAILUSAGE NBRIPUSAGE\
-                                       NBRIPUSAGE_ALLTX NBRUSAGE NCERROR ORDERID PAYID PM SCO_CATEGORY \
-                                       SCORING STATUS SUBBRAND SUBSCRIPTION_ID TRXDATE VC).collect &:to_sym unless const_defined? :OUTBOUND_SIGNATURE_PARAMETERS
-    class OutboundSignatureMismatch < StandardError; end
-
-    attr_accessor :sha_in, :sha_out
+require 'ogone/base'
 
-    def initialize(options = {})
-      @parameters = Hash.new
-      [:sha_algo, :environment, :pspid, :sha_in, :sha_out].each do |config|
-        self.send :"#{config}=", options[config] unless options[config].nil?
-      end
-    end
-
-    def sha_algo=(sha_algo)
-      unless SIGNING_ALGORITHMS.include?(sha_algo)
-        raise ArgumentError.new("Unsupported signature algorithm: #{sha_algo}")
-      end
-      @sha_algo = sha_algo
-    end
-
-    def environment=(environment)
-      unless VALID_ENVIRONMENTS.include? environment.to_s
-        raise ArgumentError.new("Unsupported Ogone environment: #{environment}")
-      end
-      @environment = environment
-    end
+module Ogone
+  class Ecommerce < Base
+    MANDATORY_PARAMETERS = %w[PSPID ORDERID AMOUNT CURRENCY LANGUAGE].freeze
+
+    OUTBOUND_SIGNATURE_PARAMETERS = %i[
+      AAVADDRESS
+      AAVCHECK
+      AAVZIP
+      ACCEPTANCE
+      ALIAS
+      AMOUNT
+      BIN
+      BRAND
+      CARDNO
+      CCCTY
+      CN
+      COMPLUS
+      CREATION_STATUS
+      CURRENCY
+      CVCCHECK
+      DCC_COMMPERCENTAGE
+      DCC_CONVAMOUNT
+      DCC_CONVCCY
+      DCC_EXCHRATE
+      DCC_EXCHRATESOURCE
+      DCC_EXCHRATETS
+      DCC_INDICATOR
+      DCC_MARGINPERCENTAGE
+      DCC_VALIDHOURS
+      DIGESTCARDNO
+      ECI
+      ED
+      ENCCARDNO
+      FXAMOUNT
+      FXCURRENCY
+      IP
+      IPCTY
+      NBREMAILUSAGE
+      NBRIPUSAGE
+      NBRIPUSAGE_ALLTX
+      NBRUSAGE
+      NCERROR
+      ORDERID
+      PAYID
+      PM
+      SCO_CATEGORY
+      SCORING
+      STATUS
+      SUBBRAND
+      SUBSCRIPTION_ID
+      TRXDATE
+      VC
+    ].freeze
 
     def pspid=(pspid)
-      raise ArgumentError.new("PSPID cannot be empty") if pspid.nil? || pspid == ""
+      super(pspid)
       @parameters[:PSPID] = pspid
     end
 
     def form_action
       unless VALID_ENVIRONMENTS.include? @environment.to_s
-        raise ConfigurationError.new("Unsupported Ogone environment: '#{@environment}'.")
+        raise ConfigurationError, "Unsupported Ogone environment: '#{@environment}'."
       end
       "https://secure.ogone.com/ncol/#{@environment}/orderstandard_utf8.asp"
     end
 
     def add_single_return_url(return_url)
-      [:ACCEPTURL, :DECLINEURL, :EXCEPTIONURL, :CANCELURL].each do |field|
+      %i[ACCEPTURL DECLINEURL EXCEPTIONURL CANCELURL].each do |field|
         @parameters[field] = return_url
       end
     end
-
-    def add_parameters(parameters)
-      @parameters.merge! parameters
-    end
-
-    def fields_for_payment(parameters = {})
-      add_parameters(parameters || {})
-      check_mandatory_parameters!
-
-      upcase_keys(@parameters).merge :SHASIGN => sha_in_sign
-    end
-
-    def check_shasign_out!(params)
-      params = upcase_keys(params)
-      raise OutboundSignatureMismatch.new if sha_out_sign(params) != params[:SHASIGN]
-    end
-
-    def upcase_keys(hash)
-      hash.inject({}) { |h, (k, v)| h[k.upcase.to_sym] = v; h }
-    end
-
-    private
-
-    def sha_in_sign
-      to_hash = sorted_upcased_parameters.inject([]) {
-                  |a, (k, v)| a << "#{k}=#{v}#{@sha_in}" unless v.nil? || v == ""
-                  a
-                }.join
-      sign to_hash
-    end
-
-    def sha_out_sign(params)
-      to_hash = OUTBOUND_SIGNATURE_PARAMETERS.inject([]) {
-                  |a, p| a << "#{p}=#{params[p]}#{@sha_out}" unless params[p].nil? || params[p] == ""
-                  a
-                }.join
-      sign to_hash
-    end
-
-    def sign(to_hash)
-      unless SIGNING_ALGORITHMS.include?(@sha_algo)
-        raise ArgumentError.new("Unsupported signature algorithm: '#{@sha_algo}'")
-      end
-      Digest.const_get(@sha_algo).hexdigest(to_hash).upcase
-    end
-
-    def sorted_upcased_parameters
-      upcase_keys(@parameters).sort
-    end
-
-    def check_mandatory_parameters!
-      MANDATORY_PARAMETERS.each do |parameter|
-        unless @parameters.include? parameter.to_sym
-          raise MandatoryParameterMissing.new parameter
-        end
-      end
-    end
-
   end
-end
+end

data/lib/ogone/flexcheckout.rb

@@ -0,0 +1,45 @@
+require 'ogone/base'
+
+module Ogone
+  class Flexcheckout < Base
+    MANDATORY_PARAMETERS = %w[
+      ACCOUNT.PSPID
+      PARAMETERS.ACCEPTURL
+      PARAMETERS.EXCEPTIONURL
+      CARD.PAYMENTMETHOD
+      LANGUAGE
+    ].freeze
+
+    OUTBOUND_SIGNATURE_PARAMETERS = %i[
+      ALIAS.ALIASID
+      ALIAS.NCERROR
+      ALIAS.NCERRORCARDNO
+      ALIAS.NCERRORCN
+      ALIAS.NCERRORCVC
+      ALIAS.NCERRORED
+      ALIAS.ORDERID
+      ALIAS.STATUS
+      ALIAS.STOREPERMANENTLY
+      CARD.BIC
+      CARD.BIN
+      CARD.BRAND
+      CARD.CARDHOLDERNAME
+      CARD.CARDNUMBER
+      CARD.CVC
+      CARD.EXPIRYDATE
+    ].freeze
+
+    def pspid=(pspid)
+      super(pspid)
+      @parameters[:'ACCOUNT.PSPID'] = pspid
+    end
+
+    def fields_for_payment(parameters = {})
+      super(parameters, 'SHASIGNATURE.SHASIGN')
+    end
+
+    def form_url
+      "https://#{ogone_host}/Tokenization/HostedPage?#{URI.encode_www_form(fields_for_payment)}"
+    end
+  end
+end

data/lib/ogone/order_direct.rb

@@ -0,0 +1,27 @@
+require 'ogone/base'
+
+module Ogone
+  class OrderDirect < Base
+    MANDATORY_PARAMETERS = %w[
+      PSPID
+      ORDERID
+      AMOUNT
+      CURRENCY
+      ALIAS
+      USERID
+      PSWD
+      OPERATION
+    ].freeze
+
+    def pspid=(pspid)
+      super(pspid)
+      @parameters[:PSPID] = pspid
+    end
+
+    def perform_order
+      url = "https://#{ogone_host}/ncol/#{@environment}/orderdirect.asp"
+      res = HTTParty.get("#{url}?#{URI.encode_www_form(fields_for_payment)}")
+      res.body
+    end
+  end
+end

data/lib/ogone/status.rb

@@ -1,45 +1,45 @@
 module Ogone
+  unless const_defined? :STATUS
+    STATUS = {
+      0  => 'Incomplete or invalid',
+      1  => 'Cancelled by client',
+      2  => 'Authorization refused',
+      4  => 'Order stored',
+      41 => 'Waiting client payment',
+      5  => 'Authorized',
+      51 => 'Authorization waiting',
+      52 => 'Authorization not known',
+      55 => 'Stand-by',
+      59 => 'Authoriz. to get manually',
+      6  => 'Authorized and cancelled',
+      61 => 'Author. deletion waiting',
+      62 => 'Author. deletion uncertain',
+      63 => 'Author. deletion refused',
+      64 => 'Authorized and cancelled',
+      7  => 'Payment deleted',
+      71 => 'Payment deletion pending',
+      72 => 'Payment deletion uncertain',
+      73 => 'Payment deletion refused',
+      74 => 'Payment deleted',
+      75 => 'Deletion processed by merchant',
+      8  => 'Refund',
+      81 => 'Refund pending',
+      82 => 'Refund uncertain',
+      83 => 'Refund refused',
+      84 => 'Payment declined by the acquirer',
+      85 => 'Refund processed by merchant',
+      9  => 'Payment requested',
+      91 => 'Payment processing',
+      92 => 'Payment uncertain',
+      93 => 'Payment refused',
+      94 => 'Refund declined by the acquirer',
+      95 => 'Payment processed by merchant',
+      99 => 'Being processed'
+    }.freeze
+  end
 
-  STATUS = {
-    0  => 'Incomplete or invalid',
-    1  => 'Cancelled by client',
-    2  => 'Authorization refused',
-    4  => 'Order stored',
-    41 => 'Waiting client payment',
-    5  => 'Authorized',
-    51 => 'Authorization waiting',
-    52 => 'Authorization not known',
-    55 => 'Stand-by',
-    59 => 'Authoriz. to get manually',
-    6  => 'Authorized and cancelled',
-    61 => 'Author. deletion waiting',
-    62 => 'Author. deletion uncertain',
-    63 => 'Author. deletion refused',
-    64 => 'Authorized and cancelled',
-    7  => 'Payment deleted',
-    71 => 'Payment deletion pending',
-    72 => 'Payment deletion uncertain',
-    73 => 'Payment deletion refused',
-    74 => 'Payment deleted',
-    75 => 'Deletion processed by merchant',
-    8  => 'Refund',
-    81 => 'Refund pending',
-    82 => 'Refund uncertain',
-    83 => 'Refund refused',
-    84 => 'Payment declined by the acquirer',
-    85 => 'Refund processed by merchant',
-    9  => 'Payment requested',
-    91 => 'Payment processing',
-    92 => 'Payment uncertain',
-    93 => 'Payment refused',
-    94 => 'Refund declined by the acquirer',
-    95 => 'Payment processed by merchant',
-    99 => 'Being processed'
-  } unless const_defined? :STATUS
-
-  PAID_STATUSES = [4, 5, 9] unless const_defined? :PAID_STATUSES
-  PENDING_STATUSES = [41, 51, 52, 91, 92, 99] unless const_defined? :PENDING_STATUSES
-  CANCELLED_STATUSES = [1] unless const_defined? :CANCELLED_STATUSES
-  REFUNDED_STATUSES = [8] unless const_defined? :REFUNDED_STATUSES
-
-end
+  PAID_STATUSES = [4, 5, 9].freeze unless const_defined? :PAID_STATUSES
+  PENDING_STATUSES = [41, 51, 52, 91, 92, 99].freeze unless const_defined? :PENDING_STATUSES
+  CANCELLED_STATUSES = [1].freeze unless const_defined? :CANCELLED_STATUSES
+  REFUNDED_STATUSES = [8].freeze unless const_defined? :REFUNDED_STATUSES
+end

data/lib/ogone/version.rb

@@ -1,3 +1,3 @@
 module Ogone
-  VERSION = "0.1.0"
+  VERSION = '0.2.0'.freeze
 end

data/ogone.gemspec

@@ -1,28 +1,29 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'ogone/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "ogone"
+  spec.name          = 'ogone'
   spec.version       = Ogone::VERSION
-  spec.authors       = ["Sebastien Saunier"]
-  spec.email         = ["seb@saunier.me"]
-  spec.description   = %q{Flexible Ogone ecommerce wrapper
+  spec.authors       = ['Sebastien Saunier']
+  spec.email         = ['seb@saunier.me']
+  spec.description   = 'Flexible Ogone ecommerce wrapper
 
 Deal simply with multiple ogone ecommerce account within your application.
 No hard coded configuration read from a *.yml file.
-  }
-  spec.summary       = %q{Flexible Ogone ecommerce wrapper}
-  spec.homepage      = "https://github.com/applidget/ogone"
-  spec.license       = "MIT"
+  '
+  spec.summary       = 'Flexible Ogone ecommerce wrapper'
+  spec.homepage      = 'https://github.com/applidget/ogone'
+  spec.license       = 'MIT'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
+  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'rubocop'
+  spec.add_dependency 'httparty'
 end

data/spec/ogone/ecommerce_spec.rb

@@ -1,90 +1,86 @@
-require "ogone/ecommerce"
+require 'ogone/ecommerce'
 
 module Ogone
   describe Ecommerce do
-
     before(:each) do
       @ogone = Ogone::Ecommerce.new
     end
 
-    it "should raise an error if incorrect sha algorithm given" do
+    it 'should raise an error if incorrect sha algorithm given' do
       lambda { @ogone.sha_algo = 'WRONG_SHA' }.should raise_error ArgumentError
     end
 
-    it "should raise an error if incorrect ogone environment given" do
+    it 'should raise an error if incorrect ogone environment given' do
       lambda { @ogone.environment = 'WRONG_ENV' }.should raise_error ArgumentError
     end
 
-    it "should raise an error if an empty PSPID is specified" do
+    it 'should raise an error if an empty PSPID is specified' do
       lambda { @ogone.pspid = '' }.should raise_error ArgumentError
     end
 
-    it "should render the test Ogone url" do
-      @ogone.environment = "test"
-      @ogone.form_action.should eq "https://secure.ogone.com/ncol/test/orderstandard_utf8.asp"
+    it 'should render the test Ogone url' do
+      @ogone.environment = 'test'
+      @ogone.form_action.should eq 'https://secure.ogone.com/ncol/test/orderstandard_utf8.asp'
     end
 
-    it "should render the production Ogone url" do
-      @ogone.environment = "prod"
-      @ogone.form_action.should eq "https://secure.ogone.com/ncol/prod/orderstandard_utf8.asp"
+    it 'should render the production Ogone url' do
+      @ogone.environment = 'prod'
+      @ogone.form_action.should eq 'https://secure.ogone.com/ncol/prod/orderstandard_utf8.asp'
     end
 
-    it "should have the PSPID stored in the parameters" do
-      @ogone.pspid = "pspid"
-      parameters[:PSPID].should eq "pspid"
+    it 'should have the PSPID stored in the parameters' do
+      @ogone.pspid = 'pspid'
+      parameters[:PSPID].should eq 'pspid'
     end
 
-    describe "#check_shasign_out!" do
-
+    describe '#check_shasign_out!' do
       before(:each) do
-        @ogone = Ogone::Ecommerce.new :sha_out => "sha_out", :sha_algo => "SHA1"
+        @ogone = Ogone::Ecommerce.new sha_out: 'sha_out', sha_algo: 'SHA1'
       end
 
-      it "should check an inbound signature" do
+      it 'should check an inbound signature' do
         params = ogone_return_parameters
         lambda { @ogone.check_shasign_out! params }.should_not raise_error Ogone::Ecommerce::OutboundSignatureMismatch
       end
 
-      it "should throw an error if the outbound shasign does not match" do
+      it 'should throw an error if the outbound shasign does not match' do
         params = {
-          "amonut" => "160",
-          "SHASIGN" => "FOO"
+          'amonut' => '160',
+          'SHASIGN' => 'FOO'
         }
         lambda { @ogone.check_shasign_out! params }.should raise_error Ogone::Ecommerce::OutboundSignatureMismatch
       end
     end
 
-    describe "#fields_for_payment" do
-
+    describe '#fields_for_payment' do
       before(:each) do
-        @ogone = Ogone::Ecommerce.new :pspid => "pspid", :sha_in => "sha_in", :sha_algo => "SHA1"
+        @ogone = Ogone::Ecommerce.new pspid: 'pspid', sha_in: 'sha_in', sha_algo: 'SHA1'
       end
 
-      it "should give a hash ready to be used in `hidden_field_tag`" do
-        fields = @ogone.fields_for_payment :AMOUNT => 100,
-                                           :CURRENCY => "EUR",
-                                           :ORDERID => "123",
-                                           :LANGUAGE => "en_US"
+      it 'should give a hash ready to be used in `hidden_field_tag`' do
+        fields = @ogone.fields_for_payment AMOUNT: 100,
+                                           CURRENCY: 'EUR',
+                                           ORDERID: '123',
+                                           LANGUAGE: 'en_US'
 
-        fields[:SHASIGN].should eq "AA7CA1F98159D14D0943311092F5435F239B4B36"
+        fields[:SHASIGN].should eq 'AA7CA1F98159D14D0943311092F5435F239B4B36'
       end
 
-      it "should also work if parameters were given with #add_parameters" do
-        @ogone.add_parameters :AMOUNT => 100, :CURRENCY => "EUR", :ORDERID => "123", :LANGUAGE => "en_US"
+      it 'should also work if parameters were given with #add_parameters' do
+        @ogone.add_parameters AMOUNT: 100, CURRENCY: 'EUR', ORDERID: '123', LANGUAGE: 'en_US'
 
         fields = @ogone.fields_for_payment
-        fields[:SHASIGN].should eq "AA7CA1F98159D14D0943311092F5435F239B4B36"
+        fields[:SHASIGN].should eq 'AA7CA1F98159D14D0943311092F5435F239B4B36'
       end
-
     end
 
-    describe "#add_single_return_url" do
-      it "should allow lazy folks to give just one back url" do
-        @ogone.add_single_return_url "http://iamsola.zy"
-        parameters[:ACCEPTURL].should eq "http://iamsola.zy"
-        parameters[:DECLINEURL].should eq "http://iamsola.zy"
-        parameters[:EXCEPTIONURL].should eq "http://iamsola.zy"
-        parameters[:CANCELURL].should eq "http://iamsola.zy"
+    describe '#add_single_return_url' do
+      it 'should allow lazy folks to give just one back url' do
+        @ogone.add_single_return_url 'http://iamsola.zy'
+        parameters[:ACCEPTURL].should eq 'http://iamsola.zy'
+        parameters[:DECLINEURL].should eq 'http://iamsola.zy'
+        parameters[:EXCEPTIONURL].should eq 'http://iamsola.zy'
+        parameters[:CANCELURL].should eq 'http://iamsola.zy'
       end
     end
 
@@ -94,25 +90,27 @@ module Ogone
       @ogone.instance_variable_get :@parameters
     end
 
+    # rubocop:disable Metrics/MethodLength
     def ogone_return_parameters
       {
-        "orderID" => "r_511b52f7230b430b3f000003_19",
-        "currency" => "EUR",
-        "amount" => "160",
-        "PM" => "CreditCard",
-        "ACCEPTANCE" => "",
-        "STATUS" => "1",
-        "CARDNO" => "",
-        "ED" => "",
-        "CN" => "Sebastien Saunier",
-        "TRXDATE" => "02/13/13",
-        "PAYID" => "19113975",
-        "NCERROR" => "",
-        "BRAND" => "",
-        "COMPLUS" => "registration_511b52f7230b430b3f000003",
-        "IP" => "80.12.86.33",
-        "SHASIGN" => "F3F5F963C700F56B69EA36173F5BFB3B28CA25E5",
+        'orderID' => 'r_511b52f7230b430b3f000003_19',
+        'currency' => 'EUR',
+        'amount' => '160',
+        'PM' => 'CreditCard',
+        'ACCEPTANCE' => '',
+        'STATUS' => '1',
+        'CARDNO' => '',
+        'ED' => '',
+        'CN' => 'Sebastien Saunier',
+        'TRXDATE' => '02/13/13',
+        'PAYID' => '19113975',
+        'NCERROR' => '',
+        'BRAND' => '',
+        'COMPLUS' => 'registration_511b52f7230b430b3f000003',
+        'IP' => '80.12.86.33',
+        'SHASIGN' => 'F3F5F963C700F56B69EA36173F5BFB3B28CA25E5'
       }
     end
+    # rubocop:enable Metrics/MethodLength
   end
-end
+end

data/spec/spec_helper.rb

@@ -4,4 +4,4 @@ require 'bundler/setup'
 require 'ogone'
 
 # RSpec.configure do |config|
-# end
+# end

metadata

@@ -1,58 +1,86 @@
 --- !ruby/object:Gem::Specification
 name: ogone
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Sebastien Saunier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-11 00:00:00.000000000 Z
+date: 2018-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! "Flexible Ogone ecommerce wrapper\n\nDeal simply with multiple ogone
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: httparty
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: "Flexible Ogone ecommerce wrapper\n\nDeal simply with multiple ogone
   ecommerce account within your application.\nNo hard coded configuration read from
   a *.yml file.\n  "
 email:
@@ -61,14 +89,18 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/ogone.rb
+- lib/ogone/base.rb
 - lib/ogone/ecommerce.rb
+- lib/ogone/flexcheckout.rb
+- lib/ogone/order_direct.rb
 - lib/ogone/status.rb
 - lib/ogone/version.rb
 - ogone.gemspec
@@ -84,17 +116,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.0
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Flexible Ogone ecommerce wrapper