oga 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c2fbbee6b62ef30eefb291f25d092cf5241b7d7
-  data.tar.gz: 035e4c3f0dc6c22ea74cb35e027a7610334ed362
+  metadata.gz: 0230f47af567902efa1575a8447774e4a35fb50c
+  data.tar.gz: 5cae5f489883d8c8e9f76309e8c1e9d9e8e7c9cc
 SHA512:
-  metadata.gz: 603ecb90ae452afc024dc64da6bd6afcfc6c4d0f1ed29151a6584460b54b0e3d84e12e2a7612d129ccdf897fd55b2d88aa5f056e14089f66c143a275b8cee985
-  data.tar.gz: 05cc8ae719b4ec9c6ca1f725db14183893d438b0361ccf55b4afe61faba623eff8347bf95b7aa693ee21e70b2a8fe217aaa43f6659a397c22ac1d18fee825f51
+  metadata.gz: 092aca9cb1b728a572e397efde33e2a4a9897e11938aa34638bbcb0d361ebc7af9d85962920c898ecfe09b531d7a78667471a7f6aa7e776b4a650ddadbf72bf0
+  data.tar.gz: ba98f9c6d4b9bcbdc7356678b00543e31ecdb4fd0657c61efd998a015a9f7e3e9564d577f5950237ecd9a173121cc3349a310431cc126f34797659b03b73c535

data/README.md

@@ -177,13 +177,17 @@ process and bundled inside the Gem itself.
 
 ## Thread Safety
 
-Documents parsed using Oga are thread-safe as long as they are not modified by
-multiple threads at the same time. Querying documents using XPath can be done by
-multiple threads just fine. Write operations, such as removing attributes, are
-_not_ thread-safe and should not be done by multiple threads at once.
+Oga does not use a unsynchronized global mutable state. As a result of this you
+can parse/create documents concurrently without any problems. Modifying
+documents concurrently can lead to bugs as these operations are not
+synchronized.
 
-It is advised that you do not share parsed documents between threads unless you
-_really_ have to.
+Some querying operations will cache data in instance variables, without
+synchronization. An example is `Oga::XML::Element#namespace` which will cache an
+element's namespace after the first call.
+
+In general it's recommended to _not_ use the same document in multiple threads
+at the same time.
 
 ## Namespace Support
 

data/lib/oga.rb

@@ -55,6 +55,7 @@ require 'oga/ruby/generator'
 
 require 'oga/xpath/lexer'
 require 'oga/xpath/parser'
+require 'oga/xpath/context'
 require 'oga/xpath/compiler'
 require 'oga/xpath/conversion'
 

data/lib/oga/version.rb

@@ -1,3 +1,3 @@
 module Oga
-  VERSION = '1.3.0'
+  VERSION = '1.3.1'
 end # Oga

data/lib/oga/xpath/compiler.rb

@@ -12,6 +12,11 @@ module Oga
       # @return [Oga::LRU]
       CACHE = LRU.new
 
+      # Context for compiled Procs. As compiled Procs do not mutate the
+      # enclosing environment we can just re-use the same instance without
+      # synchronization.
+      CONTEXT = Context.new
+
       # Wildcard for node names/namespace prefixes.
       STAR = '*'
 
@@ -86,7 +91,7 @@ module Oga
         generator = Ruby::Generator.new
         source    = generator.process(proc_ast)
 
-        eval(source)
+        CONTEXT.evaluate(source)
       ensure
         reset
       end

data/lib/oga/xpath/context.rb

@@ -0,0 +1,17 @@
+module Oga
+  module XPath
+    # Class used as the context for compiled XPath Procs.
+    #
+    # The binding of this class is used for the binding of Procs compiled by
+    # {Compiler}. Not using a specific binding would result in the procs
+    # using the binding of {Compiler#compile}, which could lead to race
+    # conditions.
+    class Context
+      # @param [String] string
+      # @return [Proc]
+      def evaluate(string)
+        binding.eval(string)
+      end
+    end # Context
+  end # XPath
+end # Oga

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: oga
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Yorick Peterse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-06 00:00:00.000000000 Z
+date: 2015-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ast
@@ -199,6 +199,7 @@ files:
 - lib/oga/xml/traversal.rb
 - lib/oga/xml/xml_declaration.rb
 - lib/oga/xpath/compiler.rb
+- lib/oga/xpath/context.rb
 - lib/oga/xpath/conversion.rb
 - lib/oga/xpath/lexer.rb
 - lib/oga/xpath/parser.rb