ofx 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f010daf75c910a87b19c737c27a0970a4a410f5e5b6ba5916f4546e2bb5f9abb
-  data.tar.gz: abf6b0090855e5c063ce2d627e8f2b4907be64a71289cb520d4ae4bf7687371e
+  metadata.gz: a1f7e1315a8e1fe59c9e97b5bb1bd470f5ba977463f3311e3eb76ecdc707afd7
+  data.tar.gz: f8463316d6ef710908701765feabbd884e7f5ee87b0ceb2188cef1284705ed23
 SHA512:
-  metadata.gz: f3ccb6719848c32e3047243715a3ec2aabbc80b2f241bfd2ff7dcbda819bf1baeb3086ee751459a28643345d4272bf4b4481dd56ba727f9ebf94ea6a680d4cf0
-  data.tar.gz: 48076b4428d20fa368544099691ebe1bf877b724b49cfce83265545a84b62b07e45759e00ae0febaf254090d53c157a1f9b7b6340f5c9d59237aa1847e590ca5
+  metadata.gz: 4883a274bcb8fcbd35b363183f9ddf896994278ade919f038d698ccd1164dd78b947ee500d3b66b27dc6c22ba719ba6144317a1fbacf66a724d35e3bc14845bd
+  data.tar.gz: 7f40b8abdde571151fe54015a243e8f569116178dc7ed0113639900bbfe4e976ca4f62ccb32dbdaa72e2ce5ddd5794fd85f50bf1dc455ac20a61c893c0e5dd49

data/lib/ofx/account.rb

@@ -1,11 +1,7 @@
+# frozen_string_literal: true
+
 module OFX
   class Account < Foundation
-    attr_accessor :balance
-    attr_accessor :bank_id
-    attr_accessor :currency
-    attr_accessor :id
-    attr_accessor :transactions
-    attr_accessor :type
-    attr_accessor :available_balance
+    attr_accessor :balance, :bank_id, :currency, :id, :transactions, :type, :available_balance
   end
 end

data/lib/ofx/balance.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 module OFX
   class Balance < Foundation
-    attr_accessor :amount
-    attr_accessor :amount_in_pennies
-    attr_accessor :posted_at
+    attr_accessor :amount, :amount_in_pennies, :posted_at
   end
-end
+end
+

data/lib/ofx/errors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OFX
   class UnsupportedFileError < StandardError; end
 end

data/lib/ofx/foundation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module OFX
   class Foundation
     def initialize(attrs)
@@ -6,4 +8,5 @@ module OFX
       end
     end
   end
-end
+end
+

data/lib/ofx/parser/ofx102.rb

@@ -23,7 +23,7 @@ module OFX
         'INFO' => :info,
         'WARN' => :warn,
         'ERROR' => :error
-      }.freeza
+      }.freeze
 
       attr_reader :headers, :body, :html
 
@@ -134,7 +134,7 @@ module OFX
                                check_number: element.search('checknum').inner_text,
                                ref_number: element.search('refnum').inner_text,
                                posted_at: build_date(element.search('dtposted').inner_text),
-                               occurred_at:,
+                               occurred_at: occurred_at,
                                type: build_type(element),
                                sic: element.search('sic').inner_text
                              })
@@ -164,7 +164,7 @@ module OFX
           offset = '+0000'
         end
 
-        date << ' #{offset}'
+        date << " #{offset}"
 
         Time.parse(date)
       end
@@ -178,9 +178,9 @@ module OFX
         end
 
         OFX::Balance.new({
-                           amount:,
+                           amount: ammount,
                            amount_in_pennies: (amount * 100).to_i,
-                           posted_at:
+                           posted_at: posted_at
                          })
       end
 
@@ -189,7 +189,7 @@ module OFX
           amount = to_decimal(node.search('availbal > balamt').inner_text)
 
           OFX::Balance.new({
-                             amount:,
+                             amount: amount,
                              amount_in_pennies: (amount * 100).to_i,
                              posted_at: build_date(node.search('availbal > dtasof').inner_text)
                            })

data/lib/ofx/parser/ofx211.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module OFX
   module Parser
     class OFX211 < OFX102
-      VERSION = "2.1.1"
+      VERSION = '2.1.1'
 
       def self.parse_headers(header_text)
         doc = Nokogiri::XML(header_text)
@@ -9,7 +11,7 @@ module OFX
         # Nokogiri can't search for processing instructions, so we
         # need to do this manually.
         doc.children.each do |e|
-          if e.type == Nokogiri::XML::Node::PI_NODE && e.name == "OFX"
+          if e.type == Nokogiri::XML::Node::PI_NODE && e.name == 'OFX'
             # Getting the attributes from the element doesn't seem to
             # work either.
             return extract_headers(e.text)
@@ -19,13 +21,14 @@ module OFX
         nil
       end
 
-      private
       def self.extract_headers(text)
         headers = {}
         text.split(/\s+/).each do |attr_text|
           match = /(.+)="(.+)"/.match(attr_text)
           next unless match
-          k, v = match[1], match[2]
+
+          k = match[1]
+          v = match[2]
           headers[k] = v
         end
         headers
@@ -33,6 +36,7 @@ module OFX
 
       def self.strip_quotes(s)
         return unless s
+
         s.sub(/^"(.*)"$/, '\1')
       end
     end

data/lib/ofx/parser.rb

@@ -1,10 +1,9 @@
+# frozen_string_literal: true
+
 module OFX
   module Parser
     class Base
-      attr_reader :headers
-      attr_reader :body
-      attr_reader :content
-      attr_reader :parser
+      attr_reader :headers, :body, :conten, :parser
 
       def initialize(resource)
         resource = open_resource(resource)
@@ -12,17 +11,17 @@ module OFX
         begin
           @content = convert_to_utf8(resource.read)
           @headers, @body = prepare(content)
-        rescue
+        rescue StandardError
           raise OFX::UnsupportedFileError
         end
 
-        case headers["VERSION"]
-        when /102/ then
-          @parser = OFX102.new(:headers => headers, :body => body)
-        when /103/ then
-          @parser = OFX103.new(:headers => headers, :body => body)
-        when /200|202|211|220/ then
-          @parser = OFX211.new(:headers => headers, :body => body)
+        case headers['VERSION']
+        when /102/
+          @parser = OFX102.new(headers: headers, body: body)
+        when /103/
+          @parser = OFX103.new(headersu: headers, body: body)
+        when /200|202|211|220/
+          @parser = OFX211.new(headers: headers, body: body)
         else
           raise OFX::UnsupportedFileError
         end
@@ -34,11 +33,12 @@ module OFX
         else
           open(resource)
         end
-      rescue
+      rescue StandardError
         StringIO.new(resource)
       end
 
       private
+
       def prepare(content)
         # split headers & body
         header_text, body = content.dup.split(/<OFX>/, 2)
@@ -55,9 +55,9 @@ module OFX
         end
 
         # Replace body tags to parse it with Nokogiri
-        body.gsub!(/>\s+</m, "><")
-        body.gsub!(/\s+</m, "<")
-        body.gsub!(/>\s+/m, ">")
+        body.gsub!(/>\s+</m, '><')
+        body.gsub!(/\s+</m, '<')
+        body.gsub!(/>\s+/m, '>')
         body.gsub!(/<(\w+?)>([^<]+)/m, '<\1>\2</\1>')
 
         [headers, body]
@@ -65,7 +65,8 @@ module OFX
 
       def convert_to_utf8(string)
         return string if Kconv.isutf8(string)
-        string.encode("UTF-8", "ISO-8859-1")
+
+        string.encode('UTF-8', 'ISO-8859-1')
       end
     end
   end

data/lib/ofx/sign_on.rb

@@ -1,8 +1,7 @@
+# frozen_string_literal: true
+
 module OFX
   class SignOn < Foundation
-    attr_accessor :language
-    attr_accessor :fi_id
-    attr_accessor :fi_name
-    attr_accessor :status
+    attr_accessor :language, :fi_id, :fi_name, :status
   end
 end

data/lib/ofx/statement.rb

@@ -1,11 +1,7 @@
+# frozen_string_literal: true
+
 module OFX
   class Statement < Foundation
-    attr_accessor :account
-    attr_accessor :available_balance
-    attr_accessor :balance
-    attr_accessor :currency
-    attr_accessor :start_date
-    attr_accessor :end_date
-    attr_accessor :transactions
+    attr_accessor :account, :available_balance, :balance, :currency, :start_date, :end_date, :transactions
   end
 end

data/lib/ofx/status.rb

@@ -1,12 +1,12 @@
+# frozen_string_literal: true
+
 module OFX
   # Error Reporting Aggregate
   class Status < Foundation
-    attr_accessor :code     # Error code
-    attr_accessor :severity # Severity of the error
-    attr_accessor :message  # Textual explanation
+    attr_accessor :code, :severity, :message
 
     def success?
-      code == 0
+      code.zero?
     end
   end
 end

data/lib/ofx/transaction.rb

@@ -1,16 +1,8 @@
+# frozen_string_literal: true
+
 module OFX
   class Transaction < Foundation
-    attr_accessor :amount
-    attr_accessor :amount_in_pennies
-    attr_accessor :check_number
-    attr_accessor :fit_id
-    attr_accessor :memo
-    attr_accessor :name
-    attr_accessor :payee
-    attr_accessor :posted_at
-    attr_accessor :occurred_at
-    attr_accessor :ref_number
-    attr_accessor :type
-    attr_accessor :sic
+    attr_accessor :amount, :amount_in_pennies, :check_number, :fit_id, :memo, :name, :payee, :posted_at, :occurred_at,
+                  :ref_number, :type, :sic
   end
 end

data/lib/ofx/version.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 module OFX
   module Version
     MAJOR = 0
     MINOR = 3
-    PATCH = 4
+    PATCH = 5
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ofx
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Nando Vieira
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-22 00:00:00.000000000 Z
+date: 2022-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri