ofx 0.3.1 → 0.3.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: c152721af7763671b8e2c6f912f85e3e3a0b7f44
+  data.tar.gz: 8e5f68901a6215bf71079cf67ff756c50630a7fb
+SHA512:
+  metadata.gz: 4eb56b361cf81ec4b091509fec2272a335514fe697fc7dd060d18e8bafa7a255cf2a55f4e0ecd0438fe3303aee2178ca591510d07767365ea310000e01c61d2c
+  data.tar.gz: 3629da082dc5e93a97220e378ac8e8811db2b5f651594ecfe887cce923455325e23981845cc4b82ac434b330d4c01b1c5550e01dbc7db2c03de94d4d73bfc69a

data/.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 *.gem
-pkg
+pkg
+Gemfile.lock

data/Gemfile

@@ -1,2 +1,2 @@
-source "http://gems.simplesideias.com.br"
+source "https://rubygems.org"
 gemspec

data/Gemfile.lock

@@ -1,41 +1,49 @@
 PATH
   remote: .
   specs:
-    ofx (0.3.1)
+    ofx (0.3.2)
       nokogiri
 
 GEM
-  remote: http://gems.simplesideias.com.br/
+  remote: https://rubygems.org/
   specs:
-    archive-tar-minitar (0.5.2)
-    columnize (0.3.2)
-    diff-lcs (1.1.2)
-    linecache19 (0.5.11)
-      ruby_core_source (>= 0.1.4)
-    nokogiri (1.4.4)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.0)
-    rspec-expectations (2.6.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
-    ruby-debug-base19 (0.11.24)
-      columnize (>= 0.3.1)
-      linecache19 (>= 0.5.11)
-      ruby_core_source (>= 0.1.4)
-    ruby-debug19 (0.11.6)
+    coderay (1.0.9)
+    columnize (0.3.6)
+    debugger (1.6.1)
       columnize (>= 0.3.1)
-      linecache19 (>= 0.5.11)
-      ruby-debug-base19 (>= 0.11.19)
-    ruby_core_source (0.1.4)
-      archive-tar-minitar (>= 0.5.2)
+      debugger-linecache (~> 1.2.0)
+      debugger-ruby_core_source (~> 1.2.3)
+    debugger-linecache (1.2.0)
+    debugger-ruby_core_source (1.2.3)
+    diff-lcs (1.1.3)
+    method_source (0.8.2)
+    mini_portile (0.5.1)
+    nokogiri (1.6.0)
+      mini_portile (~> 0.5.0)
+    pry (0.9.12.2)
+      coderay (~> 1.0.5)
+      method_source (~> 0.8)
+      slop (~> 3.4)
+    pry-debugger (0.2.2)
+      debugger (~> 1.3)
+      pry (~> 0.9.10)
+    rake (10.1.0)
+    rspec (2.7.0)
+      rspec-core (~> 2.7.0)
+      rspec-expectations (~> 2.7.0)
+      rspec-mocks (~> 2.7.0)
+    rspec-core (2.7.1)
+    rspec-expectations (2.7.0)
+      diff-lcs (~> 1.1.2)
+    rspec-mocks (2.7.0)
+    slop (3.4.6)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   ofx!
-  rspec (~> 2.6)
-  ruby-debug19
+  pry
+  pry-debugger
+  rake
+  rspec (~> 2.7)

data/README.rdoc

@@ -1,8 +1,8 @@
 = OFX
 
-A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports OFX 1.0.2.
+A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports both OFX 1.0.2 and 2.1.1.
 
-Works on both Ruby 1.8 and 1.9.
+Works on both ruby 1.9 and 2.0.
 
 == Usage
 
@@ -14,10 +14,14 @@ Works on both Ruby 1.8 and 1.9.
     p account.transactions
   end
 
-== Maintainer
+== Creator
 
 * Nando Vieira - http://simplesideias.com.br
 
+== Maintainer
+
+* Anna Cruz - http://anna-cruz.com
+
 == License
 
 (The MIT License)

data/Rakefile

@@ -3,3 +3,5 @@ Bundler::GemHelper.install_tasks
 
 require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new
+
+task :default => :spec

data/lib/ofx.rb

@@ -2,7 +2,6 @@ require "open-uri"
 require "nokogiri"
 require "bigdecimal"
 
-require "iconv"
 require "kconv"
 
 require "ofx/errors"
@@ -12,6 +11,7 @@ require "ofx/parser/ofx211"
 require "ofx/foundation"
 require "ofx/balance"
 require "ofx/account"
+require "ofx/sign_on"
 require "ofx/transaction"
 require "ofx/version"
 

data/lib/ofx/account.rb

@@ -6,5 +6,6 @@ module OFX
     attr_accessor :id
     attr_accessor :transactions
     attr_accessor :type
+    attr_accessor :available_balance
   end
 end

data/lib/ofx/parser.rb

@@ -9,9 +9,8 @@ module OFX
       def initialize(resource)
         resource = open_resource(resource)
         resource.rewind
-        @content = convert_to_utf8(resource.read)
-
         begin
+          @content = convert_to_utf8(resource.read)
           @headers, @body = prepare(content)
         rescue Exception
           raise OFX::UnsupportedFileError
@@ -64,7 +63,7 @@ module OFX
 
       def convert_to_utf8(string)
         return string if Kconv.isutf8(string)
-        Iconv.conv("UTF-8", "LATIN1//IGNORE", string)
+        string.encode("UTF-8", "ISO-8859-1")
       end
     end
   end

data/lib/ofx/parser/ofx102.rb

@@ -26,6 +26,10 @@ module OFX
         @account ||= build_account
       end
 
+      def sign_on
+        @sign_on ||= build_sign_on
+      end
+
       def self.parse_headers(header_text)
         # Change single CR's to LF's to avoid issues with some banks
         header_text.gsub!(/\r(?!\n)/, "\n")
@@ -47,12 +51,22 @@ module OFX
       private
       def build_account
         OFX::Account.new({
-          :bank_id      => html.search("bankacctfrom > bankid").inner_text,
-          :id           => html.search("bankacctfrom > acctid").inner_text,
-          :type         => ACCOUNT_TYPES[html.search("bankacctfrom > accttype").inner_text.to_s.upcase],
-          :transactions => build_transactions,
-          :balance      => build_balance,
-          :currency     => html.search("bankmsgsrsv1 > stmttrnrs > stmtrs > curdef").inner_text
+          :bank_id           => html.search("bankacctfrom > bankid").inner_text,
+          :id                => html.search("bankacctfrom > acctid, ccacctfrom > acctid").inner_text,
+          :type              => ACCOUNT_TYPES[html.search("bankacctfrom > accttype").inner_text.to_s.upcase],
+          :transactions      => build_transactions,
+          :balance           => build_balance,
+          :available_balance => build_available_balance,
+          :currency          => html.search("bankmsgsrsv1 > stmttrnrs > stmtrs > curdef, " +
+                                            "creditcardmsgsrsv1 > ccstmttrnrs > ccstmtrs > curdef").inner_text
+        })
+      end
+
+      def build_sign_on
+        OFX::SignOn.new({
+          :language          => html.search("signonmsgsrsv1 > sonrs > language").inner_text,
+          :fi_id             => html.search("signonmsgsrsv1 > sonrs > fi > fid").inner_text,
+          :fi_name           => html.search("signonmsgsrsv1 > sonrs > fi > org").inner_text
         })
       end
 
@@ -73,7 +87,8 @@ module OFX
           :check_number      => element.search("checknum").inner_text,
           :ref_number        => element.search("refnum").inner_text,
           :posted_at         => build_date(element.search("dtposted").inner_text),
-          :type              => build_type(element)
+          :type              => build_type(element),
+          :sic               => element.search("sic").inner_text
         })
       end
 
@@ -103,6 +118,20 @@ module OFX
           :posted_at => build_date(html.search("ledgerbal > dtasof").inner_text)
         })
       end
+
+      def build_available_balance
+        if html.search("availbal").size > 0
+          amount = html.search("availbal > balamt").inner_text.to_f
+
+          OFX::Balance.new({
+            :amount => amount,
+            :amount_in_pennies => (amount * 100).to_i,
+            :posted_at => build_date(html.search("availbal > dtasof").inner_text)
+          })
+        else
+          return nil
+        end
+      end
     end
   end
 end

data/lib/ofx/sign_on.rb

@@ -0,0 +1,7 @@
+module OFX
+  class SignOn < Foundation
+    attr_accessor :language
+    attr_accessor :fi_id
+    attr_accessor :fi_name
+  end
+end

data/lib/ofx/transaction.rb

@@ -10,5 +10,6 @@ module OFX
     attr_accessor :posted_at
     attr_accessor :ref_number
     attr_accessor :type
+    attr_accessor :sic
   end
 end

data/lib/ofx/version.rb

@@ -2,7 +2,7 @@ module OFX
   module Version
     MAJOR = 0
     MINOR = 3
-    PATCH = 1
+    PATCH = 2
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/ofx.gemspec

@@ -6,8 +6,8 @@ Gem::Specification.new do |s|
   s.name        = "ofx"
   s.version     = OFX::Version::STRING
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Nando Vieira"]
-  s.email       = ["fnando.vieira@gmail.com"]
+  s.authors     = ["Nando Vieira", "Anna Cruz"]
+  s.email       = ["fnando.vieira@gmail.com", "anna.cruz@gmail.com"]
   s.homepage    = "http://rubygems.org/gems/ofx"
   s.summary     = "A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports OFX 102, 200 and 211."
   s.description = <<-TXT
@@ -27,6 +27,8 @@ TXT
   s.require_paths = ["lib"]
 
   s.add_dependency "nokogiri"
-  s.add_development_dependency "rspec", "~> 2.6"
-  s.add_development_dependency "ruby-debug19"
+  s.add_development_dependency "rspec", "~> 2.7"
+  s.add_development_dependency "rake"
+  s.add_development_dependency "pry"
+  s.add_development_dependency "pry-debugger"
 end

data/spec/fixtures/creditcard.ofx

@@ -0,0 +1,79 @@
+OFXHEADER:100
+DATA:OFXSGML
+VERSION:102
+SECURITY:NONE
+ENCODING:USASCII
+CHARSET:1252
+COMPRESSION:NONE
+OLDFILEUID:NONE
+NEWFILEUID:NONE
+
+<OFX>
+  <SIGNONMSGSRSV1>
+    <SONRS>
+      <STATUS>
+        <CODE>0</CODE>
+        <SEVERITY>INFO</SEVERITY>
+      </STATUS>
+      <DTSERVER>20070623192010</DTSERVER>
+      <LANGUAGE>ENG</LANGUAGE>
+      <FI>
+        <ORG>Citigroup</ORG>
+        <FID>24909</FID>
+      </FI>
+      <INTU.BID>24909</INTU.BID>
+    </SONRS>
+  </SIGNONMSGSRSV1>
+  <CREDITCARDMSGSRSV1>
+    <CCSTMTTRNRS>
+      <TRNUID>0</TRNUID>
+      <STATUS>
+        <CODE>0</CODE>
+        <SEVERITY>INFO</SEVERITY>
+      </STATUS>
+      <CCSTMTRS>
+        <CURDEF>USD</CURDEF>
+        <CCACCTFROM>
+          <ACCTID>XXXXXXXXXXXX1111</ACCTID>
+        </CCACCTFROM>
+        <BANKTRANLIST>
+          <DTSTART>20070509120000</DTSTART>
+          <DTEND>20070608120000</DTEND>
+          <STMTTRN>
+            <TRNTYPE>DEBIT</TRNTYPE>
+            <DTPOSTED>20070510170000</DTPOSTED>
+            <TRNAMT>-19.17</TRNAMT>
+            <FITID>xx</FITID>
+            <SIC>5912</SIC>
+            <NAME>WALGREEN      34638675 ANYTOWN</NAME>
+          </STMTTRN>
+          <STMTTRN>
+            <TRNTYPE>DEBIT</TRNTYPE>
+            <DTPOSTED>20070512170000</DTPOSTED>
+            <TRNAMT>-12.0</TRNAMT>
+            <FITID>yy-56</FITID>
+            <SIC>7933</SIC>
+            <NAME>SUNSET BOWL            ANYTOWN</NAME>
+          </STMTTRN>
+          <STMTTRN>
+            <TRNTYPE>CREDIT</TRNTYPE>
+            <DTPOSTED>20070526170000</DTPOSTED>
+            <TRNAMT>11.01</TRNAMT>
+            <FITID>78-9</FITID>
+            <SIC>0000</SIC>
+            <NAME>ELECTRONIC PAYMENT-THANK YOU</NAME>
+          </STMTTRN>
+        </BANKTRANLIST>
+        <LEDGERBAL>
+          <BALAMT>-1111.01</BALAMT>
+          <DTASOF>20070623192013</DTASOF>
+        </LEDGERBAL>
+        <AVAILBAL>
+          <BALAMT>19000.99</BALAMT>
+          <DTASOF>20070623192013</DTASOF>
+        </AVAILBAL>
+      </CCSTMTRS>
+    </CCSTMTTRNRS>
+  </CREDITCARDMSGSRSV1>
+</OFX>
+

data/spec/fixtures/sample.ofx

@@ -45,6 +45,7 @@ NEWFILEUID:NONE
 						<FITID>200910091
 						<CHECKNUM>0001223
 						<MEMO>COMPRA VISA ELECTRON
+            <SIC>5072
 					</STMTTRN><STMTTRN>
 						<TRNTYPE>CREDIT
 						<DTPOSTED>20091016080000
@@ -303,6 +304,10 @@ NEWFILEUID:NONE
 					<BALAMT>598.44
 					<DTASOF>20091101
 				</LEDGERBAL>
+        <AVAILBAL>
+          <BALAMT>1555.99</BALAMT>
+          <DTASOF>20091101</DTASOF>
+        </AVAILBAL>
 			</STMTRS>
 		</STMTTRNRS>
 	</BANKMSGSRSV1>

data/spec/ofx/account_spec.rb

@@ -40,5 +40,42 @@ describe OFX::Account do
     it "should return balance date" do
       @account.balance.posted_at.should == Time.parse("2009-11-01")
     end
+    
+    context "available_balance" do
+      it "should return available balance" do
+        @account.available_balance.amount.should == 1555.99
+      end
+    
+      it "should return available balance in pennies" do
+        @account.available_balance.amount_in_pennies.should == 155599
+      end
+    
+      it "should return available balance date" do
+        @account.available_balance.posted_at.should == Time.parse("2009-11-01")
+      end
+      
+      it "should return nil if AVAILBAL not found" do
+        @ofx = OFX::Parser::Base.new("spec/fixtures/utf8.ofx")
+        @parser = @ofx.parser
+        @account = @parser.account
+        @account.available_balance.should be_nil
+      end
+    end
+    
+    context "Credit Card" do
+      before do
+        @ofx = OFX::Parser::Base.new("spec/fixtures/creditcard.ofx")
+        @parser = @ofx.parser
+        @account = @parser.account
+      end
+
+      it "should return id" do
+        @account.id.should == "XXXXXXXXXXXX1111"
+      end
+      
+      it "should return currency" do
+        @account.currency.should == "USD"
+      end
+    end
   end
 end

data/spec/ofx/ofx102_spec.rb

@@ -26,6 +26,10 @@ describe OFX::Parser::OFX102 do
   it "should set account" do
     @parser.account.should be_a_kind_of(OFX::Account)
   end
+
+  it "should set account" do
+    @parser.sign_on.should be_a_kind_of(OFX::SignOn)
+  end
   
   it "should know about all transaction types" do
     valid_types = [

data/spec/ofx/ofx211_spec.rb

@@ -22,6 +22,10 @@ describe OFX::Parser::OFX211 do
     @parser.account.should be_a_kind_of(OFX::Account)
   end
 
+  it "should set account" do
+    @parser.sign_on.should be_a_kind_of(OFX::SignOn)
+  end
+
   context "transactions" do
     before do
       @transactions = @parser.account.transactions

data/spec/ofx/sign_on_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe OFX::SignOn do
+  before do
+    @ofx = OFX::Parser::Base.new("spec/fixtures/creditcard.ofx")
+    @parser = @ofx.parser
+    @sign_on = @parser.sign_on
+  end
+
+  describe "sign_on" do
+    it "should return language" do
+      @sign_on.language.should == "ENG"
+    end
+
+    it "should return Financial Institution ID" do
+      @sign_on.fi_id.should == "24909"
+    end
+
+    it "should return Financial Institution Name" do
+      @sign_on.fi_name.should == "Citigroup"
+    end
+  end
+end

data/spec/ofx/transaction_spec.rb

@@ -43,6 +43,10 @@ describe OFX::Transaction do
     it "should have type" do
       @transaction.type.should == :debit
     end
+
+    it "should have sic" do
+      @transaction.sic.should == '5072'
+    end
   end
 
   context "credit" do
@@ -77,6 +81,10 @@ describe OFX::Transaction do
     it "should have type" do
       @transaction.type.should == :credit
     end
+    
+    it "should have empty sic" do
+      @transaction.sic.should == ''
+    end
   end
 
   context "with more info" do

metadata

@@ -1,69 +1,102 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: ofx
-version: !ruby/object:Gem::Version 
-  prerelease: 
-  version: 0.3.1
+version: !ruby/object:Gem::Version
+  version: 0.3.2
 platform: ruby
-authors: 
+authors:
 - Nando Vieira
+- Anna Cruz
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-05-16 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2013-08-24 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: nokogiri
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.7'
+  type: :development
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        version: "2.6"
+      - !ruby/object:Gem::Version
+        version: '2.7'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: ruby-debug19
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-debugger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |
   A simple OFX (Open Financial Exchange) parser built on top of Nokogiri.
   Currently supports OFX 102, 200 and 211.
-  
+
   Usage:
-  
+
     OFX("sample.ofx") do |ofx|
       p ofx
     end
-
-email: 
+email:
 - fnando.vieira@gmail.com
+- anna.cruz@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rspec
 - Gemfile
@@ -78,11 +111,13 @@ files:
 - lib/ofx/parser.rb
 - lib/ofx/parser/ofx102.rb
 - lib/ofx/parser/ofx211.rb
+- lib/ofx/sign_on.rb
 - lib/ofx/transaction.rb
 - lib/ofx/version.rb
 - ofx.gemspec
 - spec/fixtures/avatar.gif
 - spec/fixtures/bb.ofx
+- spec/fixtures/creditcard.ofx
 - spec/fixtures/invalid_version.ofx
 - spec/fixtures/sample.ofx
 - spec/fixtures/utf8.ofx
@@ -92,38 +127,37 @@ files:
 - spec/ofx/ofx211_spec.rb
 - spec/ofx/ofx_parser_spec.rb
 - spec/ofx/ofx_spec.rb
+- spec/ofx/sign_on_spec.rb
 - spec/ofx/transaction_spec.rb
 - spec/spec_helper.rb
 homepage: http://rubygems.org/gems/ofx
 licenses: []
-
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.1
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
-summary: A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports OFX 102, 200 and 211.
-test_files: 
+specification_version: 4
+summary: A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently
+  supports OFX 102, 200 and 211.
+test_files:
 - spec/fixtures/avatar.gif
 - spec/fixtures/bb.ofx
+- spec/fixtures/creditcard.ofx
 - spec/fixtures/invalid_version.ofx
 - spec/fixtures/sample.ofx
 - spec/fixtures/utf8.ofx
@@ -133,5 +167,6 @@ test_files:
 - spec/ofx/ofx211_spec.rb
 - spec/ofx/ofx_parser_spec.rb
 - spec/ofx/ofx_spec.rb
+- spec/ofx/sign_on_spec.rb
 - spec/ofx/transaction_spec.rb
 - spec/spec_helper.rb