ofx 0.2.3 → 0.2.4

data/lib/ofx/errors.rb

@@ -1,3 +1,3 @@
 module OFX
-  class UnsupportedVersionError < StandardError; end
+  class UnsupportedFileError < StandardError; end
 end

data/lib/ofx/parser.rb

@@ -7,14 +7,17 @@ module OFX
       attr_reader :parser
 
       def initialize(resource)
-        @content = open_resource(resource).read
+        resource = open_resource(resource)
+        resource.rewind
+
+        @content = resource.read
         @headers, @body = prepare(content)
 
         case @headers["VERSION"]
         when "102" then
           @parser = OFX::Parser::OFX102.new(:headers => headers, :body => body)
         else
-          raise OFX::UnsupportedVersionError
+          raise OFX::UnsupportedFileError
         end
       end
 
@@ -35,6 +38,8 @@ module OFX
           # Split headers & body
           headers, body = content.dup.split(/\n{2,}|:?<OFX>/, 2)
 
+          raise OFX::UnsupportedFileError unless body
+
           # Parse headers. When value is NONE, convert it to nil.
           headers = headers.to_enum(:each_line).inject({}) do |memo, line|
             _, key, value = *line.match(/^(.*?):(.*?)(\r?\n)*$/)

data/lib/ofx/version.rb

@@ -2,7 +2,7 @@ module OFX
   module Version
     MAJOR = 0
     MINOR = 2
-    PATCH = 3
+    PATCH = 4
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/ofx.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ofx}
-  s.version = "0.2.3"
+  s.version = "0.2.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nando Vieira"]
-  s.date = %q{2010-03-09}
+  s.date = %q{2010-03-10}
   s.description = %q{A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports OFX 1.0.2.
 
 Usage:
@@ -34,6 +34,7 @@ Usage:
      "lib/ofx/transaction.rb",
      "lib/ofx/version.rb",
      "ofx.gemspec",
+     "spec/fixtures/avatar.gif",
      "spec/fixtures/invalid_version.ofx",
      "spec/fixtures/sample.ofx",
      "spec/ofx/account_spec.rb",

data/spec/ofx/ofx_parser_spec.rb

@@ -33,7 +33,13 @@ describe OFX::Parser do
   it "should raise exception when trying to parse an unsupported OFX version" do
     lambda {
       OFX::Parser::Base.new("spec/fixtures/invalid_version.ofx")
-    }.should raise_error(OFX::UnsupportedVersionError)
+    }.should raise_error(OFX::UnsupportedFileError)
+  end
+
+  it "should raise exception when trying to parse an invalid file" do
+    lambda {
+      OFX::Parser::Base.new("spec/fixtures/avatar.gif")
+    }.should raise_error(OFX::UnsupportedFileError)
   end
 
   describe "headers" do

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 3
-  version: 0.2.3
+  - 4
+  version: 0.2.4
 platform: ruby
 authors: 
 - Nando Vieira
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-09 00:00:00 -03:00
+date: 2010-03-10 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -57,6 +57,7 @@ files:
 - lib/ofx/transaction.rb
 - lib/ofx/version.rb
 - ofx.gemspec
+- spec/fixtures/avatar.gif
 - spec/fixtures/invalid_version.ofx
 - spec/fixtures/sample.ofx
 - spec/ofx/account_spec.rb