offsite_payments 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b93c09319f5c58335021b513de7d370d04369846
-  data.tar.gz: 27db91e8bc8007d62fd62c10bbedbc301b5e87e8
+  metadata.gz: 9f3751c70ad135fce78fe690b43bd5f14cbabd90
+  data.tar.gz: 6f1a39ec1021b73443533901f56110e91b943ad9
 SHA512:
-  metadata.gz: 2e3892c9fc35ef7949b8b98ea8521bdf33d98c58b2e8a8ff220d3d7fcabd5efc4de1d0bca75ca9431d1df4374d14d938aa58e7fba60cd0a4693d46180ab5db53
-  data.tar.gz: cc5bb2b3a068fb481f6a09365ad359005fd31d5a2d202d93e143b00287653b7a5ea76533b41d90c0cbe43b375bf33eb4aa3a9b30bd89bb448b0cf4bb0fdf7223
+  metadata.gz: 63a6d6d932073822f7ac36ea377991e0f9af6ffd33cf3a0ae9662ffedd606af5625e5bb11052544d6d50c75e061c5e44243801ceb610e873398de7aee7e5aa69
+  data.tar.gz: 1197aa56f07ce913018dbde66b41186040a8c892657c1739079fe6cc194d990e753d6ef336a65bcb9fdded91367b4368e50fe6e20ce0124cfc2b037f7ee24efb

data/README.md

@@ -1,6 +1,6 @@
 # Offsite Payments
-[![Build Status](https://travis-ci.org/activemerchant/offsite_payments.png?branch=master)](https://travis-ci.org/activemerchant/offsite_payments)
-[![Code Climate](https://codeclimate.com/github/activemerchant/offsite_payments.png)](https://codeclimate.com/github/activemerchant/offsite_payments)
+[![Build Status](https://travis-ci.org/activemerchant/offsite_payments.svg?branch=master)](https://travis-ci.org/activemerchant/offsite_payments)
+[![Code Climate](https://codeclimate.com/github/activemerchant/offsite_payments/badges/gpa.svg)](https://codeclimate.com/github/activemerchant/offsite_payments)
 
 Offsite Payments is an extraction from the ecommerce system [Shopify](http://www.shopify.com). Shopify's requirements for a simple and unified API to handle dozens of different offsite payment pages (often called hosted payment pages) with very different exposed APIs was the chief principle in designing the library.
 

data/lib/offsite_payments.rb

@@ -2,6 +2,8 @@ require 'securerandom'
 require 'cgi'
 require "timeout"
 require "socket"
+require 'bigdecimal'
+require 'bigdecimal/util'
 
 require 'active_utils'
 

data/lib/offsite_payments/integrations/checkout_finland.rb

@@ -0,0 +1,166 @@
+module OffsitePayments #:nodoc:
+  module Integrations #:nodoc:
+    module CheckoutFinland
+
+      mattr_accessor :service_url
+      self.service_url = 'https://payment.checkout.fi/'
+
+      def self.notification(post)
+        Notification.new(post)
+      end
+
+      class Helper < OffsitePayments::Helper
+        include ActiveUtils::PostsData
+        self.country_format = :alpha3
+
+        def initialize(order, account, options = {})
+          md5secret options.delete(:credential2)
+          super
+
+          # Add default fields
+          add_field("VERSION", "0001") # API version
+          add_field("ALGORITHM", "3") # Return MAC version (3 is HMAC-SHA256)
+          add_field("TYPE", "0")
+          add_field("DEVICE", "1") # Offsite payment by default
+        end
+
+        def md5secret(value)
+          @md5secret = value
+        end
+
+        # Add MAC to form fields
+        def form_fields
+          @fields.merge("MAC" => generate_md5string)
+        end
+
+        # Apply parameter length limitations recommended by Checkout.fi
+        def add_field(name, value)
+          return if name.blank? || value.blank?
+          @fields[name.to_s] = check_param_length(name_to_s, value.to_s)
+        end
+
+        # API parameter length limitations specified by Checkout.fi
+        # Parameters longer than this cause the HTTP POST to fail
+        def check_param_length(name, value)
+          # Soft limitations, fields that can be clipped
+          max_length_substring = { "FIRSTNAME" => 40, "FAMILYNAME" => 40, "ADDRESS" => 40, "POSTCODE" => 14, "POSTOFFICE" => 18, "MESSAGE" => 1000, "EMAIL" => 200, "PHONE" => 30 }
+          # Hard limitations, fields that cannot be clipped
+          max_length_exception = { "RETURN" => 300, "CANCEL" => 300, "REJECT" => 300, "DELAYED" => 300, "STAMP" => 20, "AMOUNT" => 8, "REFERENCE" => 20, "CONTENT" => 2, "LANGUAGE" => 2, "MERCHANT" => 20, "COUNTRY" => 3, "CURRENCY" => 3, "DELIVERY_DATE" => 8 }
+          if max_length_substring.include? name
+            return value.to_s[0, max_length_substring[name]]
+          end
+          if max_length_exception.include? name
+            if value.to_s.length > max_length_exception[name]
+              raise ArgumentError, "Field #{name} length #{value.length} is longer than permitted by provider API. Maximum length #{max_length_exception[name]}."
+            else
+              return value
+            end
+          end
+          value
+        end
+
+        # Calculate MAC
+        def generate_md5string
+          fields = [@fields["VERSION"], @fields["STAMP"], @fields["AMOUNT"], @fields["REFERENCE"],
+                    @fields["MESSAGE"], @fields["LANGUAGE"], @fields["MERCHANT"], @fields["RETURN"],
+                    @fields["CANCEL"], @fields["REJECT"], @fields["DELAYED"], @fields["COUNTRY"],
+                    @fields["CURRENCY"], @fields["DEVICE"], @fields["CONTENT"], @fields["TYPE"],
+                    @fields["ALGORITHM"], @fields["DELIVERY_DATE"], @fields["FIRSTNAME"], @fields["FAMILYNAME"],
+                    @fields["ADDRESS"], @fields["POSTCODE"], @fields["POSTOFFICE"], @md5secret]
+           fields = fields.join("+")
+           Digest::MD5.hexdigest(fields).upcase 
+        end
+
+        # Mappings
+        mapping :order, 'STAMP' # Unique order number for each payment
+        mapping :account, 'MERCHANT' # Checkout Merchant ID
+        mapping :amount, 'AMOUNT' # Amount in cents
+        mapping :reference, 'REFERENCE' # Reference for bank statement
+        mapping :language, 'LANGUAGE' # "FI" / "SE" / "EN"
+        mapping :currency, 'CURRENCY' # "EUR" currently only
+        mapping :device, 'DEVICE' # "1" = HTML / "10" = XML
+        mapping :content, 'CONTENT' # "1" = NORMAL "2" = ADULT CONTENT
+        mapping :delivery_date, 'DELIVERY_DATE' # "YYYYMMDD"
+        mapping :description, 'MESSAGE' # Description of the order
+
+        # Optional customer data supported by API (not mandatory)
+        mapping :customer, :first_name => 'FIRSTNAME',
+                           :last_name  => 'FAMILYNAME',
+                           :email      => 'EMAIL',
+                           :phone      => 'PHONE'
+
+        # Optional fields supported by API (not mandatory)
+        mapping :billing_address, :city     => 'POSTOFFICE',
+                                  :address1 => 'ADDRESS',
+                                  :zip      => 'POSTCODE',
+                                  :country  => 'COUNTRY'
+
+        mapping :notify_url, 'DELAYED' # Delayed payment URL (mandatory)
+        mapping :reject_url, 'REJECT' # Rejected payment URL (mandatory)
+        mapping :return_url, 'RETURN' # Payment URL (optional)
+        mapping :cancel_return_url, 'CANCEL' # Cancelled payment URL (optional)
+      end
+
+      class Notification < OffsitePayments::Notification
+        # Payment can be market complete with the following status codes
+        def complete?
+          ["2", "5", "6", "8", "9", "10"].include? params["STATUS"]
+        end
+
+        # Did the customer choose delayed payment method
+        def delayed?
+          params['STATUS'] == "3"
+        end
+
+        # Did the customer cancel the payment
+        def cancelled?
+          params['STATUS'] == "-1"
+        end
+
+        # Payment requires manual activation (fraud check etc)
+        def activation?
+          params['STATUS'] == "7"
+        end
+
+        # Reference specified by the client when sending payment
+        def reference
+          params['REFERENCE']
+        end
+
+        # Unique ID assigned by Checkout
+        def transaction_id
+          params['PAYMENT']
+        end
+
+        # Unique ID assigned by customer
+        def stamp
+          params['STAMP']
+        end
+
+        # Returned Message Authentication Code
+        def mac
+          params['MAC']
+        end
+
+        def status
+          params['STATUS']
+        end
+
+        # Verify authenticity of returned data
+        def acknowledge(authcode = nil)
+          return_authcode = [params["VERSION"], params["STAMP"], params["REFERENCE"], params["PAYMENT"], params["STATUS"], params["ALGORITHM"]].join("&")
+          OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('sha256'), authcode, return_authcode).upcase == params["MAC"]
+        end
+
+        private
+
+        # Take the posted data and move the data into params
+        def parse(post)
+          post.each do |key, value|
+            params[key] = value
+          end
+        end
+      end
+    end
+  end
+end

data/lib/offsite_payments/integrations/citrus.rb

@@ -97,7 +97,7 @@ module OffsitePayments
         end
 
         def amount_ok?( order_amount )
-          BigDecimal.new( amount ) == order_amount
+          amount.to_d == order_amount
         end
 
         def item_id
@@ -120,7 +120,7 @@ module OffsitePayments
         end
 
         def amount
-          gross
+          Money.from_amount(BigDecimal.new(gross), currency)
         end
 
         def transaction_id
@@ -182,7 +182,7 @@ module OffsitePayments
         end
 
         def checksum_ok?
-          fields = [invoice, transaction_status, amount.to_s, transaction_id, issuerrefno, authidcode, customer_first_name, customer_last_name, pgrespcode, customer_address[:zip]].join
+          fields = [invoice, transaction_status, sprintf('%.2f', amount), transaction_id, issuerrefno, authidcode, customer_first_name, customer_last_name, pgrespcode, customer_address[:zip]].join
 
           unless Citrus.checksum(@secret_key, fields ) == checksum
             @message = 'checksum mismatch...'

data/lib/offsite_payments/integrations/easy_pay.rb

@@ -101,7 +101,7 @@ module OffsitePayments #:nodoc:
         end
 
         def amount
-          BigDecimal.new(gross)
+          Money.from_amount(BigDecimal.new(gross), currency)
         end
 
         def item_id
@@ -131,6 +131,10 @@ module OffsitePayments #:nodoc:
         def success_response(*args)
           { :nothing => true }
         end
+
+        def currency
+          'BYR'
+        end
       end
     end
   end

data/lib/offsite_payments/integrations/liqpay.rb

@@ -80,7 +80,7 @@ module OffsitePayments #:nodoc:
         end
 
         def amount
-          BigDecimal.new(gross)
+          Money.from_amount(BigDecimal.new(gross), currency)
         end
 
         def item_id

data/lib/offsite_payments/integrations/mollie_ideal.rb

@@ -7,7 +7,7 @@ module OffsitePayments #:nodoc:
       self.live_issuers = [
         ["ABN AMRO", "ideal_ABNANL2A"],
         ["ASN Bank", "ideal_ASNBNL21"],
-        ["Friesland Bank", "ideal_FRBKNL2L"],
+        ["Bunq", "ideal_BUNQNL2A"],
         ["ING", "ideal_INGBNL2A"],
         ["Knab", "ideal_KNABNL2H"],
         ["Rabobank", "ideal_RABONL2U"],

data/lib/offsite_payments/integrations/pay_fast.rb

@@ -212,7 +212,7 @@ module OffsitePayments #:nodoc:
 
         # The net amount credited to the receiver's account.
         def amount
-          params['amount_net']
+          Money.from_amount(BigDecimal.new(params['amount_net']), currency)
         end
 
         # The name of the item being charged for.
@@ -226,7 +226,7 @@ module OffsitePayments #:nodoc:
         end
 
         def currency
-          nil
+          'ZAR'
         end
 
         # Generated hash depends on params order so use OrderedHash instead of Hash

data/lib/offsite_payments/integrations/paydollar.rb

@@ -2,26 +2,56 @@ module OffsitePayments #:nodoc:
   module Integrations #:nodoc:
     module Paydollar
       CURRENCY_MAP = {
-          'AED' => '784',
-          'AUD' => '036',
-          'BND' => '096',
-          'CAD' => '124',
+          'HKD' => '344',
+          'USD' => '840',
+          'SGD' => '702',
           'CNY' => '156',
+          'JPY' => '392',
+          'TWD' => '901',
+          'AUD' => '036',
           'EUR' => '978',
           'GBP' => '826',
-          'HKD' => '344',
-          'IDR' => '360',
-          'JPY' => '392',
-          'KRW' => '410',
+          'CAD' => '124',
           'MOP' => '446',
+          'PHP' => '608',
+          'THB' => '764',
           'MYR' => '458',
+          'IDR' => '360',
+          'KRW' => '410',
+          'BND' => '096',
           'NZD' => '554',
-          'PHP' => '608',
           'SAR' => '682',
-          'SGD' => '702',
-          'THB' => '764',
-          'TWD' => '901',
-          'USD' => '840',
+          'AED' => '784',
+          'BRL' => '986',
+          'INR' => '356',
+          'TRY' => '949',
+          'ZAR' => '710',
+          'VND' => '704',
+          'DKK' => '208',
+          'ILS' => '376',
+          'NOK' => '578',
+          'RUB' => '643',
+          'SEK' => '752',
+          'CHF' => '756',
+          'ARS' => '032',
+          'CLP' => '152',
+          'COP' => '170',
+          'CZK' => '203',
+          'EGP' => '818',
+          'HUF' => '348',
+          'KZT' => '398',
+          'LBP' => '422',
+          'MXN' => '484',
+          'NGN' => '566',
+          'PKR' => '586',
+          'PEN' => '604',
+          'PLN' => '985',
+          'QAR' => '634',
+          'RON' => '946',
+          'UAH' => '980',
+          'VEF' => '937',
+          'LKR' => '144',
+          'KWD' => '414',
       }
 
       def self.service_url

data/lib/offsite_payments/integrations/paytm.rb

@@ -0,0 +1,168 @@
+module OffsitePayments #:nodoc:
+  module Integrations #:nodoc:
+    module Paytm
+    
+      def self.notification(post, options = {})
+        Notification.new(post, options)
+      end
+
+      def self.return(query_string, options = {})
+        Return.new(query_string, options)
+      end
+
+      def self.sign(fields, key)
+        Base64.encode64(OpenSSL::HMAC.digest(OpenSSL::Digest::SHA256.new, key, fields.sort.join)).delete("\n")
+      end
+
+      class Helper < OffsitePayments::Helper
+        CURRENCY_SPECIAL_MINOR_UNITS = {
+          'BIF' => 0,
+          'BYR' => 0,
+          'CLF' => 0,
+          'CLP' => 0,
+          'CVE' => 0,
+          'DJF' => 0,
+          'GNF' => 0,
+          'HUF' => 0,
+          'ISK' => 0,
+          'JPY' => 0,
+          'KMF' => 0,
+          'KRW' => 0,
+          'PYG' => 0,
+          'RWF' => 0,
+          'UGX' => 0,
+          'UYI' => 0,
+          'VND' => 0,
+          'VUV' => 0,
+          'XAF' => 0,
+          'XOF' => 0,
+          'XPF' => 0,
+          'BHD' => 3,
+          'IQD' => 3,
+          'JOD' => 3,
+          'KWD' => 3,
+          'LYD' => 3,
+          'OMR' => 3,
+          'TND' => 3,
+          'COU' => 4
+        }
+
+        def initialize(order, account, options = {})
+          mid_param = { MID: account }.to_query
+          @forward_url_stag = "https://pguat.paytm.com/oltp-web/genericPT?#{mid_param}"
+          @forward_url_prod = "https://secure.paytm.in/oltp-web/genericPT?#{mid_param}"
+          @key = options[:credential2]
+          @currency = options[:currency]
+
+          super
+          add_field 'x_test', @test.to_s
+        end
+
+        def credential_based_url
+          @test ?  @forward_url_stag : @forward_url_prod
+        end
+
+        def form_fields
+          sign_fields
+        end
+
+        def amount=(amount)
+          add_field 'x_amount', format_amount(amount, @currency)
+        end
+
+        def sign_fields
+          @fields.merge!('x_signature' => generate_signature)
+        end
+
+        def generate_signature
+          Paytm.sign(@fields, @key)
+        end
+
+        mapping :account,          'x_account_id'
+        mapping :currency,         'x_currency'
+        mapping :order,            'x_reference'
+        mapping :description,      'x_description'
+        mapping :invoice,          'x_invoice'
+        mapping :credential3,      'x_credential3'
+        mapping :credential4,      'x_credential4'
+
+        mapping :customer, :email      => 'x_customer_email',
+                           :phone      => 'x_customer_phone'
+
+        mapping        :notify_url, 'x_url_callback'
+        mapping        :return_url, 'x_url_complete'
+        mapping :cancel_return_url, 'x_url_cancel'
+
+        private
+
+        def format_amount(amount, currency)
+          units = CURRENCY_SPECIAL_MINOR_UNITS[currency] || 2
+          sprintf("%.#{units}f", amount)
+        end
+      end
+
+      class Notification < OffsitePayments::Notification
+        def initialize(post, options = {})
+          super
+          @key = options[:credential2]
+        end
+
+        def acknowledge(authcode = nil)
+          signature = @params['x_signature']
+          signature == generate_signature ? true : false
+        end
+
+        def item_id
+          @params['x_reference']
+        end
+
+        def currency
+          @params['x_currency']
+        end
+
+        def gross
+          @params['x_amount']
+        end
+
+        def transaction_id
+          @params['x_gateway_reference']
+        end
+
+        def status
+          result = @params['x_result']
+          result && result.capitalize
+        end
+
+        def message
+          @params['x_message']
+        end
+
+        def test?
+          @params['x_test'] == 'true'
+        end
+
+        private
+
+        def generate_signature
+          signature_params = @params.select { |k| k.start_with? 'x_' }.reject { |k| k == 'x_signature' }
+          Paytm.sign(signature_params, @key)
+        end
+      end
+
+      class Return < OffsitePayments::Return
+        def initialize(query_string, options = {})
+          super
+          @notification = Notification.new(query_string, options)
+        end
+
+        def success?
+          @notification.acknowledge
+        end
+
+        def message
+          @notification.message
+        end
+      end
+    end
+  end
+end

data/lib/offsite_payments/integrations/payu_in.rb

@@ -84,8 +84,9 @@ module OffsitePayments #:nodoc:
         end
 
         def sanitize_fields
-          ['address1', 'address2', 'city', 'state', 'country', 'productinfo', 'email', 'phone'].each do |field|
-            @fields[field].gsub!(/[^a-zA-Z0-9\-_@\/\s.]/, '') if @fields[field]
+          @fields['phone'] = @fields['phone'].gsub(/[^0-9]/, '') if @fields['phone']
+          ['address1', 'address2', 'city', 'state', 'country', 'productinfo', 'email'].each do |field|
+            @fields[field] = @fields[field].gsub(/[^a-zA-Z0-9\-_@\/\s.]/, '') if @fields[field]
           end
         end
 

data/lib/offsite_payments/integrations/platron.rb

@@ -120,7 +120,7 @@ module OffsitePayments #:nodoc:
         end
 
         def amount
-          params['pg_amount']
+          Money.from_amount(BigDecimal.new(params['pg_amount']), currency)
         end
 
         def secret

data/lib/offsite_payments/integrations/realex_offsite.rb

@@ -71,20 +71,20 @@ module OffsitePayments #:nodoc:
         end
 
         # Realex accepts currency amounts as an integer in the lowest value
-        # e.g. 
+        # e.g.
         #     format_amount(110.56, 'GBP')
         #     => 11056
         def format_amount(amount, currency)
           units = CURRENCY_SPECIAL_MINOR_UNITS[currency] || 2
           multiple = 10**units
-          return (amount.to_f * multiple.to_f).to_i
+          return ((amount || 0).to_d * multiple.to_d).to_i
         end
 
         # Realex returns currency amount as an integer
         def format_amount_as_float(amount, currency)
           units = CURRENCY_SPECIAL_MINOR_UNITS[currency] || 2
           divisor = 10**units
-          return (amount.to_f / divisor.to_f)
+          return ((amount || 0).to_d / divisor.to_d)
         end
 
         def extract_digits(value)

data/lib/offsite_payments/integrations/robokassa.rb

@@ -103,10 +103,6 @@ module OffsitePayments #:nodoc:
           true
         end
 
-        def amount
-          BigDecimal.new(gross)
-        end
-
         def item_id
           params['InvId']
         end
@@ -138,6 +134,10 @@ module OffsitePayments #:nodoc:
         def success_response(*args)
           "OK#{item_id}"
         end
+
+        def currency
+          'RUB'
+        end
       end
 
       class Return < OffsitePayments::Return

data/lib/offsite_payments/integrations/sage_pay_form.rb

@@ -160,8 +160,8 @@ module OffsitePayments #:nodoc:
           parts = fields.map { |k, v| "#{k}=#{sanitize(k, v)}" unless v.nil? }.compact.shuffle
           parts.unshift(sage_encrypt_salt(key.length, key.length * 2))
           sage_encrypt(parts.join('&'), key)
-        rescue OpenSSL::Cipher::CipherError => e
-          if e.message == 'key length too short'
+        rescue OpenSSL::Cipher::CipherError, ArgumentError => e
+          if e.message == 'key length too short' || e.message == 'key must be 16 bytes'
             raise ActionViewHelperError, 'Invalid encryption key.'
           else
             raise

data/lib/offsite_payments/integrations/universal.rb

@@ -73,14 +73,6 @@ module OffsitePayments #:nodoc:
           add_field 'x_amount', format_amount(amount, @currency)
         end
 
-        def shipping(amount)
-          add_field 'x_amount_shipping', format_amount(amount, @currency)
-        end
-
-        def tax(amount)
-          add_field 'x_amount_tax', format_amount(amount, @currency)
-        end
-
         def sign_fields
           @fields.merge!('x_signature' => generate_signature)
         end
@@ -105,6 +97,17 @@ module OffsitePayments #:nodoc:
                            :email      => 'x_customer_email',
                            :phone      => 'x_customer_phone'
 
+        mapping :billing_address, :first_name => 'x_customer_billing_first_name',
+                                  :last_name =>  'x_customer_billing_last_name',
+                                  :city =>       'x_customer_billing_city',
+                                  :company =>    'x_customer_billing_company',
+                                  :address1 =>   'x_customer_billing_address1',
+                                  :address2 =>   'x_customer_billing_address2',
+                                  :state =>      'x_customer_billing_state',
+                                  :zip =>        'x_customer_billing_zip',
+                                  :country =>    'x_customer_billing_country',
+                                  :phone =>      'x_customer_billing_phone'
+
         mapping :shipping_address, :first_name => 'x_customer_shipping_first_name',
                                    :last_name =>  'x_customer_shipping_last_name',
                                    :city =>       'x_customer_shipping_city',
@@ -160,6 +163,10 @@ module OffsitePayments #:nodoc:
           result && result.capitalize
         end
 
+        def message
+          @params['x_message']
+        end
+
         def test?
           @params['x_test'] == 'true'
         end
@@ -181,6 +188,10 @@ module OffsitePayments #:nodoc:
         def success?
           @notification.acknowledge
         end
+
+        def message
+          @notification.message
+        end
       end
     end
   end

data/lib/offsite_payments/integrations/web_pay.rb

@@ -150,7 +150,7 @@ module OffsitePayments #:nodoc:
         end
 
         def amount
-          BigDecimal.new(gross)
+          Money.from_amount(BigDecimal.new(gross), currency)
         end
 
         def item_id
@@ -180,6 +180,10 @@ module OffsitePayments #:nodoc:
         def success_response(*args)
           {:nothing => true}
         end
+
+        def currency
+          params['currency_id']
+        end
       end
     end
   end

data/lib/offsite_payments/integrations/webmoney.rb

@@ -83,7 +83,7 @@ module OffsitePayments #:nodoc:
         end
 
         def amount
-          BigDecimal.new(gross)
+          Money.from_amount(BigDecimal.new(gross), currency)
         end
 
         def key_present?
@@ -113,6 +113,10 @@ module OffsitePayments #:nodoc:
         def success_response(*args)
           {:nothing => true}
         end
+
+        def currency
+          'RUB'
+        end
       end
     end
   end

data/lib/offsite_payments/return.rb

@@ -25,9 +25,9 @@ module OffsitePayments #:nodoc:
       return {} if query_string.blank?
 
       query_string.split('&').inject({}) do |memo, chunk|
-        next if chunk.empty?
+        next memo if chunk.empty?
         key, value = chunk.split('=', 2)
-        next if key.empty?
+        next memo if key.empty?
         value = value.nil? ? nil : CGI.unescape(value)
         memo[CGI.unescape(key)] = value
         memo

data/lib/offsite_payments/version.rb

@@ -1,3 +1,3 @@
 module OffsitePayments
-  VERSION = "2.3.0"
+  VERSION = "2.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: offsite_payments
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-08 00:00:00.000000000 Z
+date: 2017-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -98,14 +98,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
@@ -216,6 +216,7 @@ files:
 - lib/offsite_payments/integrations/authorize_net_sim.rb
 - lib/offsite_payments/integrations/bit_pay.rb
 - lib/offsite_payments/integrations/bogus.rb
+- lib/offsite_payments/integrations/checkout_finland.rb
 - lib/offsite_payments/integrations/chronopay.rb
 - lib/offsite_payments/integrations/citrus.rb
 - lib/offsite_payments/integrations/coinbase.rb
@@ -248,6 +249,7 @@ files:
 - lib/offsite_payments/integrations/paypal.rb
 - lib/offsite_payments/integrations/paypal_payments_advanced.rb
 - lib/offsite_payments/integrations/paysbuy.rb
+- lib/offsite_payments/integrations/paytm.rb
 - lib/offsite_payments/integrations/payu_in.rb
 - lib/offsite_payments/integrations/payu_in_paisa.rb
 - lib/offsite_payments/integrations/platron.rb
@@ -288,7 +290,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.3
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Framework and tools for dealing with offsite (hosted) payment pages.