odeon_uk 3.0.5 → 3.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 923b9fdff96d0fa70efea9e1f4e3e6b98ff6e13e
-  data.tar.gz: 9009c376a212f175d79ee583f99a686983e758e5
+  metadata.gz: 8b082f5c0f73fda6b73b03492919f702c184722c
+  data.tar.gz: c870a782f33abddea4a316059cda6ff3d20b8534
 SHA512:
-  metadata.gz: 87307021efaed1bfc13f4b0cbf3ae0375f1b52d21412953ac64a7a7512e58a108a8206da35f6c983e9d47b45df5a77daba1a62e53a14f0f1400817bc7dfc25e6
-  data.tar.gz: ff6fcc044f3fe51a54558304bb944a050da392786b6cead54ff9bbf8ab6b35863d9c4845adfe4e4f48053828998d4a7aa78a677c1df4bc8d91a04cf33b996d5b
+  metadata.gz: 51cd7609ee9c4a39719830d96e3a6d29ac1263001105e0c7e1aac73f39e65aaeeebf66583a5071e65876470c463826eae07fe34ba2c0ab8d1c7482ac340dc6e2
+  data.tar.gz: 6b1a5702be7e67792bf5f3561bfdaab2f3064f43c977dbb9271456324054f799bee201f92621f20e84acadc6558b85238a32ad8c04bd3f08dbbac29a86f37c45

data/CHANGELOG.md

@@ -1,4 +1,9 @@
-## 3.0.4 - 2015-05-06
+## 3.0.6 - 2015-07-05
+
+### Fixed
+- Protect HTTP use against 500
+
+## 3.0.5 - 2015-07-04
 
 ### Fixed
 - API use for screenings

data/lib/odeon_uk/html/website.rb

@@ -30,6 +30,8 @@ module OdeonUk
 
       def get(path)
         URI("http://www.odeon.co.uk/#{path}").read
+      rescue OpenURI::HTTPError
+        ''
       end
     end
   end

data/lib/odeon_uk/version.rb

@@ -1,6 +1,6 @@
 # Ruby interface for http://www.odeon.co.uk
-# @version 3.0.5
+# @version 3.0.6
 module OdeonUk
   # Gem version
-  VERSION = '3.0.5'
+  VERSION = '3.0.6'
 end

data/test/lib/odeon_uk/html/website_test.rb

@@ -8,30 +8,60 @@ describe OdeonUk::Html::Website do
   describe '#cinema(id)' do
     subject { described_class.new.cinema(71) }
 
-    before { stub_get('cinemas/odeon/71/', cinema_html(71)) }
+    describe 'successful http request' do
+      before { stub_get('cinemas/odeon/71/', cinema_html(71)) }
 
-    it 'returns a string' do
-      subject.class.must_equal String
+      it 'returns a string' do
+        subject.class.must_equal String
+      end
+    end
+
+    describe 'unsuccessful http request' do
+      before { stub_get_with_500('cinemas/odeon/71/') }
+
+      it 'returns an empty string' do
+        subject.must_equal ''
+      end
     end
   end
 
   describe '#sitemap' do
     subject { described_class.new.sitemap }
 
-    before { stub_get('sitemap/', sitemap_html) }
+    describe 'successful http request' do
+      before { stub_get('sitemap/', sitemap_html) }
 
-    it 'returns a string' do
-      subject.class.must_equal String
+      it 'returns a string' do
+        subject.class.must_equal String
+      end
+    end
+
+    describe 'unsuccessful http request' do
+      before { stub_get_with_500('sitemap/') }
+
+      it 'returns an empty string' do
+        subject.must_equal ''
+      end
     end
   end
 
   describe '#showtimes(id)' do
     subject { described_class.new.showtimes(71) }
 
-    before { stub_get('showtimes/week/71/?siteId=71', showtimes_html(71)) }
+    describe 'successful http request' do
+      before { stub_get('showtimes/week/71/?siteId=71', showtimes_html(71)) }
+
+      it 'returns a string' do
+        subject.class.must_equal String
+      end
+    end
+
+    describe 'unsuccessful http request' do
+      before { stub_get_with_500('showtimes/week/71/?siteId=71') }
 
-    it 'returns a string' do
-      subject.class.must_equal String
+      it 'returns an empty string' do
+        subject.must_equal ''
+      end
     end
   end
 end

data/test/support/website_fixtures_helper.rb

@@ -17,6 +17,11 @@ module WebsiteFixturesHelper
     File.read(File.expand_path("../../fixtures/#{filepath}.html", __FILE__))
   end
 
+  def stub_get_with_500(site_path)
+    url      = "http://www.odeon.co.uk/#{site_path}"
+    stub_request(:get, url).to_return(status: [500, 'Internal Server Error'])
+  end
+
   def stub_get(site_path, response_body)
     url      = "http://www.odeon.co.uk/#{site_path}"
     response = { status: 200, body: response_body, headers: {} }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: odeon_uk
 version: !ruby/object:Gem::Version
-  version: 3.0.5
+  version: 3.0.6
 platform: ruby
 authors:
 - Andy Croll
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-04 00:00:00.000000000 Z
+date: 2015-07-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake