oddb2xml 2.5.2 → 2.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb05ed21aeb328d6c0e778329e443bc05452ac01
-  data.tar.gz: 123c961d1f3f418d4c95e042b8ed0ee71b16befb
+  metadata.gz: 1a338462cc07d2820cb85ed2bab9e76e527a7b2e
+  data.tar.gz: 8b675f13da43ab8967e5d6b389553029433899bf
 SHA512:
-  metadata.gz: 35ade63ce2514719a6ef2aa9768dbdf3b623050a6a27f40df3e500d1c3dc9c79cd646c939bc4a0a70db41b41d4b1022971a94c2f9d6b5cdaea355ec7eba4f771
-  data.tar.gz: 43a0b83e64bb749026b203693f865b708c88e8527c9168a135e7a59b5f52b70043522ea79c7fa544cca13d3436a582dc028c11b93c02963414cb26e2fddcfe62
+  metadata.gz: 45c766b45fe01b2b441aaab304347336f3962d2b83224dd43a5462da2b11c1f3cbeb598aba0c0c79e5fbba2ce6b9d951304a572adf1a2dfe29426c99b6b7858e
+  data.tar.gz: feb8c5046c1585e289a17a02f56d9dcebace6ddd8fb0df2c7d0027b1e4fcaabd838c555b799c2e549e2113d47acdf03cfb8cb6255a1651685987af506fb33595

data/.travis.yml

@@ -14,6 +14,7 @@ rvm:
   - 2.2.7
   - 2.3.4
   - 2.4.1
+  - 2.5.0
   - ruby-head
 
 matrix:

data/History.txt

@@ -1,3 +1,11 @@
+=== 2.5.3 / 28.03.2018
+
+* Updated needed Ruby version in README.md
+* Test using Ruby 2.5.0 on tracis-ci, too
+* Fix spec tests on travis-ci
+* Added bin/check_artikelstamm
+* Fixed problem with prodno in Artikeltstamm
+
 === 2.5.2 / 21.03.2018
 
 *  Artikelstamm

data/README.md

@@ -106,14 +106,8 @@ FR
 
 ## Supported ruby version
 
-We run tests on travis-ci.org for the Ruby versions mentioned in the .travis.yml file. These are
-* 1.9.3
-* 2.0.0
-* 2.1
-* ruby-head
-
-If you are running an older Ruby-Version (eg. 1.8 or 1.9.1), please upgrade before reporting a bug.
-See also http://bugs.ruby-lang.org/projects/ruby/wiki/ReleaseEngineering
+We run tests on travis-ci.org for the Ruby versions mentioned in the .travis.yml file. You will need ruby > 2.4 to work correctly.
+Ruby 2.2/2.3 have problems with i18n encoding and fail a spec test for Naropin
 
 
 ## XSD files

data/bin/check_artikelstamm

@@ -0,0 +1,30 @@
+#!/usr/bin/env ruby
+require 'pathname'
+
+root = Pathname.new(__FILE__).realpath.parent.parent
+$:.unshift root.join('lib') if $0 == __FILE__
+
+require 'oddb2xml/version'
+require 'oddb2xml/semantic_check'
+require 'trollop'
+
+@opts = Trollop::options(ARGV) do
+  version "#$0 ver.#{Oddb2xml::VERSION}"
+  banner <<-EOS
+    Runs various semanti_check for the Elexis artikelstamm
+  Usage:
+  #{File.basename(__FILE__)} xml_file_to_check
+EOS
+end
+$stdout.sync = false
+
+args = ARGV
+if args.size != 1
+  puts "you must pass exactly one  existing files. Not #{args}"
+  exit 2
+end
+
+startTime = Time.now
+result = Oddb2xml::SemanticCheck.new(ARGV.first).allSemanticChecks
+diff = (Time.now-startTime).to_i
+puts "#{Time.now.strftime("%H:%M:%S")}: #{__FILE__} done. Took #{diff} seconds"

data/lib/oddb2xml/builder.rb

@@ -51,7 +51,7 @@ module Oddb2xml
       @options    = args
       @subject    = nil
       @refdata    = {}
-      @items      = {} # Items from Preparations.xml in BAG, using GTINs as key
+      @items      = {} # Items from Preparations.xml in BAG, using @gtins as key
       @flags      = {}
       @lppvs      = {}
       @infos      = {}
@@ -1362,7 +1362,7 @@ module Oddb2xml
 
     def build_artikelstamm
       @@emitted_v5_gtins = []
-      @csv_file = CSV.open(File.join(WorkDir, "Elexis_Artikelstamm_v5.csv"), "w+")
+      @csv_file = CSV.open(File.join(WorkDir,  "artikelstamm_#{Date.today.strftime('%d%m%Y')}_v5.csv"), "w+")
       @csv_file << ['gtin', 'price', 'galenic_form', 'pkg_size', 'pexf', 'ppub', 'iksnr', 'atc_code', 'active_substance', 'original', 'it-code', 'sl-liste']
       @csv_file.sync = true
       variant = "build_artikelstamm"
@@ -1399,23 +1399,18 @@ module Oddb2xml
       end
       def emit_items(xml)
         nr_items = 0
-        gtins_to_article = {}
-        @articles.each {|article| gtins_to_article[article[:ean13]] = article }
-        gtins = gtins_to_article.keys + @infos_zur_rose.keys + @packs.values.collect{|x| x[:ean13]}
-        gtins = (gtins-@@gtin2ignore)
-        gtins.sort!.uniq!
-        @nr_items = gtins.size
-        gtins.each do |ean13|
+        @nr_items = @gtins.size
+        @gtins.each do |ean13|
           pac,no8 = nil,ean13.to_s[4..11] # BAG-XML(SL/LS)
           next if ean13 == 0
-          obj = gtins_to_article[ean13] || @infos_zur_rose[ean13]
+          obj = @gtins_to_article[ean13] || @infos_zur_rose[ean13]
           if obj
             obj = @packs[no8].merge(obj) if @packs[no8]
           else
             obj = @packs[no8] # obj not yet in refdata. Use data from swissmedic_package.xlsx
           end
           nr_items += 1
-          Oddb2xml.log "build_article #{nr_items} of #{gtins.size} articles" if nr_items % 5000 == 0
+          Oddb2xml.log "build_article #{nr_items} of #{@gtins.size} articles" if nr_items % 5000 == 0
           item = @items[ean13]
           pack_info = nil
           pack_info = @packs[no8] if no8 && /#{ean13}/.match(@packs[no8].to_s) # info from Packungen.xlsx from swissmedic_info
@@ -1506,7 +1501,8 @@ module Oddb2xml
                 when 'N'; xml.DEDUCTIBLE 10; # 10%
                 else #     xml.DEDUCTIBLE '' # k.A.
                 end if item && item[:deductible]
-                xml.PRODNO            ppac[:prodno] if ppac && ppac[:prodno] # pkg_gtin.to_s[4..11]
+                prodno = SwissmedicExtractor.getProdnoForEan13(pkg_gtin)
+                xml.PRODNO prodno if prodno
                 csv = []
                 @csv_file << [pkg_gtin, name, package[:unit], measure,
                               pexf ? pexf : '',
@@ -1566,7 +1562,7 @@ module Oddb2xml
       @nr_articles = 0
       used_limitations = []
       Oddb2xml.log "#{variant}: Deleted #{@old_rose_size - @new_rose_size} entries from ZurRose where GTIN start with 7680 (Swissmedic)"
-      # Oddb2xml.log "#{variant} #{nr_products} of #{@products.size} articles and ignore #{@@gtin2ignore.size} GTINS specified via #{@@ignore_file}"
+      # Oddb2xml.log "#{variant} #{nr_products} of #{@products.size} articles and ignore #{@@gtin2ignore.size} @gtins specified via #{@@ignore_file}"
       _builder = Nokogiri::XML::Builder.new(:encoding => 'utf-8') do |xml|
         xml.doc.tag_suffix = @tag_suffix
         datetime = Time.new.strftime('%FT%T%z')
@@ -1579,7 +1575,14 @@ module Oddb2xml
           'DATA_SOURCE'       => 'oddb2xml'
         }
         emitted_prodno = []
+        no8_to_prodno = {}
+        @packs.collect{ |key, val| no8_to_prodno[key] = val [:prodno] }
         xml.comment("Produced by #{__FILE__} version #{VERSION} at #{Time.now}")
+        @gtins_to_article = {}
+        @articles.each {|article| @gtins_to_article[article[:ean13]] = article }
+        @gtins = @gtins_to_article.keys + @infos_zur_rose.keys + @packs.values.collect{|x| x[:ean13]}
+        @gtins = (@gtins-@@gtin2ignore)
+        @gtins.sort!.uniq!
         xml.ARTIKELSTAMM(options_xml) do
           xml.PRODUCTS do
             products = @products.sort_by { |ean13, obj| ean13 }
@@ -1600,6 +1603,10 @@ module Oddb2xml
               next if emitted_prodno.index(prodno)
               sequence ||= @articles.find{|x| x[:ean13].eql?(ean)}
               next unless sequence && (sequence[:name_de] || sequence[:desc_de])
+              if SwissmedicExtractor.getEan13forProdno(prodno).size == 0
+                puts "No item found for prodno #{prodno} no8 #{obj[:no8]} #{sequence[:name_de]} "
+                next
+              end
               emitted_prodno << prodno
               nr_products += 1
               xml.PRODUCT do
@@ -1659,7 +1666,7 @@ module Oddb2xml
       lines << "  - #{sprintf('%5d', @products.size)} products"
       lines << "  - #{sprintf('%5d', @limitations.size)} limitations"
       lines << "  - #{sprintf('%5d', @nr_articles)} articles"
-      lines << "  - #{sprintf('%5d', @@gtin2ignore.size)} ignored GTINS"
+      lines << "  - #{sprintf('%5d', @@gtin2ignore.size)} ignored @gtins"
       @@articlestamm_v5_info_lines = lines
       _builder.to_xml({:indent => 4, :encoding => 'UTF-8'})
     end

data/lib/oddb2xml/cli.rb

@@ -94,7 +94,7 @@ module Oddb2xml
       compress if @options[:compress_ext]
       res = report
       nrSecs =  (Time.now - startTime).to_i
-      if defined?(RSpec) && (nrSecs).to_i > 10 then require 'pry'; binding.pry ; end
+      if defined?(RSpec) && (nrSecs).to_i > 10 && ENV['TRAVIS'].to_s.empty? then require 'pry'; binding.pry ; end
       res
     end
     private

data/lib/oddb2xml/extractor.rb

@@ -80,7 +80,7 @@ module Oddb2xml
               puts "BagXmlExtractor: Skipping as missing GTIN in SwissmedicNo8 #{pac.SwissmedicNo8}  BagDossierNo #{pac.BagDossierNo} PackId #{pac.PackId} #{item[:name_de]}. Skipping"
             else
               ean12 = '7680' + pac.SwissmedicNo8
-              # pac.GTIN  = (ean12 + Oddb2xml.calc_checksum(ean12))
+              pac.GTIN  = (ean12 + Oddb2xml.calc_checksum(ean12)) unless @artikelstamm
               puts "BagXmlExtractor: Missing GTIN in SwissmedicNo8 #{pac.SwissmedicNo8}  BagDossierNo #{pac.BagDossierNo} PackId #{pac.PackId} #{item[:name_de]}."
             end
           end
@@ -187,11 +187,11 @@ module Oddb2xml
       items.each do |pac|
         ean13 = (gtin = pac.GTIN.to_s) ? gtin: '0'
         if ean13.size < 13
-          puts "Refdata #{@type} use 13 chars not #{ean13.size} for #{ean13}"
+          puts "Refdata #{@type} use 13 chars not #{ean13.size} for #{ean13}" if $VERBOSE
           ean13 = ean13.rjust(13, '0')
         end
         if ean13.size == 14 && ean13[0] == '0'
-          puts "Refdata #{@type} remove leading '0' for #{ean13}"
+          puts "Refdata #{@type} remove leading '0' for #{ean13}" if $VERBOSE
           ean13 = ean13[1..-1]
         end
         # but in refdata_nonPharma we have a about 700 GTINs which are 14 characters and longer
@@ -225,8 +225,17 @@ module Oddb2xml
       @type  = type
       Oddb2xml.log("SwissmedicExtractor #{@filename} #{File.size(@filename)} bytes")
       return unless File.exists?(@filename)
+      @@prodno_to_ean13 = {}
+      @@ean13_to_prodno = {}
       @sheet = RubyXL::Parser.parse(File.expand_path(@filename)).worksheets[0]
     end
+    # Needed for ensuring consitency for the Artikelstamm
+    def self.getEan13forProdno(prodno)
+      @@prodno_to_ean13[prodno] || []
+    end
+    def self.getProdnoForEan13(ean13)
+      @@ean13_to_prodno[ean13]
+    end
     def to_arry
       data = []
       return data unless @sheet
@@ -255,10 +264,10 @@ module Oddb2xml
       when :package
         Oddb2xml.check_column_indices(@sheet)
         ith       = COLUMNS_JULY_2015.keys.index(:index_therapeuticus)
-        i_5       = COLUMNS_JULY_2015.keys.index(:iksnr)
+        iksnr       = COLUMNS_JULY_2015.keys.index(:iksnr)
         seq_name  = COLUMNS_JULY_2015.keys.index(:name_base)
         i_3       = COLUMNS_JULY_2015.keys.index(:ikscd)
-        p_1_2     = COLUMNS_JULY_2015.keys.index(:seqnr)
+        seqnr     = COLUMNS_JULY_2015.keys.index(:seqnr)
         cat       = COLUMNS_JULY_2015.keys.index(:ikscat)
         siz       = COLUMNS_JULY_2015.keys.index(:size)
         atc       = COLUMNS_JULY_2015.keys.index(:atc_class)
@@ -287,19 +296,25 @@ module Oddb2xml
         @sheet.each_with_index do |row, i|
 
           next if (i <= 1)
-          next unless row and row[i_5] and row[i_3]
-          next unless row[i_5].value.to_i > 0 and row[i_3].value.to_i > 0
-          no8 = sprintf('%05d',row[i_5].value.to_i) + sprintf('%03d',row[i_3].value.to_i)
-          prodno = sprintf('%05d',row[i_5].value.to_i) + sprintf('%02d', row[p_1_2].value.to_i).to_s
+          next unless row and row[iksnr] and row[i_3]
+          next unless row[iksnr].value.to_i > 0 and row[i_3].value.to_i > 0
+          no8 = sprintf('%05d',row[iksnr].value.to_i) + sprintf('%03d',row[i_3].value.to_i)
           unless no8.empty?
             next if no8.to_i == 0
             ean_base12 = "7680#{no8}"
+            prodno =  Oddb2xml.gen_prodno(row[iksnr].value.to_i, row[seqnr].value.to_i)
+            ean13 = (ean_base12.ljust(12, '0') + Oddb2xml.calc_checksum(ean_base12))
+            @@prodno_to_ean13[prodno] ||= []
+            @@prodno_to_ean13[prodno] << ean13
+            @@ean13_to_prodno[ean13] = prodno
             data[no8] = {
-              :ean13                => (ean_base12.ljust(12, '0') + Oddb2xml.calc_checksum(ean_base12)),
-              :prodno               => prodno ? prodno : '',
+              :ean13                => ean13,
+              :prodno               => prodno,
+              :seqnr                => row[seqnr].value,
+              :iksnr                => row[iksnr].value,
               :ith_swissmedic       => row[ith] ? row[ith].value.to_s : '',
               :swissmedic_category  => row[cat].value.to_s,
-              :atc_code             => row[atc] ? Oddb2xml.add_epha_changes_for_ATC(row[i_5].value.to_s, row[atc].value.to_s) : '',
+              :atc_code             => row[atc] ? Oddb2xml.add_epha_changes_for_ATC(row[iksnr].value.to_s, row[atc].value.to_s) : '',
               :list_code            => row[list_code] ? row[list_code].value.to_s : '',
               :package_size         => row[siz] ? row[siz].value.to_s : '',
               :einheit_swissmedic   => row[eht] ? row[eht].value.to_s : '',

data/lib/oddb2xml/semantic_check.rb

@@ -0,0 +1,141 @@
+# encoding: utf-8
+require 'ox'
+
+module Oddb2xml
+  def self.log_timestamp(msg)
+    full_msg = "#{Time.now.strftime("%H:%M:%S")}: #{msg}"
+    puts full_msg
+    STDOUT.flush
+    full_msg
+  end
+  class SemanticCheckXML
+    attr_accessor :components
+    attr_reader :keys, :sub_key_names, :filename, :basename, :version, :hash
+    def initialize(filename, components = ["PRODUCTS", "LIMITATIONS", "ITEMS",])
+      raise "File #{filename} must exist" unless File.exist?(filename)
+      @filename = filename
+      @basename = File.basename(filename)
+      @components = components
+      @hash = load_file(@filename)
+    end
+    def self.get_component_key_name(component_name)
+        return 'LIMNAMEBAG' if /LIMITATION/i.match(component_name)
+        return 'PRODNO' if /PRODUCT/i.match(component_name)
+        return 'GTIN' if /ITEM/i.match(component_name)
+        raise "Cannot determine keyname for component #{component_name}"
+    end
+    def get_items(component_name)
+      @hash[:ARTIKELSTAMM][component_name.to_sym].values.first
+    end
+    def load_file(name)
+      Oddb2xml.log_timestamp "Reading #{name} #{(File.size(name)/1024/1024).to_i} MB. This may take some time"
+      Ox.load(IO.read(name), mode: :hash_no_attrs)
+    end
+  end
+  class SemanticCheck
+    attr_accessor :items, :products, :limitations
+    def initialize(filename)
+      @filename = filename
+      @stammdaten = SemanticCheckXML.new(filename)
+    end
+
+    def everyProductNumberIsUnique
+      puts "#{Time.now.strftime("%H:%M:%S")}: everyProductNumberIsUnique"
+      return false unless  products.size > 0
+      return products.collect{ |x| x[:PRODNO]}.uniq.size == products.size
+    end
+
+    def everyGTINIsUnique
+      puts "#{Time.now.strftime("%H:%M:%S")}: everyGTINIsUnique"
+      return false unless  items.size > 0
+      return items.collect{ |x| x[:GTIN]}.uniq.size == items.size
+    end
+
+    def everyGTINIsNumericOnly
+      puts "#{Time.now.strftime("%H:%M:%S")}: everyGTINIsNumericOnly"
+      items.each do |item|
+        unless /^[0-9]+$/i.match(item[:GTIN])
+          puts "GTIN is not Numeric Only"
+          return false
+        end
+      end
+    end
+    
+    def everyPharmaArticleHasAProductItem
+      result = true
+      puts "#{Time.now.strftime("%H:%M:%S")}: everyPharmaArticleHasAProductItem"
+      allProductNumbers = products.collect{ |product| product[:PRODNO] }
+      items.each do |item|
+        next unless item[:PRODNO]
+        unless allProductNumbers.index(item[:PRODNO])
+          puts "Item #{item[:GTIN]}  has no Product #{item[:PRODNO]}  #{item[:DSCR]}"
+          result = false
+        end
+      end
+      result
+    end
+
+    def everyProductHasAtLeastOneArticle
+      result = true
+      puts "#{Time.now.strftime("%H:%M:%S")}: veryProductHasAtLeastOneArticle"
+      allProductNumbers = items.collect{ |item| item[:PRODNO] }
+      products.each do |product|
+        unless allProductNumbers.index(product[:PRODNO])
+          puts "product #{product[:PRODNO]}: has no Item #{product[:DSCR]}"
+          result = false
+        end
+      end
+      result
+    end
+    
+    def everyReferencedLimitationIsIncluded
+      puts "#{Time.now.strftime("%H:%M:%S")}: everyReferencedLimitationIsIncluded"
+      allLimitations = limitations.collect{ |lim| lim[:LIMNAMEBAG] }
+      products.each do |product|
+        next unless product[:LIMNAMEBAG]
+        unless allLimitations.index(product[:LIMNAMEBAG])
+          puts "product #{product[:PRODNO]}  has no limitation #{product[:LIMNAMEBAG]} #{product[:DSCR]}"
+          return false
+        end
+      end
+    end
+
+    def checkPackageSize
+      puts "#{Time.now.strftime("%H:%M:%S")}: checkPackageSize"
+      items.each do |item|
+        if item['PKG_SIZE'] && item['PKG_SIZE'].length >= 6
+          puts "WARNING possibly invalid package size #{item['PKG_SIZE']}"
+          pp item
+        end
+      end
+    end
+
+    def allSemanticChecks
+      @limitations = @stammdaten.get_items('LIMITATIONS')
+      @items = @stammdaten.get_items('ITEMS')
+      @products = @stammdaten.get_items('PRODUCTS')
+      puts "#{Time.now.strftime("%H:%M:%S")}: Running all semantic checks for #{@stammdaten.filename} for #{products.size} products and #{items.size} items"
+      unless everyProductNumberIsUnique &&
+          everyGTINIsUnique &&
+          everyGTINIsNumericOnly &&
+          everyPharmaArticleHasAProductItem &&
+          everyProductHasAtLeastOneArticle &&
+          everyReferencedLimitationIsIncluded &&
+          checkPackageSize
+        puts "#{Time.now.strftime("%H:%M:%S")}: Checking #{@stammdaten.filename} failed"
+        false
+      else
+        puts "#{Time.now.strftime("%H:%M:%S")}: Everything is okay"
+        true
+      end
+    rescue => error
+      puts "Execution failed with #{error}"
+      raise error
+    end
+  end
+end
+
+if $0.eql?(__FILE__)
+  daten = Oddb2xml::SemanticCheck.new(ARGV.first)
+  daten.allSemanticChecks
+end

data/lib/oddb2xml/util.rb

@@ -2,6 +2,9 @@
 require 'open-uri'
 module Oddb2xml
   FAKE_GTIN_START = '999999'
+  def Oddb2xml.gen_prodno(iksnr, seqnr)
+     sprintf('%05d',iksnr) + sprintf('%02d', seqnr)
+  end
   def Oddb2xml.calc_checksum(str)
     str = str.strip
     sum = 0

data/lib/oddb2xml/version.rb

@@ -1,3 +1,3 @@
 module Oddb2xml
-  VERSION = "2.5.2"
+  VERSION = "2.5.3"
 end

data/oddb2xml.gemspec

@@ -35,6 +35,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'httpi' #, '>= 2.4.1'
   spec.add_dependency 'trollop' #, '>= 2.4.1'
   spec.add_dependency 'xml-simple'
+  spec.add_dependency 'ox'
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"

data/spec/artikelstamm_spec.rb

@@ -32,7 +32,8 @@ describe Oddb2xml::Builder do
     @oddb2xml_xsd = File.expand_path(File.join(File.dirname(__FILE__), '..', 'oddb2xml.xsd'))
     @oddb_calc_xsd = File.expand_path(File.join(File.dirname(__FILE__), '..', 'oddb_calc.xsd'))
     @elexis_v5_xsd = File.expand_path(File.join(__FILE__, '..', '..', 'Elexis_Artikelstamm_v5.xsd'))
-    @elexis_v5_csv = File.join(Oddb2xml::WorkDir, 'Elexis_Artikelstamm_v5.csv')
+    @elexis_v5_csv = File.join(Oddb2xml::WorkDir, "artikelstamm_#{Date.today.strftime('%d%m%Y')}_v5.csv")
+
     expect(File.exist?(@oddb2xml_xsd)).to eq true
     expect(File.exist?(@oddb_calc_xsd)).to eq true
     expect(File.exist?(@elexis_v5_xsd)).to eq true
@@ -126,9 +127,9 @@ describe Oddb2xml::Builder do
 
     it 'should contain a PRODUCT which was not in refdata' do
       expected = %(<PRODUCT>
-            <PRODNO>6118601</PRODNO>
+            <PRODNO>5559401</PRODNO>
             <SALECD>A</SALECD>
-            <DSCR>Nutriflex Omega special, Infusionsemulsion 625 ml</DSCR>
+            <DSCR>Nutriflex Lipid plus, Infusionsemulsion, 1250ml</DSCR>
             <DSCRF/>
             <ATC>B05BA10</ATC>
         </PRODUCT>)

data/spec/builder_spec.rb

@@ -456,7 +456,7 @@ def checkProductXml(nbr_record = -1)
   expect(desitin.elements['SubstanceSwissmedic'].text).to eq 'levetiracetamum'
   expect(desitin.elements['CompositionSwissmedic'].text).to eq 'levetiracetamum 250 mg, excipiens pro compressi obducti pro charta.'
   expect(desitin.elements['CPT/CPTCMP/LINE'].text).to eq '0'
-  expect(desitin.elements['CPT/CPTCMP/SUBNO'].text).to eq '14'
+  expect(desitin.elements['CPT/CPTCMP/SUBNO'].text).to eq '15'
   expect(desitin.elements['CPT/CPTCMP/QTY'].text).to eq '250'
   expect(desitin.elements['CPT/CPTCMP/QTYU'].text).to eq 'mg'
 
@@ -473,15 +473,15 @@ def checkProductXml(nbr_record = -1)
 end
 
 describe Oddb2xml::Builder do
-  NrExtendedArticles = 70
-  NrSubstances = 28
-  NrLimitations = 13
+  NrExtendedArticles = 74
+  NrSubstances = 30
+  NrLimitations = 14
   
   NrInteractions = 2
   NrCodes = 5
   NrProdno = 31
-  NrPackages = 39
-  NrProducts = 34
+  NrPackages = 43
+  NrProducts = 39
   RegExpDesitin = /1125819012LEVETIRACETAM DESITIN Mini Filmtab 250 mg 30 Stk/
   include ServerMockHelper
   def common_run_init(options = {})
@@ -535,6 +535,7 @@ describe Oddb2xml::Builder do
     
     it 'should validate XSD article' do
       @inhalt = File.read(oddb_article_xml)
+      # This fails on Ruby < 2.4 as NAROPIN INJ LÖS 0.2 % 10 is wrongly encoded
       expect(File.read(oddb_article_xml).scan(ARTICLE_NAROPIN).size).to eq 1
     end
 
@@ -702,6 +703,7 @@ describe Oddb2xml::Builder do
       check_elements(oddb_article_xml, ARTICLE_COMMON_ELEMENTS)
       check_elements(oddb_article_xml, ARTICLE_ZURROSE_ELEMENTS)
       it 'should contain NAROPIN' do
+        # This fails on Ruby < 2.4 as NAROPIN INJ LÖS 0.2 % 10 is wrongly encoded
         expect(File.read(oddb_article_xml).scan(ARTICLE_NAROPIN).size).to eq 1
       end
     end

data/spec/check_artikelstamm_spec.rb

@@ -0,0 +1,46 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'oddb2xml/semantic_check'
+
+describe Oddb2xml::SemanticCheck do
+  CheckDir = File.expand_path(File.join(File.dirname(__FILE__), 'data', 'check_artikelstamm'))
+
+  def common_run_init(options = {})
+    @savedDir = Dir.pwd
+    cleanup_directories_before_run
+    FileUtils.makedirs(Oddb2xml::WorkDir)
+    Dir.chdir(Oddb2xml::WorkDir)
+    mock_downloads
+  end
+
+  after(:all) do
+    Dir.chdir @savedDir if @savedDir and File.directory?(@savedDir)
+  end
+  context 'checking' do
+    before(:each) do
+      common_run_init
+    end
+    
+    files2check = Dir.glob(CheckDir + '/*.xml')
+
+    files2check.each do |file2check|
+      it 'should exist' do
+        expect(File.exists?(file2check)).to eq true
+      end
+
+      it "#{File.basename(file2check)} should return okay" do
+        result = Oddb2xml::SemanticCheck.new(file2check).allSemanticChecks
+        puts "\n\nSemanticCheck: #{file2check} #{File.exist?(file2check)} returned #{result}"
+        puts "SemanticCheck: #{file2check} #{File.size(file2check)}"
+        # expect(result).to eq true
+      end if /okay/i.match(File.basename(file2check))
+
+      it "#{File.basename(file2check)} should return an error" do
+        result = Oddb2xml::SemanticCheck.new(file2check).allSemanticChecks
+        expect(result).to eq false
+      end unless /okay/i.match(File.basename(file2check))
+
+    end
+  end
+end