odbc_adapter 5.0.2 → 5.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 50537871f7c280cfa024f2757f0b34a24cf74494
-  data.tar.gz: ecfa4c272bdeb25fbcdfd82a7999613ff411de4f
+  metadata.gz: 4debf1d258924d263e9f5979f9264048a046dad7
+  data.tar.gz: 4211fdf1c9b1674d521319eca06ceb5f1060c643
 SHA512:
-  metadata.gz: c82ef5e10b49d630fd7d1c0d9c57b947fd2fd71e9210bbe56c1bbfbc80f175de4e4323b6685ac518f2a0a128c9f9afe028288aba5d9971a4b2b90db913a67c4f
-  data.tar.gz: abec63e36b8bf76012eb9d0ac49972865096b7ad4c083a0586017c16e5d7c7c0e5c7ac9cf6cfc12b33133680100dc6cd5df411cfdfe2af3645dfaf4729bdbf02
+  metadata.gz: 246b9da217696c875c1df669064d7e7198d8b8505aaf70358125ec77fb90152ba93555b5d8ccbde4c15af85934aebd9277be6c00751d71e78f4a409516da8400
+  data.tar.gz: 015bd47b7d7208c088ed6ecd6f1357e2a24e3c5d3513205bb0d56303396a1d7d868ab2691990782ee3d827033efa41997d553500580cc08a696b843bf997cb09

data/.rubocop.yml

@@ -0,0 +1,32 @@
+AllCops:
+  DisplayCopNames: true
+  DisplayStyleGuide: true
+  TargetRubyVersion: 2.0
+  Exclude:
+  - 'vendor/**/*'
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%w': '[]'
+    '%i': '[]'

data/README.md

@@ -1,8 +1,8 @@
 # ODBCAdapter
 
-[![Build Status](https://travis-ci.com/localytics/odbc_adapter.svg?token=kQUiABmGkzyHdJdMnCnv&branch=master)](https://travis-ci.com/localytics/odbc_adapter)
+[![Build Status](https://travis-ci.org/localytics/odbc_adapter.svg?branch=master)](https://travis-ci.org/localytics/odbc_adapter)
 
-An ActiveRecord ODBC adapter. Master branch is working off of edge Rails. Previous work has been done to make it compatible with Rails 3.2 and 4.2; for those versions use the 3.2.x or 4.2.x gem releases.
+An ActiveRecord ODBC adapter. Master branch is working off of Rails 5.0.1. Previous work has been done to make it compatible with Rails 3.2 and 4.2; for those versions use the 3.2.x or 4.2.x gem releases.
 
 This adapter will work for basic queries for most DBMSs out of the box, without support for migrations. Full support is built-in for MySQL 5 and PostgreSQL 9 databases. You can register your own adapter to get more support for your DBMS using the `ODBCAdapter.register` function.
 

data/Rakefile

@@ -1,5 +1,6 @@
 require 'bundler/gem_tasks'
 require 'rake/testtask'
+require 'rubocop/rake_task'
 
 Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
@@ -7,4 +8,7 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList['test/**/*_test.rb']
 end
 
+RuboCop::RakeTask.new(:rubocop)
+Rake::Task[:test].prerequisites << :rubocop
+
 task default: :test

data/lib/active_record/connection_adapters/odbc_adapter.rb

@@ -12,36 +12,36 @@ require 'odbc_adapter/column'
 require 'odbc_adapter/column_metadata'
 require 'odbc_adapter/database_metadata'
 require 'odbc_adapter/registry'
-require 'odbc_adapter/type_caster'
 require 'odbc_adapter/version'
 
 module ActiveRecord
   class Base
     class << self
+      # Build a new ODBC connection with the given configuration.
       def odbc_connection(config)
         config = config.symbolize_keys
 
-        connection, options =
+        connection, config =
           if config.key?(:dsn)
             odbc_dsn_connection(config)
           elsif config.key?(:conn_str)
             odbc_conn_str_connection(config)
           else
-            raise ArgumentError, "No data source name (:dsn) or connection string (:conn_str) specified."
+            raise ArgumentError, 'No data source name (:dsn) or connection string (:conn_str) specified.'
           end
 
         database_metadata = ::ODBCAdapter::DatabaseMetadata.new(connection)
-        database_metadata.adapter_class.new(connection, logger, database_metadata)
+        database_metadata.adapter_class.new(connection, logger, config, database_metadata)
       end
 
       private
 
+      # Connect using a predefined DSN.
       def odbc_dsn_connection(config)
         username   = config[:username] ? config[:username].to_s : nil
         password   = config[:password] ? config[:password].to_s : nil
         connection = ODBC.connect(config[:dsn], username, password)
-        options    = { dsn: config[:dsn], username: username, password: password }
-        [connection, options]
+        [connection, config.merge(username: username, password: password)]
       end
 
       # Connect using ODBC connection string
@@ -49,20 +49,12 @@ module ActiveRecord
       # e.g. "DSN=virt5;UID=rails;PWD=rails"
       #      "DRIVER={OpenLink Virtuoso};HOST=carlmbp;UID=rails;PWD=rails"
       def odbc_conn_str_connection(config)
-        connstr_keyval_pairs = config[:conn_str].split(';')
-
         driver = ODBC::Driver.new
         driver.name = 'odbc'
-        driver.attrs = {}
-
-        connstr_keyval_pairs.each do |pair|
-          keyval = pair.split('=')
-          driver.attrs[keyval[0]] = keyval[1] if keyval.length == 2
-        end
+        driver.attrs = config[:conn_str].split(';').map { |option| option.split('=', 2) }.to_h
 
         connection = ODBC::Database.new.drvconnect(driver)
-        options    = { conn_str: config[:conn_str], driver: driver }
-        [connection, options]
+        [connection, config.merge(driver: driver)]
       end
     end
   end
@@ -77,35 +69,36 @@ module ActiveRecord
       ADAPTER_NAME = 'ODBC'.freeze
       BOOLEAN_TYPE = 'BOOLEAN'.freeze
 
-      ERR_DUPLICATE_KEY_VALUE     = 23505
-      ERR_QUERY_TIMED_OUT         = 57014
+      ERR_DUPLICATE_KEY_VALUE     = 23_505
+      ERR_QUERY_TIMED_OUT         = 57_014
       ERR_QUERY_TIMED_OUT_MESSAGE = /Query has timed out/
 
+      # The object that stores the information that is fetched from the DBMS
+      # when a connection is first established.
       attr_reader :database_metadata
 
-      def initialize(connection, logger, database_metadata)
-        super(connection, logger)
-        @connection        = connection
+      def initialize(connection, logger, config, database_metadata)
+        configure_time_options(connection)
+        super(connection, logger, config)
         @database_metadata = database_metadata
       end
 
-      # Returns the human-readable name of the adapter. Use mixed case - one
-      # can always use downcase if needed.
+      # Returns the human-readable name of the adapter.
       def adapter_name
         ADAPTER_NAME
       end
 
-      # Does this adapter support migrations? Backend specific, as the
-      # abstract adapter always returns +false+.
+      # Does this adapter support migrations? Backend specific, as the abstract
+      # adapter always returns +false+.
       def supports_migrations?
         true
       end
 
       # CONNECTION MANAGEMENT ====================================
 
-      # Checks whether the connection to the database is still active. This includes
-      # checking whether the database is actually capable of responding, i.e. whether
-      # the connection isn't stale.
+      # Checks whether the connection to the database is still active. This
+      # includes checking whether the database is actually capable of
+      # responding, i.e. whether the connection isn't stale.
       def active?
         @connection.connected?
       end
@@ -115,14 +108,15 @@ module ActiveRecord
       def reconnect!
         disconnect!
         @connection =
-          if options.key?(:dsn)
-            ODBC.connect(options[:dsn], options[:username], options[:password])
+          if @config.key?(:dsn)
+            ODBC.connect(@config[:dsn], @config[:username], @config[:password])
           else
-            ODBC::Database.new.drvconnect(options[:driver])
+            ODBC::Database.new.drvconnect(@config[:driver])
           end
+        configure_time_options(@connection)
         super
       end
-      alias :reset! :reconnect!
+      alias reset! reconnect!
 
       # Disconnects from the database if already connected. Otherwise, this
       # method does nothing.
@@ -130,12 +124,16 @@ module ActiveRecord
         @connection.disconnect if @connection.connected?
       end
 
+      # Build a new column object from the given options. Effectively the same
+      # as super except that it also passes in the native type.
+      # rubocop:disable Metrics/ParameterLists
       def new_column(name, default, sql_type_metadata, null, table_name, default_function = nil, collation = nil, native_type = nil)
         ::ODBCAdapter::Column.new(name, default, sql_type_metadata, null, table_name, default_function, collation, native_type)
       end
 
       protected
 
+      # Build the type map for ActiveRecord
       def initialize_type_map(map)
         map.register_type 'boolean',              Type::Boolean.new
         map.register_type ODBC::SQL_CHAR,         Type::String.new
@@ -168,13 +166,14 @@ module ActiveRecord
         alias_type map, ODBC::SQL_TYPE_TIMESTAMP, ODBC::SQL_TIMESTAMP
       end
 
+      # Translate an exception from the native DBMS to something usable by
+      # ActiveRecord.
       def translate_exception(exception, message)
         error_number = exception.message[/^\d+/].to_i
 
-        case
-        when error_number == ERR_DUPLICATE_KEY_VALUE
+        if error_number == ERR_DUPLICATE_KEY_VALUE
           ActiveRecord::RecordNotUnique.new(message, exception)
-        when error_number == ERR_QUERY_TIMED_OUT, exception.message =~ ERR_QUERY_TIMED_OUT_MESSAGE
+        elsif error_number == ERR_QUERY_TIMED_OUT || exception.message =~ ERR_QUERY_TIMED_OUT_MESSAGE
           ::ODBCAdapter::QueryTimeoutError.new(message, exception)
         else
           super
@@ -183,11 +182,19 @@ module ActiveRecord
 
       private
 
+      # Can't use the built-in ActiveRecord map#alias_type because it doesn't
+      # work with non-string keys, and in our case the keys are (almost) all
+      # numeric
       def alias_type(map, new_type, old_type)
         map.register_type(new_type) do |_, *args|
           map.lookup(old_type, *args)
         end
       end
+
+      # Ensure ODBC is mapping time-based fields to native ruby objects
+      def configure_time_options(connection)
+        connection.use_time = true
+      end
     end
   end
 end

data/lib/odbc_adapter/adapters/mysql_odbc_adapter.rb

@@ -16,7 +16,7 @@ module ODBCAdapter
       # Explicitly turning off prepared statements in the MySQL adapter because
       # of a weird bug with SQLDescribeParam returning a string type for LIMIT
       # parameters. This is blocking them from running with an error:
-      # 
+      #
       #     You have an error in your SQL syntax; ...
       #     ... right syntax to use near ''1'' at line 1: ...
       def prepared_statements
@@ -49,11 +49,11 @@ module ODBCAdapter
         0
       end
 
-      def disable_referential_integrity(&block)
-        old = select_value("SELECT @@FOREIGN_KEY_CHECKS")
+      def disable_referential_integrity(&_block)
+        old = select_value('SELECT @@FOREIGN_KEY_CHECKS')
 
         begin
-          update("SET FOREIGN_KEY_CHECKS = 0")
+          update('SET FOREIGN_KEY_CHECKS = 0')
           yield
         ensure
           update("SET FOREIGN_KEY_CHECKS = #{old}")

data/lib/odbc_adapter/adapters/postgresql_odbc_adapter.rb

@@ -6,7 +6,7 @@ module ODBCAdapter
       BOOLEAN_TYPE = 'bool'.freeze
       PRIMARY_KEY  = 'SERIAL PRIMARY KEY'.freeze
 
-      alias :create :insert
+      alias create insert
 
       # Override to handle booleans appropriately
       def native_database_types
@@ -19,7 +19,7 @@ module ODBCAdapter
 
       # Filter for ODBCAdapter#tables
       # Omits table from #tables if table_filter returns true
-      def table_filter(schema_name, table_type)
+      def table_filtered?(schema_name, table_type)
         %w[information_schema pg_catalog].include?(schema_name) || table_type !~ /TABLE/i
       end
 
@@ -35,7 +35,7 @@ module ODBCAdapter
         "#{table_name}_#{pk || 'id'}_seq"
       end
 
-      def sql_for_insert(sql, pk, id_value, sequence_name, binds)
+      def sql_for_insert(sql, pk, _id_value, _sequence_name, binds)
         unless pk
           table_ref = extract_table_ref_from_insert_sql(sql)
           pk = primary_key(table_ref) if table_ref
@@ -94,7 +94,7 @@ module ODBCAdapter
           when :connection_limit
             " CONNECTION LIMIT = #{value}"
           else
-            ""
+            ''
           end
         end
 
@@ -131,7 +131,7 @@ module ODBCAdapter
         execute("DROP INDEX #{quote_table_name(index_name)}")
       end
 
-      def rename_index(table_name, old_name, new_name)
+      def rename_index(_table_name, old_name, new_name)
         execute("ALTER INDEX #{quote_column_name(old_name)} RENAME TO #{quote_table_name(new_name)}")
       end
 
@@ -149,8 +149,8 @@ module ODBCAdapter
         # Construct a clean list of column names from the ORDER BY clause,
         # removing any ASC/DESC modifiers
         order_columns = orders.map { |s| s.gsub(/\s+(ASC|DESC)\s*(NULLS\s+(FIRST|LAST)\s*)?/i, '') }
-        order_columns.reject! { |c| c.blank? }
-        order_columns = order_columns.zip((0...order_columns.size).to_a).map { |s,i| "#{s} AS alias_#{i}" }
+        order_columns.reject!(&:blank?)
+        order_columns = order_columns.zip((0...order_columns.size).to_a).map { |s, i| "#{s} AS alias_#{i}" }
 
         "DISTINCT #{columns}, #{order_columns * ', '}"
       end

data/lib/odbc_adapter/column.rb

@@ -2,6 +2,9 @@ module ODBCAdapter
   class Column < ActiveRecord::ConnectionAdapters::Column
     attr_reader :native_type
 
+    # Add the native_type accessor to allow the native DBMS to report back what
+    # it uses to represent the column internally.
+    # rubocop:disable Metrics/ParameterLists
     def initialize(name, default, sql_type_metadata = nil, null = true, table_name = nil, native_type = nil, default_function = nil, collation = nil)
       super(name, default, sql_type_metadata, null, table_name, default_function, collation)
       @native_type = native_type

data/lib/odbc_adapter/column_metadata.rb

@@ -13,7 +13,7 @@ module ODBCAdapter
       date:        [ODBC::SQL_TYPE_DATE, ODBC::SQL_DATE, ODBC::SQL_TYPE_TIMESTAMP, ODBC::SQL_TIMESTAMP],
       binary:      [ODBC::SQL_LONGVARBINARY, ODBC::SQL_VARBINARY],
       boolean:     [ODBC::SQL_BIT, ODBC::SQL_TINYINT, ODBC::SQL_SMALLINT, ODBC::SQL_INTEGER]
-    }
+    }.freeze
 
     attr_reader :adapter
 
@@ -56,7 +56,7 @@ module ODBCAdapter
       create_params = selected_row[5]
       # Depending on the column type, the CREATE_PARAMS keywords can
       # include length, precision or scale.
-      if create_params && create_params.strip.length > 0 && abstract != :decimal
+      if create_params && !create_params.strip.empty? && abstract != :decimal
         result[:limit] = selected_row[2] # SQLGetTypeInfo: COL_SIZE
       end
 

data/lib/odbc_adapter/database_metadata.rb

@@ -11,7 +11,7 @@ module ODBCAdapter
       SQL_MAX_TABLE_NAME_LEN
       SQL_USER_NAME
       SQL_DATABASE_NAME
-    ]
+    ].freeze
 
     attr_reader :values
 

data/lib/odbc_adapter/database_statements.rb

@@ -20,7 +20,7 @@ module ODBCAdapter
     # Executes +sql+ statement in the context of this connection using
     # +binds+ as the bind substitutes. +name+ is logged along with
     # the executed +sql+ statement.
-    def exec_query(sql, name = 'SQL', binds = [], prepare: false)
+    def exec_query(sql, name = 'SQL', binds = [], prepare: false) # rubocop:disable Lint/UnusedMethodArgument
       log(sql, name) do
         stmt =
           if prepared_statements
@@ -33,16 +33,9 @@ module ODBCAdapter
         values  = stmt.to_a
         stmt.drop
 
-        casters = TypeCaster.build_from(columns.values)
-        if casters.any?
-          values.each do |row|
-            casters.each { |caster| row[caster.idx] = caster.cast(row[caster.idx]) }
-          end
-        end
-
         values = dbms_type_cast(columns.values, values)
         column_names = columns.keys.map { |key| format_case(key) }
-        result = ActiveRecord::Result.new(column_names, values)
+        ActiveRecord::Result.new(column_names, values)
       end
     end
 
@@ -52,7 +45,7 @@ module ODBCAdapter
     def exec_delete(sql, name, binds)
       execute(sql, name, binds)
     end
-    alias :exec_update :exec_delete
+    alias exec_update exec_delete
 
     # Begins the transaction (and turns off auto-committing).
     def begin_db_transaction
@@ -81,7 +74,10 @@ module ODBCAdapter
 
     private
 
-    def dbms_type_cast(columns, values)
+    # A custom hook to allow end users to overwrite the type casting before it
+    # is returned to ActiveRecord. Useful before a full adapter has made its way
+    # back into this repository.
+    def dbms_type_cast(_columns, values)
       values
     end
 
@@ -122,7 +118,7 @@ module ODBCAdapter
 
     # Assume column is nullable if nullable == SQL_NULLABLE_UNKNOWN
     def nullability(col_name, is_nullable, nullable)
-      not_nullable = (!is_nullable || nullable.to_s.match('NO') != nil)
+      not_nullable = (!is_nullable || !nullable.to_s.match('NO').nil?)
       result = !(not_nullable || nullable == SQL_NO_NULLS)
 
       # HACK!

data/lib/odbc_adapter/quoting.rb

@@ -18,7 +18,7 @@ module ODBCAdapter
 
       # If upcase identifiers, only quote mixed case names.
       if database_metadata.upcase_identifiers?
-        return name unless (name =~ /([A-Z]+[a-z])|([a-z]+[A-Z])/)
+        return name unless name =~ /([A-Z]+[a-z])|([a-z]+[A-Z])/
       end
 
       "#{quote_char.chr}#{name}#{quote_char.chr}"
@@ -33,9 +33,9 @@ module ODBCAdapter
         if value.respond_to?(zone_conversion_method)
           value = value.send(zone_conversion_method)
         end
-        value.strftime("%Y-%m-%d %H:%M:%S") # Time, DateTime
+        value.strftime('%Y-%m-%d %H:%M:%S') # Time, DateTime
       else
-        value.strftime("%Y-%m-%d") # Date
+        value.strftime('%Y-%m-%d') # Date
       end
     end
   end

data/lib/odbc_adapter/schema_statements.rb

@@ -27,7 +27,7 @@ module ODBCAdapter
     end
 
     # Returns an array of indexes for the given table.
-    def indexes(table_name, name = nil)
+    def indexes(table_name, _name = nil)
       stmt   = @connection.indexes(native_case(table_name.to_s))
       result = stmt.fetch_all || []
       stmt.drop unless stmt.nil?
@@ -38,7 +38,7 @@ module ODBCAdapter
 
       result.each_with_object([]).with_index do |(row, indices), row_idx|
         # Skip table statistics
-        next if row[6] == 0 # SQLStatistics: TYPE
+        next if row[6].zero? # SQLStatistics: TYPE
 
         if row[7] == 1 # SQLStatistics: ORDINAL_POSITION
           # Start of column descriptor block for next index
@@ -50,7 +50,7 @@ module ODBCAdapter
         index_cols << format_case(row[8]) # SQLStatistics: COLUMN_NAME
         next_row = result[row_idx + 1]
 
-        if (row_idx == result.length - 1) || (next_row[6] == 0 || next_row[7] == 1)
+        if (row_idx == result.length - 1) || (next_row[6].zero? || next_row[7] == 1)
           indices << ActiveRecord::ConnectionAdapters::IndexDefinition.new(table_name, format_case(index_name), unique, index_cols)
         end
       end
@@ -58,7 +58,7 @@ module ODBCAdapter
 
     # Returns an array of Column objects for the table specified by
     # +table_name+.
-    def columns(table_name, name = nil)
+    def columns(table_name, _name = nil)
       stmt   = @connection.columns(native_case(table_name.to_s))
       result = stmt.fetch_all || []
       stmt.drop
@@ -104,7 +104,9 @@ module ODBCAdapter
         fk_from_table      = key[2]  # PKTABLE_NAME
         fk_to_table        = key[6]  # FKTABLE_NAME
 
-        ActiveRecord::ConnectionAdapters::ForeignKeyDefinition.new(fk_from_table, fk_to_table,
+        ActiveRecord::ConnectionAdapters::ForeignKeyDefinition.new(
+          fk_from_table,
+          fk_to_table,
           name:        key[11], # FK_NAME
           column:      key[3],  # PKCOLUMN_NAME
           primary_key: key[7],  # FKCOLUMN_NAME

data/lib/odbc_adapter/version.rb

@@ -1,3 +1,3 @@
 module ODBCAdapter
-  VERSION = '5.0.2'
+  VERSION = '5.0.3'.freeze
 end

data/odbc_adapter.gemspec

@@ -26,4 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'minitest', '~> 5.0'
   spec.add_development_dependency 'simplecov', '~> 0.12'
+  spec.add_development_dependency 'rubocop', '~> 0.47'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: odbc_adapter
 version: !ruby/object:Gem::Version
-  version: 5.0.2
+  version: 5.0.3
 platform: ruby
 authors:
 - Localytics
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-02-09 00:00:00.000000000 Z
+date: 2017-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-odbc
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.12'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.47'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.47'
 description: 
 email:
 - oss@localytics.com
@@ -88,6 +102,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE
@@ -110,7 +125,6 @@ files:
 - lib/odbc_adapter/quoting.rb
 - lib/odbc_adapter/registry.rb
 - lib/odbc_adapter/schema_statements.rb
-- lib/odbc_adapter/type_caster.rb
 - lib/odbc_adapter/version.rb
 - odbc_adapter.gemspec
 homepage: https://github.com/localytics/odbc_adapter
@@ -133,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: An ActiveRecord ODBC adapter

data/lib/odbc_adapter/type_caster.rb

@@ -1,42 +0,0 @@
-module ODBCAdapter
-  class TypeCaster
-    # When fetching a result set, the Ruby ODBC driver converts all ODBC
-    # SQL types to an equivalent Ruby type; with the exception of
-    # SQL_DATE, SQL_TIME and SQL_TIMESTAMP.
-    TYPES = [
-      ODBC::SQL_DATE,
-      ODBC::SQL_TIME,
-      ODBC::SQL_TIMESTAMP
-    ]
-
-    attr_reader :idx
-
-    def initialize(idx)
-      @idx = idx
-    end
-
-    def cast(value)
-      case value
-      when ODBC::TimeStamp
-        Time.gm(value.year, value.month, value.day, value.hour, value.minute, value.second)
-      when ODBC::Time
-        now = DateTime.now
-        Time.gm(now.year, now.month, now.day, value.hour, value.minute, value.second)
-      when ODBC::Date
-        Date.new(value.year, value.month, value.day)
-      else
-        value
-      end
-    rescue
-      # Handle pre-epoch dates
-      DateTime.new(value.year, value.month, value.day, value.hour, value.minute, value.second)
-    end
-
-    # Build a list of casters from a list of columns
-    def self.build_from(columns)
-      columns.each_with_index.each_with_object([]) do |(column, idx), casters|
-        casters << new(idx) if TYPES.include?(column.type)
-      end
-    end
-  end
-end