octokit 3.7.0 → 3.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f2a4c4a887142b38092500f915ae1e76045a088
-  data.tar.gz: 8b6a457b671dda7b59e4d95a9e21bf02326a0ff1
+  metadata.gz: 2ed9c913826b2d42443b7ba5790e5c1a64eacf8c
+  data.tar.gz: 417bda71bdee949b4d4285750e2567c629df7027
 SHA512:
-  metadata.gz: dcca491b69213f7fd2fe9aee6c439c7751b7d77802a2f8328e64456e6f3bc5739eef054e2640294df1c6430d820adef26d1d30aba1243c4b7fe7a377441b8169
-  data.tar.gz: d6e871030302eb322560f7534ff8ea963d616c455e711666a860c784443933a34e89ec6dc4bbf658e55ea6136d8c090e357b37b92743199c0760f508a2c2d34a
+  metadata.gz: 71b430500419af8f9cfd601400a519d6476490ec8d9fdb81487f346137e40b6f8cc2254f01671031475ea96cd7478b7d5598a29827f566f234f4ffc6f1a8cd2e
+  data.tar.gz: 6dc2cb4d23e657ae56d573bd8beb705120e3a01a28a73bfcb5b0786e478dcf47f813a34ae6536d82adf8d41bd6a5d84e1a114a32a65054364d23bdc6b3d7738f

data/README.md

@@ -497,7 +497,7 @@ Octokit uses environmental variables for storing credentials used in testing.
 If you are testing an API endpoint that doesn't require authentication, you
 can get away without any additional configuration. For the most part, tests
 use an authenticated client, using a token stored in `ENV['OCTOKIT_TEST_GITHUB_TOKEN']`.
-There are several different authenticating method's used accross the api.
+There are several different authenticating method's used across the api.
 Here is the full list of configurable environmental variables for testing
 Octokit:
 

data/lib/octokit/client/issues.rb

@@ -77,7 +77,7 @@ module Octokit
       #
       # @param repo [Integer, String, Repository, Hash] A GitHub repository
       # @param title [String] A descriptive title
-      # @param body [String] A concise description
+      # @param body [String] An optional concise description
       # @param options [Hash] A customizable set of options.
       # @option options [String] :assignee User login.
       # @option options [Integer] :milestone Milestone number.
@@ -86,7 +86,7 @@ module Octokit
       # @see https://developer.github.com/v3/issues/#create-an-issue
       # @example Create a new Issues for a repository
       #   Octokit.create_issue("sferik/rails_admin", 'Updated Docs', 'Added some extra links')
-      def create_issue(repo, title, body, options = {})
+      def create_issue(repo, title, body = nil, options = {})
         options[:labels] = case options[:labels]
                            when String
                              options[:labels].split(",").map(&:strip)
@@ -95,7 +95,9 @@ module Octokit
                            else
                              []
                            end
-        post "#{Repository.path repo}/issues", options.merge({:title => title, :body => body})
+        parameters = { :title => title }
+        parameters[:body] = body unless body.nil?
+        post "#{Repository.path repo}/issues", options.merge(parameters)
       end
       alias :open_issue :create_issue
 

data/lib/octokit/client/labels.rb

@@ -28,7 +28,7 @@ module Octokit
       # @example Get the "V3 Addition" label from octokit/octokit.rb
       #   Octokit.labels("octokit/octokit.rb", "V3 Addition")
       def label(repo, name, options = {})
-        get "#{Repository.path repo}/labels/#{CGI.escape(name)}", options
+        get "#{Repository.path repo}/labels/#{name}", options
       end
 
       # Add a label to a repository
@@ -56,7 +56,7 @@ module Octokit
       # @example Update the label "Version 1.0" with new color "#cceeaa"
       #   Octokit.update_label("octokit/octokit.rb", "Version 1.0", {:color => "cceeaa"})
       def update_label(repo, label, options = {})
-        patch "#{Repository.path repo}/labels/#{CGI.escape(label)}", options
+        patch "#{Repository.path repo}/labels/#{label}", options
       end
 
       # Delete a label from a repository.
@@ -70,7 +70,7 @@ module Octokit
       # @example Delete the label "Version 1.0" from the repository.
       #   Octokit.delete_label!("octokit/octokit.rb", "Version 1.0")
       def delete_label!(repo, label, options = {})
-        boolean_from_response :delete, "#{Repository.path repo}/labels/#{CGI.escape(label)}", options
+        boolean_from_response :delete, "#{Repository.path repo}/labels/#{label}", options
       end
 
       # Remove a label from an Issue
@@ -85,7 +85,7 @@ module Octokit
       # @example Remove the label "Version 1.0" from the repository.
       #   Octokit.remove_label("octokit/octokit.rb", 23, "Version 1.0")
       def remove_label(repo, number, label, options = {})
-        delete "#{Repository.path repo}/issues/#{number}/labels/#{CGI.escape(label)}", options
+        delete "#{Repository.path repo}/issues/#{number}/labels/#{label}", options
       end
 
       # Remove all label from an Issue

data/lib/octokit/client/pull_requests.rb

@@ -54,18 +54,18 @@ module Octokit
       #                      a merge to a base of another repo.
       # @param head [String] The branch (or git ref) where your changes are implemented.
       # @param title [String] Title for the pull request
-      # @param body [String] The body for the pull request. Supports GFM.
+      # @param body [String] The body for the pull request (optional). Supports GFM.
       # @return [Sawyer::Resource] The newly created pull request
       # @example
       #   @client.create_pull_request("octokit/octokit.rb", "master", "feature-branch",
       #     "Pull Request title", "Pull Request body")
-      def create_pull_request(repo, base, head, title, body, options = {})
+      def create_pull_request(repo, base, head, title, body = nil, options = {})
         pull = {
           :base  => base,
           :head  => head,
           :title => title,
-          :body  => body,
         }
+        pull[:body] = body unless body.nil?
         post "#{Repository.path repo}/pulls", options.merge(pull)
       end
 
@@ -181,7 +181,7 @@ module Octokit
       # @return [Array<Sawyer::Resource>] List of comments
       def pull_request_comments(repo, number, options = {})
         # return the comments for a pull request
-        get "#{Repository.path repo}/pulls/#{number}/comments", options
+        paginate("#{Repository.path repo}/pulls/#{number}/comments", options)
       end
       alias :pull_comments   :pull_request_comments
       alias :review_comments :pull_request_comments

data/lib/octokit/client/releases.rb

@@ -23,8 +23,8 @@ module Octokit
       # @option options [String] :target_commitish Specifies the commitish value that determines where the Git tag is created from.
       # @option options [String] :name Name for the release
       # @option options [String] :body Content for release notes
-      # @option options [String] :draft Mark this release as a draft
-      # @option options [String] :prerelease Mark this release as a pre-release
+      # @option options [Boolean] :draft Mark this release as a draft
+      # @option options [Boolean] :prerelease Mark this release as a pre-release
       # @return [Sawyer::Resource] The release
       # @see https://developer.github.com/v3/repos/releases/#create-a-release
       def create_release(repo, tag_name, options = {})
@@ -47,8 +47,8 @@ module Octokit
       # @option options [String] :target_commitish Specifies the commitish value that determines where the Git tag is created from.
       # @option options [String] :name Name for the release
       # @option options [String] :body Content for release notes
-      # @option options [String] :draft Mark this release as a draft
-      # @option options [String] :prerelease Mark this release as a pre-release
+      # @option options [Boolean] :draft Mark this release as a draft
+      # @option options [Boolean] :prerelease Mark this release as a pre-release
       # @return [Sawyer::Resource] The release
       # @see https://developer.github.com/v3/repos/releases/#edit-a-release
       def update_release(url, options = {})

data/lib/octokit/default.rb

@@ -14,7 +14,7 @@ module Octokit
     USER_AGENT   = "Octokit Ruby Gem #{Octokit::VERSION}".freeze
 
     # Default media type
-    MEDIA_TYPE   = "application/vnd.github.v3+json"
+    MEDIA_TYPE   = "application/vnd.github.v3+json".freeze
 
     # Default WEB endpoint
     WEB_ENDPOINT = "https://github.com".freeze

data/lib/octokit/error.rb

@@ -62,6 +62,8 @@ module Octokit
         Octokit::TooManyRequests
       elsif body =~ /login attempts exceeded/i
         Octokit::TooManyLoginAttempts
+      elsif body =~ /abuse/i
+        Octokit::AbuseDetected
       else
         Octokit::Forbidden
       end
@@ -187,6 +189,10 @@ module Octokit
   # and body matches 'login attempts exceeded'
   class TooManyLoginAttempts < Forbidden; end
 
+  # Raised when GitHub returns a 403 HTTP status code
+  # and body matches 'abuse'
+  class AbuseDetected < Forbidden; end
+
   # Raised when GitHub returns a 404 HTTP status code
   class NotFound < ClientError; end
 

data/lib/octokit/repository.rb

@@ -18,6 +18,9 @@ module Octokit
         @id = repo
       when String
         @owner, @name = repo.split('/')
+        unless @owner && @name
+          raise ArgumentError, "Invalid Repository. Use user/repo format."
+        end
       when Repository
         @owner = repo.owner
         @name = repo.name

data/lib/octokit/version.rb

@@ -1,7 +1,17 @@
 module Octokit
+  # Current major release.
+  # @return [Integer]
+  MAJOR = 3
 
-  # Current version
-  # @return [String]
-  VERSION = "3.7.0".freeze
+  # Current minor release.
+  # @return [Integer]
+  MINOR = 7
+
+  # Current patch level.
+  # @return [Integer]
+  PATCH = 1
 
+  # Full release version.
+  # @return [String]
+  VERSION = [MAJOR, MINOR, PATCH].join('.').freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: octokit
 version: !ruby/object:Gem::Version
-  version: 3.7.0
+  version: 3.7.1
 platform: ruby
 authors:
 - Wynn Netherland
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-03 00:00:00.000000000 Z
+date: 2015-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler