occams-record 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f60c7e2adfe9a547efe1d4c9eccd25b8baa7c733
-  data.tar.gz: 7955381fac5f5792b7e9a537dd5962199dff7116
+  metadata.gz: 22118121c55c3eeb9cc211b6871f34d6ad9d94a5
+  data.tar.gz: bad217602878815157dba40a38cfd52ac58fdd6d
 SHA512:
-  metadata.gz: 2e47c6911ac5648a01c9feeadcee5c1dd1e0a3d5dc9b475108bbbb86a6e06a87f31863521862ee6c807c33e85b34b793a9469188c1d72789d2cb389d088cdaf7
-  data.tar.gz: 0a35392419e4527552da87d433754d0a2998d016d5a27f332f78d6932605cdb856e256175d06cfbd9f8c214bd4908b5ed6d8455c38169f0568c3ad4ac5442ce0
+  metadata.gz: 1da29e4dad1adabf559e808b691c9281d299abde694999ae4de00a8502ebfe61b9dcde370d84ddea754744fcc32580b644759a48a37b9de3ca521bca4a9d6836
+  data.tar.gz: 8daa621bd1b62c34750afb1075f9f868bd030b313b8deb947011527464e97941a50b83b64a1d0e1ac46225b34dc8a6eabae2ed719f976db249697efb32f14986

data/README.md

@@ -17,7 +17,7 @@ For those stuck with ActiveRecord, OccamsRecord seeks to solve these issues by m
 * When eager loading associations you may specify which columns to `SELECT`. (This can be a significant performance boost to both your database and Rails app, on top of the above numbers.)
 * When eager loading associations you may completely customize the query (`WHERE`, `ORDER BY`, `LIMIT`, etc.)
 * By forcing eager loading of associations, OccamsRecord bypasses the primary cause of performance problems in Rails: N+1 queries.
-* The forced eager loading helps the developer visualize the "shape" of the query/result, which can make obvious certain insights that would otherwise require lots of digging. For example, if you're eager loading 15 associations, maybe you need to add some redundant foreign keys or denormalize some fields.
+* Forced eager loading also makes you consider the "shape" of your data, which can help you identify areas that need refactored (e.g. redundant foreign keys, more denormalization, etc.)
 
 **What don't you give up?**
 
@@ -31,7 +31,7 @@ Glad you asked. [Look over the results yourself.](https://github.com/jhollinger/
 
 **Why not use a different ORM?**
 
-That's a great idea; check out [sequel](https://rubygems.org/gems/sequel) or [rom](https://rubygems.org/gems/rom)! But for large, legacy codebases heavily invested in ActiveRecord, switching ORMs often isn't practical. OccamsRecord can help you get some of those wins without throwing everything out.
+That's a great idea; check out [sequel](https://rubygems.org/gems/sequel) or [rom](https://rubygems.org/gems/rom)! But for large, legacy codebases heavily invested in ActiveRecord, switching ORMs often isn't practical. OccamsRecord can help you get some of those wins without a rewrite.
 
 ## Usage
 
@@ -122,7 +122,7 @@ end
 
 widgets = OccamsRecord.
   query(Widget.order("name"), use: MyWidgetMethods).
-  eager_load(:orders, use: MyOrderMethods).
+  eager_load(:orders, use: [MyOrderMethods, SomeAdditionalMethods]).
   run
 
 widgets[0].to_s

data/lib/occams-record/query.rb

@@ -88,7 +88,7 @@ module OccamsRecord
       sql = scope.to_sql
       @query_logger << sql if @query_logger
       result = conn.exec_query sql
-      row_class = OccamsRecord.build_result_row_class(model, result.columns, @eager_loaders.map(&:name), @use)
+      row_class = OccamsRecord.build_result_row_class(model, result.columns, result.column_types, @eager_loaders.map(&:name), modules: @use)
       rows = result.rows.map { |row| row_class.new row }
 
       @eager_loaders.each { |loader|

data/lib/occams-record/result_row.rb

@@ -11,13 +11,14 @@ module OccamsRecord
   #
   # @param model [ActiveRecord::Base] the AR model representing the table (it holds column & type info).
   # @param column_names [Array<String>] the column names in the result set. The order MUST match the order returned by the query.
+  # @param column_types [Hash] Column name => type from an ActiveRecord::Result
   # @param association_names [Array<String>] names of associations that will be eager loaded into the results.
-  # @param included_modules [Array<Module>] (optional)
+  # @param modules [Array<Module>] (optional)
   # @return [OccamsRecord::ResultRow] a class customized for this result set
   #
-  def self.build_result_row_class(model, column_names, association_names, included_modules = nil)
+  def self.build_result_row_class(model, column_names, column_types, association_names, modules: nil)
     Class.new(ResultRow) do
-      Array(included_modules).each { |mod| include mod } if included_modules
+      Array(modules).each { |mod| include mod } if modules
 
       self.columns = column_names.map(&:to_s)
       self.associations = association_names.map(&:to_s)
@@ -27,8 +28,11 @@ module OccamsRecord
       attr_accessor(*association_names)
 
       # Build a getter for each attribute returned by the query. The values will be type converted on demand.
-      column_names.each_with_index do |col, idx|
-        type = model.attributes_builder.types[col.to_s] || raise("OccamsRecord: Column `#{col}` does not exist on model `#{model.name}`")
+      self.columns.each_with_index do |col, idx|
+        type =
+          column_types[col] ||
+          model.attributes_builder.types[col] ||
+          raise("OccamsRecord: Column `#{col}` does not exist on model `#{self.model_name}`")
         define_method col do
           @cast_values_cache[idx] ||= type.send(TYPE_CAST_METHOD, @raw_values[idx])
         end

data/lib/occams-record/version.rb

@@ -3,5 +3,5 @@
 #
 module OccamsRecord
   # Library version
-  VERSION = '0.6.0'.freeze
+  VERSION = '0.7.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: occams-record
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Jordan Hollinger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-11 00:00:00.000000000 Z
+date: 2017-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord