occams-record 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 93cf9f49f91eee71e3ad4f920ab2a6be8f212363
-  data.tar.gz: 0b213d2fc9d5882a4c387e94989af64d96c0b037
+  metadata.gz: 626b915405cadac96171e3283e1f05172ff5a272
+  data.tar.gz: bb347409b11e0c9602520a2444b56bb751c1f0e8
 SHA512:
-  metadata.gz: 34f6973012cdae863862cf6a8850442d18333f320bd5920866d1f7bd402dc6530bcadb76bece429512b6ec6c5a527afbdf8d1d8041145ff5691071c95ee9dba0
-  data.tar.gz: 2068ccf8a5c863ac5c9a63f5df408b6d3fafda5cca6b0bb292873397480048f985e89c8d27e9ce08dcc80890c72f2720172c477baa527e00c51e526b04f7a5d9
+  metadata.gz: 480de46340d39119a7e2b9b2734db2ac204d938e4313eef0b50d3ea39fb575683c84c78455a4f9492891f36074acdf611d634702f3d1d353df1722e60f75ed11
+  data.tar.gz: 5ddc0ad13f4d214e921341e88428e2e40bfac204f6e377343110ac7ca875ac668722361261f7d35cc9cfa2f3fb70465082725db118c02467086d339727210b08

data/README.md

@@ -82,7 +82,7 @@ widgets = OccamsRecord.
   eager_load(:order_items, select: "widget_id, order_id") {
 
     # load the orders
-    eager_load(:orders, -> { order "order_date DESC" }) {
+    eager_load(:orders, -> { select("id, customer_id").order("order_date DESC") }) {
 
       # load the customers who made the orders, but only their names
       eager_load(:customer, select: "id, name")
@@ -130,6 +130,13 @@ widgets[0].orders[0].description
 => "O839SJZ98B 1/8/2017"
 ```
 
+## Unsupported features
+
+The following `ActiveRecord` are not supported, and I have no plans to do so. However, I'd be glad to accept pull requests.
+
+* ActiveRecord enum types
+* ActiveRecord serialized types
+
 ## Testing
 
 To run the tests, simply run:

data/lib/occams-record/eager_loaders/habtm.rb

@@ -20,20 +20,20 @@ module OccamsRecord
       #
       def merge!(assoc_rows, rows)
         joins_by_id = join_rows(rows).reduce({}) { |a, join|
-          id = join[0]
+          id = join[0].to_s
           a[id] ||= []
-          a[id] << join[1]
+          a[id] << join[1].to_s
           a
         }
 
         assoc_rows_by_id = assoc_rows.reduce({}) { |a, row|
-          id = row.send @ref.association_primary_key
+          id = row.send(@ref.association_primary_key).to_s
           a[id] = row
           a
         }
 
         rows.each do |row|
-          id = row.send @ref.active_record_primary_key
+          id = row.send(@ref.active_record_primary_key).to_s
           assoc_fkeys = (joins_by_id[id] || []).uniq
           associations = assoc_rows_by_id.values_at(*assoc_fkeys).compact.uniq
           row.send @assign, associations

data/lib/occams-record/version.rb

@@ -3,5 +3,5 @@
 #
 module OccamsRecord
   # Library version
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.4.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: occams-record
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Jordan Hollinger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-23 00:00:00.000000000 Z
+date: 2017-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord