observed-http 0.1.0 → 0.2.0.rc1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZGI2ODA0ZmI1YzJlZTRlMjZjMTQ1M2ZjMDQ0ZTgxOWY2OWY5ZWViMw==
+    OTEzNTdjYzM4NDkwNDRhZmUzMmMyNWJmZjk2NTQ4NWEwNTkwZGZjYQ==
   data.tar.gz: !binary |-
-    ZmY0MGMzZTRiYTljMjQzZjg0NjgzZTY1ZTdkN2UzMGQ3ODM5NDAyZA==
-!binary "U0hBNTEy":
+    NWFlYzNlNDFjNjRkNTFjZmMwYTRiMjNjMWI4NWE5NWUwY2RhNGRmYg==
+SHA512:
   metadata.gz: !binary |-
-    YzdiMmVlNjExYmY2NDQ4ZmViOTI3NzEwODFjMGI5NzFiYTA1MTBmZThiNzQ4
-    ODk4MzdiNzI0NTlmM2IzNWYxNDVkY2MzNjQzMWEzNGI0MTk1OWE3YTZhM2Zk
-    YjJhNjBmMGQxYWIwZmQ1MmQwODExMTk0OTc3YmNiZDkwNjgyYjY=
+    MzQzMTc3ODQ0NGQwZmM1ZDY1ODc3OGYwNmJlYmQyYjc5NDc0N2RmOTEyZmFj
+    ODY2OTU3MzQ3NGY4MmJlMDJkOGYwOTAzZTQ2Y2Y1NDYzYzYzM2UxZGNkOWU3
+    YWI0MTQ4YzNmZmMzOWE1NTdiYWM3M2ZhZmYwZWZkYmZjZjZmMjE=
   data.tar.gz: !binary |-
-    NzUyNTViNzE0ZGI2MjU1OTMxNmI4NjYxNzhkNjhmNzljNmUxOWZjYjI3YTI5
-    YjkyM2Q2NTY3ZTNiNTc1NjA4Y2YzYmFjNzBkZjQwNjYwNjJlZWIxNDg2YjM4
-    YTcxMDY2NTdlOGU3ZWU5MmY2NzE1NDFjZGQ4MGVkZThiZjM1MzY=
+    ZWEyZGU5YzI0NmEwN2RjZmEzMTU5M2I3M2U1ZWE2YjZiZTdjZmUxMTgwN2Fi
+    ZDFiMTk1ZWE4YjRhYjcyNmMzOGJlNDdjMjE5NmFhZWUyMzU3OGUwYTJhYzlh
+    ZTdiNWJkMTRlYjU3MzM0ZDBlMTg3NWI1NWViMWVlNDBkZWVmZTc=

data/lib/observed/http/version.rb

@@ -1,5 +1,5 @@
 module Observed
   module Http
-    VERSION = "0.1.0"
+    VERSION = "0.2.0.rc1"
   end
 end

data/lib/observed/http.rb

@@ -1,5 +1,7 @@
 require 'observed/http/version'
+require 'observed/observer'
 require 'observed/observer_helpers/timer'
+require 'observed/logging'
 require 'timeout'
 require 'net/http'
 
@@ -8,18 +10,22 @@ module Observed
     class HTTP < Observed::Observer
 
       include Observed::ObserverHelpers::Timer
+      include Observed::Logging
 
       attribute :timeout_in_milliseconds, default: 5000
 
       attribute :method
       attribute :url
+      attribute :logger
 
       def observe
-        logger.debug "method: #{method}, url: #{url}"
+        method = get_attribute_value(:method)
+
+        log_debug "method: #{method}, url: #{url}"
 
         uri = URI.parse(url)
 
-        logger.debug "uri: #{uri}, uri.host: #{uri.host}, uri.port:#{uri.port}, uri.path: #{uri.path}"
+        log_debug "uri: #{uri}, uri.host: #{uri.host}, uri.port:#{uri.port}, uri.path: #{uri.path}"
 
         http_method = method.capitalize
         path = if uri.path.size == 0
@@ -36,23 +42,19 @@ module Observed
 
         time_and_report(tag: self.tag, timeout_in_seconds: timeout_in_seconds) do
 
-          logger.debug "Sending a HTTP request with the timeout of #{timeout_in_seconds} seconds"
+          log_debug "Sending a HTTP request with the timeout of #{timeout_in_seconds} seconds"
 
           body = Net::HTTP.start(uri.host, uri.port) {|http|
             http.request(req)
           }.body
 
-          logger.debug "Response body: #{body}"
+          log_debug "Response body: #{body}"
 
           "#{http_method} #{uri}"
         end
 
       end
 
-      def logger
-        @logger ||= Logger.new(STDOUT)
-      end
-
       plugin_name 'http'
 
     end

data/observed-http.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "observed", "~> 0.1.0"
+  spec.add_dependency "observed", "~> 0.2.0.rc1"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/spec/http_spec.rb

@@ -1,14 +1,69 @@
 require 'spec_helper'
 
-require 'observed/application/oneshot'
+require 'observed/http'
+
+describe Observed::Plugins::HTTP do
 
-describe Observed::Application::Oneshot do
   subject {
-    Observed::Application::Oneshot.create(
-        config_file: 'spec/fixtures/observed.conf'
-    )
+    Observed::Plugins::HTTP.new
+  }
+
+  before {
+    subject.configure config
+  }
+
+  let(:config) {
+    {
+        timeout_in_milliseconds: 1000,
+        method: 'get',
+        url: 'http://google.com/',
+        tag: 'test',
+        system: sys
+    }
+  }
+
+  let(:sys) {
+    sys = mock('system')
+    sys.stubs(:now).returns(before).then.returns(after)
+    sys
+  }
+
+  let(:before) {
+    Time.now
+  }
+
+  let(:after) {
+    Time.now + 1
   }
-  it 'initializes' do
-    expect(subject.run.size).not_to eq(0)
+
+  let(:response) {
+    res = stub('response')
+    res.stubs(body: 'the response body')
+    res
+  }
+
+  context 'when timed out' do
+    before {
+      Timeout.expects(:timeout).raises(Timeout::Error)
+
+      sys.expects(:report).with('test.error', {status: :error, error: {message: 'Timed out.'}, timed_out: true})
+    }
+
+    it 'reports an error' do
+      expect { subject.observe }.to_not raise_error
+    end
   end
+
+  context 'when not timed out' do
+    before {
+      Timeout.expects(:timeout).returns({ status: :success, result: 'Get http://google.com/' })
+
+      sys.expects(:report).with('test.success', {status: :success, result: 'Get http://google.com/', elapsed_time: after - before})
+    }
+
+    it 'reports an success' do
+      expect { subject.observe }.to_not raise_error
+    end
+  end
+
 end

data/spec/integration_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+require 'observed/application/oneshot'
+
+describe Observed::Application::Oneshot do
+  subject {
+    Observed::Application::Oneshot.create(
+        config_file: 'spec/fixtures/observed.conf'
+    )
+  }
+  it 'initializes' do
+    expect(subject.run.size).not_to eq(0)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: observed-http
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0.rc1
 platform: ruby
 authors:
 - KUOKA Yusuke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-11 00:00:00.000000000 Z
+date: 2014-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: observed
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0.rc1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -155,6 +155,7 @@ files:
 - observed-http.gemspec
 - spec/fixtures/observed.conf
 - spec/http_spec.rb
+- spec/integration_spec.rb
 - spec/spec_helper.rb
 homepage: ''
 licenses:
@@ -171,12 +172,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ! '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.5
+rubygems_version: 2.1.10
 signing_key: 
 specification_version: 4
 summary: observed-http is a plugin for Observed to run health-check against Web services
@@ -186,4 +187,5 @@ test_files:
 - features/support/env.rb
 - spec/fixtures/observed.conf
 - spec/http_spec.rb
+- spec/integration_spec.rb
 - spec/spec_helper.rb