object_attorney 2.8.1 → 2.9.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YjBiYjY2NTJjZDkxMzdhMDE4OGExNzM2NGE5NDMzYjVmZmYwYjg2OA==
+    NTk2ZjBiODdlOGJlOGRjZDRkYTZkMjViZjllOThhYjgxMTBjYzYyMQ==
   data.tar.gz: !binary |-
-    NjI5NDA4NGU4YjNkZTJjZTdjZWJkMDNiNjgwZmIxMmIwMzlkOGZlNQ==
+    NjdhYzlhNjJiZjYyZTkzZWI3MjkzMjViYzVjZGRkNDVmYTkxN2JlMg==
 SHA512:
   metadata.gz: !binary |-
-    MzkxYmE0YTM3ZDdlZTJjZWQyMDQ3YThiZTE4MWNlZTM5NDg0MjhhOTllMjQ5
-    YmZlZmRkMGNiY2I3Y2EzN2FhYzEyZmQ0MzY0OWE3ODMwYzg3NmZmZjYxMDYz
-    MWRhNjk5ZDQ1NzczNWI4NWI1MTY5YWRmNzI0ODg2NjJlOGVmM2I=
+    NWE0YTk0N2FhNDZjOWJiYmU5ZDE0Mjg0ZWQwZWZkNDQ1ZTE5ZWQyMDRhM2E0
+    M2VhMWM2ODU2ZjI2ZWY3MTkxOWE3OWViOGNiM2ViNmQ4YTY5OTYyNjBmNDRj
+    NTQzYmNhMTcxOGY2YjZlNDc4ZDI5M2U1N2JiNTQwNmRhNmMwMDM=
   data.tar.gz: !binary |-
-    ZTA5YWQwMzBhZjU5ZmVlNDQ0MmUyMjRlYTVjZmEzOTJjODk4YmZlZDcyZmQw
-    MWZjYTk5MjQyNDk3OWFlZThmNGE3MjJlNjc0NjMyNmJiNDcwZTZhMWEzNTA3
-    NzM0ZmRiMTBhN2YwM2Y3N2YwM2IxMGY0ODBhMTkxMGVjODAxODA=
+    MTNlZDEzMTUwMmViMjE4OTY3YzU3MjBjYTliM2Q1N2VjM2I3MTVmMzNiN2Fj
+    NTQwZDY2N2NiMjcwYmJlMDY1Y2JhNWJlOTk2ZDIxOThiYjY3MzIzZjJiMWQy
+    ZGJmZGVjNmVlMWYxMTkxNTUyMGY2YjhhN2M5M2IwYTU5NTBmMGE=

data/lib/object_attorney/delegation.rb

@@ -2,6 +2,14 @@ module ObjectAttorney
 
   module Delegation
 
+    module MissingMethods
+
+      def method_missing(method, *args, &block)
+        represented_object.send(method, *args, &block)
+      end
+
+    end
+
     def zuper_method(method_name, *args)
       self.superclass.send(method_name, *args) if self.superclass.respond_to?(method_name)
     end
@@ -28,12 +36,11 @@ module ObjectAttorney
 
     def delegate_getter(getter)
       delegate getter, to: :represented_object
-      add_exposed_getters(getter)
+      add_exposed_data getter
     end
 
     def delegate_setter(setter)
       delegate "#{setter}=", to: :represented_object
-      add_exposed_setters(setter)
     end
 
   end

data/lib/object_attorney/exposed_data.rb

@@ -2,15 +2,15 @@ module ObjectAttorney
 
   module ExposedData
 
-    def exposed_data
-      self.class.exposed_getters.reduce({}) do |data, getter|
+    def to_hash
+      self.class.exposed_data.reduce({}) do |data, getter|
         data[getter] = send(getter)
         data
       end
     end
 
     def to_json(options = {})
-      exposed_data.to_json
+      to_hash.to_json
     end
 
     def self.included(base)
@@ -19,24 +19,16 @@ module ObjectAttorney
 
     module ClassMethods
       
-      def exposed_getters
-        return @exposed_getters if defined?(@exposed_getters)
+      def exposed_data
+        return @exposed_data if defined?(@exposed_data)
 
-        @exposed_getters = zuper_method(:exposed_getters)
+        @exposed_data = zuper_method(:exposed_data)
         
-        @exposed_getters ||= represented_object_class.present? && represented_object_class.method_defined?(:id) ? [:id] : []
+        @exposed_data ||= represented_object_class.present? && represented_object_class.method_defined?(:id) ? [:id] : []
       end
 
-      def add_exposed_getters(*getters)
-        exposed_getters.push(*getters) unless exposed_getters.include?(getters)
-      end
-
-      def exposed_setters
-        @exposed_setters ||= (zuper_method(:exposed_setters) || [])
-      end
-
-      def add_exposed_setters(*setters)
-        exposed_setters.push(*setters) unless exposed_setters.include?(setters)
+      def add_exposed_data(*getters)
+        exposed_data.push(*getters) unless exposed_data.include?(getters)
       end
 
     end

data/lib/object_attorney/representation.rb

@@ -62,6 +62,8 @@ module ObjectAttorney
         properties(*options[:properties]) if options.include?(:properties)
         getters(*options[:getters]) if options.include?(:getters)
         setters(*options[:setters]) if options.include?(:setters)
+
+        class_eval { include Delegation::MissingMethods } if options[:delegate_missing_methods]
       end
 
       def represented_object_reflection

data/lib/object_attorney/version.rb

@@ -1,3 +1,3 @@
 module ObjectAttorney
-  VERSION = "2.8.1"
+  VERSION = "2.9.0"
 end

data/spec/object_attorney/delegation_spec.rb

@@ -1,5 +1,39 @@
 require "spec_helper"
 
+describe PostForm::Presenter do
+
+  it "1. Editing a 'Post', through one property and delegating all missing methods to the represented object", current: true do
+    params = {
+      post: {
+        title: 'altered title',
+        body: 'altered body',
+        user_id: 666        
+      }
+    }
+
+    post = Post.create({ title: 'First post', body: 'post body', user_id: 1 })
+
+    post_form = described_class.new(params[:post], post)
+
+    post_form.save.should == true
+
+    Post.all.count.should == 1
+    post = Post.first
+    post.title.should == 'altered title'
+    post.body.should == 'post body'
+    post.user_id.should == 1
+
+    post_form.title.should == 'altered title'
+    post_form.body.should == 'post body'
+    post_form.user_id.should == 1
+
+    post_form.user_id = 665
+    post_form.user_id.should == 665
+  end
+
+end
+
+
 shared_examples "a PostForm with delegated properties" do
 
   it "1. Creating a 'Post' with 3 params, but only 2 are delegated" do
@@ -38,7 +72,9 @@ shared_examples "a PostForm with only delegated getters" do
   it "1. Editing a 'Post' with 3 params, no changes should take place but the getters should" do
     params = {
       post: {
-        title: 'altered title', body: 'altered body', user_id: 666        
+        title: 'altered title',
+        body: 'altered body',
+        user_id: 666        
       }
     }
 

data/spec/object_attorney/exposed_data_spec.rb

@@ -14,8 +14,7 @@ describe PostForm::GrandSon do
     post_form = described_class.new(params[:post], post)
 
     post_form.save.should == true
-    described_class.exposed_getters.should == [:id, :title, :email, :author, :body, :date]
-    described_class.exposed_setters.should == [:title, :user_id]
+    described_class.exposed_data.should == [:id, :title, :email, :author, :body, :date]
 
     Post.all.count.should == 1
     post = Post.first
@@ -35,7 +34,7 @@ describe PostForm::GrandSon do
     
     data = { id:1, title: "altered title", email: "test@gmail.com", author: "test", body: "post body", date: "20-10-2010" }
 
-    post_form.exposed_data.should == data
+    post_form.to_hash.should == data
     post_form.to_json.should == data.to_json
   end
 

data/spec/spec_helper.rb

@@ -30,7 +30,6 @@ require 'support/form_objects/bulk_posts_allow_only_existing_form'
 require 'support/form_objects/bulk_posts_allow_only_new_form'
 require 'support/form_objects/bulk_posts_with_form_objects_form'
 require 'support/form_objects/user_form'
-require 'support/form_objects/user_form_with_ruby_errors'
 
 RSpec.configure do |config|
   #config.treat_symbols_as_metadata_keys_with_true_values = true

data/spec/support/form_objects/post_form.rb

@@ -50,6 +50,12 @@ module PostForm
   end
   
 
+  class Presenter
+    include ObjectAttorney
+    represents :post, delegate_missing_methods: true, properties: [:title]
+  end
+
+
   class Properties1
     include ObjectAttorney
     represents :post
@@ -94,7 +100,7 @@ module PostForm
   class Father < GrandFather
     properties :title
 
-    add_exposed_getters :email, :author
+    add_exposed_data :email, :author
 
     attr_accessor :email, :author
   end
@@ -106,7 +112,7 @@ module PostForm
   class GrandSon < Son
     setters :user_id
 
-    add_exposed_getters :date
+    add_exposed_data :date
 
     attr_accessor :date
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: object_attorney
 version: !ruby/object:Gem::Version
-  version: 2.8.1
+  version: 2.9.0
 platform: ruby
 authors:
 - João Gonçalves
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-21 00:00:00.000000000 Z
+date: 2014-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -103,7 +103,6 @@ files:
 - spec/object_attorney/post_with_only_existing_comments_form_spec.rb
 - spec/object_attorney/post_with_only_new_comments_form_spec.rb
 - spec/object_attorney/user_form_spec.rb
-- spec/object_attorney/user_form_with_ruby_errors_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model/validations.rb
 - spec/support/database_setup.rb
@@ -120,7 +119,6 @@ files:
 - spec/support/form_objects/post_with_only_existing_comments_form.rb
 - spec/support/form_objects/post_with_only_new_comments_form.rb
 - spec/support/form_objects/user_form.rb
-- spec/support/form_objects/user_form_with_ruby_errors.rb
 - spec/support/models/address.rb
 - spec/support/models/comment.rb
 - spec/support/models/post.rb
@@ -166,7 +164,6 @@ test_files:
 - spec/object_attorney/post_with_only_existing_comments_form_spec.rb
 - spec/object_attorney/post_with_only_new_comments_form_spec.rb
 - spec/object_attorney/user_form_spec.rb
-- spec/object_attorney/user_form_with_ruby_errors_spec.rb
 - spec/spec_helper.rb
 - spec/support/active_model/validations.rb
 - spec/support/database_setup.rb
@@ -183,7 +180,6 @@ test_files:
 - spec/support/form_objects/post_with_only_existing_comments_form.rb
 - spec/support/form_objects/post_with_only_new_comments_form.rb
 - spec/support/form_objects/user_form.rb
-- spec/support/form_objects/user_form_with_ruby_errors.rb
 - spec/support/models/address.rb
 - spec/support/models/comment.rb
 - spec/support/models/post.rb

data/spec/object_attorney/user_form_with_ruby_errors_spec.rb

@@ -1,15 +0,0 @@
-require "spec_helper"
-
-describe UserFormWithRubyErrors do
-
-  xit "1. 'UserFormWithRubyErrors' when saving should through an error!" do
-    params = { user: { email: 'email@gmail.com', terms_of_service: true } }
-
-    user_form = UserFormWithRubyErrors.new(params[:user])
-    save_result = user_form.save
-
-    save_result.should == true
-    User.all.count.should == 1
-  end
-
-end

data/spec/support/form_objects/user_form_with_ruby_errors.rb

@@ -1,15 +0,0 @@
-class UserFormWithRubyErrors
-
-  include ObjectAttorney
-
-  represents :user, properties: [:email]
-
-  attr_accessor :terms_of_service
-
-  validates_acceptance_of :terms_of_service, accept: true, allow_nil: false
-
-  def submit
-    fake_var == true
-  end
-
-end