object_attorney 1.0.2 → 1.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NGI4MzlkYzA2YTkxOTc0Yzc1ZWJkOGIxYzk1Y2NjNGExY2Q2YWExOQ==
+    YzdjZjUwYTk2MGM5NDM2Nzg3MTE4YmY3ODVhZDVlODQ4MmRiMmRjYg==
   data.tar.gz: !binary |-
-    ZjBkNGJmMTNmMjgxYWY0NjRhYjgxZmNlNWI1MDliY2JmMjMwMzQ2NA==
+    NjQ0YzRjYjg3YTlkMzgyYTU5Njk4MTNmMTkwNDU2NWRiNWMxNmE2NQ==
 SHA512:
   metadata.gz: !binary |-
-    YjI0MzM3ZTRjMzM2MTYxYmIxZTg0ZTU4YzRkNjkwMzk0MTYzOTZjNDI1NGIz
-    Y2IxNDJjY2U3N2U0NzhlOGJhMzViMTQxYmYzZmQ1ZDIwZDhhNzFiNzNjODk5
-    MzQyNThmNjU5ZjdiMGRlODM0MGZjZDY4ODA2ZTdlY2JhMDRkNmI=
+    NTYwMTk5MGNjNzI4NTQwMWM4ZGFlOTBkY2JkMDYwZTdmZmQwMjk0ZGVjMDZl
+    NjIwZmUxNWY3ZThlNTViNTg5YjRiZjMwYTRiZDAyYTZmMGM5ZjJhYzg4ZGM5
+    YThhODIzOTFjMzAzMmE4YjM3MDgyMzhkNTlkOGRlYjlkODkwOWQ=
   data.tar.gz: !binary |-
-    ZmU1NWM2NTJjMGY3MjlmOGJkNGQzZTUxMzVjY2RiMTVlZjQ2OTNjOGNlMjU2
-    NTAyMzg5YTk0ZTBjOTIyYWY2OThhMTkxYjhhOWFmZDk5ZTMxMTkyMzY3MTQz
-    MWU3NmZjM2I2Y2YzNGI2NWFhODIyNDFjNGI2YzE0Y2I2MTU1NTI=
+    MzQzNGRkZDIwMjYwOGVlMjFkMjkzYTA4MGM2OTQ5ZDk1OTdiNmQxZjE3MGM0
+    MTdmMGJmOWIzZGI2MzAwYWJmZTZhOGQ2YTM0MzczYmNlZWYzYzZlODUxYmU0
+    YjU4ODQ1MmYwZDkxMzk4MDBiNGViMWFhZGQyNWY2YWM1OTAyODQ=

data/.gitignore

@@ -14,5 +14,6 @@ rdoc
 spec/reports
 test/tmp
 test/version_tmp
-tmp
-*.DS_Store
+tmp/*
+*.DS_Store
+db/test.sqlite3

data/.rspec

@@ -0,0 +1,3 @@
+--tty
+--color
+--format documentation

data/.rvmrc

@@ -0,0 +1 @@
+rvm 1.9.3@object_attorney --create

data/Gemfile

@@ -2,3 +2,15 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in object_attorney.gemspec
 gemspec
+
+group :development, :test do
+  gem "rspec", "~> 2.11"
+  gem "sqlite3"
+  gem "activerecord"
+  #gem 'database_cleaner'
+  gem "pry"
+
+  unless ENV["CI"]
+    gem "guard-rspec", "~> 0.7"
+  end
+end

data/Guardfile

@@ -0,0 +1,5 @@
+guard :rspec, :cli => "--color --fail-fast -I. -fs" do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')  { "spec" }
+end

data/Rakefile

@@ -1 +1,19 @@
 require "bundler/gem_tasks"
+
+# see: http://blog.aizatto.com/2007/05/27/activerecord-migrations-without-rails/
+# require 'active_record'
+# require 'yaml'
+
+# ENV["RAILS_ENV"] ||= 'test'
+
+# task :default => :migrate
+ 
+# desc "Migrate the database through scripts in db/migrate. Target specific version with VERSION=x"
+# task :migrate => :environment do
+#   ActiveRecord::Migrator.migrate('db/migrate', ENV["VERSION"] ? ENV["VERSION"].to_i : nil )
+# end
+ 
+# task :environment do
+#   ActiveRecord::Base.establish_connection(YAML::load(File.open('config/database.yml'))[ENV["RAILS_ENV"]])
+#   ActiveRecord::Base.logger = Logger.new(File.open('tmp/database.log', 'a'))
+# end

data/db/migrate/20131205114900_create_posts.rb

@@ -0,0 +1,14 @@
+class CreatePosts < ActiveRecord::Migration
+  def up
+    create_table :posts do |t|
+      t.string :title
+      t.text :body
+      t.boolean :admin, default: false
+      t.timestamps
+    end
+  end
+
+  def down
+    drop_table :posts
+  end
+end

data/db/schema.rb

@@ -0,0 +1,22 @@
+# This file is auto-generated from the current state of the database. Instead
+# of editing this file, please use the migrations feature of Active Record to
+# incrementally modify your database, and then regenerate this schema definition.
+#
+# Note that this schema.rb definition is the authoritative source for your
+# database schema. If you need to create the application database on another
+# system, you should be using db:schema:load, not running all the migrations
+# from scratch. The latter is a flawed and unsustainable approach (the more migrations
+# you'll amass, the slower it'll run and the greater likelihood for issues).
+#
+# It's strongly recommended that you check this file into your version control system.
+
+ActiveRecord::Schema.define(version: 20131020175047) do
+
+  create_table "posts", force: true do |t|
+    t.string   "title"
+    t.text     "body"
+    t.datetime "created_at"
+    t.datetime "updated_at"
+  end
+
+end

data/lib/object_attorney/nested_objects.rb

@@ -2,7 +2,7 @@ module ObjectAttorney
   module NestedObjects
 
     def nested_objects
-      @@nested_objects.map { |nested_object_sym| self.send(nested_object_sym) }.flatten
+      self.class.nested_objects.map { |nested_object_sym| self.send(nested_object_sym) }.flatten
     end
 
     def mark_for_destruction
@@ -18,11 +18,17 @@ module ObjectAttorney
 
       _destroy = attributes["_destroy"] || attributes[:_destroy]
 
-      object.mark_for_destruction if ["true", "1"].include?(_destroy)
+      object.mark_for_destruction if ["true", "1", true].include?(_destroy)
     end
 
     protected #################### PROTECTED METHODS DOWN BELOW ######################
 
+    def save_nested_objects(save_method)
+      nested_objects.map do |nested_object|
+        call_save_or_destroy(nested_object, save_method)
+      end.all?
+    end
+
     def validate_nested_objects
       #nested_objects.all?(&:valid?) #will not validate all nested_objects
       return true if nested_objects.reject(&:marked_for_destruction?).map(&:valid?).all?
@@ -31,7 +37,7 @@ module ObjectAttorney
     end
 
     def import_nested_objects_errors
-      @@nested_objects.map do |nested_object_sym|
+      self.class.nested_objects.map do |nested_object_sym|
         
         [*self.send(nested_object_sym)].each do |nested_object|
           nested_object.errors.full_messages.each { |message| self.errors.add(nested_object_sym, message) }
@@ -54,8 +60,6 @@ module ObjectAttorney
       base.class_eval do
         validate :validate_nested_objects
       end
-
-      @@nested_objects = []
     end
 
     def attributes_without_destroy(attributes)
@@ -101,7 +105,7 @@ module ObjectAttorney
 
     def build_new_nested_objects(existing_and_new_nested_objects, nested_object_name)
       (send("#{nested_object_name}_attributes") || {}).values.each do |attributes|
-        next if attributes["id"].present?
+        next if attributes["id"].present? || attributes[:id].present?
 
         new_nested_object = send("build_#{nested_object_name.to_s.singularize}", attributes_without_destroy(attributes))
         mark_for_destruction_if_necessary(new_nested_object, attributes)
@@ -122,6 +126,10 @@ module ObjectAttorney
         nil
       end
 
+      def nested_objects
+        self.instance_variable_get("@nested_objects") || zuper_method('nested_objects') || []
+      end
+
       private #################### PRIVATE METHODS DOWN BELOW ######################
 
       def define_nested_objects_getter_methods(nested_objects_list)

data/lib/object_attorney/orm.rb

@@ -2,13 +2,17 @@ require "object_attorney/orm_handlers/smooth_operator"
 
 module ObjectAttorney
   module ORM
+
+    def id
+      represented_object.try(:id)
+    end
   
     def new_record?
-      try_or_return(@represented_object, :new_record?, true)
+      try_or_return(represented_object, :new_record?, true)
     end
 
     def persisted?
-      try_or_return(@represented_object, :persisted?, false)
+      try_or_return(represented_object, :persisted?, false)
     end
 
     def save
@@ -23,13 +27,13 @@ module ObjectAttorney
     end
 
     def destroy
-      return true if @represented_object.blank?
-      evoke_method_on_object(@represented_object, :destroy)
+      return true if represented_object.blank?
+      evoke_method_on_object(represented_object, :destroy)
     end
 
     def call_save_or_destroy(object, save_method)
       if object == self
-        @represented_object.present? ? evoke_method_on_object(@represented_object, save_method) : true
+        represented_object.present? ? evoke_method_on_object(represented_object, save_method) : true
       else
         save_method = :destroy if check_if_marked_for_destruction?(object)
         evoke_method_on_object(object, save_method)
@@ -42,8 +46,18 @@ module ObjectAttorney
     def after_save; end
 
     def save_after_validations(save_method)
-      return true if @represented_object.blank?
-      evoke_method_on_object(@represented_object, save_method)
+      submit(save_method)
+    end
+
+    def submit(save_method)
+      save_result = save_represented_object(save_method)
+      save_result = save_nested_objects(save_method) if save_result
+      save_result
+    end
+
+    def save_represented_object(save_method)
+      return true if represented_object.blank?
+      call_save_or_destroy(represented_object, save_method)
     end
 
     private #################### PRIVATE METHODS DOWN BELOW ######################

data/lib/object_attorney/orm_handlers/smooth_operator.rb

@@ -15,13 +15,13 @@ module ObjectAttorney
       end
 
       def destroy(options = {})
-        return true if @represented_object.blank?
-        evoke_method_on_object(@represented_object, :destroy, options)
+        return true if represented_object.blank?
+        evoke_method_on_object(represented_object, :destroy, options)
       end
 
       def call_save_or_destroy(object, save_method, options = {})
-        if object == self || object == @represented_object
-          @represented_object.present? ? evoke_method_on_object(@represented_object, save_method, options) : true
+        if object == self || object == represented_object
+          represented_object.present? ? evoke_method_on_object(represented_object, save_method, options) : true
         else
           save_method = :destroy if check_if_marked_for_destruction?(object)
           evoke_method_on_object(object, save_method, options)
@@ -31,8 +31,8 @@ module ObjectAttorney
       protected #################### PROTECTED METHODS DOWN BELOW ######################
 
       def save_after_validations(save_method, options = {})
-        return true if @represented_object.blank?
-        evoke_method_on_object(@represented_object, save_method, options).ok?
+        return true if represented_object.blank?
+        evoke_method_on_object(represented_object, save_method, options).ok?
       end
 
       private #################### PRIVATE METHODS DOWN BELOW ######################

data/lib/object_attorney/version.rb

@@ -1,3 +1,3 @@
 module ObjectAttorney
-  VERSION = "1.0.2"
+  VERSION = "1.1.1"
 end

data/lib/object_attorney.rb

@@ -1,6 +1,7 @@
 require "object_attorney/version"
 require "object_attorney/nested_objects"
 require "object_attorney/orm"
+require 'active_record'
 
 module ObjectAttorney
 
@@ -39,21 +40,21 @@ module ObjectAttorney
 
   def allowed_attribute(attribute)
     attribute = attribute.to_s
-
-    return false  if !respond_to?("#{attribute}=") || self.class.black_list.include?(attribute)
-    return true   if self.class.white_list.empty?
-
-    self.class.white_list.include?(attribute)
+    respond_to?("#{attribute}=")
   end
 
   def validate_represented_object
-    valid = override_validations? ? true : try_or_return(@represented_object, :valid?, true)
+    valid = override_validations? ? true : try_or_return(represented_object, :valid?, true)
     import_represented_object_errors unless valid
     valid
   end
 
   def import_represented_object_errors
-    @represented_object.errors.each { |key, value| self.errors.add(key, value) }
+    represented_object.errors.each { |key, value| self.errors.add(key, value) }
+  end
+
+  def represented_object
+    @represented_object ||= self.class.represented_object_class.try(:new)
   end
 
   private #################### PRIVATE METHODS DOWN BELOW ######################
@@ -87,36 +88,28 @@ module ObjectAttorney
 
   module ClassMethods
 
-    def represents(represented_object, represented_object_class = nil)
-      @@represented_object_class = represented_object_class || represented_object.to_s.camelize.constantize
+    def represents(represented_object_name, represented_object_class = nil)
+      self.instance_variable_set("@represented_object_class", represented_object_class || represented_object_name.to_s.camelize.constantize)
 
-      define_method(represented_object) do
-        @represented_object ||= @@represented_object_class.new
+      define_method(represented_object_name) do
+        represented_object
       end
     end
 
-    def delegate_properties(*properties, options)
-      properties.each { |property| delegate_propertiy(property, options) }
-    end
-
-    def delegate_propertiy(property, options)
-      delegate property, "#{property}=", options
-    end
-
-    def attr_white_list=(*white_list)
-      @@white_list = white_list.map(&:to_s)
+    def represented_object_class
+      self.instance_variable_get("@represented_object_class") || zuper_method('represented_object_class')
     end
 
-    def white_list
-      @@white_list ||= []
+    def zuper_method(method_name, *args)
+      self.superclass.send(method_name, *args) if self.superclass.respond_to?(method_name)
     end
 
-    def attr_black_list(*black_list)
-      @@black_list = black_list.map(&:to_s)
+    def delegate_properties(*properties, options)
+      properties.each { |property| delegate_property(property, options) }
     end
 
-    def black_list
-      @@black_list ||= ["_destroy"]
+    def delegate_property(property, options)
+      delegate property, "#{property}=", options
     end
 
     def human_attribute_name(attribute_key_name, options = {})
@@ -130,19 +123,19 @@ module ObjectAttorney
       
       translation = I18n.translate(defaults.shift, options.merge(default: defaults))
 
-      if translation == no_translation && @@represented_object_class.respond_to?(:human_attribute_name)
-        translation = @@represented_object_class.human_attribute_name(attribute_key_name, options)
+      if translation == no_translation && represented_object_class.respond_to?(:human_attribute_name)
+        translation = represented_object_class.human_attribute_name(attribute_key_name, options)
       end
 
       translation
     end
 
     def model_name
-      @@_model_name ||= begin
+      @_model_name ||= begin
         namespace = self.parents.detect do |n|
           n.respond_to?(:use_relative_model_naming?) && n.use_relative_model_naming?
         end
-        ActiveModel::Name.new(@@represented_object_class || self, namespace)
+        ActiveModel::Name.new(represented_object_class || self, namespace)
       end
     end
 

data/object_attorney.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = ObjectAttorney::VERSION
   spec.authors       = ["João Gonçalves"]
   spec.email         = ["goncalves.joao@gmail.com"]
-  spec.description   = %q{Form Object Patter Implementation}
-  spec.summary       = %q{This gem allows you to extract the code responsible for Validations, Nested Objects and Forms, from your model, into a specific class for a specific use case.}
+  spec.description   = %q{Form Object pattern implementation for Rails}
+  spec.summary       = %q{This gem allows you to extract the code responsible for 'validations', 'nested objects' and 'strong parameters' from your model onto a specific class for a specific use case.}
   spec.homepage      = "https://github.com/goncalvesjoao/object_attorney"
   spec.license       = "MIT"
 

data/spec/object_attorney/bulk_posts_form_child_spec.rb

@@ -0,0 +1,191 @@
+require "spec_helper"
+
+describe BulkPostsFormChild do
+
+  it "Creating multiple Posts, with a tabless model 'BulkPostsFormChild' has if it had 'accepts_nested_attributes_for :posts'" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { state: "draft", title: "My title1" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    bulk_posts_form_child = BulkPostsFormChild.new(params[:bulk_post])
+    bulk_posts_form_child.save
+    
+    expect(Post.all.count).to(eq(2))
+  end
+
+  it "Trying to create multiple Posts, with the same title (testing the 'validates_nested_uniqueness')" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { state: "draft", title: "My title1" },
+          "1" => { state: "public", title: "My title1" }
+        }
+      }
+    }
+
+    bulk_posts_form = BulkPostsFormChild.new(params[:bulk_post])
+    bulk_posts_form.save
+    
+    # TODO: Ensure that the nested objects remember their respective errors
+    # see: http://stackoverflow.com/questions/13879700/rails-model-valid-flusing-custom-errors-and-falsely-returning-true
+    
+    expect(Post.all.count).to(eq(0))
+  end
+
+  it "Creating new Post and editing an existing one" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { id: 1, state: "draft", title: "Changed title" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsFormChild.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(2)) && expect(existing_post.title).to(eq('Changed title'))
+  end
+
+  it "Creating new Post and deleting an existing one" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsFormChild.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
+  end
+
+  it "Trying to create multiple Posts, but one of them is invalid" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { title: "My title1" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    BulkPostsFormChild.new(params[:bulk_post]).save
+
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { state: 'draft', title: "My title1" },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    BulkPostsFormChild.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(0))
+  end
+
+  it "Trying to create new Post and editing an existing one, but one of them is invalid" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { id: 1, title: "Changed title" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsFormChild.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { id: 1, state: 'draft', title: "Changed title" },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    BulkPostsFormChild.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+  end
+
+  it "Trying to create new Post and deleting an existing one, but the new one is invalid" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsFormChild.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+  end
+
+  it "Trying to create new Post and deleting an existing one, the existing one is invalid but since it is marked for destruction, it should be deleted" do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { id: 1, title: "Changed title", _destroy: true },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    bulk_posts_form_child = BulkPostsFormChild.new(params[:bulk_post])
+    bulk_posts_form_child.save
+    
+    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
+  end
+
+  it "Trying to create new Post and deleting an existing one, both of them are invalid, no changes should occur." do
+    params = {
+      bulk_post: {
+        admin: true,
+        posts_attributes: {
+          "0" => { id: 1, title: "Changed title", _destroy: true },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsFormChild.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+  end
+
+end

data/spec/object_attorney/bulk_posts_form_spec.rb

@@ -0,0 +1,178 @@
+require "spec_helper"
+
+describe BulkPostsForm do
+
+  it "Creating multiple Posts, with a tabless model 'BulkPostsForm' has if it had 'accepts_nested_attributes_for :posts'" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { state: "draft", title: "My title1" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    BulkPostsForm.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(2))
+  end
+
+  it "Creating multiple Posts, with the same title (testing the 'validates_nested_uniqueness')" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { state: "draft", title: "My title1" },
+          "1" => { state: "public", title: "My title1" }
+        }
+      }
+    }
+
+    bulk_posts_form = BulkPostsForm.new(params[:bulk_post])
+    bulk_posts_form.save
+    
+    # TODO: Ensure that the nested objects remember their respective errors
+    # see: http://stackoverflow.com/questions/13879700/rails-model-valid-flusing-custom-errors-and-falsely-returning-true
+    
+    expect(Post.all.count).to(eq(0))
+  end
+
+  it "Creating new Post and editing an existing one" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { id: 1, state: "draft", title: "Changed title" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsForm.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(2)) && expect(existing_post.title).to(eq('Changed title'))
+  end
+
+  it "Creating new Post and deleting an existing one" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsForm.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
+  end
+
+  it "Trying to create multiple Posts, but one of them is invalid" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { title: "My title1" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    BulkPostsForm.new(params[:bulk_post]).save
+
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { state: 'draft', title: "My title1" },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    BulkPostsForm.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(0))
+  end
+
+  it "Trying to create new Post and editing an existing one, but one of them is invalid" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { id: 1, title: "Changed title" },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsForm.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { id: 1, state: 'draft', title: "Changed title" },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    BulkPostsForm.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+  end
+
+  it "Trying to create new Post and deleting an existing one, but the new one is invalid" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { id: 1, state: "draft", title: "Changed title", _destroy: true },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsForm.new(params[:bulk_post]).save
+    existing_post.reload
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+  end
+
+  it "Trying to create new Post and deleting an existing one, the existing one is invalid but since it is marked for destruction, it should be deleted" do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { id: 1, title: "Changed title", _destroy: true },
+          "1" => { state: "public", title: "My title2" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsForm.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(1)) && expect(Post.where(id: existing_post.id).present?).to(eq(false))
+  end
+
+  it "Trying to create new Post and deleting an existing one, both of them are invalid, no changes should occur." do
+    params = {
+      bulk_post: {
+        posts_attributes: {
+          "0" => { id: 1, title: "Changed title", _destroy: true },
+          "1" => { state: "public" }
+        }
+      }
+    }
+
+    existing_post = Post.create(title: "My title1")
+    BulkPostsForm.new(params[:bulk_post]).save
+    
+    expect(Post.all.count).to(eq(1)) && expect(existing_post.title).to(eq('My title1'))
+  end
+
+end

data/spec/object_attorney/post_form_child_spec.rb

@@ -0,0 +1,60 @@
+require "spec_helper"
+
+describe PostFormChild do
+
+  it "PostFormChild becomes invalid when Post does and incorporates its errors" do
+    post = Post.new
+    post.should have(1).error_on(:title)
+    post.title = "My title"
+    post.should have(:no).errors_on(:title)
+
+    post_form = PostFormChild.new({ state: 'draft', date: Date.today })
+    post_form.should have(1).error_on(:title)
+    post_form.title = "My title"
+    post_form.should have(:no).errors_on(:title)
+  end
+
+  it "PostFormChild may require the validations of fields that Post doesn't have" do
+    params = { post: { title: "My title" } }
+
+    post = Post.new(params[:post])
+    post.should have(:no).errors_on(:date)
+
+    post_form = PostFormChild.new(params[:post].merge(state: 'public'))
+    post_form.should have(1).error_on(:date)
+    post_form.date = Date.today
+    post_form.should have(:no).errors_on(:date)
+  end
+
+  it "Post creation through PostFormChild" do
+    params = { post: { state: 'public', title: "My title", body: "My body", date: Date.today } }
+    post_form = PostFormChild.new(params[:post])
+
+    expect(post_form.save).to(eq(true)) && expect(post_form.post.persisted?).to(eq(true))
+  end
+
+  it "Post can't be created if PostFormChild isn't valid" do
+    params = { post: { state: 'public', title: "My title", body: "My body" } }
+    post_form = PostFormChild.new(params[:post])
+
+    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
+  end
+
+  it "Post can't be created if Post isn't valid" do
+    params = { post: { state: 'public', date: Date.today, body: "My body" } }
+    post_form = PostFormChild.new(params[:post])
+
+    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
+  end
+
+  it "PostFormChild won't allow weak params to be updated, unlike Post" do
+    params = { post: { title: 'My title', body: "My body", admin: true } }
+
+    post_form = PostFormChild.new(params[:post].merge({ state: 'public', date: Date.today }))
+    expect(post_form.save).to(eq(true)) && expect(post_form.post.admin).to(eq(false))
+    
+    post = Post.new(params[:post])
+    expect(post.save).to(eq(true)) && expect(post.admin).to(eq(true))
+  end
+
+end

data/spec/object_attorney/post_form_spec.rb

@@ -0,0 +1,60 @@
+require "spec_helper"
+
+describe PostForm do
+
+  it "PostForm becomes invalid when Post does and incorporates its errors" do
+    post = Post.new
+    post.should have(1).error_on(:title)
+    post.title = "My title"
+    post.should have(:no).errors_on(:title)
+
+    post_form = PostForm.new({ state: 'draft' })
+    post_form.should have(1).error_on(:title)
+    post_form.title = "My title"
+    post_form.should have(:no).errors_on(:title)
+  end
+
+  it "PostForm may require the validations of fields that Post doesn't have" do
+    params = { post: { title: "My title" } }
+
+    post = Post.new(params[:post])
+    post.should have(:no).errors_on(:state)
+
+    post_form = PostForm.new(params[:post])
+    post_form.should have(1).error_on(:state)
+    post_form.state = "draft"
+    post_form.should have(:no).errors_on(:state)
+  end
+
+  it "Post creation through PostForm" do
+    params = { post: { state: 'public', title: "My title", body: "My body" } }
+    post_form = PostForm.new(params[:post])
+
+    expect(post_form.save).to(eq(true)) && expect(post_form.post.persisted?).to(eq(true))
+  end
+
+  it "Post can't be created if PostForm isn't valid" do
+    params = { post: { title: "My title", body: "My body" } }
+    post_form = PostForm.new(params[:post])
+
+    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
+  end
+
+  it "Post can't be created if Post isn't valid" do
+    params = { post: { state: 'public', body: "My body" } }
+    post_form = PostForm.new(params[:post])
+
+    expect(post_form.save).to(eq(false)) && expect(post_form.post.persisted?).to(eq(false))
+  end
+
+  it "PostForm won't allow weak params to be updated, unlike Post" do
+    params = { post: { title: 'My title', body: "My body", admin: true } }
+
+    post_form = PostForm.new(params[:post].merge({ state: 'public' }))
+    expect(post_form.save).to(eq(true)) && expect(post_form.post.admin).to(eq(false))
+    
+    post = Post.new(params[:post])
+    expect(post.save).to(eq(true)) && expect(post.admin).to(eq(true))
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,47 @@
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
+
+ENV["RAILS_ENV"] ||= 'test'
+
+require 'bundler'
+Bundler.setup
+require 'rspec'
+require 'pry'
+#require 'database_cleaner'
+
+require 'object_attorney'
+require 'support/database_setup'
+require 'support/active_model/validations'
+require 'support/models/post'
+require 'support/models/post_form'
+require 'support/models/post_form_child'
+require 'support/models/bulk_posts_form'
+require 'support/models/bulk_posts_form_child'
+
+RSpec.configure do |config|
+
+  I18n.enforce_available_locales = false
+
+  # see: http://iain.nl/testing-activerecord-in-isolation
+  config.around do |example|
+    ActiveRecord::Base.transaction do
+      example.run
+      raise ActiveRecord::Rollback
+    end
+  end
+
+  # see: https://github.com/bmabey/database_cleaner#rspec-example
+  # config.before(:suite) do
+  #   DatabaseCleaner.strategy = :transaction
+  #   DatabaseCleaner.clean_with(:truncation)
+  # end
+
+  # config.before(:each) do
+  #   DatabaseCleaner.start
+  # end
+
+  # config.after(:each) do
+  #   DatabaseCleaner.clean
+  # end
+
+end

data/spec/support/active_model/validations.rb

@@ -0,0 +1,21 @@
+
+# see: http://iain.nl/testing-activerecord-in-isolation
+module ActiveModel::Validations
+  # Extension to enhance `should have` on AR Model instances.  Calls
+  # model.valid? in order to prepare the object's errors object.
+  #
+  # You can also use this to specify the content of the error messages.
+  #
+  # @example
+  #
+  #     model.should have(:no).errors_on(:attribute)
+  #     model.should have(1).error_on(:attribute)
+  #     model.should have(n).errors_on(:attribute)
+  #
+  #     model.errors_on(:attribute).should include("can't be blank")
+  def errors_on(attribute)
+    self.valid?
+    [self.errors[attribute]].flatten.compact
+  end
+  alias :error_on :errors_on
+end

data/spec/support/database_setup.rb

@@ -0,0 +1,14 @@
+# see: http://iain.nl/testing-activerecord-in-isolation
+ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:"
+ActiveRecord::Migrator.up "db/migrate"
+
+# see: http://blog.aizatto.com/2007/05/27/activerecord-migrations-without-rails/
+#ActiveRecord::Base.establish_connection(YAML::load(File.open('config/database.yml'))[ENV["RAILS_ENV"]])
+#ActiveRecord::Base.logger = Logger.new(File.open('tmp/database.log', 'a'))
+
+# config/database.yml
+# test:
+#   adapter: sqlite3
+#   database: db/test.sqlite3
+#   pool: 5
+#   timeout: 5000

data/spec/support/models/bulk_posts_form.rb

@@ -0,0 +1,21 @@
+require 'object_attorney/nested_uniqueness_validator'
+
+class BulkPostsForm
+
+  include ObjectAttorney
+
+  accepts_nested_objects :posts
+
+  validates_nested_uniqueness :posts, uniq_value: :title
+
+  ##################### BODY BELLOW THIS LINE ####################
+
+  def build_post(attributes = {}, post = nil)
+    PostForm.new(attributes, post)
+  end
+
+  def existing_posts
+    Post.all.map { |post| build_post({}, post) }
+  end
+
+end

data/spec/support/models/bulk_posts_form_child.rb

@@ -0,0 +1,7 @@
+class BulkPostsFormChild < BulkPostsForm
+
+  attr_accessor :admin
+
+  validates_presence_of :admin
+
+end

data/spec/support/models/post.rb

@@ -0,0 +1,3 @@
+class Post < ActiveRecord::Base
+  validates_presence_of :title
+end

data/spec/support/models/post_form.rb

@@ -0,0 +1,13 @@
+class PostForm
+
+  include ObjectAttorney
+
+  represents :post, Post
+
+  delegate_properties :title, :body, to: :post
+
+  attr_accessor :state
+
+  validates_presence_of :state
+
+end

data/spec/support/models/post_form_child.rb

@@ -0,0 +1,7 @@
+class PostFormChild < PostForm
+
+  attr_accessor :date
+
+  validates_presence_of :date
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: object_attorney
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.1
 platform: ruby
 authors:
 - João Gonçalves
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-04 00:00:00.000000000 Z
+date: 2013-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -38,7 +38,7 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: Form Object Patter Implementation
+description: Form Object pattern implementation for Rails
 email:
 - goncalves.joao@gmail.com
 executables: []
@@ -46,10 +46,15 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
+- .rvmrc
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- db/migrate/20131205114900_create_posts.rb
+- db/schema.rb
 - lib/object_attorney.rb
 - lib/object_attorney/nested_objects.rb
 - lib/object_attorney/nested_uniqueness_validator.rb
@@ -57,6 +62,18 @@ files:
 - lib/object_attorney/orm_handlers/smooth_operator.rb
 - lib/object_attorney/version.rb
 - object_attorney.gemspec
+- spec/object_attorney/bulk_posts_form_child_spec.rb
+- spec/object_attorney/bulk_posts_form_spec.rb
+- spec/object_attorney/post_form_child_spec.rb
+- spec/object_attorney/post_form_spec.rb
+- spec/spec_helper.rb
+- spec/support/active_model/validations.rb
+- spec/support/database_setup.rb
+- spec/support/models/bulk_posts_form.rb
+- spec/support/models/bulk_posts_form_child.rb
+- spec/support/models/post.rb
+- spec/support/models/post_form.rb
+- spec/support/models/post_form_child.rb
 homepage: https://github.com/goncalvesjoao/object_attorney
 licenses:
 - MIT
@@ -80,7 +97,19 @@ rubyforge_project:
 rubygems_version: 2.1.10
 signing_key: 
 specification_version: 4
-summary: This gem allows you to extract the code responsible for Validations, Nested
-  Objects and Forms, from your model, into a specific class for a specific use case.
-test_files: []
-has_rdoc: 
+summary: This gem allows you to extract the code responsible for 'validations', 'nested
+  objects' and 'strong parameters' from your model onto a specific class for a specific
+  use case.
+test_files:
+- spec/object_attorney/bulk_posts_form_child_spec.rb
+- spec/object_attorney/bulk_posts_form_spec.rb
+- spec/object_attorney/post_form_child_spec.rb
+- spec/object_attorney/post_form_spec.rb
+- spec/spec_helper.rb
+- spec/support/active_model/validations.rb
+- spec/support/database_setup.rb
+- spec/support/models/bulk_posts_form.rb
+- spec/support/models/bulk_posts_form_child.rb
+- spec/support/models/post.rb
+- spec/support/models/post_form.rb
+- spec/support/models/post_form_child.rb