obfuscated_identifier 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3fe76e8c21cff5d81384599c49de05b53dd6f26
-  data.tar.gz: d15816d65ee76a1226a826853c98441b41d0d553
+  metadata.gz: 5f05e9a15ddbdc7de72525602c9c3e9713af8907
+  data.tar.gz: 4b4eb21cb3a9e5493e190ce081d5e4404fba7651
 SHA512:
-  metadata.gz: 6f2d887a344032f28fe86aacd2c947771d0be33daeadbd27209235527500ffef86350261c1aaeb3f80f21ed0fe71703c93ce87c36509dedc20b8ab2e712303f7
-  data.tar.gz: 36633ab880ea8269782db357193943c65005c3840ab0100fc57b419d312f90a2d62f1ff05eab7b1b669e53c7002d4b4797f7d75d6a0fb51830eda80ca0919dca
+  metadata.gz: 407aabe099a93f6f8cd4765dc98b5b1cb7bb1e5cead3a956e1d636a44034cf6a29400507294de0680e680460de91d94bcd86334114f11bd79ffc7e53574553d7
+  data.tar.gz: 6bce6c15a8298251bd46dcea0d8b91a04e9447c51b07faf4b4b46b2da2ca4f444ea2a93b9967c950bb134569f2f312b3775d189c3a2d67e072e48e1cb040123d

data/lib/obfuscated_identifier/version.rb

@@ -1,3 +1,3 @@
 module ObfuscatedIdentifier
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/obfuscated_identifier.rb

@@ -31,6 +31,8 @@ module ObfuscatedIdentifier
     end
 
     def from_identifier(value)
+      return nil unless valid_identifier_pattern?(value)
+
       counts = value.each_char.map { |c| @identifier_pattern.index(c.to_s) }.reverse
 
       numbers = counts[0..-2].each_with_index.map do |count, index|
@@ -40,6 +42,14 @@ module ObfuscatedIdentifier
       numbers.join('').to_i
     end
 
+    def valid_identifier_pattern?(value)
+      return false if value.nil? || value == ''
+      return false if value.length != @identifier_length
+      return false if value.match(/[^a-f 0-9]/)
+
+      true
+    end
+
     def to_identifier(value)
       padded_string = pad_number(value)
 

data/spec/obfuscated_identifier_spec.rb

@@ -64,12 +64,46 @@ describe ObfuscatedIdentifier do
   end
 
   describe '.from_identifier' do
-    it 'returns a number' do
-      expect(klass.from_identifier(example_identifier)).to be_instance_of(Fixnum)
+    context 'when the identifier is valid' do
+      it 'returns a number' do
+        expect(klass.from_identifier(example_identifier)).to be_instance_of(Fixnum)
+      end
+
+      it 'returns the expected integer' do
+        expect(klass.from_identifier(example_identifier)).to eq(example_number)
+      end
     end
 
-    it 'returns the expected integer' do
-      expect(klass.from_identifier(example_identifier)).to eq(example_number)
+    context 'when the identifier is nil' do
+      let(:example_identifier) { 'nil' }
+
+      it 'returns nil' do
+        expect(klass.from_identifier(example_identifier)).to be_nil
+      end
+    end
+
+    context 'when the identifier is blank' do
+      let(:example_identifier) { '' }
+
+      it 'returns nil' do
+        expect(klass.from_identifier(example_identifier)).to be_nil
+      end
+    end
+
+    context 'when the identifier is an invalid length' do
+      let(:example_identifier) { 'foo' }
+
+      it 'returns nil' do
+        expect(klass.from_identifier(example_identifier)).to be_nil
+      end
+    end
+
+    context 'when the identifier contains invalid characters' do
+      let(:example_identifier) { 'b2801d946ae53cz*' }
+
+      it 'returns nil' do
+        expect(klass.from_identifier(example_identifier)).to be_nil
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: obfuscated_identifier
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Steve Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-04 00:00:00.000000000 Z
+date: 2015-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport