nytimes-congress 1.4.0 → 1.4.1

data/README.mkdn

@@ -20,20 +20,20 @@ You get a Congress object either by calling Congress.new with a number and chamb
 
 Through a Congress object, you can get a hash of Legislators, keyed by congressional Bio ID.
 
-    senators = Senate.members
+    >> senators = Senate.members
 
 Legislator
 ---------------------
 You could crawl the Hash values to find the bio ID in question, as this is a useful key to use across other open government APIs (notably Sunlight).
 
-    $ hrc = senators.values.find {|legislator| legislator.name == "Hillary Clinton"}
-    $ bio_id = hrc.bio_id
+    >> coburn = senators.values.find {|legislator| legislator.last_name == "Coburn"}
+    >> bio_id = coburn.id
 
 Legislators come down the wire with a lot of interesting info, such as how often they vote along party lines, what roles they serve in Congress and more.  Check out the full set of attributes in the Legislator class.  
 
 You can also grab a Legislator directly by their Bio ID. This call includes full details on the congressperson's roles, biographical info and more:
 
-    $ Legislator.find('C001041')
+    >> Legislator.find('C001041')
     
 When accessing a Legislator from a collection of congress members, they include only a limited set of attributes.  However, the library will make a second API call and lazy-load full attributes if you ask for them specifically.  So even though a Legislator object returned through Congress.members don't have the #gender attribute, if you call for a specific Legislators gender, that data will be fetched and populated just in time.
 
@@ -41,10 +41,17 @@ Current Member
 ---------------------
 If you need to check the current representative for a House district or senators from a state, each chamber exposes a method for that. Note that the senate call does not need a district and returns a list of two senators.
 
-    $ pa19 = House.current_member_for_state_district("PA", 19)
-    $ pa19.name
-    "Todd R. Platts"
+    >> pa19 = House.current_member_for_state_district("PA", 19)
+    >> pa19.values.each do |member| puts member.name end
+    Todd R. Platts
 
+Members by Vote Type
+---------------------
+These responses are returned as an array of hashes rather than a single hash (like the Legislator methods), because the order matters. These methods return members ordered according to rank for missed votes percentage, voting with party percentage, the number of "Lone No" votes and perfect voting attendance. Missed votes ranks in descending order (most votes missed first), while voting with party ranks in ascending order (lowest party agreement percentage first).
+
+    >> party = House.votes('party')
+    >> party.first
+    => {"party_votes_pct"=>"70.49", "name"=>"Walt Minnick", "notes"=>"", "total_votes"=>"1326", "district"=>"1", "rank"=>"1", "votes_with_party"=>"18", "id"=>"M001175", "party"=>"D", "state"=>"ID"}
     
 Roll Call Votes
 ---------------------

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
+:patch: 1
 :build: 
-:patch: 0
 :major: 1
 :minor: 4

data/lib/ny-times-congress.rb

@@ -7,11 +7,13 @@ require 'JSON'
 require 'congress/base'
 require 'congress/attribute_transformation'
 require 'congress/congress'
+require 'congress/current_member'
 require 'congress/legislator'
 require 'congress/legislator_vote_comparison'
+require 'congress/member_vote_type'
 require 'congress/role'
 require 'congress/roll_call_vote'
 require 'congress/position'
 require 'congress/nomination'
 require 'congress/floor'
-require 'congress/current_member'
+

data/lib/ny-times/congress/congress.rb

@@ -12,7 +12,7 @@ module NYTimes
       end
       
       def members(params = {})        
-        @members ||= fetch_members(Base.invoke("#{api_path}/members.json")['results'].first)
+        @members ||= fetch_members(Base.invoke("#{api_path}/members.json")['results'].first['members'])
       end
       
       def self.new_members(params = {})
@@ -45,25 +45,33 @@ module NYTimes
         end
       end
       
+      def votes(type)
+        members = fetch_members_by_type(Base.invoke("#{number}/#{chamber}/votes/#{type}.json")['results'].first['members'])
+      end
+      
       protected
       
       def fetch_members(results)
   			results.inject({}) do |hash, member| 
   			  hash[member['id']] = Legislator.new(member)
-  			  hash.delete_if {|k,v| k.nil? }
   			  hash
   			end
       end
 
       def fetch_current_members(results)
-        if results.length > 1
-    			results.collect do |member| 
-    			  CurrentMember.new(member)
-    			end
-    		else
-    		  CurrentMember.new(results.first)
+    		results.inject({}) do |hash, member|
+    			hash[member['id']] = CurrentMember.new(member)
+    			hash
     		end
       end
+      
+      def fetch_members_by_type(results)
+        h = Hash.new
+  			results.each do |member|
+  			  h[member['id']] = MemberVoteType.new(member)
+  			  h
+  			end
+      end
 
       def self.fetch_new_members
         results = Base.invoke("/members/new.json")['results'].first

data/lib/ny-times/congress/member_vote_type.rb

@@ -0,0 +1,37 @@
+module NYTimes
+	module Congress
+		class MemberVoteType < Base
+      include AttributeTransformation
+      attr_reader :attributes, :id
+
+			ATTRIBUTE_MAP = { 
+			  :integer_for =>  [:total_votes, :missed_votes, :rank, :district, :votes_with_party, :loneno],
+			  :float_for => [:missed_votes_pct, :party_votes_pct],
+			  :string_for  =>  [:id, :name, :party, :state, :notes] 
+			}
+						  
+      ATTRIBUTES = ATTRIBUTE_MAP.values.flatten
+      ATTRIBUTES.each {|attribute| define_lazy_reader_for_attribute_named(attribute) }
+      
+  		def initialize(args={})
+  		  prepare_arguments(args)
+  		  @attributes = {}
+				@transformed_arguments.each_pair {|name, value| attributes[name.to_sym] = value }
+			end
+      
+      def to_s
+    	  id
+    	end
+
+			private
+						  
+			  def prepare_arguments(hash)
+			    args = hash.dup
+    			@id = args.delete('member_id') || args.delete('id')
+    			raise ArgumentError, "could not assign ID" unless @id.is_a?(String)
+    			@transformed_arguments = transform(args, ATTRIBUTE_MAP)
+    	  end
+      
+    end
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: nytimes-congress
 version: !ruby/object:Gem::Version 
-  hash: 7
+  hash: 5
   prerelease: false
   segments: 
   - 1
   - 4
-  - 0
-  version: 1.4.0
+  - 1
+  version: 1.4.1
 platform: ruby
 authors: 
 - Patrick Ewing
@@ -61,6 +61,7 @@ files:
 - lib/ny-times/congress/floor.rb
 - lib/ny-times/congress/legislator.rb
 - lib/ny-times/congress/legislator_vote_comparison.rb
+- lib/ny-times/congress/member_vote_type.rb
 - lib/ny-times/congress/nomination.rb
 - lib/ny-times/congress/position.rb
 - lib/ny-times/congress/role.rb