nxt_cop 1.3.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3ced16c64af5bb68e2c10850dd9277e29f3a39de3d9cc32bdde3296530f55cf
-  data.tar.gz: 6fa32563d60a5fde5b6c4734617913d69cf6d6cd1441096fae6377837c75993a
+  metadata.gz: 1eb597d25eddcad36a8b678d16aec8012a29e0b9c33a145fc7e528303cf1ea27
+  data.tar.gz: dfa1494d7e788cf1500f030938995d8e5a53a74cee29d3b1fc726687dc7cab85
 SHA512:
-  metadata.gz: 1d43e0c5e70c4b7241c58784717a3b5218e0267dcef358a00308f1689bc17d3f2067eeddc428769e41342c612ce144a137cd39ffc1f8b3ae68f92966c1d4fef2
-  data.tar.gz: c8df079c6ffaac61b89fb07c04fdb38d466cb01ccd5be1c004cb9f73a104fa3647cd7b790dabeb02cdcf668fdf3718300f353a4fd747991e3fefe340d8ba0b22
+  metadata.gz: 1d2923f5964870f8e7262c19476874f01e1785ddbba09ce158909f3cbf0758f7857de4df85586372abb669686d79cbf74f49d74500a4566e457b4eecca830583
+  data.tar.gz: 5e7efb90fc058ffc9b7c02a6aa948fcd0b20cf50c3b274998dbcc0ca5acc7c268c950afa97031073202747b009c4e520a1b400a1f60d2110f9479c340298acba

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# v2.0.0 2023-11-28
+## What's Changed
+* Enabled all cops by default
+
+**Full Changelog**: https://github.com/nxt-insurance/nxt_cop/compare/v1.3.1...v2.0.0
+
 # v1.3.1 2023-10-10
 ## What's Changed
 * Bumped dependencies version

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nxt_cop (1.3.1)
+    nxt_cop (2.0.0)
       rubocop (~> 1.57.2)
       rubocop-rails (~> 2.8)
       rubocop-rspec (~> 2.12)
@@ -9,7 +9,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.1)
+    activesupport (7.1.2)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -59,10 +59,11 @@ GEM
       rubocop (~> 1.41)
     rubocop-factory_bot (2.24.0)
       rubocop (~> 1.33)
-    rubocop-rails (2.22.1)
+    rubocop-rails (2.22.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rspec (2.25.0)
       rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)

data/default.yml

@@ -18,7 +18,8 @@ AllCops:
     - db/migrate/*
     - vendor/**/*
     - node_modules/**/*
-  DisabledByDefault: true
+  DisabledByDefault: false
+  NewCops: disable # to avoid warnings. TODO: remove this setting and add new cops from the warning.
 
 # A bunch of these layout cops are enabled by default,
 # but for some reason 'DisableByDefault' is set to 'true' above.
@@ -260,3 +261,364 @@ Lint/MixedCaseRange:
   Enabled: true
 Lint/RedundantRegexpQuantifiers:
   Enabled: true
+
+# This is default cops we want to keep disabled:
+Style/FrozenStringLiteralComment:
+  Enabled: false
+Layout/LineLength:
+  Enabled: false
+Style/ArgumentsForwarding:
+  Enabled: false
+Naming/BlockForwarding:
+  Enabled: false
+Rails/FreezeTime:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Naming/VariableNumber:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/CyclomaticComplexity:
+  Enabled: false
+Style/SafeNavigation:
+  Enabled: false
+Rails/Output:
+  Enabled: false
+Style/Next: # this one looks dangerous
+  Enabled: false
+Bundler/OrderedGems:
+  Enabled: false
+Bundler/DuplicatedGroup:
+  Enabled: false
+Rails/HttpStatus:
+  Enabled: false
+Rails/SkipsModelValidations:
+  Enabled: false
+Style/InfiniteLoop:
+  Enabled: false
+Style/StderrPuts:
+  Enabled: false
+Style/NumericPredicate:
+  Enabled: false
+Metrics/PerceivedComplexity:
+  Enabled: false
+Style/RegexpLiteral:
+  Enabled: false
+Rails/Delegate:
+  Enabled: false
+Style/RaiseArgs:
+  Enabled: false
+Rails/HasManyOrHasOneDependent: # Nice to have but challenging to fix
+  Enabled: false
+Rails/InverseOf:
+  Enabled: false
+Style/MultilineBlockChain:
+  Enabled: false
+Naming/AccessorMethodName:
+  Enabled: false
+Naming/PredicateName:
+  Enabled: false
+Style/FormatStringToken:
+  Enabled: false
+Style/RedundantSort: # dangerous since autofix breaks the code
+  Enabled: false
+Style/SymbolProc:
+  Enabled: false
+Rails/ApplicationController:
+  Enabled: false
+Rails/ApplicationRecord:
+  Enabled: false
+Style/ExplicitBlockArgument:
+  Enabled: false
+Rails/DynamicFindBy:
+  Enabled: false
+Metrics/ParameterLists:
+  Enabled: false
+Rails/IndexWith:
+  Enabled: false
+Style/FormatString:
+  Enabled: false
+Rails/Blank:
+  Enabled: false
+Rails/Present:
+  Enabled: false
+Style/NumericLiterals:
+  Enabled: false
+Style/Lambda:
+  Enabled: false
+Style/Proc:
+  Enabled: false
+Style/ExponentialNotation:
+  Enabled: false
+Style/PreferredHashMethods: # can be changed via vote
+  Enabled: false
+Rails/Presence:
+  Enabled: false
+Metrics/ModuleLength:
+  Enabled: false
+Style/RedundantConditional:
+  Enabled: false
+Style/TrailingUnderscoreVariable:
+  Enabled: false
+Style/ParenthesesAroundCondition:
+  Enabled: false
+Style/HashEachMethods:
+  Enabled: false
+Style/RedundantAssignment:
+  Enabled: false
+Style/CaseLikeIf:
+  Enabled: false
+Style/RedundantBegin:
+  Enabled: false
+Rails/FilePath:
+  Enabled: false
+Style/Alias:
+  Enabled: false
+Style/SingleArgumentDig:
+  Enabled: false
+Style/RescueModifier: # because it's heavily used in application service
+  Enabled: false
+Style/IfUnlessModifier:
+  Enabled: false
+Naming/BinaryOperatorParameterName:
+  Enabled: false
+Style/SignalException:
+  Enabled: false
+Style/TrivialAccessors:
+  Enabled: false
+Rails/HasAndBelongsToMany:
+  Enabled: false
+Style/AccessModifierDeclarations:
+  Enabled: false
+Rails/ReadWriteAttribute:
+  Enabled: false
+Rails/RedundantReceiverInWithOptions:
+  Enabled: false
+Style/HashTransformValues:
+  Enabled: false
+Rails/IndexBy:
+  Enabled: false
+Rails/Pick:
+  Enabled: false
+Style/CombinableLoops:  # hard to autocorrect properly
+  Enabled: false
+FactoryBot/CreateList:
+  Enabled: false
+Rails/ReflectionClassName:
+  Enabled: false
+Style/RedundantSelf:
+  Enabled: false
+Style/GuardClause:
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  Enabled: false
+Style/StringConcatenation:  # heavily used in insurance service
+  Enabled: false
+Style/InverseMethods:
+  Enabled: false
+Style/RedundantInterpolation:
+  Enabled: false
+Style/ZeroLengthPredicate:
+  Enabled: false
+
+# 🤔 Should we enable these cops or not? They look useful but require alignment within the team
+Style/OpenStructUse:
+  Enabled: false
+Style/RedundantConstantBase: # new in 1.40
+  Enabled: false
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+Style/ConditionalAssignment:
+  Enabled: false
+Style/BlockDelimiters:
+  Enabled: false
+Style/TrailingCommaInArrayLiteral:
+  Enabled: false
+FactoryBot/FactoryClassName:
+  Enabled: false
+Style/NumericLiteralPrefix:
+  Enabled: false
+Style/OptionalBooleanParameter:
+  Enabled: false
+Style/IdenticalConditionalBranches: # Is it safe to auto-fix?
+  Enabled: false
+Naming/RescuedExceptionsVariableName: # Would be nice to have, but should align on the name first
+  Enabled: false
+
+Naming/MethodParameterName: # should enable but we have to manually fix this
+  Enabled: false
+Rails/UniqueValidationWithoutIndex: # definitely enable!!!
+  Enabled: false
+Rails/Validation: # discuss with the team
+  Enabled: false
+Rails/LexicallyScopedActionFilter:  # enable and manually disable offences
+  Enabled: false
+Security/Open:
+  Enabled: false
+Naming/FileName:
+  Enabled: false
+Style/EmptyElse:
+  Enabled: false
+Style/MixinUsage: # Enable and then manually disable offenses?
+  Enabled: false
+
+
+
+# ✅ Enabled in 2.0 version (activated by "enable all rules by default')
+# Let's keep commented list here for visibility for a while
+#
+#Layout/SpaceInsideParens:
+#  Enabled: false
+#Layout/SpaceBeforeFirstArg:
+#  Enabled: false
+#Layout/ExtraSpacing:
+#  Enabled: false
+#Layout/SpaceAfterColon:
+#  Enabled: false
+#Rails/PluralizationGrammar:
+#  Enabled: false
+#Layout/SpaceAroundMethodCallOperator:
+#  Enabled: false
+#Style/RedundantFreeze:
+#  Enabled: false
+#Layout/SpaceInLambdaLiteral:
+#  Enabled: false
+#Layout/LeadingCommentSpace:
+#  Enabled: false
+#Layout/DefEndAlignment:
+#  Enabled: false
+#Style/RedundantRegexpEscape:
+#  Enabled: false
+#Layout/HeredocIndentation:
+#  Enabled: false
+#Layout/ClosingHeredocIndentation:
+#  Enabled: false
+#Layout/LeadingEmptyLines:
+#  Enabled: false
+#Layout/EmptyLinesAroundAccessModifier:
+#  Enabled: false
+#Style/NegatedIf:
+#  Enabled: false
+#Style/CommentAnnotation:
+#  Enabled: false
+#Layout/MultilineOperationIndentation:
+#  Enabled: false
+#Style/ExpandPathArguments:
+#  Enabled: false
+#Layout/EmptyLinesAroundMethodBody:
+#  Enabled: false
+#Style/RedundantReturn:
+#  Enabled: false
+#Style/GlobalStdStream:
+#  Enabled: false
+#Style/FloatDivision:
+#  Enabled: false
+#Style/RescueStandardError:
+#  Enabled: false
+#Style/NilComparison:
+#  Enabled: false
+#Style/RedundantFetchBlock:
+#  Enabled: false
+#Style/Encoding:
+#  Enabled: false
+#Style/EmptyLiteral:
+#  Enabled: false
+#Layout/SpaceInsideReferenceBrackets:
+#  Enabled: false
+#Style/EmptyLambdaParameter:
+#  Enabled: false
+#Style/TernaryParentheses:
+#  Enabled: false
+#Naming/MethodName:
+#  Enabled: false
+#Style/SlicingWithRange:
+#  Enabled: false
+#Style/EmptyCaseCondition:
+#  Enabled: false
+#Style/SoleNestedConditional:
+#  Enabled: false
+#Rails/FindEach:
+#  Enabled: false
+#Style/RedundantFileExtensionInRequire:
+#  Enabled: false
+#Layout/SpaceInsideArrayLiteralBrackets:
+#  Enabled: false
+#Style/HashAsLastArrayItem:
+#  Enabled: false
+#Lint/RedundantCopDisableDirective:
+#  Enabled: false
+#Layout/SpaceAroundKeyword:
+#  Enabled: false
+#Style/KeywordParametersOrder:
+#  Enabled: false
+#Style/BlockComments:
+#  Enabled: false
+#Style/AndOr:
+#  Enabled: false
+#Style/EachWithObject:
+#  Enabled: false
+#Layout/SpaceAroundBlockParameters:
+#  Enabled: false
+#Style/MultilineTernaryOperator:
+#  Enabled: false
+#Style/RedundantParentheses:
+#  Enabled: false
+#Security/JSONLoad:
+#  Enabled: false
+#Style/MethodCallWithoutArgsParentheses:
+#  Enabled: false
+#Style/CommentedKeyword:
+#  Enabled: false
+#Style/MultilineIfModifier:
+#  Enabled: false
+#Style/IfInsideElse:
+#  Enabled: false
+#Style/AccessorGrouping:
+#  Enabled: false
+#Layout/BlockEndNewline:
+#  Enabled: false
+#Rails/RedundantForeignKey:
+#  Enabled: false
+#Style/UnlessElse:
+#  Enabled: false
+#Layout/EmptyLinesAroundModuleBody:
+#  Enabled: false
+#Rails/RakeEnvironment:
+#  Enabled: false
+#Layout/EmptyLinesAroundArguments:
+#  Enabled: false
+#Style/EachForSimpleLoop:
+#  Enabled: false
+#Style/ClassCheck:
+#  Enabled: false
+#Style/NestedParenthesizedCalls:
+#  Enabled: false
+#Style/LineEndConcatenation:
+#  Enabled: false
+#Style/ParallelAssignment:
+#  Enabled: false
+#Layout/EmptyLinesAroundExceptionHandlingKeywords:
+#  Enabled: false
+#Layout/SpaceAroundEqualsInParameterDefault:
+#  Enabled: false
+#Style/YodaCondition:
+#  Enabled: false
+#Layout/SpaceInsideStringInterpolation:
+#  Enabled: false
+#Style/EmptyMethod:
+#  Enabled: false
+#Layout/EmptyLineBetweenDefs:
+#  Enabled: false
+#Naming/ConstantName:
+#  Enabled: false
+#Rails/RelativeDateConstant:
+#  Enabled: false

data/lib/nxt_cop/version.rb

@@ -1,3 +1,3 @@
 module NxtCop
-  VERSION = '1.3.1'.freeze
+  VERSION = '2.0.0'.freeze
 end

data/nxt_cop.gemspec

@@ -1,4 +1,4 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'nxt_cop/version'
 
@@ -24,13 +24,15 @@ Gem::Specification.new do |spec|
       'public gem pushes.'
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
+  spec.required_ruby_version = '>= 3.2'
+
   spec.add_dependency 'rubocop', '~> 1.57.2'
   spec.add_dependency 'rubocop-rails', '~> 2.8'
   spec.add_dependency 'rubocop-rspec', '~> 2.12'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nxt_cop
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Scott Livingstone
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-11-10 00:00:00.000000000 Z
+date: 2024-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -117,7 +117,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="