nutrella 1.4.0 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a6d83b25cd95d98651ae81097264d6e1e5d6cb24cc0d51ef3d3a197774a0cd3
-  data.tar.gz: a66e05e57cf86ec91bb98bb7f2ef6aacc6ecac079f26eeb7b2571b3d220c827d
+  metadata.gz: 3ada2f552730cbf6221835584e054c6e11e97772d0a31ea615b82216555d4b09
+  data.tar.gz: 199bdf1116434ed92d25c718fa8aee98e96c998427176508a55b81acf59bee01
 SHA512:
-  metadata.gz: b4b3760610a3d564af84f9414dbba812f00807e3f370a9cdada7cfe67d6d8e3a17d95c105d3fb40a2da7d88e65aed4f0c90abf45846d8cfec16ac4a66830231d
-  data.tar.gz: 0e3e14772d78f495fa650e6ab8d7a01e4234a0d5f10a90b3a368ed1dd0068251be63c2689f072c2846269aaadfcb8977e9f800d75d7f9eec0e1063960d75a78d
+  metadata.gz: 9d4bf1688c192e4a6b0f669d610931ec99c1ff95c9147b09e8a88e66933e8f53957cca69040cbd9462f867d6084bea00beb787e27f22fec8da227a18186ee8db
+  data.tar.gz: f57b83dfb937e477a8f56d71bda8a6b3414252bab313d6c1f1c501b3d504ce691a99f5f4b0db3f2c4b7708bf96a87127ab6d53a6462c386f13cfea763f889731

data/.rubocop.yml

@@ -1,5 +1,4 @@
 require:
-  - rubocop-performance
   - rubocop-rspec
 
 AllCops:
@@ -12,9 +11,21 @@ AllCops:
 Layout/MultilineMethodCallBraceLayout:
   Enabled: false
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
 Metrics/BlockLength:
   Enabled: false
 
+Naming/MemoizedInstanceVariableName:
+  EnforcedStyleForLeadingUnderscores: required
+
 RSpec/AnyInstance:
   Enabled: false
 
@@ -45,6 +56,15 @@ RSpec/MultipleExpectations:
 RSpec/SubjectStub:
   Enabled: false
 
+Style/BlockDelimiters:
+  Enabled: true
+  EnforcedStyle: line_count_based
+  BracesRequiredMethods:
+    - 'let'
+
+Style/ExponentialNotation:
+  Enabled: true
+
 # We can ignore this small performance improvement.
 Style/FrozenStringLiteralComment:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.6.6

data/CHANGELOG.md

@@ -6,16 +6,28 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.5.0] - 2020-04-26
+
+#### New Features
+
+- Added a configuration option to support opening boards in the desktop Trello app
+
 ## [1.4.0] - 2020-03-30
+
+#### Breaking Changes
+
 - Drop support for Ruby 2.4
 
 ## [1.3.1] - 2019-05-20
-### Added
+
+#### New Features
+
 - Added a configuration option to adjust the command that launches your Trello boards
 
 ## [1.3.0] - 2019-05-20
-### Yanked
+
+#### Yanked
 
 ## [1.2.2] - 2019-04-27
-### Added
+
 - Added a changelog

data/README.md

@@ -47,6 +47,7 @@ If your haven't already done so, insert your `key`, `secret`, and `token` into y
 
 The configuration file should look like the following (don't use the keys below, they won't work):
 
+```yaml
     # Trello Developer API Keys
     key: c2fc703429da08b6e7dcb0a878e35564
     secret: 7fd865f372891afa93aabdb6b836254bcda10c8a320def2b3207e2ffb425bc0a
@@ -55,50 +56,69 @@ The configuration file should look like the following (don't use the keys below,
     # Optional Configuration
     organization: 542d76ac2fad4697c3e80448
     launch_command: open $url$
+    enable_trello_app: false
+```
+
+Finally, you can tweak your configuration:
 
-Finally, you can adjust the launch_command to fit your needs. For example, on macOS to open your
-Trello board in Firefox change the last line to:
+1. Adjust the launch_command configuration to fit your needs. For example, on macOS to open
+your Trello board in Firefox change your configuration to:
 
+```yaml
     launch_command: open -a firefox $url$
+```
+
+1. Adjust the enable_trello_app configuration to open boards in the Trello app. For example,
+if you have installed the Trello app on macOS to open your Trello board in the Trello app
+change your configuration to:
 
+```yaml
+    enable_trello_app: true
+```
 
 ## Usage
 
 Create or open a Trello board based on the name of the current git branch:
 
+```sh
     $ nutrella
+```
 
 Create or open a named Trello board:
 
+```sh
     $ nutrella <git-branch-name>
+```
 
 Note: you can invoke `nutrella` from your project directory or from any subdirectory.
 
+
 ## Troubleshooting
 
-#### `method_missing: undefined method 'this'`
+1. For `method_missing: undefined method 'this'`
 
-Try updating `RubyGems`
+    Try updating `RubyGems`
 
-```sh
-gem update --system
-```
+    ```sh
+    gem update --system
+    ```
 
-#### `uninitialized constant Gem::Source (NameError)`
+1. For `uninitialized constant Gem::Source (NameError)`
 
-Try updating `bundler`
+    Try updating `bundler`
 
-```sh
-gem install bundler
-```
+    ```sh
+    gem install bundler
+    ```
 
-#### `cannot load such file -- nutrella`
+1. For `cannot load such file -- nutrella`
 
-This error may appear after running `irb -rubygems` and you are unable to `require 'nutrella'`. Try running `irb -rubygems` from your home directory:
+    This error may appear after running `irb -rubygems` and you are unable to `require 'nutrella'`.
+    Try running `irb -rubygems` from your home directory:
 
-```sh
-cd ~
-```
+    ```sh
+    cd ~
+    ```
 
 
 ## Origin of Name

data/lib/nutrella/cache.rb

@@ -41,7 +41,7 @@ module Nutrella
     end
 
     def cache_contents
-      @cache_contents ||= YAML.load_file(path)
+      @_cache_contents ||= YAML.load_file(path)
     end
   end
 end

data/lib/nutrella/command.rb

@@ -14,23 +14,35 @@ module Nutrella
     end
 
     def run
-      open board_url # rubocop:disable Security/Open
+      launch(board_url)
     end
 
     private
 
+    def launch(url)
+      launch_command = configuration_values.fetch(:launch_command).gsub("$url$", url)
+
+      system(launch_command)
+    end
+
     def board_url
-      url_cache.fetch(@board_name) { task_board.lookup_or_create(@board_name).url }
+      enable_trello_app? ? trello_url(cached_url) : cached_url
+    end
+
+    def cached_url
+      @_cached_url ||= url_cache.fetch(@board_name) { task_board.lookup_or_create(@board_name).url }
     end
 
     def configuration_values
-      @configuration_values ||= Nutrella::Configuration.values(configuration_filename)
+      @_configuration_values ||= Nutrella::Configuration.values(configuration_filename)
     end
 
-    def open(url)
-      launch_command = configuration_values.fetch(:launch_command).gsub("$url$", url)
+    def enable_trello_app?
+      configuration_values.fetch(:enable_trello_app)
+    end
 
-      system(launch_command)
+    def trello_url(http_url)
+      http_url.gsub(/^http.?:/, "trello:")
     end
 
     def task_board

data/lib/nutrella/configuration.rb

@@ -18,6 +18,7 @@ module Nutrella
       # Optional Configuration
       organization: #{NULOGY_ORGANIZATION_ID}
       launch_command: open $url$
+      enable_trello_app: False
     YAML
 
     attr_reader :path, :values
@@ -35,19 +36,22 @@ module Nutrella
     private
 
     def load_configuration
-      configuration = YAML.load_file(path)
-
       @values = {
         key: configuration.fetch("key"),
         secret: configuration.fetch("secret"),
         token: configuration.fetch("token"),
         organization: configuration.fetch("organization", NULOGY_ORGANIZATION_ID),
-        launch_command: configuration.fetch("launch_command", "open $url$")
+        launch_command: configuration.fetch("launch_command", "open $url$"),
+        enable_trello_app: configuration.fetch("enable_trello_app", "False")
       }
     rescue => e
       abort "#{path} #{e}"
     end
 
+    def configuration
+      @_configuration ||= YAML.load_file(path)
+    end
+
     def configuration_missing?
       return false if File.exist?(path)
 

data/lib/nutrella/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nutrella
-  VERSION = "1.4.0"
+  VERSION = "1.5.0"
 end

data/nutrella.gemspec

@@ -30,8 +30,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "rake", ">= 12.1", "< 13.1"
   spec.add_development_dependency "rspec", ">= 3.9", "< 4.0"
-  spec.add_development_dependency "rubocop", "~> 0.80"
-  spec.add_development_dependency "rubocop-performance", "~> 1.5"
+  spec.add_development_dependency "rubocop", "~> 0.82"
   spec.add_development_dependency "rubocop-rspec", "~> 1.38"
   spec.add_development_dependency "simplecov", "~> 0.17"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nutrella
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors:
 - Alistair McKinnell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-30 00:00:00.000000000 Z
+date: 2020-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-trello
@@ -70,28 +70,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.80'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '0.82'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -182,7 +168,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A command line tool for creating a Trello Board based on the current git