nunes 0.3.0 → 0.3.1

data/Gemfile

@@ -3,7 +3,7 @@ gemspec
 
 gem "rails", "~> 3.2.12"
 gem "sqlite3-ruby", require: "sqlite3"
-gem "minitest"
+gem "minitest", '~> 4.7', :platforms => :ruby_19
 gem "rake"
 
 group :watch do

data/README.md

@@ -22,7 +22,7 @@ Or install it yourself as:
 
 ## Usage
 
-nunes works out of the box with [instrumental app](http://instrumentalapp.com) (my person favorite) and [statsd](https://github.com/reinh/statsd). All you need to do is subscribe using an instance of statsd or instrumental's agent and you are good to go.
+nunes works out of the box with [instrumental app](http://instrumentalapp.com) (my personal favorite) and [statsd](https://github.com/reinh/statsd). All you need to do is subscribe using an instance of statsd or instrumental's agent and you are good to go.
 
 ### With Instrumental
 
@@ -69,6 +69,8 @@ Based on those events, you'll get metrics like this in instrumental and statsd:
 
 * `action_controller.status.200`
 * `action_controller.format.html`
+* `action_controller.controller.Admin.PostsController.new.status.403`
+* `action_controller.controller.Admin.PostsController.index.format.json`
 * `action_controller.exception.RuntimeError` - where RuntimeError is the class of any exceptions that occur while processing a controller's action.
 * `active_support.cache.hit`
 * `active_support.cache.miss`
@@ -81,6 +83,8 @@ Based on those events, you'll get metrics like this in instrumental and statsd:
 * `action_controller.controller.PostsController.index.runtime.total`
 * `action_controller.controller.PostsController.index.runtime.view`
 * `action_controller.controller.PostsController.index.runtime.db`
+* `action_controller.controller.PostsController.index.status.200`
+* `action_controller.controller.PostsController.index.format.html`
 * `action_view.template.app.views.posts.index.html.erb` - where `app.views.posts.index.html.erb` is the path of the view file
 * `action_view.partial.app.views.posts._post.html.erb` - I can even do partials! woot woot!
 * `action_mailer.deliver.PostMailer`

data/lib/nunes/subscribers/action_controller.rb

@@ -41,6 +41,10 @@ module Nunes
           timing "#{namespace}.runtime.total",      runtime
           timing "#{namespace}.runtime.view", view_runtime if view_runtime
           timing "#{namespace}.runtime.db",   db_runtime   if db_runtime
+
+          increment "#{namespace}.format.#{format}" if format
+          increment "#{namespace}.status.#{status}" if status
+
         end
 
         if exception_info

data/lib/nunes/version.rb

@@ -1,3 +1,3 @@
 module Nunes
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/test/namespaced_controller_instrumentation_test.rb

@@ -21,5 +21,26 @@ class NamespacedControllerInstrumentationTest < ActionController::TestCase
 
     assert_timer "action_controller.controller.Admin.PostsController.index.runtime.total"
     assert_timer "action_controller.controller.Admin.PostsController.index.runtime.view"
+    assert_timer "action_controller.controller.Admin.PostsController.index.runtime.db"
+
+    assert_counter "action_controller.format.html"
+    assert_counter "action_controller.status.200"
+
+    assert_counter "action_controller.controller.Admin.PostsController.index.format.html"
+    assert_counter "action_controller.controller.Admin.PostsController.index.status.200"
+  end
+
+  test "process_action w/ json" do
+    get :index, format: :json
+
+    assert_counter "action_controller.controller.Admin.PostsController.index.format.json"
+  end
+
+  test "process_action bad_request" do
+    get :new
+
+    assert_response :forbidden
+
+    assert_counter "action_controller.controller.Admin.PostsController.new.status.403"
   end
 end

data/test/rails_app/app/controllers/admin/posts_controller.rb

@@ -7,5 +7,13 @@ class Admin::PostsController < ApplicationController
       Post.new('First'),
       Post.new('Second'),
     ]
+    respond_to do |format|
+      format.html { render }
+      format.json { render :json => @posts }
+    end
+  end
+
+  def new
+    head :forbidden
   end
 end

data/test/rails_app/config/routes.rb

@@ -1,6 +1,6 @@
 RailsApp::Application.routes.draw do
   namespace :admin do
-    resources :posts, only: :index
+    resources :posts, only: [:index, :new]
   end
 
   resources :posts, only: :index

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nunes
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-25 00:00:00.000000000 Z
+date: 2013-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler