nullalign 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1af15eca93e06667b2a429e1c853c03c101a9425
-  data.tar.gz: 3ba414cae84fceaf9ff1e66f65322eb3e6b153bc
+  metadata.gz: 657f6a975071d2ef7bfa17fb58ea80d6faa56a94
+  data.tar.gz: e67511b01e6a7a50d6efeecf44a7c3d882e8083d
 SHA512:
-  metadata.gz: cb64c015c7b25c0c070d97157df4b5d027b77170884bafe5d15bfb2cbdae3f5a144be744ed4a7a750e0106da661e303a1c32f4a0c8f0f224cb08fe2cb9f91034
-  data.tar.gz: 46e03a6c9c628434afbbdf27f2be293eaa4ed7b68ceb146f14fa97f7b94b9e98ccbde3fff140ba73c35f7bc319064e6e6641937746d61e11d74aa2faaebb9ce6
+  metadata.gz: 298ebc2eaeea4b157d574d9858c8ba40e6c308779490cae645bce7ba93e0d97c539527621e65b0e56421f3d68789c3bb240527f067b01a24bd614b8ece9eed8c
+  data.tar.gz: b89c85dc3acabd3f87aae7920909fc4bc1ee7ce6287f921c4e0b91b4343a943e543739253b43d9f72a1d1180dcf501c331d149d35b56cfef1b01f3898ebedded

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## v0.0.3 Feb 14 2018
+* Add nullalign:fix Rake task
+
 ## v0.0.2 Oct 23 2017
 * Skip conditional validations
 

data/README.md

@@ -35,6 +35,12 @@ Run it like this:
     CheckinLabel       checkin_labels: name, xml
     CheckinTime        checkin_times: campus
 
+## Generating a migration
+
+You can also run a Rake task which will generate a migration which will add indexes as needed:
+
+    bundle exec rake nullalign:fix
+
 ## Limitations
 
 nullalign depends on being able to find all your `ActiveRecord::Base`
@@ -51,6 +57,7 @@ like 'nonullalign' if people think that would be useful.  Just let me know.
 
 * [Tom Copeland](https://thomasleecopeland.com) - author
 * [Woongcheol Yang](https://github.com/woongy) - support for conditional validations
+* [Paweł Dąbrowski](https://twitter.com/pdabrowski_k1) - Rake task suggestion
 
 ## Tests
 

data/lib/nullalign.rb

@@ -2,6 +2,7 @@ require 'nullalign/models'
 require 'nullalign/introspectors/table_data'
 require 'nullalign/introspectors/validates_presence_of'
 require 'nullalign/reporter'
+require 'nullalign/railtie'
 
 module Nullalign
   def self.run
@@ -15,9 +16,40 @@ module Nullalign
     reporter.report_validates_presence_problems(problems)
     problems.empty?
   end
-  
+
+  def self.generate_migration
+    models = Nullalign::Models.new($LOAD_PATH)
+    models.preload_all
+
+    reporter = Nullalign::Reporter.new
+
+    introspector = Nullalign::Introspectors::ValidatesPresenceOf.new
+    problems = problems(models.all, introspector)
+    if problems.empty?
+      puts "Hooray! All presence validators are backed by a non-null constraint."
+    else
+      str = "class AddMissingNonnullConstraints < ActiveRecord::Migration[5.1]\n"
+      str << "  def change\n"
+      null_constraints_by_table_name = problems.map do |model, columns|
+        [model.name, model, columns]
+      end.sort_by(&:first)
+      counter = 0
+      null_constraints_by_table_name.each do |table_name, model, columns|
+        columns.each do |constraint|
+          counter += 1
+          str << "    change_column_null :#{model.table_name}, :#{constraint.column}, false\n"
+        end
+      end
+      str << "  end\n"
+      str << "end\n"
+      filename = "db/migrate/#{Time.now.utc.strftime("%Y%m%d%H%M%S")}_add_missing_nonnull_constraints.rb"
+      puts "Adding migration #{File.basename(filename)} containing #{counter} change_column_null entries"
+      File.open(filename, "w") {|f| f.syswrite(str)}
+    end
+  end
+
   private
-  
+
   def self.problems(models, introspector)
     models.map do |m|
       [m, introspector.missing_nonnull_constraints(m)]
@@ -25,4 +57,4 @@ module Nullalign
       columns.empty?
     end
   end
-end
+end

data/lib/nullalign/railtie.rb

@@ -0,0 +1,9 @@
+if defined?(Rails)
+  module Nullalign
+    class Railtie < Rails::Railtie
+      rake_tasks do
+        load 'tasks/nullalign.rake'
+      end
+    end
+  end
+end

data/lib/nullalign/version.rb

@@ -1,3 +1,3 @@
 module Nullalign
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/tasks/nullalign.rake

@@ -0,0 +1,6 @@
+namespace :nullalign do
+  desc "Generate a migration to fix issues nullalign found"
+  task fix: :environment do
+    Nullalign.generate_migration
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nullalign
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Tom Copeland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-23 00:00:00.000000000 Z
+date: 2018-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -75,10 +75,12 @@ files:
 - lib/nullalign/introspectors/validates_presence_of.rb
 - lib/nullalign/models.rb
 - lib/nullalign/nonnull_constraint.rb
+- lib/nullalign/railtie.rb
 - lib/nullalign/reporter.rb
 - lib/nullalign/reporters/base.rb
 - lib/nullalign/reporters/validates_presence_of.rb
 - lib/nullalign/version.rb
+- lib/tasks/nullalign.rake
 - nullalign.gemspec
 - spec/introspectors/table_data_spec.rb
 - spec/introspectors/validates_presence_of_spec.rb