null_object 0.0.2 → 0.0.3

data/README.md

@@ -3,6 +3,35 @@
 Dead simple library to create null objects (objects that respond to all
 messages)
 
+## Why?
+
+Imagine that sometimes your code uses a [statsd](https://github.com/etsy/statsd)
+client to instrument itself. But only sometimes.
+
+If you used `nil` to represent the case where the statsd client isn't configured,
+you end up writing code like this ... which sucks:
+
+```ruby
+statsd.increment("foo") if statsd
+```
+
+And how to you deal with timers? I have no idea
+
+```ruby
+# statsd might be nil, ugh!
+statsd.timer("foo") { ... }
+```
+
+But if your `statsd` were either a real `Statsd` client **or a `NullObject`**,
+the problems go away:
+
+```
+obj = NullObject.new { |&block| block.call if block }
+
+@statsd.increment("foo")     # no need for a conditional; it's a no-op
+@statsd.timer("foo") { ... } # yields to the block, but otherwise a no-op
+```
+
 ## Usage
 
 Respond to ALL the things:
@@ -14,6 +43,13 @@ obj.bar     # => obj
 obj.foo.bar # => obj
 ```
 
+Yield ALL the things:
+
+```ruby
+obj = NullObject.new { |&block| block.call if block }
+obj.foo { puts "bar" } # outputs "bar"
+```
+
 Respond to SOME of the things:
 
 ```ruby

data/lib/null_object.rb

@@ -11,23 +11,13 @@ class NullObject
     @return_block = return_block
   end
 
-  def method_missing(method, *args)
-    matched = false
-    return_value = if @methods.empty?
-                     matched = true and __global_return_value__
-                   elsif @methods.is_a?(Hash) && @methods.key?(method.to_sym)
-                     matched = true and @methods[method.to_sym]
-                   elsif @methods.is_a?(Enumerable) && @methods.include?(method.to_sym)
-                     matched = true and __global_return_value__
-                   end
-
-    if matched
-      # Next time, there'll be a real method and we'll avoid the method_missing
-      # chain
-      singleton_class = class << self; self; end;
-      singleton_class.__send__(:define_method, method) { return_value }
-
-      return_value
+  def method_missing(method, *args, &block)
+    if @methods.empty?
+      __global_return_value__(*args, &block)
+    elsif @methods.is_a?(Hash) && @methods.key?(method.to_sym)
+      @methods[method.to_sym]
+    elsif @methods.is_a?(Enumerable) && @methods.include?(method.to_sym)
+      __global_return_value__(*args, &block)
     else
       super
     end
@@ -35,7 +25,7 @@ class NullObject
 
   private
 
-  def __global_return_value__
-    @return_block ? @return_block.call : self
+  def __global_return_value__(*args, &block)
+    @return_block ? @return_block.call(*args, &block) : self
   end
 end

data/lib/null_object/version.rb

@@ -1,3 +1,3 @@
 class NullObject
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/null_object.gemspec

@@ -17,5 +17,6 @@ Gem::Specification.new do |gem|
 
   gem.add_development_dependency "rspec", "~>2.10.0"
   gem.add_development_dependency "bourne", "~>1.1.2"
+  gem.add_development_dependency "pry"
   gem.add_development_dependency "rake"
 end

data/spec/null_object_spec.rb

@@ -8,6 +8,16 @@ describe NullObject do
     obj.foo.bar.should be obj
   end
 
+  it "yields ALL the things" do
+    obj = NullObject.new { |&block| block.call if block }
+    obj.foo.should be_nil
+
+    called = false
+    obj.foo { called = true }
+
+    called.should be_true
+  end
+
   it "responds to SOME of the things" do
     obj = NullObject.new(:foo, :bar)
     obj.foo.should be obj

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'mocha'
+require 'pry'
 require File.join(File.dirname(__FILE__), '..', 'lib', 'null_object')
 
 RSpec.configure do |config|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: null_object
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70364672404620 !ruby/object:Gem::Requirement
+  requirement: &70206631894660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 2.10.0
   type: :development
   prerelease: false
-  version_requirements: *70364672404620
+  version_requirements: *70206631894660
 - !ruby/object:Gem::Dependency
   name: bourne
-  requirement: &70364672403920 !ruby/object:Gem::Requirement
+  requirement: &70206631893640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,21 @@ dependencies:
         version: 1.1.2
   type: :development
   prerelease: false
-  version_requirements: *70364672403920
+  version_requirements: *70206631893640
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: &70206631893100 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *70206631893100
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70364672403540 !ruby/object:Gem::Requirement
+  requirement: &70206631908780 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70364672403540
+  version_requirements: *70206631908780
 description: Dead simple library to create null objects (objects that respond to all
   messages)
 email:
@@ -77,7 +88,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2648222180714243262
+      hash: 2394258275185068831
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -86,7 +97,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2648222180714243262
+      hash: 2394258275185068831
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.15