noun-project-api 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 31efd2c37c5ac37ddb6ac38054485ab56a13fb65
-  data.tar.gz: e2de0f1c8e3e52d09ad8a57d4854fa1f66eeb121
+SHA256:
+  metadata.gz: 94eaa51b84658f3763af7b3fe27e9f3f2f3b2666be78a2e580f0b2b569fcc10c
+  data.tar.gz: f5cc891b28b004f1680f4176725775a02d616d720423357d36d3c5105a49e0ce
 SHA512:
-  metadata.gz: 2aae5a8fa9d877dcdaa83cea76a7de58ec4a777671522e1600d89ea0808582471d51f8f360dc7ddbe4ab99baf9a52972156977a79434e63a961008483ff03593
-  data.tar.gz: a3f9934c896120832073dfbe595aab89fd6edc7de5c5eb5a5222ec9fa192fdd8bb6a28400763a1a3117e8f862eaba446b7c3daebd35dc8257ca9a37b5db5c134
+  metadata.gz: fa6d50bafc00705171eec159e1290719299b5422ea956e1d8c8681365e6654fb444419e938de2ce00b80f50dc9142bc0fe4e0d146557bd89aa4ce728719886f2
+  data.tar.gz: a3830940fe3886f39575ee050503ee8884062f23bc7c6ed34b43aa565d67d437fe320f3c4f3c1cb4bf4902b4b4a18a1ab3df52e87261d83271658044821bcab6

data/lib/noun-project-api.rb

@@ -1,5 +1,6 @@
 require "oauth"
 require "json"
+require "noun-project-api/errors"
 require "noun-project-api/connection"
 require "noun-project-api/icon_retriever"
 require "noun-project-api/reporter"

data/lib/noun-project-api/base_item.rb

@@ -5,7 +5,7 @@ module NounProjectApi
     ITEM_NAME = nil
 
     def initialize(origin)
-      fail(NotImplementedError, "Must use a subclass") if self.class::ITEM_NAME.nil?
+      raise NotImplementedError.new("Must use a subclass") if self.class::ITEM_NAME.nil?
 
       origin = JSON.parse(origin) if origin.is_a? String
       origin = origin.delete(

data/lib/noun-project-api/connection.rb

@@ -6,7 +6,7 @@ module NounProjectApi
     def initialize(token, secret)
       @token = token
       @secret = secret
-      fail(ArgumentError, "Missing token or secret") unless @token && @secret
+      raise ArgumentError.new("Missing token or secret") unless @token && @secret
 
       @access_token = OAuth::AccessToken.new(OAuth::Consumer.new(token, secret))
     end

data/lib/noun-project-api/errors.rb

@@ -0,0 +1,12 @@
+module NounProjectApi
+  class ServiceError < StandardError
+    attr_reader :status, :body
+
+    def initialize(status, body)
+      @status = status
+      @body = body
+
+      super("Noun Project API Error")
+    end
+  end
+end

data/lib/noun-project-api/icons_retriever.rb

@@ -11,7 +11,7 @@ module NounProjectApi
     # * offset - offset the results
     # * page - page number
     def find(term, limit = nil, offset = nil, page = nil)
-      fail(ArgumentError, "Missing search term") unless term
+      raise ArgumentError.new("Missing search term") unless term
 
       search = OAuth::Helper.escape(term)
       search += "?limit_to_public_domain=#{NounProjectApi.configuration.public_domain ? 1 : 0}"
@@ -24,7 +24,7 @@ module NounProjectApi
       args.each { |k, v| search += "&#{k}=#{v}" } if args.size > 0
 
       result = access_token.get("#{API_BASE}#{API_PATH}#{search}")
-      fail(ArgumentError, "Bad request") unless %w(200 404).include? result.code
+      raise ArgumentError.new("Bad request") unless %w(200 404).include? result.code
 
       if result.code == "200"
         JSON.parse(result.body)["icons"].map { |icon| Icon.new(icon) }
@@ -51,7 +51,7 @@ module NounProjectApi
       end
 
       result = access_token.get("#{API_BASE}#{API_PATH}recent_uploads#{search}")
-      fail(ArgumentError, "Bad request") unless result.code == "200"
+      raise ArgumentError.new("Bad request") unless result.code == "200"
 
       JSON.parse(result.body)["recent_uploads"].map { |icon| Icon.new(icon) }
     end

data/lib/noun-project-api/reporter.rb

@@ -7,7 +7,7 @@ module NounProjectApi
 
     def report_used(ids)
       ids = [ids] if ids.is_a?(String) || ids.is_a?(Fixnum)
-      fail(ArgumentError, "Missing ids") if ids.nil? || ids.empty?
+      raise ArgumentError.new("Missing ids") if ids.nil? || ids.empty?
 
       result = access_token.post(
         "#{API_BASE}#{API_PATH}",

data/lib/noun-project-api/retriever.rb

@@ -5,10 +5,10 @@ module NounProjectApi
 
     # Find an item based on it's id.
     def find(id)
-      fail(ArgumentError, "Missing id/slug") unless id
+      raise ArgumentError.new("Missing id/slug") unless id
 
       result = access_token.get("#{API_BASE}#{self.class::API_PATH}#{id}")
-      fail(ArgumentError, "Bad request") unless result.code == "200"
+      raise ServiceError.new(result.code, result.body) unless result.code == "200"
 
       self.class::ITEM_CLASS.new(result.body)
     end

data/spec/lib/noun-project-api/collection_retriever_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe NounProjectApi::CollectionRetriever do
         @missing_response
       )
 
-      expect { @collection.find(id) }.to raise_error(ArgumentError)
+      expect { @collection.find(id) }.to raise_error(NounProjectApi::ServiceError)
     end
   end
 
@@ -79,7 +79,7 @@ RSpec.describe NounProjectApi::CollectionRetriever do
         @missing_response
       )
 
-      expect { @collection.find_by_slug(slug) }.to raise_error(ArgumentError)
+      expect { @collection.find_by_slug(slug) }.to raise_error(NounProjectApi::ServiceError)
     end
   end
 end

data/spec/lib/noun-project-api/icon_retriever_spec.rb

@@ -45,7 +45,7 @@ RSpec.describe NounProjectApi::IconRetriever do
         @missing_response
       )
 
-      expect { @icon.find(id) }.to raise_error(ArgumentError)
+      expect { @icon.find(id) }.to raise_error(NounProjectApi::ServiceError)
     end
   end
 
@@ -79,7 +79,7 @@ RSpec.describe NounProjectApi::IconRetriever do
         @missing_response
       )
 
-      expect { @icon.find_by_slug(slug) }.to raise_error(ArgumentError)
+      expect { @icon.find_by_slug(slug) }.to raise_error(NounProjectApi::ServiceError)
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,11 +1,8 @@
-require "codeclimate-test-reporter"
-CodeClimate::TestReporter.start
-
 require "bundler/setup"
 require "noun-project-api"
 require "pry"
 require "faker"
-require 'json'
+require "json"
 
 require_relative "support/fakes"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: noun-project-api
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Nadav Shatz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-16 00:00:00.000000000 Z
+date: 2018-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oauth
@@ -16,76 +16,98 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: semver
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.11'
 description: A Gem to expose a wrapping API for The Noun Project API's
 email: nadav@tailorbrands.com
 executables: []
@@ -98,6 +120,7 @@ files:
 - lib/noun-project-api/collection.rb
 - lib/noun-project-api/collection_retriever.rb
 - lib/noun-project-api/connection.rb
+- lib/noun-project-api/errors.rb
 - lib/noun-project-api/icon.rb
 - lib/noun-project-api/icon_retriever.rb
 - lib/noun-project-api/icons_retriever.rb
@@ -134,19 +157,19 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: An API wrapper for The Noun Project API's
 test_files:
+- spec/spec_helper.rb
+- spec/support/fakes.rb
+- spec/lib/nount_project_api_spec.rb
+- spec/lib/noun-project-api/collection_spec.rb
+- spec/lib/noun-project-api/icon_spec.rb
 - spec/lib/noun-project-api/base_item_spec.rb
 - spec/lib/noun-project-api/collection_retriever_spec.rb
-- spec/lib/noun-project-api/collection_spec.rb
+- spec/lib/noun-project-api/retriever_spec.rb
 - spec/lib/noun-project-api/icon_retriever_spec.rb
-- spec/lib/noun-project-api/icon_spec.rb
-- spec/lib/noun-project-api/icons_retriever_spec.rb
 - spec/lib/noun-project-api/reporter_spec.rb
-- spec/lib/noun-project-api/retriever_spec.rb
-- spec/lib/nount_project_api_spec.rb
-- spec/spec_helper.rb
-- spec/support/fakes.rb
+- spec/lib/noun-project-api/icons_retriever_spec.rb