noun-project-api 0.0.8 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38b46a0bde8395513cae9b4d2096d15cab2de56d
-  data.tar.gz: 5a148071f5a87420443ba2b7affe37bc24e24ba5
+  metadata.gz: 1f48184a1d214d1c7a49a7613f70b2c6837e7752
+  data.tar.gz: e5cd3736f3dd1d3cf8cc7c33941051d76f4837be
 SHA512:
-  metadata.gz: f964c8927b12370efc633b7c07b7e99ee19ee1081f3c782130f6593c8e1d280cc553e2a03a57da034d6e9bb1e6963c42fdb33c7eeb6363408e4679e8ec575626
-  data.tar.gz: 3f394da10b8dff96754c0810c7f2b66ae1894f74dabaac5dae898b5fcdd2703561d19d6ed73abd9083c1b3aaa8d47b64e87ef5c883d9387ae4a5e0ee07f96d7d
+  metadata.gz: a2279e8f3a1eb12deb20eaf8716e211e89d205197426a44074e668fe62b16732007f542b12375a82e2e1656409a0500659b23cd2e01788abe69309891483ad6d
+  data.tar.gz: 9bdcac6c98affae7970a37690f9ab44244d938724916f949c54b40c2af8616bffc6bc2384e90e5abc825e294bc45d89720d0f4eedd1e776784c902abf7d357ef

data/lib/noun-project-api/icons_retriever.rb

@@ -8,7 +8,7 @@ module NounProjectApi
     def find(term, limit = nil, offset = nil, page = nil)
       raise ArgumentError.new('Missing search term') unless term
 
-      search = URI::encode(term)
+      search = CGI.escape(term)
       search += "?limit_to_public_domain=#{NounProjectApi.configuration.public_domain ? 1 : 0}"
 
       args = { "limit" => limit, "offset" => offset, "page" => page }.reject { |k, v| v.nil? }

data/spec/lib/noun-project-api/icons_retriever_spec.rb

@@ -64,11 +64,11 @@ RSpec.describe NounProjectApi::IconsRetriever do
         code: '200'
       )
 
-      term = 'some search'
+      term = 'some search with \',] bad chars'
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{CGI.escape(term)}?limit_to_public_domain=0"
       ).and_return(
         valid_response
       )
@@ -91,7 +91,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{CGI.escape(term)}?limit_to_public_domain=0"
       ).and_return(
         valid_response
       )
@@ -114,7 +114,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=1"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{CGI.escape(term)}?limit_to_public_domain=1"
       ).and_return(
         valid_response
       )
@@ -139,7 +139,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0&limit=#{limit}"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{CGI.escape(term)}?limit_to_public_domain=0&limit=#{limit}"
       ).and_return(
         valid_response
       )
@@ -160,7 +160,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{CGI.escape(term)}?limit_to_public_domain=0"
       ).and_return(
         missing_response
       )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: noun-project-api
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.1.0
 platform: ruby
 authors:
 - Nadav Shatz
@@ -72,6 +72,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: semver
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A Gem to expose a wrapping API for The Noun Project API's
 email: nadav@tailorbrands.com
 executables: []