noun-project-api 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c4bcc5e69be85f084b513b6cc957ccea30627657
-  data.tar.gz: a57feb45cf2a81a9219d2a0666799b8cf38a4a3f
+  metadata.gz: 38b46a0bde8395513cae9b4d2096d15cab2de56d
+  data.tar.gz: 5a148071f5a87420443ba2b7affe37bc24e24ba5
 SHA512:
-  metadata.gz: 692fa679a1b992274bf53f3cb5fb3c08cbd3764627c8445ae63128f0d4a135f8e691546582e436dc709ba6f4068c232d59f390c6c4999fa508f135337e711457
-  data.tar.gz: 8d148ecb2aa64473dd605be26e69a0974ebfad4d262bebea536c3b480c162f1e94be9a2ef379cc8d6a3cdefe335037f9c2d19aee02cc4564311a934301248134
+  metadata.gz: f964c8927b12370efc633b7c07b7e99ee19ee1081f3c782130f6593c8e1d280cc553e2a03a57da034d6e9bb1e6963c42fdb33c7eeb6363408e4679e8ec575626
+  data.tar.gz: 3f394da10b8dff96754c0810c7f2b66ae1894f74dabaac5dae898b5fcdd2703561d19d6ed73abd9083c1b3aaa8d47b64e87ef5c883d9387ae4a5e0ee07f96d7d

data/lib/noun-project-api.rb

@@ -3,4 +3,20 @@ require 'noun-project-api/icons_retriever'
 require 'noun-project-api/icon'
 
 module NounProjectApi
+  def self.configuration
+    @configuration ||=  Configuration.new
+  end
+
+  def self.configure
+    self.configuration ||= Configuration.new
+    yield(configuration) if block_given?
+  end
+
+  class Configuration
+    attr_accessor :public_domain
+
+    def initialize
+      @public_domain = false
+    end
+  end
 end

data/lib/noun-project-api/icons_retriever.rb

@@ -9,11 +9,11 @@ module NounProjectApi
       raise ArgumentError.new('Missing search term') unless term
 
       search = URI::encode(term)
+      search += "?limit_to_public_domain=#{NounProjectApi.configuration.public_domain ? 1 : 0}"
 
       args = { "limit" => limit, "offset" => offset, "page" => page }.reject { |k, v| v.nil? }
       if args.size > 0
-        search += '?'
-        args.each { |k, v| search += "#{k}=#{v}&" }
+        args.each { |k, v| search += "&#{k}=#{v}" }
       end
 
       result = self.access_token.get("#{API_BASE}#{API_PATH}#{search}")

data/spec/lib/noun-project-api/icon_spec.rb

@@ -60,5 +60,18 @@ RSpec.describe NounProjectApi::IconRetriever do
       expect(@valid_icon.id).to be_a(Fixnum)
       expect(@valid_icon.id).to eq(@json["icon"]["id"].to_i)
     end
+
+    it 'builds a simple hash' do
+      expect(@valid_icon.to_hash).to eq({
+        id: @valid_icon.id,
+        preview_url_200: @valid_icon.preview_url(NounProjectApi::Icon::PREVIEW_SIZE_200),
+        preview_url_84: @valid_icon.preview_url(NounProjectApi::Icon::PREVIEW_SIZE_84),
+        preview_url_42: @valid_icon.preview_url(NounProjectApi::Icon::PREVIEW_SIZE_42)
+      })
+    end
+
+    it 'json formats the hash' do
+      expect(@valid_icon.to_json).to eq JSON.dump @valid_icon.to_hash
+    end
   end
 end

data/spec/lib/noun-project-api/icons_retriever_spec.rb

@@ -68,7 +68,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0"
       ).and_return(
         valid_response
       )
@@ -91,7 +91,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0"
       ).and_return(
         valid_response
       )
@@ -103,6 +103,31 @@ RSpec.describe NounProjectApi::IconsRetriever do
       end
     end
 
+    it 'properly handles public domain only config' do
+      valid_hash = JSON.parse(Fakes::Results::ICONS_VALID)
+      valid_response = OpenStruct.new(
+        body: Fakes::Results::ICONS_VALID,
+        code: '200'
+      )
+
+      term = 'some search'
+      expect(@icons.access_token).to receive(
+        :get
+      ).with(
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=1"
+      ).and_return(
+        valid_response
+      )
+
+      NounProjectApi.configuration.public_domain = true
+      results = @icons.find(term)
+      expect(results.size).to eq(valid_hash["icons"].size)
+      results.each do |icon|
+        expect(icon).to be_a(NounProjectApi::Icon)
+      end
+      NounProjectApi.configuration.public_domain = false
+    end
+
     it 'returns a proper result with a correct phrase and passes along the args' do
       valid_response = OpenStruct.new(
         body: Fakes::Results::ICONS_VALID,
@@ -114,7 +139,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit=#{limit}&"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0&limit=#{limit}"
       ).and_return(
         valid_response
       )
@@ -135,7 +160,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{URI::encode(term)}?limit_to_public_domain=0"
       ).and_return(
         missing_response
       )

data/spec/lib/nount_project_api_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+RSpec.describe NounProjectApi do
+  it 'has the correct default' do
+    expect(NounProjectApi.configuration.public_domain).to be false
+  end
+
+  it 'sets the correct configuration' do
+    expect(NounProjectApi.configuration.public_domain).to be false
+
+    NounProjectApi.configure do |config|
+      config.public_domain = true
+    end
+
+    expect(NounProjectApi.configuration.public_domain).to be true
+
+    NounProjectApi.configuration.public_domain = false
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: noun-project-api
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Nadav Shatz
@@ -88,6 +88,7 @@ files:
 - spec/lib/noun-project-api/icon_spec.rb
 - spec/lib/noun-project-api/icons_retriever_spec.rb
 - spec/lib/noun-project-api/retriever_spec.rb
+- spec/lib/nount_project_api_spec.rb
 - spec/spec_helper.rb
 - spec/support/fakes.rb
 homepage: https://github.com/TailorBrands/noun-project-api
@@ -119,5 +120,6 @@ test_files:
 - spec/lib/noun-project-api/icon_spec.rb
 - spec/lib/noun-project-api/icons_retriever_spec.rb
 - spec/lib/noun-project-api/retriever_spec.rb
+- spec/lib/nount_project_api_spec.rb
 - spec/spec_helper.rb
 - spec/support/fakes.rb