notify_user 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 77798252ab441cbfca131b125e40292b701210dd
-  data.tar.gz: 5cc16d6d5c354588db35b6a0797ce61da23a669d
+  metadata.gz: 8d21b220862a946109126fd399260454de810107
+  data.tar.gz: 84d380d7553c60678ccaaf4846f71570c41d3d2c
 SHA512:
-  metadata.gz: fdb8a7efaa8c5e7af6bc9b8a84ae0189ce564c4492d25d8cb00c991a1964df787e00a392e77cea452c358e34380bc785d4638177304dd74df052a5d0ddc90d7c
-  data.tar.gz: 13e3307a5e50a15aade5b029bdf9483b3d20df4bd1b704b6057c2ba60dd30dc36433f14542520c5b0203cb485f5afe5f01a55304e19b79d601cf2f5160a1d710
+  metadata.gz: 957169fda235cd41be58726384b17f9a03b4981c2611878daf07d09a346dad9d0b8bb57f7c3ed49664e79f1bdb4750f4e2fa76ed4b3dfcde9662888fd3f7e3c7
+  data.tar.gz: 0ec1c8ff6731c5c0769f1f5e372331728049e8be4c36130583bee81e86b6216b73ef43f7fa781ad9907c9e287de91bac02766fa7ff5c232e2fb5620c3712f450

data/README.md

@@ -53,17 +53,6 @@ wwtd
 ## APNS providers
 By default, we use [Houston](https://github.com/nomad/houston/) to deliver push notifications via APNS from the server.
 
-The initialiser for `notify_user` contains the following configuration when delivering via Houston:
-```
-# Number of connections Houston will maintain to APNS:
-config.connection_pool_size = 3
-
-# Time in seconds Houston will wait for a free connection before failing:
-config.connection_pool_timeout = 300
-```
-
-We maintain persistent connections to APNS via background workers, and these values will allow you to configure how many connections the workers maintain, as well as the amount of time to wait for an idle connection before timing out.
-
 You also need to provide exported versions of your push notification certificate and key as .pem files, these instructions come from the [APN on Rails](https://github.com/PRX/apn_on_rails) project on how to do that:
 
 Once you have the certificate from Apple for your application, export your key

data/app/models/notify_user/apn_connection.rb

@@ -1,6 +1,10 @@
 module NotifyUser
   class APNConnection
 
+    POOL = ConnectionPool.new(size: ENV['APNS_CONNECTION_POOL_SIZE'] || 1, timeout: ENV['APNS_CONNECTION_TIMEOUT'] || 30) {
+      APNConnection.new
+    }
+
     def initialize
       connection
     end

data/app/models/notify_user/apns.rb

@@ -5,9 +5,8 @@ module NotifyUser
   class Apns < Push
     NO_ERROR = -42
     INVALID_TOKEN_ERROR = 8
-    CONNECTION = APNConnection.new
 
-    attr_accessor :push_options
+    attr_accessor :push_options, :apn_connection
 
     def initialize(notifications, devices, options)
       super(notifications, devices, options)
@@ -17,7 +16,10 @@ module NotifyUser
     end
 
     def push
-      send_notifications
+      APNConnection::POOL.with do |apn_conn|
+        @apn_connection = apn_conn
+        send_notifications
+      end
     end
 
     private
@@ -25,11 +27,11 @@ module NotifyUser
     attr_accessor :devices
 
     def connection
-      CONNECTION.connection
+      apn_connection.connection
     end
 
     def reset_connection
-      CONNECTION.reset
+      apn_connection.reset
     end
 
     def setup_options

data/lib/generators/notify_user/install/templates/initializer.rb

@@ -14,11 +14,4 @@ NotifyUser.setup do |config|
 
   # Provider for APNS:
   config.apns_provider = :houston
-
-  # Number of connections Houston will maintain to APNS:
-  config.connection_pool_size = 3
-
-  # Time in seconds Houston will wait for a free connection before failing:
-  config.connection_pool_timeout = 300
-
 end

data/lib/notify_user.rb

@@ -20,14 +20,6 @@ module NotifyUser
   mattr_accessor :apns_provider
   @@apns_provider = nil
 
-  # Number of connections Houston will maintain to APNS:
-  mattr_accessor :connection_pool_size
-  @@connection_pool_size = nil
-
-  # Time in seconds Houston will wait for a free connection before failing:
-  mattr_accessor :connection_pool_timeout
-  @@connection_pool_timeout = nil
-
   # Used to set up NotifyUser from the initializer.
   def self.setup
     yield self

data/lib/notify_user/version.rb

@@ -1,3 +1,3 @@
 module NotifyUser
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: notify_user
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Tom Spacek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-19 00:00:00.000000000 Z
+date: 2015-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails