notifier 1.1.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c842629dcf6da711e4d5979dd03a395e35e4aa752271f80f3fca65f50aff3bf9
-  data.tar.gz: aec07ca38b8a39779dbf9e65383ea26cb140dc46b7069fb79798853ef9b3f611
+  metadata.gz: f11e00e55117bf997579f4d0cd0ba9acb4242d5e5045c519c36f938f637235d8
+  data.tar.gz: f4091e3ef9660c00ad6620dc45d648adb686174549eda5ecc33cf7e4e654da41
 SHA512:
-  metadata.gz: a274ece6e94cb827c710d249ec9540551a116c2f99dbfa78ff8fe6c0458e9aa0c3fbd36df587cff7bbfdde4b9d1f213d1b07c5c9e3c66c1854f9a5f49e40af8a
-  data.tar.gz: d741722e7fea144a2c920c4add06a7fab380cb9b591c437c095707bab9cbbb21cbfb3a929d2d315c9e19ea468d85b4214bdefb77b1cfbd6a05c3cc7aaf942242
+  metadata.gz: 155c248f28980870789ac3a679ce2a8a89434be67d91164ad19444b9f7ce7de2c4b1796f007f417bb14f01ae0ba26f7c0aa20fcf599ed800b67bd054932feb0f
+  data.tar.gz: 6ed42de3b14e5de5de1ce707f528203be37344afeb2c25ce394d36e28a959afa07cc6ec2957c601732e7ff1a94c69b5225f3283a3313e127e10ec332a3bfabe7

data/README.md

@@ -7,7 +7,6 @@ Send system notifications on several platforms with a simple and unified API.
 Currently supports:
 
 - terminal-notifier (Notification Center wrapper for Mac OS X)
-- GNTP Protocol (Growl, with Vagrant support)
 - Kdialog (Linux/KDE)
 - Knotify (Linux/KDE)
 - OSD Cat (Linux)
@@ -68,6 +67,14 @@ prefer:
 Notifier.default_notifier = :notify_send
 ```
 
+Alternatively, you can set the default notifier by using the `NOTIFIER` env var.
+The following example assumes `test_notifier` is configured on this Rails
+project. The env var has precedence of `Notifier.default_notifier`.
+
+```console
+$ NOTIFIER=hud rails test
+```
+
 The available names are `terminal_notifier`, `kdialog`, `knotify`,
 `notify_send`, `osd_cat`, and `snarl`.
 

data/lib/notifier/hud.rb

@@ -5,37 +5,28 @@ module Notifier
     extend self
 
     def supported?
-      Notifier.os?(/darwin/) && hud?
+      Notifier.os?(/darwin/) && hud_bin
     end
 
-    def uri
-      URI("http://127.0.0.1:32323/hud")
-    end
-
-    def hud?
-      return @hud unless @hud.nil?
-
-      @hud = begin
-        response = Net::HTTP.get_response(uri)
-        response.code == "200"
-      rescue StandardError
-        false
-      end
-
-      @hud
+    def hud_bin
+      @hud_bin ||= [
+        "/Applications/hud.app/Contents/MacOS/cli",
+        "~/Applications/hud.app/Contents/MacOS/cli"
+      ].first {|path| File.expand_path(path) }
     end
 
     def notify(options)
-      Thread.new do
-        Net::HTTP.post_form(
-          uri,
-          {
-            "title" => options[:title].to_s,
-            "message" => options[:message].to_s,
-            "symbolName" => options[:image].to_s
-          }
-        )
-      end.join
+      command = [
+        hud_bin,
+        "--title",
+        options[:title].to_s,
+        "--message",
+        options[:message].to_s,
+        "--symbol-name",
+        options[:image].to_s
+      ]
+
+      Thread.new { system(*command) }.join
     end
   end
 end

data/lib/notifier/version.rb

@@ -3,8 +3,8 @@
 module Notifier
   module Version
     MAJOR = 1
-    MINOR = 1
-    PATCH = 0
+    MINOR = 2
+    PATCH = 1
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/lib/notifier.rb

@@ -30,7 +30,8 @@ module Notifier
   end
 
   def notifier
-    supported_notifier_from_name(default_notifier) || supported_notifiers.first
+    supported_notifier_from_name(ENV.fetch("NOTIFIER", default_notifier)) ||
+      supported_notifiers.first
   end
 
   def notify(options)

data/test/notifier/notifier_test.rb

@@ -11,6 +11,7 @@ class NotifierTest < Minitest::Test
     end
 
     Notifier.default_notifier = nil
+    ENV.delete("NOTIFIER")
   end
 
   teardown do
@@ -40,6 +41,17 @@ class NotifierTest < Minitest::Test
     assert_equal Notifier::Knotify, Notifier.notifier
   end
 
+  test "prefers default notifier using env var" do
+    ENV["NOTIFIER"] = "knotify"
+
+    Notifier::Snarl.stubs(:supported?).returns(true)
+    Notifier::Knotify.stubs(:supported?).returns(true)
+
+    Notifier.default_notifier = :snarl
+
+    assert_equal Notifier::Knotify, Notifier.notifier
+  end
+
   test "sends notification" do
     params = {
       title: "Some title",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: notifier
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Nando Vieira
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-22 00:00:00.000000000 Z
+date: 2022-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-utils