notifications_opener 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73460d17fb8bd6f0f018b8fbfd7da6136adc50ea
-  data.tar.gz: 09bcb14762bfce0381b52c51779c51c5bda58079
+  metadata.gz: 883f8b5c7c2d01571e1c0eab6304dce6be1b8b85
+  data.tar.gz: 50e31296b78f07f8735a3d1a674ae749f2fd0c9f
 SHA512:
-  metadata.gz: 22ee94c4749f15356b7a60ba03670e49f47fb937b036ad51db7424d32e4af07269e2898d936563480ec7ab0354c0af7633753921903e732ae8bf9bfeb1623f7d
-  data.tar.gz: 8ec7c6309b5a80a6b8fa854a87e0c6779e8b090d1ca86fb15e1b3a85ed8ab963b1603ed821e1346cd371a1b9699c059311b41ad4c76f64e6109b4d344528d590
+  metadata.gz: 2ccef8872761f72855b4c71bc48e4b3c9986321ded79533eed8bbe81d9001efef09afc4918c3b9c63fc54ff54b3e3e6df134b7e1d1ef0dd687d8a7ebfbb4caac
+  data.tar.gz: c7496ad12e0bfa3762ee66ea7de660e2a28cecd9fc1789a2f214d8de6777744d19730e72e93cb9e16d96a40e71d820e0d1e33b6e709cc18baaeb9363e76009d0

data/README.md

@@ -1,3 +1,5 @@
+[![Gem Version](https://badge.fury.io/rb/notifications_opener.svg)](http://badge.fury.io/rb/notifications_opener)
+
 # Notifications Opener
 
 Blocks SMSs from being delivered in development. Instead opens a preview in the browser by intercepting the request to the configured SMS API.

data/lib/notifications_opener/interceptor.rb

@@ -1,10 +1,5 @@
-##
-# This class represents as an interceptor for the HTTP requests to the
-# specified URL
-
 require 'webmock'
 require 'rack'
-
 ##
 # On requiring webmock it disables HTTP connections by default
 # so we need to call this method after requiring it, since we only
@@ -12,6 +7,9 @@ require 'rack'
 WebMock.allow_net_connect!
 
 module NotificationsOpener
+  ##
+  # This class represents as an interceptor for the HTTP requests to the
+  # specified URL
   class Interceptor
     attr_accessor :config,
                   :response_handler

data/lib/notifications_opener/message.rb

@@ -1,10 +1,9 @@
-##
-# This class represents builds a usable message based on the parameters
-
 require 'erb'
 require 'launchy'
 
 module NotificationsOpener
+  ##
+  # This class represents builds a usable message based on the parameters
   class Message
     attr_accessor :config,
                   :from,
@@ -20,14 +19,14 @@ module NotificationsOpener
       @message = config[:message]
 
       @location = config[:location]
-      @file_path = get_file_path
+      @file_path = generate_file_path
     end
 
     # #
     # Creates the file with the interpolated content in the specified location
     # Opens it up in a browser from preview
     def deliver
-      File.open(file_path, 'w') { | file | file.write(rendered_content) }
+      File.open(file_path, 'w') { |file| file.write(rendered_content) }
       Launchy.open("file:///#{URI.parse(file_path)}")
     end
 
@@ -39,10 +38,10 @@ module NotificationsOpener
     end
 
     def template
-      File.read(File.expand_path("../message.html.erb", __FILE__))
+      File.read(File.expand_path('../message.html.erb', __FILE__))
     end
-    
-    def get_file_path
+
+    def generate_file_path
       location + '/' + SecureRandom.hex + '.html'
     end
   end

data/lib/notifications_opener/response_handler.rb

@@ -1,8 +1,7 @@
-##
-# The (instance of)class represents a Rack application
-# Responsible to handle a stubbed request manually
-
 module NotificationsOpener
+  ##
+  # The (instance of)class represents a Rack application
+  # Responsible to handle a stubbed request manually
   class ResponseHandler
     attr_accessor :config,
                   :message
@@ -12,10 +11,11 @@ module NotificationsOpener
     end
 
     def call(env)
-      @message = NotificationsOpener::Message.new(get_required_params(env['QUERY_STRING']))
+      message_params = get_required_params(env['QUERY_STRING'])
+      @message = NotificationsOpener::Message.new(message_params)
       message.deliver
 
-      [200, { }, [ ]]
+      [200, {}, []]
     end
 
     private
@@ -31,12 +31,11 @@ module NotificationsOpener
     end
 
     def get_params_from_query_string(q)
-      p = { }
-      q.split('&').each do | kv |
+      p = {}
+      q.split('&').each do |kv|
         kv = kv.split('=')
         p[kv[0]] = kv[1]
       end
-      p p
       p
     end
   end

data/lib/notifications_opener/version.rb

@@ -1,3 +1,3 @@
 module NotificationsOpener
-  VERSION = "0.1.1"
+  VERSION = '0.1.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: notifications_opener
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - abhisheksarka