notification-pusher 1.0.0.beta9 → 1.0.0.beta10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7bd278a400f98567d17b9e39887e5e8960ddbfd99b9c2ad9edb6a462cf12f7c
-  data.tar.gz: bcd25f7e997fae9a09a75cec3b8994bacd4ba15c7500b786db314efff13b3f81
+  metadata.gz: 85507c35f9a208143b6c60d0619a2451ee338ff647bf387d6a35d68d710013df
+  data.tar.gz: 10a5c1cf5effbc81e8307afcc28d18f32e453a1a6bf644e8c6efcd9bac7d3d1b
 SHA512:
-  metadata.gz: 9188a46b341e911a926f67256f9ce958bc4fa20bd2dca0fd6d1dffb14374e89c4fc2634e07cb01851c195ad914edf76d03de9c8187a3e94bd98340f5eb37190c
-  data.tar.gz: f6a1df4e1b7640c06682282b01bb983f6f0a81ddb97e613e9ab3314c453733ab8d5d41dbd51aab73c20c09558db84f8162b5ead8645ffc49a1eda4d7c18a3afb
+  metadata.gz: 9948eff2f69db1e4062c83e526d058a50b01b79e91e1e927873078228ac52885eb079e9cbf352283333ce980c043e9cfbb083091bbcec3c29dadc1fd0093fe4a
+  data.tar.gz: b74d4e8fac75032fd8ebccc9ae37f1dcadb870a8ef3aef7c4618d12d471b00a93d77964fd1f16f5d635deea342bf65be45bbf2dc0c9de360c0e6da59d4a67871

data/README.md

@@ -102,14 +102,12 @@ notification.push [name_one, name_two], name_one: custom_options, name_two: cust
 Writing custom pushers is fairly simple. Just add a new subclass to `NotificationPusher`:
 
 ```ruby
-module NotificationPusher
-    class CustomPusher
-
-        def initialize notification, options = {}
-            # ...
-        end
+class NotificationPusher::CustomPusher
 
+    def initialize notification, options = {}
+        # ...
     end
+    
 end
 ```
 

data/lib/notification_pusher/notification_library.rb

@@ -24,20 +24,14 @@ module NotificationPusher
 
             def initialize_pusher
                 unless self.push.nil?
-                    if self.push.kind_of(Array)
+                    if self.push.kind_of?(Array)
                         self.push.each do |class_name|
-                            pusher = NotificationPusher::Pusher.find_by_name(class_name).last
-                            if defined?(NotificationPusher.const_get(pusher.name))
-                                options = pusher.options.merge! self.push_options[class_name.to_sym]
-                                pusher.instances << NotificationPusher.const_get(pusher.name).new self, options
-                            end
+                            pusher = NotificationPusher::Pusher.find_by_name(class_name).first
+                            pusher.push(self, self.push_options[class_name.to_sym])
                         end
                     else
-                        pusher = NotificationPusher::Pusher.find_by_name(self.push).last
-                        if defined?(NotificationPusher.const_get(pusher.name))
-                            options = pusher.options.merge! self.push_options
-                            pusher.instances << NotificationPusher.const_get(pusher.name).new self, options
-                        end
+                        pusher = NotificationPusher::Pusher.find_by_name(self.push).first
+                        pusher.push(self, self.push_options)
                     end
                 end
             end

data/lib/notification_pusher/pusher.rb

@@ -11,7 +11,16 @@ module NotificationPusher
             @options = options
         end
 
-        def find_by_name name
+        def push notification, options = {}
+            default_options = self.options
+            options = default_options.merge! options
+            if defined?(NotificationPusher.const_get(pusher.name))
+                instance = NotificationPusher.const_get(self.name).new notification, options
+                self.instances << instance
+            end
+        end
+
+        def self.find_by_name name
             ObjectSpace.each_object(NotificationPusher::Pusher).select { |pusher| pusher.name == name }
         end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: notification-pusher
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta9
+  version: 1.0.0.beta10
 platform: ruby
 authors:
 - Jonas Hübotter
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.beta9
+        version: 1.0.0.beta10
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0.beta9
+        version: 1.0.0.beta10
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement