notification-pusher-actionmailer 1.2.5 → 1.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25146467a290aa8c050f4a1d5293c52bf8a882dfdbf5b32bc0e7d8508f567304
-  data.tar.gz: 75f3dc70e13d29a80a62f9e9b5096a3e8b9c509f140a3d392ac1dc4b1336f1e3
+  metadata.gz: 8712a4c61c9fbc50771a3a8b4b8df266df08a9bc157b8ff8f4417e679a925504
+  data.tar.gz: eb81367f4f3f529ef51dc90db4037bd83f57b395c0192281ad788923a41e6e29
 SHA512:
-  metadata.gz: d418cbffb0ce8118c34f9b09abc36d260ab61931bf8161f685d5b0f60f45f1e69c42a171c00ec12bca2a5768792c539d9da299ba9583fccd4dd7277a20a1b77d
-  data.tar.gz: 8a27d143b5f485dac4ee4e8755b526d36ff4154e13ca96823f200948d8703e02df534b14d57156639ef7a93fa330a348a9c7aa4c9d80304826fdc85692e25427
+  metadata.gz: 9e7fab7423b084d66edb15968f662ba7bfce4f278632a5a9cbdc2a7f492a7114c39cff9a78e655a4d21b8f170c6d5a0ab3337aed8f02a420104b6610060bc130
+  data.tar.gz: cd01d224c4813cb8732ab18648d9960232b19a378ddd1c6d2dc8f6d9f60c40ec8a86c378e960bffa962901590cc582b43db309a4c952384c4b02f0ef925c737a

data/LICENSE

@@ -1,21 +1,21 @@
-MIT License
-
-Copyright (c) 2017 Jonas Hübotter
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+MIT License
+
+Copyright (c) 2017 Jonas Hübotter
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/README.md

@@ -1,135 +1,135 @@
-# NotificationPusher for ActionMailer
-
-[![Gem Version](https://badge.fury.io/rb/notification-pusher-actionmailer.svg)](https://badge.fury.io/rb/notification-pusher-actionmailer) <img src="https://travis-ci.org/jonhue/notifications-rails.svg?branch=master" />
-
-A pusher to send your notifications via email utilizing ActionMailer.
-
----
-
-## Table of Contents
-
-* [Installation](#installation)
-* [Usage](#usage)
-    * [Options](#options)
-* [To Do](#to-do)
-* [Contributing](#contributing)
-    * [Contributors](#contributors)
-    * [Semantic versioning](#semantic-versioning)
-* [License](#license)
-
----
-
-## Installation
-
-NotificationPusher for ActionMailer works with Rails 5 onwards. You can add it to your `Gemfile` with:
-
-```ruby
-gem 'notification-pusher-actionmailer'
-```
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install notification-pusher-actionmailer
-
-If you always want to be up to date fetch the latest from GitHub in your `Gemfile`:
-
-```ruby
-gem 'notification-pusher-actionmailer', github: 'jonhue/notifications-rails'
-```
-
----
-
-## Usage
-
-Define this pusher in your `NotificationPusher` configuration:
-
-```ruby
-NotificationPusher.configure do |config|
-    config.define_pusher :ActionMailer
-end
-```
-
-You can pass a `from` parameter, which will override the default email address specified in `ApplicationMailer`:
-
-```ruby
-NotificationPusher.configure do |config|
-    config.define_pusher :ActionMailer, from: 'my@email.com'
-end
-```
-
-Then add a renderer called `_actionmailer.html.erb` to every notification type you aim to support. Learn more [here](https://github.com/jonhue/notifications-rails/tree/master/notification-renderer).
-
-Now you can push your notifications:
-
-```ruby
-notification = Notification.create target: User.first, object: Recipe.first
-notification.push :ActionMailer, to: 'another@email.com'
-```
-
-**Note:** If the email address, you want to push to, is the same as `notification.target.email` you can omit the `to` parameter.
-
-It is also possible to override the email address sending this notification, by passing a `from` parameter.
-
-### Options
-
-**`to`** Receiver email address. Takes a string.
-
-**`from`** Sender email address. Takes a string. Defaults to email specified in `ApplicationMailer`.
-
-**`renderer`** Specify a renderer. Takes a string. Defaults to `'actionmailer'`.
-
-**`layout`** Layout used for template rendering. Takes a string. Defaults to layout specified in `ApplicationMailer`.
-
----
-
-## To Do
-
-[Here](https://github.com/jonhue/notifications-rails/projects/6) is the full list of current projects.
-
-To propose your ideas, initiate the discussion by adding a [new issue](https://github.com/jonhue/notifications-rails/issues/new).
-
----
-
-## Contributing
-
-We hope that you will consider contributing to NotificationPusher for ActionMailer. Please read this short overview for some information about how to get started:
-
-[Learn more about contributing to this repository](https://github.com/jonhue/notifications-rails/blob/master/CONTRIBUTING.md), [Code of Conduct](https://github.com/jonhue/notifications-rails/blob/master/CODE_OF_CONDUCT.md)
-
-### Contributors
-
-Give the people some :heart: who are working on this project. See them all at:
-
-https://github.com/jonhue/notifications-rails/graphs/contributors
-
-### Semantic Versioning
-
-NotificationPusher for ActionMailer follows Semantic Versioning 2.0 as defined at http://semver.org.
-
-## License
-
-MIT License
-
-Copyright (c) 2017 Jonas Hübotter
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+# NotificationPusher for ActionMailer
+
+[![Gem Version](https://badge.fury.io/rb/notification-pusher-actionmailer.svg)](https://badge.fury.io/rb/notification-pusher-actionmailer) <img src="https://travis-ci.org/jonhue/notifications-rails.svg?branch=master" />
+
+A pusher to send your notifications via email utilizing ActionMailer.
+
+---
+
+## Table of Contents
+
+* [Installation](#installation)
+* [Usage](#usage)
+    * [Options](#options)
+* [To Do](#to-do)
+* [Contributing](#contributing)
+    * [Contributors](#contributors)
+    * [Semantic versioning](#semantic-versioning)
+* [License](#license)
+
+---
+
+## Installation
+
+NotificationPusher for ActionMailer works with Rails 5 onwards. You can add it to your `Gemfile` with:
+
+```ruby
+gem 'notification-pusher-actionmailer'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install notification-pusher-actionmailer
+
+If you always want to be up to date fetch the latest from GitHub in your `Gemfile`:
+
+```ruby
+gem 'notification-pusher-actionmailer', github: 'jonhue/notifications-rails'
+```
+
+---
+
+## Usage
+
+Define this pusher in your `NotificationPusher` configuration:
+
+```ruby
+NotificationPusher.configure do |config|
+    config.define_pusher :ActionMailer
+end
+```
+
+You can pass a `from` parameter, which will override the default email address specified in `ApplicationMailer`:
+
+```ruby
+NotificationPusher.configure do |config|
+    config.define_pusher :ActionMailer, from: 'my@email.com'
+end
+```
+
+Then add a renderer called `_actionmailer.html.erb` to every notification type you aim to support. Learn more [here](https://github.com/jonhue/notifications-rails/tree/master/notification-renderer).
+
+Now you can push your notifications:
+
+```ruby
+notification = Notification.create target: User.first, object: Recipe.first
+notification.push :ActionMailer, to: 'another@email.com'
+```
+
+**Note:** If the email address, you want to push to, is the same as `notification.target.email` you can omit the `to` parameter.
+
+It is also possible to override the email address sending this notification, by passing a `from` parameter.
+
+### Options
+
+**`to`** Receiver email address. Takes a string.
+
+**`from`** Sender email address. Takes a string. Defaults to email specified in `ApplicationMailer`.
+
+**`renderer`** Specify a renderer. Takes a string. Defaults to `'actionmailer'`.
+
+**`layout`** Layout used for template rendering. Takes a string. Defaults to layout specified in `ApplicationMailer`.
+
+---
+
+## To Do
+
+[Here](https://github.com/jonhue/notifications-rails/projects/6) is the full list of current projects.
+
+To propose your ideas, initiate the discussion by adding a [new issue](https://github.com/jonhue/notifications-rails/issues/new).
+
+---
+
+## Contributing
+
+We hope that you will consider contributing to NotificationPusher for ActionMailer. Please read this short overview for some information about how to get started:
+
+[Learn more about contributing to this repository](https://github.com/jonhue/notifications-rails/blob/master/CONTRIBUTING.md), [Code of Conduct](https://github.com/jonhue/notifications-rails/blob/master/CODE_OF_CONDUCT.md)
+
+### Contributors
+
+Give the people some :heart: who are working on this project. See them all at:
+
+https://github.com/jonhue/notifications-rails/graphs/contributors
+
+### Semantic Versioning
+
+NotificationPusher for ActionMailer follows Semantic Versioning 2.0 as defined at http://semver.org.
+
+## License
+
+MIT License
+
+Copyright (c) 2017 Jonas Hübotter
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/app/mailers/notification_pusher/action_mailer/notification_mailer.rb

@@ -1,10 +1,15 @@
-class NotificationPusher::ActionMailer::NotificationMailer < ApplicationMailer
-
-    def push notification, options = {}
-        render(layout: options[:layout]) if options.has_key?(:layout)
-        @notification = notification
-        @renderer = options[:renderer] || 'actionmailer'
-        mail to: options[:to] || notification.target.email, from: options[:from]
-    end
-
-end
+# frozen_string_literal: true
+
+module NotificationPusher
+  class ActionMailer
+    class NotificationMailer < ApplicationMailer
+      def push(notification,
+               from:, to: nil, renderer: 'actionmailer', layout: nil)
+        render(layout: layout) unless layout.nil?
+        @notification = notification
+        @renderer = renderer
+        mail(to: to || notification.target.email, from: from)
+      end
+    end
+  end
+end

data/app/views/notification_pusher/action_mailer/notification_mailer/push.html.erb

@@ -1 +1 @@
-<%= render_notification @notification, @renderer %>
+<%= render_notification @notification, @renderer %>

data/lib/notification-pusher-actionmailer.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require 'notification-pusher'
 require 'notification_pusher/action_mailer'

data/lib/notification_pusher/action_mailer.rb

@@ -1,11 +1,15 @@
-require 'notification-renderer'
+# frozen_string_literal: true
 
-class NotificationPusher::ActionMailer
+require 'notification-renderer'
 
+module NotificationPusher
+  class ActionMailer
     require 'notification_pusher/action_mailer/engine'
 
-    def initialize notification, options = {}
-        ::NotificationPusher::ActionMailer::NotificationMailer.push notification, options
+    def initialize(notification, options = {})
+      ::NotificationPusher::ActionMailer::NotificationMailer.push(
+        notification, options
+      )
     end
-
+  end
 end

data/lib/notification_pusher/action_mailer/engine.rb

@@ -1,9 +1,11 @@
-require 'rails/railtie'
-require 'action_mailer'
-
-module NotificationPusher
-    class ActionMailer
-        class Engine < ::Rails::Engine
-        end
-    end
-end
+# frozen_string_literal: true
+
+require 'rails/railtie'
+require 'action_mailer'
+
+module NotificationPusher
+  class ActionMailer
+    class Engine < ::Rails::Engine
+    end
+  end
+end

metadata

@@ -1,106 +1,119 @@
 --- !ruby/object:Gem::Specification
 name: notification-pusher-actionmailer
 version: !ruby/object:Gem::Version
-  version: 1.2.5
+  version: 1.2.6
 platform: ruby
 authors:
 - Jonas Hübotter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-25 00:00:00.000000000 Z
+date: 2018-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: railties
+  name: actionmailer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
-  name: actionmailer
+  name: notification-pusher
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: 1.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: 1.2.6
 - !ruby/object:Gem::Dependency
-  name: notification-pusher
+  name: notification-renderer
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.5
+        version: 1.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.5
+        version: 1.2.6
 - !ruby/object:Gem::Dependency
-  name: notification-renderer
+  name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.5
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.5
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: '0'
 description: A pusher to send your notifications via email utilizing ActionMailer.
 email: me@jonhue.me
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- CHANGELOG.md
 - LICENSE
 - README.md
 - app/mailers/notification_pusher/action_mailer/notification_mailer.rb
@@ -120,7 +133,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: 2.2.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -128,7 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A pusher to send your notifications via email utilizing ActionMailer

data/CHANGELOG.md

@@ -1,23 +0,0 @@
-# Changelog
-
-### master
-
-* nothing yet
-
-### 1.0.0 - 2017/12/28
-
-* bugfixes
-
-### 1.0.0.beta6 - 2017/12/28
-
-* bugfixes
-    * fix lib loading problems
-
-### 1.0.0.beta4 - 2017/12/27
-
-* features
-    * add functionality
-
-### 1.0.0.beta1 - 2017/12/22
-
-* initial release