notifiable-apns-grocer 0.9.2 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c93d207045d385543328378c3b2a8599d3263dd
-  data.tar.gz: 216667de8a48363778d2c8d9bba91d1856e1ed56
+  metadata.gz: 6a06d78cc911ead79cb82a82ac8d300356103c61
+  data.tar.gz: a8ab71412ce38e6243ae014a01967033f76c0f99
 SHA512:
-  metadata.gz: 88bf1a0ec973d3cd9b3424ae411d35a7c572e887ee217c524e892a49fdae609b12c8de9f5e68ccdb64c92a35a0061d0d28ae1382d0085e717796e17f595472b5
-  data.tar.gz: 5c0d1c890ef904da91a93c66bef085171eb2202dca140644b5276af46fb6fb74772e1e0509c8141513ea184b422ab9ee5f226a318e557bacdf1f7e0bc71bced9
+  metadata.gz: 2b58e61ad194010c7893140834ec7a87b1e90a227943cdf9211bf95af62646b25703a18d3316b919169585fbd68dfa7686d7a8fb2155779fbbd24a98af872e28
+  data.tar.gz: 1ca98ff7c33c18737dca7a9b7b957685c526d9c9da339baae973fc9757a5c989e2f409527bd69d29e2610f16340fd5300978d8ae6beb45509928a0bf5fc1a9ea

data/README.md

@@ -1,29 +1,3 @@
 # Notifiable::Apns::Grocer
 
-TODO: Write a gem description
-
-## Installation
-
-Add this line to your application's Gemfile:
-
-    gem 'notifiable-apns-grocer'
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install notifiable-apns-grocer
-
-## Usage
-
-TODO: Write usage instructions here
-
-## Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+Please refer to the [notifiable-rails](https://github.com/FutureWorkshops/notifiable-rails) Readme for further information.

data/lib/notifiable/apns/grocer/stream.rb

@@ -1,13 +1,14 @@
 require 'notifiable'
 require 'grocer'
+require 'connection_pool'
 
 module Notifiable
   module Apns
     module Grocer
   		class Stream < Notifiable::NotifierBase
         
-        attr_accessor :sandbox, :certificate, :passphrase
-        
+        attr_accessor :sandbox, :certificate, :passphrase, :connection_pool_size, :connection_pool_timeout
+                
         def close
           super
           @grocer_pusher = nil        
@@ -15,40 +16,45 @@ module Notifiable
         end
       
   			protected      
-  			def enqueue(device_token)        				
+    			def enqueue(device_token)        				
           
-          grocer_notification = ::Grocer::Notification.new(
-            device_token: device_token.token, 
-            alert: notification.message, 
-            custom: notification.send_params
-          )
-            
-  				grocer_pusher.push(grocer_notification) unless Notifiable.delivery_method == :test
+            grocer_notification = ::Grocer::Notification.new(
+              device_token: device_token.token, 
+              alert: notification.message, 
+              custom: notification.send_params
+            )
           
-          # TODO - add errors via enhanced interface
-          #0   - No errors encountered
-          #1   - Processing error
-          #2   - Missing device token
-          #3   - Missing topic
-          #4   - Missing payload
-          #5   - Invalid token size
-          #6   - Invalid topic size
-          #7   - Invalid payload size
-          #8   - Invalid token
-          #255 - None (unknown)
-
-          processed(device_token, 0)
-  			end
+            pusher_pool.with do |pusher|
+              pusher.push(grocer_notification) unless Notifiable.delivery_method == :test
+            end
+                      
+            # assume processed. Errors will be receieved through a callback
+            processed(device_token, 0)
+    			end
       
-        def flush
-          process_feedback unless self.test_env?
-        end
-
-        def sandbox?
-          self.sandbox.eql? "1"
-        end
+          def flush
+            process_feedback unless self.test_env?
+          end
 
-        private        
+        private
+        # override getters with defaults
+          def sandbox
+            @sandbox || "0"
+          end
+          
+          def connection_pool_size
+            @connection_pool_size || 10
+          end
+          
+          def connection_pool_timeout
+            @connection_pool_timeout || 10
+          end
+         
+          def sandbox?
+            sandbox.eql? "1"
+          end
+        
+        # logic     
           def gateway_config 
             {
               certificate: self.certificate,
@@ -68,9 +74,11 @@ module Notifiable
               retries:     3
             }
           end
-        
-          def grocer_pusher
-            @grocer_pusher ||= ::Grocer.pusher(gateway_config)
+          
+          def pusher_pool
+            @pusher_pool ||= ConnectionPool.new(size: connection_pool_size, timeout: connection_pool_timeout) do
+              ::Grocer.pusher(gateway_config)
+            end
           end
       
           def grocer_feedback

data/lib/notifiable/apns/grocer/version.rb

@@ -1,7 +1,7 @@
 module Notifiable
   module Apns
     module Grocer
-      VERSION = "0.9.2"
+      VERSION = "0.10.0"
     end
   end
 end

data/notifiable-apns-grocer.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "notifiable-rails", ">=0.19.0"
   spec.add_dependency "grocer", '~> 0.5.0'
+  spec.add_dependency "connection_pool", '~> 2.0.0'
  
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/spec/{grocer_spec.rb → stream_spec.rb}

@@ -37,14 +37,24 @@ describe Notifiable::Apns::Grocer::Stream do
     }
   end
   
-  it "works using production gateway" do
-    
+  it "can use production gateway" do
     g = Notifiable::Apns::Grocer::Stream.new(Rails.env, n1)
     a.configuration = {:apns => {:sandbox => "0"}} # This is how production is configured
     a.configure(:apns, g)
     
-    expect(g.send(:sandbox?)).to be_false
+    expect(g.send(:sandbox?)).to be_falsey
+  end
+
+  it "has default connection pool size" do
+    g = Notifiable::Apns::Grocer::Stream.new(Rails.env, n1)
+    
+    expect(g.send(:connection_pool_size)).to eq 10 
+  end
+  
+  it "has default connection pool timeout" do
+    g = Notifiable::Apns::Grocer::Stream.new(Rails.env, n1)
     
+    expect(g.send(:connection_pool_timeout)).to eq 10 
   end
   
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: notifiable-apns-grocer
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.10.0
 platform: ruby
 authors:
 - Kamil Kocemba
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-03 00:00:00.000000000 Z
+date: 2014-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: notifiable-rails
@@ -39,6 +39,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 0.5.0
+- !ruby/object:Gem::Dependency
+  name: connection_pool
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -172,8 +186,8 @@ files:
 - lib/notifiable/apns/grocer/version.rb
 - lib/tasks/load_test.rake
 - notifiable-apns-grocer.gemspec
-- spec/grocer_spec.rb
 - spec/spec_helper.rb
+- spec/stream_spec.rb
 - spec/support/db/migrate/20131228225138_create_notifiable_apps.rb
 - spec/support/db/migrate/20131228225139_create_notifiable_device_tokens.rb
 - spec/support/db/migrate/20131228225140_create_notifiable_notifications.rb
@@ -203,8 +217,8 @@ signing_key:
 specification_version: 4
 summary: Plugin to use Grocer for APNS with Notifiable-Rails
 test_files:
-- spec/grocer_spec.rb
 - spec/spec_helper.rb
+- spec/stream_spec.rb
 - spec/support/db/migrate/20131228225138_create_notifiable_apps.rb
 - spec/support/db/migrate/20131228225139_create_notifiable_device_tokens.rb
 - spec/support/db/migrate/20131228225140_create_notifiable_notifications.rb