notifi 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6e4a2d1542811e1450438e3baa0c53957d661b62
-  data.tar.gz: a2631e6d89dbae06477ab1faca312fe456aa011a
+  metadata.gz: cad2891de7b3d0be5b2de35d439e43063b6f9fdf
+  data.tar.gz: d62130642a7e75f6737a8416c4e9091d3346673b
 SHA512:
-  metadata.gz: cad3a752693240a9e9278200efc7c8bab0706a3c621add50560aed32870cf3982e6cfb737ed394c13a0c9c7dc32294d53e31c6ceff1306595fc3647a763ff699
-  data.tar.gz: 6218e9a86974f9d5ad83927c9b05e95a1a6eaeb3838efd007f283efa0ef60f3446043ce4ec43c0ae08fcde983a923b25e954022dbbb457a5f118e70745a0f43d
+  metadata.gz: 78ffb1d52cc79ca4b0c878d201a3c9f9644ea6b8f4e568e3d25612e984927d1e9d0bcf5e2eb3aa9f764ac9901f0e6fdee3fe2c7d96746d0011c1205e2dbb9730
+  data.tar.gz: eaceb32d9e479ec444b9a0041d1c7162d2a20d7a0767c387cb038107f2d48b44846d9247615f9ebba2059cf6c633fcb3ca3193cdbca3eb47dbcdd55feb9fcc3b

data/lib/notifi/subscription.rb

@@ -8,12 +8,17 @@ module Notifi
     has_many :notifications, dependent: :destroy, inverse_of: :subscription
 
     def notify(event=:default, notifier=nil, set: {})
-      set[:subscription] = self
-      set[:notifier] = notifier
-      set[:subscriber] = self.subscriber
-      set[:subscribable] = self.subscribable
+      # TODO I wanted to do this in the subscribable notify method so you could
+      # still forceably notifiy the notifier, but for the life of me I couldn't
+      # get it to work.
+      if notifier != self.subscriber
+        set[:subscription] = self
+        set[:notifier] = notifier
+        set[:subscriber] = self.subscriber
+        set[:subscribable] = self.subscribable
 
-      self.notification_class(event).create(set)
+        self.notification_class(event).create(set)
+      end
     end
 
     def subscribable_options

data/lib/notifi/version.rb

@@ -1,3 +1,3 @@
 module Notifi
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/subscribable_spec.rb

@@ -17,13 +17,22 @@ describe 'subscribable' do
 
   it 'should be able to provide a notifier' do
     user = User.create
-    comment = Comment.create
+    notifier = User.create
 
-    user.subscribe_to comment
+    user.subscribe_to subscribable
 
-    comment.notify(notifier: user)
+    subscribable.notify(notifier: notifier)
 
-    user.notifications.first.notifier.should eq user
+    user.notifications.first.notifier.should eq notifier
+  end
+
+  it 'should not notify the notifier' do
+    notifier = User.create
+    notifier.subscribe_to subscribable
+
+    subscribable.notify(notifier: notifier)
+
+    notifier.notifications.empty?.should be true
   end
 
   context 'custom notifications' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: notifi
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Hunter Haydel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-19 00:00:00.000000000 Z
+date: 2013-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid