noticed 2.6.0 → 2.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04e620f63d7f92b5220c39fa3bb848d8c8905b39a93e8d5c32b7d904f462e694
-  data.tar.gz: 43e89757c72ea2475171a080a2ff0881100e229298bfa63d8b816e17e44aa5cd
+  metadata.gz: 97bfcc3bd0808b9ec095996a5076483fcbd52b34876bcdb5a07c0d81976089e5
+  data.tar.gz: b8f52c48beb1de00e6f0a8cf90e136697ddb06ef41cc21da70462191f586dc49
 SHA512:
-  metadata.gz: 444c47faf233395d77b9ccb003a99f8e45768298f27eac35318f36f5f385ee5ca76f91bbd189e92e3bfb7e50f2ffdaec58ea87e42a6f68c6e5d8e4ee6a61baaf
-  data.tar.gz: aeea21827f7eb7071ad482babe06a130a69b27190b15ada99bf3727fa522eb75c4fb8d460d28234f604177a11ae3c34f4a3b6a0c218aebe7d7538577aa1cc465
+  metadata.gz: 7eda93498c3441412df68ffc1b5d52e587ba6367ed77577976ef9dd90264e4c5651c6e7352403fb3116eebdb7795e766eda59c01515cf156e07f9121b64fe4c5
+  data.tar.gz: 3b12968aaf984955272136b55ad19b050dabddcb93cb0ddeb0a82f3d89022e49f4538d1cb35d4e3da3274e85245d6a3a2113642b83582020b346c64897940a7e

data/app/models/noticed/ephemeral.rb

@@ -59,3 +59,5 @@ module Noticed
     end
   end
 end
+
+ActiveSupport.run_load_hooks :noticed_ephemeral, Noticed::Ephemeral

data/app/models/noticed/event.rb

@@ -24,3 +24,5 @@ module Noticed
     end
   end
 end
+
+ActiveSupport.run_load_hooks :noticed_ephemeral, Noticed::Event

data/app/models/noticed/notification.rb

@@ -12,3 +12,5 @@ module Noticed
     delegate :params, :record, to: :event
   end
 end
+
+ActiveSupport.run_load_hooks :noticed_ephemeral, Noticed::Notification

data/lib/noticed/bulk_delivery_methods/slack.rb

@@ -10,8 +10,8 @@ module Noticed
         json = evaluate_option(:json)
         response = post_request url, headers: headers, json: json
 
-        if raise_if_not_ok?
-          raise ResponseUnsuccessful.new(response, url, {headers: headers, json: json}) unless JSON.parse(response.body)["ok"]
+        if raise_if_not_ok? && !success?(response)
+          raise ResponseUnsuccessful.new(response, url, {headers: headers, json: json})
         end
 
         response
@@ -23,7 +23,16 @@ module Noticed
 
       def raise_if_not_ok?
         value = evaluate_option(:raise_if_not_ok)
-        value.nil? ? true : value
+        value.nil? || value
+      end
+
+      def success?(response)
+        if response.content_type == "application/json"
+          JSON.parse(response.body).dig("ok")
+        else
+          # https://api.slack.com/changelog/2016-05-17-changes-to-errors-for-incoming-webhooks
+          response.is_a?(Net::HTTPSuccess)
+        end
       end
     end
   end

data/lib/noticed/delivery_methods/fcm.rb

@@ -16,7 +16,7 @@ module Noticed
           headers: {authorization: "Bearer #{access_token}"},
           json: format_notification(device_token))
       rescue Noticed::ResponseUnsuccessful => exception
-        if exception.response.code == "404" && config[:invalid_token]
+        if bad_token?(exception.response) && config[:invalid_token]
           notification.instance_exec(device_token, &config[:invalid_token])
         else
           raise
@@ -32,6 +32,10 @@ module Noticed
         end
       end
 
+      def bad_token?(response)
+        response.code == "404" || response.code == "400"
+      end
+
       def credentials
         @credentials ||= begin
           value = evaluate_option(:credentials)

data/lib/noticed/delivery_methods/slack.rb

@@ -10,8 +10,8 @@ module Noticed
         json = evaluate_option(:json)
         response = post_request url, headers: headers, json: json
 
-        if raise_if_not_ok?
-          raise ResponseUnsuccessful.new(response, url, {headers: headers, json: json}) unless JSON.parse(response.body)["ok"]
+        if raise_if_not_ok? && !success?(response)
+          raise ResponseUnsuccessful.new(response, url, {headers: headers, json: json})
         end
 
         response
@@ -23,7 +23,16 @@ module Noticed
 
       def raise_if_not_ok?
         value = evaluate_option(:raise_if_not_ok)
-        value.nil? ? true : value
+        value.nil? || value
+      end
+
+      def success?(response)
+        if response.content_type == "application/json"
+          JSON.parse(response.body).dig("ok")
+        else
+          # https://api.slack.com/changelog/2016-05-17-changes-to-errors-for-incoming-webhooks
+          response.is_a?(Net::HTTPSuccess)
+        end
       end
     end
   end

data/lib/noticed/version.rb

@@ -1,3 +1,3 @@
 module Noticed
-  VERSION = "2.6.0"
+  VERSION = "2.6.1"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: noticed
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 2.6.1
 platform: ruby
 authors:
 - Chris Oliver
 bindir: bin
 cert_chain: []
-date: 2025-01-16 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -99,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Notifications for Ruby on Rails applications
 test_files: []