noticed 1.6.2 → 1.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 061ed935e699ea448343624ca8df81a5d884446616e9c613a46c19dafd7322e3
-  data.tar.gz: a358b5c5d96adf95277510eaad75a65c4e579418d80d7daadb35b0315d5010f2
+  metadata.gz: dca9fddb81724156c172bcb7ac9bdcbc7d3571554dd3b906d3df02395c730b23
+  data.tar.gz: 5a8676aa3224c61b6623b81db22aecde7fa175c5514da465dfd735269b91394a
 SHA512:
-  metadata.gz: 7c7768341c6aa1183d872447ff1da9d28b6f45548c5203ab99bf08588909995fbc05557dc55aa54265fd328b85ed1fc234c8cf9b33af1e6937adad2cc0c865b4
-  data.tar.gz: d817b2475b44d40fed4d4b456dff9b16f21f7a6d0a5cfc65c2e242347312e2614c473da213378ae7e8d134a8eb9a8c3d433362d46af058a19b6f708d84fbca20
+  metadata.gz: 582f1a4e7282af29b7a66fcf322f13e2af6880757a3871a7cb74a44b3cc5fb9de6e404e5a62d78349cd7283caab14445bb63a508595878d98cadc352ea8bcbc1
+  data.tar.gz: 3764af8b5240a7b7de561512086497ea60ff9fecb1ff49d85ce2ea42509b97188519a97d9e05c884e0d48aebbfdca3cb27022b88347160e066942fd00b191ec5

data/README.md

@@ -109,7 +109,7 @@ end
 * `if: :method_name`  - Calls `method_name` and cancels delivery method if `false` is returned
 * `unless: :method_name`  - Calls `method_name` and cancels delivery method if `true` is returned
 * `delay: ActiveSupport::Duration` - Delays the delivery for the given duration of time
-* `delay: :method_name` - Calls `method_name which should return an `ActiveSupport::Duration` and delays the delivery for the given duration of time
+* `delay: :method_name` - Calls `method_name` which should return an `ActiveSupport::Duration` and delays the delivery for the given duration of time
 
 ##### Helper Methods
 

data/lib/generators/noticed/model/base_generator.rb

@@ -16,7 +16,6 @@ module Noticed
         argument :attributes, type: :array, default: [], banner: "field:type field:type"
 
         def generate_notification
-          binding.irb
           generate :model, name, "recipient:references{polymorphic}", "type", "params:#{json_column_type}", "read_at:datetime:index", *attributes
         end
 

data/lib/noticed/delivery_methods/base.rb

@@ -6,7 +6,7 @@ module Noticed
 
       class_attribute :option_names, instance_writer: false, default: []
 
-      attr_reader :notification, :options, :params, :recipient, :record
+      attr_reader :notification, :options, :params, :recipient, :record, :logger
 
       class << self
         # Copy option names from parent
@@ -36,6 +36,9 @@ module Noticed
         @recipient = args[:recipient]
         @record = args[:record]
 
+        # Set the default logger
+        @logger = @options.fetch(:logger, Rails.logger)
+
         # Make notification aware of database record and recipient during delivery
         @notification.record = args[:record]
         @notification.recipient = args[:recipient]
@@ -65,7 +68,6 @@ module Noticed
       #   post("http://example.com", basic_auth: {user:, pass:}, headers: {}, json: {}, form: {})
       #
       def post(url, args = {})
-        options ||= {}
         basic_auth = args.delete(:basic_auth)
         headers = args.delete(:headers)
 
@@ -76,8 +78,8 @@ module Noticed
         response = request.post(url, args)
 
         if options[:debug]
-          Rails.logger.debug("POST #{url}")
-          Rails.logger.debug("Response: #{response.code}: #{response}")
+          logger.debug("POST #{url}")
+          logger.debug("Response: #{response.code}: #{response}")
         end
 
         if !options[:ignore_failure] && !response.status.success?

data/lib/noticed/version.rb

@@ -1,3 +1,3 @@
 module Noticed
-  VERSION = "1.6.2"
+  VERSION = "1.6.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: noticed
 version: !ruby/object:Gem::Version
-  version: 1.6.2
+  version: 1.6.3
 platform: ruby
 authors:
 - Chris Oliver
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-28 00:00:00.000000000 Z
+date: 2023-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails