notable 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 91975df22291af40ac05c843a010f31596265d0d079b425bdd3c67e6a39cfc33
-  data.tar.gz: 6545cf681ab0754e5ca2c53dca09f604dc4a8ea83fa54a2fe0e0ae7386814d08
+  metadata.gz: 5541640f476e0e97318e6767a54afaa5cdeb0d35891372f87eef3d528e5ceaaa
+  data.tar.gz: 8d16fd5688ad556b83c72ab9787ccac3fb2c0ba55468a3d6c829a4166110e64a
 SHA512:
-  metadata.gz: be3f75a95fba1891c522b206f6810565930b963393fec88326ff4b9dde63ec338be9fd45a8ff2b697781f2b1d4270a9619476b5266fe2f60bc6232d8c19bd8ee
-  data.tar.gz: eb6f5b4dc56aa25df22a5fa628fb689f2fe78244826ad542deb85694ff4927438abfd475d6fd3ba4187ce3fc00d5e7aa4b8d81d7d4446d5e6e35c15abc150224
+  metadata.gz: ba086c17aa9de949c21349d6c754addb8de84f31635b3a57f7a52bce63aee66cce22476926c347a231456f4cd837765c83543636624f61237e197f5896ec227c
+  data.tar.gz: 135bebfd4c0acfa206d6acd39099040db35a90c98b5b13fe01e056253e953e685fe6ad00836a98e8443d412324d7e517ead6332ed2332f6c891b2a7dd146bb9c

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.6.1 (2026-02-07)
+
+- Added `scrub_invalid_utf8` option
+- Improved handling of invalid parameters
+
 ## 0.6.0 (2025-04-03)
 
 - Dropped support for Ruby < 3.2 and Rails < 7.1

data/README.md

@@ -1,7 +1,5 @@
 # Notable
 
-:star2: :star2: :star2:
-
 Notable tracks notable requests and background jobs and stores them in your database.  What makes a request or job notable? There are a number of default situations, but ultimately you decide what interests you.
 
 By default, Notable tracks:
@@ -108,6 +106,12 @@ Anonymize IP addresses
 Notable.mask_ips = true
 ```
 
+Scrub invalid UTF-8 from data
+
+```ruby
+Notable.scrub_invalid_utf8 = true
+```
+
 ### Jobs
 
 Set slow threshold

data/lib/notable/engine.rb

@@ -6,7 +6,7 @@ module Notable
       if Notable.requests_enabled?
         # insert in same place as request_store
         app.config.middleware.insert_after ActionDispatch::RequestId, Notable::Middleware
-        # TODO switch to register_interceptor in 0.6.0
+        # TODO switch to register_interceptor in 0.7.0
         ActionDispatch::DebugExceptions.prepend Notable::DebugExceptions
       end
     end

data/lib/notable/middleware.rb

@@ -10,8 +10,7 @@ module Notable
       request_time = Notable.monotonic_time - start_time
 
       Safely.safely do
-        if env["action_dispatch.exception"]
-          e = env["action_dispatch.exception"]
+        if (e = env["action_dispatch.exception"]) && (!defined?(ActionController::TooManyRequests) || !e.is_a?(ActionController::TooManyRequests))
           message =
             case status.to_i
             when 404
@@ -37,11 +36,19 @@ module Notable
           url = request.original_url
 
           controller = env["action_controller.instance"]
-          action = controller && "#{controller.params["controller"]}##{controller.params["action"]}"
-          params = controller && controller.request.filtered_parameters.except("controller", "action")
+          action = controller && "#{controller.controller_path}##{controller.action_name}"
+          params = controller && (controller.request.filtered_parameters.except("controller", "action") rescue nil)
 
           user = Notable.user_method.call(env)
 
+          user_agent = request.user_agent
+          referrer = request.referer
+
+          if Notable.scrub_invalid_utf8
+            user_agent = user_agent.scrub
+            referrer = referrer.scrub
+          end
+
           notes.each do |note|
             ip = request.remote_ip
             if ip && Notable.mask_ips
@@ -57,9 +64,9 @@ module Notable
               params: params,
               request_id: request.uuid,
               ip: ip,
-              user_agent: request.user_agent,
+              user_agent: user_agent,
               url: url,
-              referrer: request.referer,
+              referrer: referrer,
               request_time: request_time
             }
             Notable.track_request_method.call(data, env)

data/lib/notable/throttle.rb

@@ -5,3 +5,8 @@ ActiveSupport::Notifications.subscribe "rack.attack" do |_name, _start, _finish,
     Notable.track "Throttle", request.env["rack.attack.matched"]
   end
 end
+
+# TODO uncomment in 0.7.0
+# ActiveSupport::Notifications.subscribe "rate_limit.action_controller" do |_|
+#   Notable.track "Throttle", "throttle note"
+# end

data/lib/notable/version.rb

@@ -1,3 +1,3 @@
 module Notable
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

data/lib/notable.rb

@@ -22,6 +22,7 @@ module Notable
     attr_accessor :user_method
     attr_accessor :slow_request_threshold
     attr_accessor :mask_ips
+    attr_accessor :scrub_invalid_utf8
 
     # jobs
     attr_accessor :track_job_method
@@ -31,6 +32,8 @@ module Notable
   self.requests_enabled = true
   self.jobs_enabled = true
   self.mask_ips = false
+  # TODO default to true in 0.7.0
+  self.scrub_invalid_utf8 = false
 
   def self.requests_enabled?
     enabled && requests_enabled

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: notable
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Andrew Kane
 bindir: bin
 cert_chain: []
-date: 2025-04-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -79,7 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Track notable requests and background jobs
 test_files: []