norman-has_image 0.2.0 → 0.2.2

data/CHANGELOG

@@ -1,5 +1,18 @@
+2008-09-10 Norman Clarke <norman@randomba.org>
+  * Fixed images not being converted to target format.
+  
+2008-08-29 Norman Clarke <norman@randomba.org>
+  * Fixed bad call to has_image_file
+  
 2008-08-28 Norman Clarke <norman@randomba.org>
   * Added ability to regenerate a model's thumbnails.
+  * Changed a few methods in storage to accept the model rather than the id.
+    This makes storage more hackable as regards generating paths and file names.
+  * Added "has_image_id" method to model instance methods to facilitate
+    grouping the images under a directory structure based on a related model's
+    ids.
+  * Made the generated file name simply by the image object's id - this
+    is better adherance to the principle of least surprise.
 
 2008-08-25 Norman Clarke <norman@randomba.org>
   * Fixed bad call to resize_to in view helper.

data/lib/has_image/storage.rb

@@ -140,9 +140,8 @@ module HasImage
     def install_main_image(id, name)
       FileUtils.mkdir_p path_for(id)
       main = processor.resize(@temp_file, @options[:resize_to])
-      main.tempfile.close
       file = File.open(File.join(path_for(id), file_name_for(name)), "w")
-      file.write(IO.read(main.tempfile.path))
+      file.write(IO.read(main.path))
       file.close
       main.tempfile.close!
     end

data/lib/has_image.rb

@@ -236,7 +236,7 @@ module HasImage
     def update_images
       return if storage.temp_file.blank?
       remove_images
-      update_attribute(:has_image_file, storage.install_images(has_image_id))      
+      update_attribute(:has_image_file, storage.install_images(self))      
     end
 
     # Processes and installs the image and its thumbnails.

data/test/processor_test.rb

@@ -1,4 +1,4 @@
-require 'test_helper.rb'
+require File.dirname(__FILE__) + '/test_helper.rb'
 
 class StorageTest < Test::Unit::TestCase
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: norman-has_image
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors: 
 - Norman Clarke
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-08-28 00:00:00 -07:00
+date: 2008-09-10 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency