nori 2.7.0 → 2.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6515a0d2251bf29125e62c2d84f2af5a8476bd61e034366a5a648e50cf828f82
-  data.tar.gz: 68cff0141890e2bbc25318a6661a0b575d8920728455db6140cc17857434a798
+  metadata.gz: e562b494afc72df387f136e51af0c5e0445b528b5515eedad7f60b3d49d207a5
+  data.tar.gz: 5eabad83b50392e39973058c70d6307ddaaeea47934c292fbd472ee0f93680f9
 SHA512:
-  metadata.gz: 54053888a425e88dc43628927d911e3eb1c087d86d5140febe0ca0a3acc21eacb156a9ae43a1e609b20a89d83eb13f360c15ecb7bc3d70208b00088ea92e7b4c
-  data.tar.gz: 3d3c2eb4b821d260198fa223dfd1c186d17e821cbeea1741284af38216b397a1ac6c6e49f9d18963c0638ed09163e300f2f017dca718aa3bda07704d1d30dc5a
+  metadata.gz: 6366a2ac0d9dd99e4fd7b0f32d95dfb21f76885ab18fc7f3f7767c5e257b61e3817d2bf13f9a113feb2482fdb6f5a912956ef5d17a3f868a9139e9b55683402f
+  data.tar.gz: cf295850b06961ed67644a8c06c61152cecf5c8512f8a74a03115e47fe8f9a567300d9af8d91504013777400882869cb7016c80563015e6423e86718c7b828bd

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.7.1 (2024-07-28)
+
+* Stop monkey-patching String with #snakecase by @mchu in https://github.com/savonrb/nori/pull/102
+
 # 2.7.0 (2024-02-13)
 
 * Added support for ruby 3.1, 3.2, 3.3. Dropped support for ruby 2.7 and below.
@@ -12,6 +16,20 @@
 # 2.5.0 (2015-03-31)
 
 * Formally drop support for ruby 1.8.7. Installing Nori from rubygems for that version should no longer attempt to install versions that will not work.
+* BREAKING CHANGE: Newlines are now preserved when present in the value of inner text nodes. See the example below:
+
+before:
+
+```
+Nori.new.parse("<outer>\n&lt;embedded&gt;\n&lt;one&gt;&lt;/one&gt;\n&lt;two&gt;&lt;/two&gt;\n&lt;embedded&gt;\n</outer>")
+=> {"outer"=>"<embedded><one></one><two></two><embedded>"}
+```
+
+after:
+```
+Nori.new.parse("<outer>\n&lt;embedded&gt;\n&lt;one&gt;&lt;/one&gt;\n&lt;two&gt;&lt;/two&gt;\n&lt;embedded&gt;\n</outer>")
+=> {"outer"=>"<embedded>\n<one></one>\n<two></two>\n<embedded>\n"}
+```
 
 # 2.4.0 (2014-04-19)
 

data/README.md

@@ -89,7 +89,7 @@ Nori lets you specify a custom formula to convert XML tags to Hash keys using `c
 Nori.new.parse('<userResponse><accountStatus>active</accountStatus></userResponse>')
 # => {"userResponse"=>{"accountStatus"=>"active"}}
 
-parser = Nori.new(:convert_tags_to => lambda { |tag| tag.snakecase.to_sym })
+parser = Nori.new(:convert_tags_to => lambda { |tag| Nori::StringUtils.snakecase(tag).to_sym })
 parser.parse('<userResponse><accountStatus>active</accountStatus></userResponse>')
 # => {:user_response=>{:account_status=>"active"}}
 ```

data/lib/nori/core_ext/hash.rb

@@ -27,7 +27,7 @@ class Nori
       #     #=> 'one="1" two="TWO"'
       def to_xml_attributes
         map do |k, v|
-          %{#{k.to_s.snakecase.sub(/^(.{1,1})/) { |m| m.downcase }}="#{v}"}
+          %{#{StringUtils.snakecase(k.to_s).sub(/^(.{1,1})/) { |m| m.downcase }}="#{v}"}
         end.join(' ')
       end
 

data/lib/nori/core_ext.rb

@@ -1,2 +1,2 @@
-require "nori/core_ext/string"
+require "nori/string_utils"
 require "nori/core_ext/hash"

data/lib/nori/string_utils.rb

@@ -0,0 +1,18 @@
+class Nori
+  module StringUtils
+    # Converts a string to snake case.
+    #
+    # @param inputstring [String] The string to be converted to snake case.
+    # @return [String] A copy of the input string converted to snake case.
+    def self.snakecase(inputstring)
+      str = inputstring.dup
+      str.gsub!(/::/, '/')
+      str.gsub!(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
+      str.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
+      str.tr!(".", "_")
+      str.tr!("-", "_")
+      str.downcase!
+      str
+    end
+  end
+end

data/lib/nori/version.rb

@@ -1,3 +1,3 @@
 class Nori
-  VERSION = '2.7.0'
+  VERSION = '2.7.1'
 end

data/spec/nori/api_spec.rb

@@ -55,7 +55,7 @@ describe Nori do
     it "converts all tags by a given formula" do
       xml = '<userResponse id="1"><accountStatus>active</accountStatus></userResponse>'
 
-      snakecase_symbols = lambda { |tag| tag.snakecase.to_sym }
+      snakecase_symbols = lambda { |tag| Nori::StringUtils.snakecase(tag).to_sym }
       nori = nori(:convert_tags_to => snakecase_symbols)
 
       expect(nori.parse(xml)).to eq({ :user_response => { :@id => "1", :account_status => "active" } })

data/spec/nori/string_utils_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+
+describe Nori::StringUtils do
+
+  describe ".snakecase" do
+    it "lowercases one word CamelCase" do
+      expect(Nori::StringUtils.snakecase("Merb")).to eq("merb")
+    end
+
+    it "makes one underscore snakecase two word CamelCase" do
+      expect(Nori::StringUtils.snakecase("MerbCore")).to eq("merb_core")
+    end
+
+    it "handles CamelCase with more than 2 words" do
+      expect(Nori::StringUtils.snakecase("SoYouWantContributeToMerbCore")).to eq("so_you_want_contribute_to_merb_core")
+    end
+
+    it "handles CamelCase with more than 2 capital letter in a row" do
+      expect(Nori::StringUtils.snakecase("CNN")).to eq("cnn")
+      expect(Nori::StringUtils.snakecase("CNNNews")).to eq("cnn_news")
+      expect(Nori::StringUtils.snakecase("HeadlineCNNNews")).to eq("headline_cnn_news")
+    end
+
+    it "does NOT change one word lowercase" do
+      expect(Nori::StringUtils.snakecase("merb")).to eq("merb")
+    end
+
+    it "leaves snake_case as is" do
+      expect(Nori::StringUtils.snakecase("merb_core")).to eq("merb_core")
+    end
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nori
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.7.1
 platform: ruby
 authors:
 - Daniel Harrington
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-02-13 00:00:00.000000000 Z
+date: 2024-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -89,18 +89,18 @@ files:
 - lib/nori.rb
 - lib/nori/core_ext.rb
 - lib/nori/core_ext/hash.rb
-- lib/nori/core_ext/string.rb
 - lib/nori/parser/nokogiri.rb
 - lib/nori/parser/rexml.rb
 - lib/nori/string_io_file.rb
+- lib/nori/string_utils.rb
 - lib/nori/string_with_attributes.rb
 - lib/nori/version.rb
 - lib/nori/xml_utility_node.rb
 - nori.gemspec
 - spec/nori/api_spec.rb
 - spec/nori/core_ext/hash_spec.rb
-- spec/nori/core_ext/string_spec.rb
 - spec/nori/nori_spec.rb
+- spec/nori/string_utils_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/savonrb/nori
 licenses:

data/lib/nori/core_ext/string.rb

@@ -1,21 +0,0 @@
-class Nori
-  module CoreExt
-    module String
-
-      # Returns the String in snake_case.
-      def snakecase
-        str = dup
-        str.gsub!(/::/, '/')
-        str.gsub!(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
-        str.gsub!(/([a-z\d])([A-Z])/, '\1_\2')
-        str.tr! ".", "_"
-        str.tr! "-", "_"
-        str.downcase!
-        str
-      end unless method_defined?(:snakecase)
-
-    end
-  end
-end
-
-String.send :include, Nori::CoreExt::String

data/spec/nori/core_ext/string_spec.rb

@@ -1,33 +0,0 @@
-require "spec_helper"
-
-describe String do
-
-  describe "#snakecase" do
-    it "lowercases one word CamelCase" do
-      expect("Merb".snakecase).to eq("merb")
-    end
-
-    it "makes one underscore snakecase two word CamelCase" do
-      expect("MerbCore".snakecase).to eq("merb_core")
-    end
-
-    it "handles CamelCase with more than 2 words" do
-      expect("SoYouWantContributeToMerbCore".snakecase).to eq("so_you_want_contribute_to_merb_core")
-    end
-
-    it "handles CamelCase with more than 2 capital letter in a row" do
-      expect("CNN".snakecase).to eq("cnn")
-      expect("CNNNews".snakecase).to eq("cnn_news")
-      expect("HeadlineCNNNews".snakecase).to eq("headline_cnn_news")
-    end
-
-    it "does NOT change one word lowercase" do
-      expect("merb".snakecase).to eq("merb")
-    end
-
-    it "leaves snake_case as is" do
-      expect("merb_core".snakecase).to eq("merb_core")
-    end
-  end
-
-end