noodall-form-builder 0.1.3 → 0.2.0

data/app/controllers/noodall/form_responses_controller.rb

@@ -18,7 +18,9 @@ module Noodall
       respond_to do |format|
         if @form_response.valid? and @form_response.save
 
-          unless @form_response.is_spam?
+          if @form_response.is_spam?
+            logger.info "Form response was deemed to be spam: #{@form_response.inspect}"
+          else
             begin
               # mail the response to the form recipient
               FormMailer.form_response(@form, @form_response).deliver unless @form.email.blank?

data/app/models/noodall/form_response.rb

@@ -1,6 +1,6 @@
 module Noodall
   class FormResponse
-    include MongoMapper::EmbeddedDocument
+    include MongoMapper::Document
 
     key :name, String
     key :email, String, :format => /.+\@.+\..+/
@@ -11,14 +11,14 @@ module Noodall
     key :defensio_signature, String
     key :spaminess, Float, :default => 0
 
-    def required_fields
-      self.form.fields.select{ |f| f.required? }
-    end
-
     before_save :check_for_spam
     attr_protected :approved
 
-    embedded_in :form
+    belongs_to :form, :class => Noodall::Form, :foreign_key => 'noodall_form_id'
+
+    def required_fields
+      self.form.fields.select{ |f| f.required? }
+    end
 
     def approve!
       self.approved = true
@@ -41,9 +41,9 @@ module Noodall
       value = self.send(name)
 
       if value.is_a?(Array)
-        "[#{value.join(', ')}]"
+        value.join(', ')
       else
-        "Val: #{value}"
+        value.to_s
       end
     end
 
@@ -54,8 +54,8 @@ module Noodall
         return unless status == 200
 
         self.defensio_signature = response['signature']
-        self.spaminess = response['spaminess'] || 0
-        self.approved = response['allow'] || false
+        self.spaminess = response['spaminess']
+        self.approved = response['allow']
       end
     end
 

data/features/step_definitions/form_builder_steps.rb

@@ -53,13 +53,9 @@ end
 
 Given /^a form exists that has had many responses$/ do
   form = Factory(:form)
-
-  responses = []
-  9.times do |i|
-    responses << Factory(:response)
+  9.times do
+    Factory(:response, :form => form)
   end
-  form.responses = responses
-  form.save!
 end
 
 When /^I click "([^\"]*)" on the forms row in the Form List$/ do |arg1|
@@ -192,7 +188,7 @@ end
 When /^a form response is deemed to be spam$/ do
   When %{a website visitor visits the content}
   defensio_dummy = double("defensio dummy")
-  defensio_dummy.stub(:post_document){ [200, {'spaminess' => 1}] }
+  defensio_dummy.stub(:post_document){ [200, {'spaminess' => 1, "allow" => false}] }
 
   Noodall::FormResponse.stub(:defensio).and_return(defensio_dummy)
   When %{they fill in and submit the form}

data/features/support/defensio_mock.rb

@@ -1,6 +1,8 @@
 Before do
   defensio_dummy = double("defensio dummy")
-  defensio_dummy.stub(:post_document){ [200, {:spaminess => 0.2}] }
+  defensio_dummy.stub(:post_document) do
+    [200, {"spaminess" => 0.2, "allow" => true}]
+  end
 
   Noodall::FormResponse.stub(:defensio).and_return(defensio_dummy)
 end

data/features/support/env.rb

@@ -49,4 +49,5 @@ Factory.find_definitions
 
 require 'factory_girl/step_definitions'
 require 'csv' #for checking CSV content
+require 'ruby-debug'
 

data/lib/noodall/form_builder/version.rb

@@ -1,5 +1,5 @@
 module Noodall
   module FormBuilder
-    VERSION = "0.1.3"
+    VERSION = "0.2.0"
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: noodall-form-builder
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 23
   prerelease: 
   segments: 
   - 0
-  - 1
-  - 3
-  version: 0.1.3
+  - 2
+  - 0
+  version: 0.2.0
 platform: ruby
 authors: []
 
@@ -15,11 +15,13 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-16 00:00:00 +00:00
+date: 2011-04-20 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  name: bundler
+  prerelease: false
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -30,12 +32,12 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  name: bundler
-  prerelease: false
-  version_requirements: *id001
   type: :development
+  requirement: *id001
 - !ruby/object:Gem::Dependency 
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  name: fastercsv
+  prerelease: false
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -44,10 +46,8 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  name: fastercsv
-  prerelease: false
-  version_requirements: *id002
   type: :runtime
+  requirement: *id002
 description: Functionality for building custom forms
 email: []