nonnative 1.59.1 → 1.60.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a2c4751f90acdfd5c610819ec3c6400c06ef5565a21a57de76ca934e0ae4c4c
-  data.tar.gz: 0543d81897672535887ded26db0631b03868ee465dfe0a1361795da890223f12
+  metadata.gz: 6020ea5cff78072f14de7b11b17af9db8c4be430ed98093b3251c45f72d51767
+  data.tar.gz: c8f94ee98cc1d2e6424d96fb4359bf851bec9133bb87e2250fb8905608bee6fa
 SHA512:
-  metadata.gz: 92d476f0b27e5524b7698846b25b7cd4dd761582784dc53124093bb0c6bff31f8dec73869685a43e77de00d826204fe55d7bcd0644b83a5bbdae27a9add43e36
-  data.tar.gz: b2bbaa52ee9e45e36c5903f5989ab1100c3f4c23a49e344f2fa287bc870e98d206c956d94c5af75be7136880b1a50294846dba314e081bf6562cef1ccc999c0d
+  metadata.gz: 505eefe99b975f2650ec1b805fdbb5c4dcd068103bea0698ecbfcba26985c53204ae75fa55a943d2d8dfbe0c6cf99748bb2999e4b7d4f07cc150bdf652fb8852
+  data.tar.gz: 6fbcc4ba9f618a6a1ed9fc910b379382cc4100112e18e3174739fb9f68f4a4f0fa7da01e93735440a00c6bd774af68f33db0b63af7a154f61ac025bcb7372f93

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.60.0](https://github.com/alexfalkowski/nonnative/compare/v1.59.1...v1.60.0) (2022-04-25)
+
+
+### Features
+
+* remove strategy to allow finer control in features. ([#119](https://github.com/alexfalkowski/nonnative/issues/119)) ([60b8310](https://github.com/alexfalkowski/nonnative/commit/60b8310ab8ae2a2761d867ab169f8ad5bbbed416))
+
 ### [1.59.1](https://github.com/alexfalkowski/nonnative/compare/v1.59.0...v1.59.1) (2022-04-25)
 
 ## [1.59.0](https://github.com/alexfalkowski/nonnative/compare/v1.58.2...v1.59.0) (2022-04-25)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nonnative (1.59.1)
+    nonnative (1.60.0)
       concurrent-ruby (~> 1.0, >= 1.0.5)
       cucumber (>= 7, < 8)
       get_process_mem (~> 0.2.1)

data/README.md

@@ -43,13 +43,9 @@ Configure nonnative with the following:
 ### Strategy
 
 The strategy can be one of the following values:
-- startup - will start the process once.
-- before - will hook into cucumbers Before and After.
-- manual - do this manually
-
-This can be overridden by the following environment variables:
-- NONNATIVE_STRATEGY - Set this to override what is set in the config.
-- NONNATIVE_TIMEOUT - Set this (in seconds, e.g 5) to override what is set in the config.
+- startup - When we include `nonnative/startup`, it will start it once.
+- before - When we tag our features with `@startup` it will start and stop after the scenario.
+- manual - When we tag our features with `@manual` it will stop after the scenario.
 
 ### Processes
 
@@ -61,12 +57,10 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.process do |p|
     p.name = 'start_1'
     p.command = -> { 'features/support/bin/start 12_321' }
-    p.timeout = config.strategy.timeout
+    p.timeout = 5
     p.port = 12_321
     p.log = 'features/logs/12_321.log'
     p.signal = 'INT' # Possible values are described in Signal.list.keys.
@@ -89,7 +83,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 processes:
   -
     name: start_1
@@ -157,8 +150,6 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.server do |s|
     s.name = 'server_1'
     s.klass = Nonnative::EchoServer
@@ -181,7 +172,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 servers:
   -
     name: server_1
@@ -239,8 +229,6 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.server do |s|
     s.name = 'http_server_1'
     s.klass = Nonnative::Features::HTTPServer
@@ -255,7 +243,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 servers:
   -
     name: http_server_1
@@ -303,8 +290,6 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.server do |s|
     s.name = 'grpc_server_1'
     s.klass = Nonnative::Features::GRPCServer
@@ -319,7 +304,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 servers:
   -
     name: grpc_server_1
@@ -349,8 +333,6 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.service do |s|
     s.name = 'postgres'
     p.port = 5432
@@ -367,7 +349,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 processes:
   -
     name: postgres
@@ -401,8 +382,6 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.process do |p|
     p.proxy = {
       type: 'fault_injection',
@@ -420,7 +399,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 processes:
   -
     proxy:
@@ -439,8 +417,6 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.server do |s|
     s.proxy = {
       type: 'fault_injection',
@@ -458,7 +434,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 servers:
   -
     proxy:
@@ -477,8 +452,6 @@ Setup it up programmatically:
 require 'nonnative'
 
 Nonnative.configure do |config|
-  config.strategy = :startup
-
   config.service do |s|
     s.proxy = {
       type: 'fault_injection',
@@ -496,7 +469,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 services:
   -
     proxy:
@@ -605,7 +577,6 @@ Setup it up through configuration:
 
 ```yaml
 version: 1.0
-strategy: startup
 processes:
   -
     name: go

data/lib/nonnative/configuration.rb

@@ -3,29 +3,21 @@
 module Nonnative
   class Configuration
     def initialize
-      @strategy = Strategy.new
       @processes = []
       @servers = []
       @services = []
     end
 
     attr_accessor :processes, :servers, :services
-    attr_reader :strategy
 
     def load_file(path)
       file = YAML.load_file(path)
 
-      self.strategy = file['strategy']
-
       add_processes(file)
       add_servers(file)
       add_services(file)
     end
 
-    def strategy=(value)
-      @strategy = Strategy.new(value)
-    end
-
     def process
       process = Nonnative::ConfigurationProcess.new
       yield process

data/lib/nonnative/cucumber.rb

@@ -2,10 +2,22 @@
 
 World(RSpec::Benchmark::Matchers)
 
+Before('@startup') do
+  Nonnative.start
+end
+
+After('@startup') do
+  Nonnative.stop
+end
+
 After('@manual') do
   Nonnative.stop
 end
 
+Before('@clear') do
+  Nonnative.clear
+end
+
 Given('I set the proxy for process {string} to {string}') do |name, operation|
   process = Nonnative.pool.process_by_name(name)
   process.proxy.send(operation)

data/lib/nonnative/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nonnative
-  VERSION = '1.59.1'
+  VERSION = '1.60.0'
 end

data/lib/nonnative.rb

@@ -47,7 +47,6 @@ require 'nonnative/close_all_socket_pair'
 require 'nonnative/delay_socket_pair'
 require 'nonnative/invalid_data_socket_pair'
 require 'nonnative/socket_pair_factory'
-require 'nonnative/strategy'
 require 'nonnative/go_command'
 require 'nonnative/cucumber'
 
@@ -69,8 +68,6 @@ module Nonnative
 
     def configure
       yield configuration
-
-      require "nonnative/#{configuration.strategy}"
     end
 
     def start

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nonnative
 version: !ruby/object:Gem::Version
-  version: 1.59.1
+  version: 1.60.0
 platform: ruby
 authors:
 - Alejandro Falkowski
@@ -245,7 +245,6 @@ files:
 - bin/console
 - bin/setup
 - lib/nonnative.rb
-- lib/nonnative/before.rb
 - lib/nonnative/close_all_socket_pair.rb
 - lib/nonnative/configuration.rb
 - lib/nonnative/configuration_process.rb
@@ -262,7 +261,6 @@ files:
 - lib/nonnative/http_client.rb
 - lib/nonnative/http_server.rb
 - lib/nonnative/invalid_data_socket_pair.rb
-- lib/nonnative/manual.rb
 - lib/nonnative/no_proxy.rb
 - lib/nonnative/not_found_error.rb
 - lib/nonnative/observability.rb
@@ -279,7 +277,6 @@ files:
 - lib/nonnative/start_error.rb
 - lib/nonnative/startup.rb
 - lib/nonnative/stop_error.rb
-- lib/nonnative/strategy.rb
 - lib/nonnative/timeout.rb
 - lib/nonnative/version.rb
 - nonnative.gemspec

data/lib/nonnative/before.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-Before do
-  Nonnative.start
-end
-
-After do
-  Nonnative.stop
-end

data/lib/nonnative/manual.rb

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-# Do nothing as it's manual

data/lib/nonnative/strategy.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module Nonnative
-  class Strategy
-    def initialize(strategy = 'before', timeout = 5)
-      @strategy = strategy
-      @timeout = timeout
-    end
-
-    def timeout
-      (env_timeout || @timeout).to_i
-    end
-
-    def to_s
-      (env_strategy || @strategy).to_s
-    end
-
-    private
-
-    def env_strategy
-      @env_strategy ||= ENV.fetch('NONNATIVE_STRATEGY', nil)
-    end
-
-    def env_timeout
-      @env_timeout ||= ENV.fetch('NONNATIVE_TIMEOUT', nil)
-    end
-  end
-end