non_printable_sanitization 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d65ef0806319671ff574e1b01b23482d4b061f2b
-  data.tar.gz: f80f508f1c7ce55c0e2bc37d7c9d6d8a0afddaf2
+  metadata.gz: 1e788de9464ae1da90ea6bbd9450ff2f53ed01c5
+  data.tar.gz: 4bd7f0057d26a3ad9096ea864cef9558d2ad6a16
 SHA512:
-  metadata.gz: 036832a873f736556e32b1897eff765e91ef5f2556b72683d56c3f75e73e4da39dc36615c279f59d045d534e91291436bec17d6402132bebbd2c18fd237dbcee
-  data.tar.gz: 5d824e55c4319e99a120cb3cf76f80b0adf094772dde7811e8e3d67b58950a3fc8f9fb07526909c08c2da8e5320745a55ccf63638499527a0e408e2395cd7240
+  metadata.gz: bcff60eb6beefb429e2329d9c7c073ac46530eeac737ed3feff345b8b76c07bd7f2a421f3d2f627e10f8d33110f26292546266ed66b2b98b275609153fbcfd01
+  data.tar.gz: 76b355402a41efd0fa1d4d0e4cd84c78e392ac8cf81961aa67ae2df7b5f32bcb292b50ccf102b1ea260ace4fab3ab92516c6568318329b0c89084d126ba69e37

data/lib/non_printable_sanitization.rb

@@ -5,6 +5,10 @@ require 'uri'
 require "non_printable_sanitization/version"
 
 class NonPrintableSanitization
+  def self.skip_paths
+    @skip_paths ||= []
+  end
+
   def initialize(app, options = {})
     @app = app
     @options = options
@@ -13,10 +17,12 @@ class NonPrintableSanitization
   def call(env)
     request = ::Rack::Request.new(env)
 
-    if request.content_length.to_i > 0 # check we even have data
-      if !request.get? && !request.delete? # make sure it's not a GET/DELETE request
-        unless request_is_file_upload?(env) # make sure we don't want binary data
-          remove_non_printable_characters!(env)
+    unless skip_path?(env)
+      if request.content_length.to_i > 0 # check we even have data
+        if !request.get? && !request.delete? # make sure it's not a GET/DELETE request
+          unless request_is_file_upload?(env) # make sure we don't want binary data
+            remove_non_printable_characters!(env)
+          end
         end
       end
     end
@@ -49,4 +55,9 @@ class NonPrintableSanitization
     content_type = env["CONTENT_TYPE"] || "none"
     content_type.downcase.include?("form-data")
   end
+
+  def skip_path?(env)
+    path_info = env['PATH_INFO'] || ""
+    ::NonPrintableSanitization.skip_paths.any? { |skip_path| path_info =~ skip_path }
+  end
 end

data/lib/non_printable_sanitization/version.rb

@@ -1,3 +1,3 @@
 class NonPrintableSanitization
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/non_printable_sanitization_spec.rb

@@ -24,8 +24,12 @@ describe ::NonPrintableSanitization do
 
   context "when called with a binary body POST request" do
     let(:request) { Rack::MockRequest.new(start_app) }
+    let(:path) { "/some/path" }
+
     before(:each) do
-      request.post("/some/path", :input => post_data, "CONTENT_TYPE" => content_type)
+      ::NonPrintableSanitization.skip_paths << /skippable/i
+      request.post(path, :input => post_data, "CONTENT_TYPE" => content_type)
+      ::NonPrintableSanitization.skip_paths.clear
     end
 
     context "with text/plain content" do
@@ -46,6 +50,18 @@ describe ::NonPrintableSanitization do
       end
     end
 
+    context "when path is skipped" do
+      context "with text/plain content" do
+        let(:path) { "/skippable" }
+        let(:post_data) { "derp derp derp\0" }
+        let(:content_type) { "text/plain" }
+
+        it "skips sanitize of the non-printable \0" do
+          expect(app.request_body).to eq(post_data)
+        end
+      end
+    end
+
     context "with multipart/form-data content" do
       let(:post_data) { "derp derp derp\0" }
       let(:content_type) { "multipart/form-data" }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: non_printable_sanitization
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Brandon Dewitt