nokogiri 1.10.8 → 1.10.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9fbdbd925466e95e61566b1a8764889f23c596c3bda5ea28feed0acf85c6b99
-  data.tar.gz: 2060b7113b6bcfb7176b99d2d14b2e2dbdc19e198fd1185728d04272a13340cc
+  metadata.gz: 3d1d5c9d95d1e0a6a38567773f0d2e757cf47f8a2682f075378b72c9f6df0630
+  data.tar.gz: beb788ad86795af43d5e071e0be74264b0964d47c4fb675edd09680780e05f8a
 SHA512:
-  metadata.gz: e2a54877f2be89ec80f5cde2cbccdc92afb8f5dbd9f2ead7663d06094945d0a38652b4d57d22c9697801eac893f4e9e40899e23b8673cbb53e8c85e644ac4529
-  data.tar.gz: e1dc94dcf380e5884c2a941a7b49f1c70e8b93a371aabc20fbdfa460d4f585c7a0ad12bc2216c648bd440b01cc597a72f4a30c5e98c0425daa0cf890047833a2
+  metadata.gz: f55b5734fbecbbf37fca001abe0295512508164b343719cdec50d00773c811c1ec881680587eef70aa4bd9ec12d9e8f07f35e214a2991a7785ba9e58ad182f08
+  data.tar.gz: ce4602dca04823b0f80592285f7c2d24489b1fd04df7368f25d0466d0c5b22940c5afbad4e9640c97221caae74ce385e53f03e1ae23269a3b42af1861c34fb25

data/ext/nokogiri/xml_schema.c

@@ -133,6 +133,31 @@ static VALUE read_memory(VALUE klass, VALUE content)
   return rb_schema;
 }
 
+/* Schema creation will remove and deallocate "blank" nodes.
+ * If those blank nodes have been exposed to Ruby, they could get freed
+ * out from under the VALUE pointer.  This function checks to see if any of
+ * those nodes have been exposed to Ruby, and if so we should raise an exception.
+ */
+static int has_blank_nodes_p(VALUE cache)
+{
+    long i;
+
+    if (NIL_P(cache)) {
+        return 0;
+    }
+
+    for (i = 0; i < RARRAY_LEN(cache); i++) {
+        xmlNodePtr node;
+        VALUE element = rb_ary_entry(cache, i);
+        Data_Get_Struct(element, xmlNode, node);
+        if (xmlIsBlankNode(node)) {
+            return 1;
+        }
+    }
+
+    return 0;
+}
+
 /*
  * call-seq:
  *  from_document(doc)
@@ -152,6 +177,10 @@ static VALUE from_document(VALUE klass, VALUE document)
   /* In case someone passes us a node. ugh. */
   doc = doc->doc;
 
+  if (has_blank_nodes_p(DOC_NODE_CACHE(doc))) {
+    rb_raise(rb_eArgError, "Creating a schema from a document that has blank nodes exposed to Ruby is dangerous");
+  }
+
   ctx = xmlSchemaNewDocParserCtxt(doc);
 
   errors = rb_ary_new();

data/lib/nokogiri/version.rb

@@ -1,6 +1,6 @@
 module Nokogiri
   # The version of Nokogiri you are using
-  VERSION = "1.10.8"
+  VERSION = "1.10.9"
 
   class VersionInfo # :nodoc:
     def jruby?

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nokogiri
 version: !ruby/object:Gem::Version
-  version: 1.10.8
+  version: 1.10.9
 platform: ruby
 authors:
 - Aaron Patterson
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-10 00:00:00.000000000 Z
+date: 2020-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mini_portile2