nokogiri-happymapper 0.5.4 → 0.5.5

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.5.5 / 2012-09-30
+
+* Fix for Boolean attributes to ensure that they parse correctly (zrob)
+
 ## 0.5.4/ 2012-09-25
 
 * #wrap method allows you to better model xml content that is buried deep

data/lib/happymapper.rb

@@ -7,7 +7,7 @@ class XmlContent; end
 
 module HappyMapper
 
-  VERSION = "0.5.4"
+  VERSION = "0.5.5"
 
   DEFAULT_NS = "happymapper"
 
@@ -479,7 +479,7 @@ module HappyMapper
         # Attributes that have a nil value should be ignored unless they explicitly
         # state that they should be expressed in the output.
         #
-        if value || attribute.options[:state_when_nil]
+        if not value.nil? || attribute.options[:state_when_nil]
           attribute_namespace = attribute.options[:namespace] || default_namespace
           [ "#{attribute_namespace ? "#{attribute_namespace}:" : ""}#{attribute.tag}", value ]
         else

data/spec/happymapper_to_xml_spec.rb

@@ -53,6 +53,8 @@ module ToXML
     # Class composition
     #
     element :country, 'Country', :tag => 'country'
+    
+    attribute :occupied, Boolean
 
     def initialize(parameters)
       parameters.each_pair do |property,value|
@@ -110,7 +112,8 @@ module ToXML
         'city' => 'Seattle',
         'country' => Country.new(:name => 'USA', :code => 'us', :empty_code => nil, 
           :description => Country::Description.new("A lovely country") ),
-        'date_created' => '2011-01-01 15:00:00')
+        'date_created' => '2011-01-01 15:00:00',
+        'occupied' => false)
         
         
         address.dates_updated = ["2011-01-01 16:01:00","2011-01-02 11:30:01"]
@@ -144,6 +147,10 @@ module ToXML
         @address_xml.xpath("@modified").should be_empty
       end
       
+      it 'should save attributes that are Boolean and have a value of false' do
+        @address_xml.xpath('@occupied').text.should == "false"
+      end
+      
       context "state_when_nil option" do
       
         it "should save an empty element" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nokogiri-happymapper
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.5.5
   prerelease: 
 platform: ruby
 authors:
@@ -106,12 +106,9 @@ files:
 - spec/xpath_spec.rb
 homepage: http://github.com/dam5s/happymapper
 licenses: []
-post_install_message: ! "\n  Thank you for installing nokogiri-happymapper 0.5.4 /
-  2012-09-25.\n  \n  Changes:\n    \n  * #wrap method allows you to better model xml
-  content that is buried deep\n    within the xml. This implementation addresses issues
-  with calling #to_xml\n    with content that was parsed from an xpath. (zrob)\n  \n
-  \ * Parent HappyMapper classes may dictate the name of the tag for the child\n    HappyMapper
-  instances. (zrob)\n  \n\n\n"
+post_install_message: ! "\n  Thank you for installing nokogiri-happymapper 0.5.5 /
+  2012-09-30.\n  \n  Changes:\n    \n  * Fix for Boolean attributes to ensure that
+  they parse correctly (zrob)\n  \n\n\n"
 rdoc_options: []
 require_paths:
 - lib