noiseless 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 191caa0c33ef498748dcff326328dbd5e02b7f3a225ef1999b91127edb23490b
-  data.tar.gz: 3260bb7ca298d9b3ccdfb9e89a5a6e89759dbe56e2637b811439653cef4f9673
+  metadata.gz: 1d1df760c71373680498360fa0daef2cfc6a2dd42b08c7edd67f1027174958a5
+  data.tar.gz: bd720e1daa952b0c64c769a1f2927d5dd9083a5c3722c97c71fc644ab47f0670
 SHA512:
-  metadata.gz: eff7ee517dd4bea214b4602231baf34e518fc01546f3fe47f8b759aa75efb889aa6113bca2de56031b5ebf01ac893099217be4f5afc7af7c0802bf8686759601
-  data.tar.gz: f0cd3e05dafd3b3a86a7d6a278eac89a5230dbd859674fe209264e8b033a8ec75640a44d969ec1cf945e3ad414fa4137b9816871f1c05e9e30d1e6eb9957d6c9
+  metadata.gz: 1802b68562f768b1eee9c5533d26f9a5f387cc8d3052f27474809f889ea142bc8d6903ca4c60c56cfae2989c6e5e36def0abcac0f205d8fe6e86f1a4d87bd979
+  data.tar.gz: 8fad323b3284af9d96d9609dac487fa2980310d3470b074d0d135b2fbc09eef80d294f9369ae3836ec9fa6b0b7d515ed6cf1c7724e88ab55729a0e66ac1ae11d

data/lib/noiseless/adapter.rb

@@ -359,8 +359,8 @@ module Noiseless
     end
 
     def build_aggregations_hash(aggregations)
-      aggregations.each_with_object({}) do |agg, hash|
-        hash[agg.name] = build_single_aggregation(agg)
+      aggregations.to_h do |agg|
+        [agg.name, build_single_aggregation(agg)]
       end
     end
 

data/lib/noiseless/adapters/execution_modules/http_transport.rb

@@ -30,11 +30,27 @@ module Noiseless
         # +timeout:+.
         DEFAULT_TIMEOUT = 5
 
-        def initialize(hosts: [], timeout: DEFAULT_TIMEOUT, **connection_params)
+        # Default wall-clock deadline (seconds) for a complete round-trip:
+        # request write, response headers, and full body. The idle timeout
+        # above never trips against a backend that keeps trickling bytes —
+        # each read makes "progress" — which leaves callers blocked in
+        # Sync { ... .wait } indefinitely. This caps total duration instead.
+        # Override per-connection with +request_timeout:+; nil disables the
+        # deadline (long bulk imports may need a higher value or nil).
+        DEFAULT_REQUEST_TIMEOUT = 30
+
+        BufferedResponse = Struct.new(:status, :body) do
+          def read = body
+          def success? = (200..299).cover?(status)
+          def close = nil
+        end
+
+        def initialize(hosts: [], timeout: DEFAULT_TIMEOUT, request_timeout: DEFAULT_REQUEST_TIMEOUT, **connection_params)
           # Ensure we always have at least one host
           hosts_array = Array(hosts)
           @hosts = hosts_array.empty? ? ["http://localhost:#{default_port}"] : hosts_array
           @timeout = timeout
+          @request_timeout = request_timeout
           @connection_params = connection_params
 
           # Initialize HTTP clients for each host. The endpoint timeout makes a
@@ -95,7 +111,27 @@ module Noiseless
           host = @hosts.sample
           client = @clients[host]
 
-          wrap_transport_errors(host: host) { yield(client) }
+          wrap_transport_errors(host: host) do
+            with_request_deadline(host: host) do
+              buffer_response(yield(client))
+            end
+          end
+        end
+
+        def with_request_deadline(host:, &)
+          task = @request_timeout && Async::Task.current?
+          return yield unless task
+
+          task.with_timeout(@request_timeout, &)
+        rescue Async::TimeoutError
+          raise Noiseless::ConnectionError,
+                "search backend at #{host} exceeded request_timeout (#{@request_timeout}s wall-clock)"
+        end
+
+        def buffer_response(response)
+          BufferedResponse.new(response.status, response.read)
+        ensure
+          response.close
         end
 
         def parse_json_response!(response, error_class: Noiseless::RequestError, context: nil)

data/lib/noiseless/adapters/execution_modules/typesense_execution.rb

@@ -402,7 +402,7 @@ module Noiseless
           headers
         end
 
-        # rubocop:disable Lint/DuplicateBranch
+        # rubocop:disable-next Lint/DuplicateBranch
         def map_type_to_typesense(elasticsearch_type)
           # Map Elasticsearch types to Typesense types
           case elasticsearch_type
@@ -418,7 +418,6 @@ module Noiseless
             "string" # Default to string for unknown types
           end
         end
-        # rubocop:enable Lint/DuplicateBranch
       end
     end
   end

data/lib/noiseless/connection_manager.rb

@@ -7,9 +7,10 @@ module Noiseless
       @configs = {}
     end
 
-    # Register a named client statically from YAML (boot-time only)
-    def register(name, adapter:, hosts:, timeout: nil)
-      @configs[name.to_sym] = { adapter: adapter, hosts: hosts, timeout: timeout }
+    # Register a named client statically from YAML (boot-time only).
+    # request_timeout: :default uses the adapter default, nil disables the deadline.
+    def register(name, adapter:, hosts:, timeout: nil, request_timeout: :default)
+      @configs[name.to_sym] = { adapter: adapter, hosts: hosts, timeout: timeout, request_timeout: request_timeout }
     end
 
     # Retrieve a client; defaults to :primary
@@ -21,6 +22,7 @@ module Noiseless
         config = @configs.fetch(name) { raise "Unknown connection: #{name}" }
         params = { hosts: config[:hosts] }
         params[:timeout] = config[:timeout] unless config[:timeout].nil?
+        params[:request_timeout] = config[:request_timeout] unless config[:request_timeout] == :default
         Adapters.lookup(config[:adapter], **params)
       end
     end

data/lib/noiseless/query_builder.rb

@@ -221,13 +221,13 @@ module Noiseless
     end
 
     def to_ast
-      filter_nodes = @nodes.select { |n| n.is_a?(AST::Filter) }
-      vector_nodes = @nodes.select { |n| n.is_a?(AST::Vector) }
+      filter_nodes = @nodes.grep(AST::Filter)
+      vector_nodes = @nodes.grep(AST::Vector)
       must_nodes = @nodes.reject do |n|
         n.is_a?(AST::Filter) || n.is_a?(AST::Sort) || n.is_a?(AST::Paginate) || n.is_a?(AST::Vector)
       end
       bool_node = AST::Bool.new(must: must_nodes, filter: filter_nodes)
-      sort_nodes     = @nodes.select { |n| n.is_a?(AST::Sort) }
+      sort_nodes     = @nodes.grep(AST::Sort)
       paginate_node  = @nodes.find { |n| n.is_a?(AST::Paginate) }
       AST::Root.new(
         indexes: @indexes,

data/lib/noiseless/response/empty.rb

@@ -13,7 +13,7 @@ module Noiseless
       end
 
       def each
-        return enum_for(__method__) unless block_given?
+        enum_for(__method__) unless block_given?
       end
     end
   end

data/lib/noiseless/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Noiseless
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/lib/noiseless.rb

@@ -98,7 +98,9 @@ module Noiseless
     config.connections_config.each do |name, params|
       adapter_name = params[:adapter]
       hosts = params[:hosts] || []
-      connections.register(name, adapter: adapter_name, hosts: hosts, timeout: params[:timeout])
+      register_params = { adapter: adapter_name, hosts: hosts, timeout: params[:timeout] }
+      register_params[:request_timeout] = params[:request_timeout] if params.key?(:request_timeout)
+      connections.register(name, **register_params)
     end
   end
 

data/lib/tasks/release.rake

@@ -11,9 +11,7 @@ namespace :release do
     version_path = File.expand_path("../../lib/noiseless/version", __dir__)
     require version_path
 
-    if spec.version.to_s != Noiseless::VERSION
-      raise "Version mismatch: gemspec=#{spec.version} lib=#{Noiseless::VERSION}"
-    end
+    raise "Version mismatch: gemspec=#{spec.version} lib=#{Noiseless::VERSION}" if spec.version.to_s != Noiseless::VERSION
 
     ruby = Shellwords.escape(RbConfig.ruby)
     sh "#{ruby} -Ilib -e 'require \"noiseless\"; abort(\"version mismatch\") unless Noiseless::VERSION == \"#{Noiseless::VERSION}\"'"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: noiseless
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Abdelkader Boudih
@@ -29,42 +29,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.20'
+        version: '2.45'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.20'
+        version: '2.45'
 - !ruby/object:Gem::Dependency
   name: async-http
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.103'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.103'
 - !ruby/object:Gem::Dependency
   name: async-pool
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -85,14 +85,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: async-safe
   requirement: !ruby/object:Gem::Requirement
@@ -109,6 +109,20 @@ dependencies:
         version: '0.5'
 - !ruby/object:Gem::Dependency
   name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+- !ruby/object:Gem::Dependency
+  name: minitest-mock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"