noid-rails 3.0.3 → 3.1.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.circleci/config.yml +40 -42
- data/CONTRIBUTING.md +21 -12
- data/README.md +21 -5
- data/lib/noid/rails/version.rb +1 -1
- data/noid-rails.gemspec +3 -3
- metadata +12 -12
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 2cbea20da5c324c2711c1870026241c59bfc873685b4e96696364e16fadd2a19
|
|
4
|
+
data.tar.gz: 887c02907ba46a5c7b9a9c349d61ad3afd4507b6b0c0cceb9118994b5f48286c
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: e5e4879180742e94910422d58283f90ede3c1bf726c361bbfaf02ceceb6bebfc95175e20d19530e751f73d60d5150d4eb5e7896d85bb40ddc7c77459f4b2fb0e
|
|
7
|
+
data.tar.gz: 91bfe3889556af3dd53e7fc18a94712fd49b060b69741ea0da03e0b84d9418becf2e9d1ba169ea0d793cedb6d7f98c3a06994f9a7bbdfd078d6cf64522323f5c
|
data/.circleci/config.yml
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
version: 2.1
|
|
2
2
|
orbs:
|
|
3
|
-
samvera: samvera/circleci-orb@0
|
|
3
|
+
samvera: samvera/circleci-orb@1.0
|
|
4
4
|
jobs:
|
|
5
5
|
bundle_and_test:
|
|
6
6
|
parameters:
|
|
@@ -8,7 +8,7 @@ jobs:
|
|
|
8
8
|
type: string
|
|
9
9
|
bundler_version:
|
|
10
10
|
type: string
|
|
11
|
-
default:
|
|
11
|
+
default: 2.4.3
|
|
12
12
|
rails_version:
|
|
13
13
|
type: string
|
|
14
14
|
executor:
|
|
@@ -21,6 +21,19 @@ jobs:
|
|
|
21
21
|
steps:
|
|
22
22
|
- samvera/cached_checkout
|
|
23
23
|
|
|
24
|
+
- run:
|
|
25
|
+
name: Check for a branch named 'master'
|
|
26
|
+
command: |
|
|
27
|
+
git fetch --all --quiet --prune --prune-tags
|
|
28
|
+
if [[ -n "$(git branch --all --list master */master)" ]]; then
|
|
29
|
+
echo "A branch named 'master' was found. Please remove it."
|
|
30
|
+
echo "$(git branch --all --list master */master)"
|
|
31
|
+
fi
|
|
32
|
+
[[ -z "$(git branch --all --list master */master)" ]]
|
|
33
|
+
|
|
34
|
+
- run: 'sudo apt-get update'
|
|
35
|
+
- run: 'sudo apt-get install -y libsqlite3-dev'
|
|
36
|
+
|
|
24
37
|
- samvera/bundle_for_gem:
|
|
25
38
|
ruby_version: << parameters.ruby_version >>
|
|
26
39
|
bundler_version: << parameters.bundler_version >>
|
|
@@ -42,53 +55,38 @@ workflows:
|
|
|
42
55
|
ci:
|
|
43
56
|
jobs:
|
|
44
57
|
- bundle_and_test:
|
|
45
|
-
name:
|
|
46
|
-
ruby_version: 2.
|
|
47
|
-
rails_version:
|
|
48
|
-
|
|
49
|
-
name: ruby2-7_rails6-0
|
|
50
|
-
ruby_version: 2.7.1
|
|
51
|
-
rails_version: 6.0.3.1
|
|
58
|
+
name: ruby3-2_rails7-0
|
|
59
|
+
ruby_version: 3.2.0
|
|
60
|
+
rails_version: 7.0.4
|
|
61
|
+
|
|
52
62
|
- bundle_and_test:
|
|
53
|
-
name:
|
|
54
|
-
ruby_version:
|
|
55
|
-
rails_version:
|
|
63
|
+
name: ruby3-1_rails7-0
|
|
64
|
+
ruby_version: 3.1.3
|
|
65
|
+
rails_version: 7.0.4
|
|
56
66
|
|
|
57
67
|
- bundle_and_test:
|
|
58
|
-
name:
|
|
59
|
-
ruby_version:
|
|
60
|
-
rails_version:
|
|
68
|
+
name: ruby3-0_rails7-0
|
|
69
|
+
ruby_version: 3.0.5
|
|
70
|
+
rails_version: 7.0.4
|
|
61
71
|
- bundle_and_test:
|
|
62
|
-
name:
|
|
63
|
-
ruby_version:
|
|
64
|
-
rails_version: 6.
|
|
72
|
+
name: ruby3-0_rails6-1
|
|
73
|
+
ruby_version: 3.0.5
|
|
74
|
+
rails_version: 6.1.7
|
|
65
75
|
- bundle_and_test:
|
|
66
|
-
name:
|
|
67
|
-
ruby_version:
|
|
68
|
-
rails_version:
|
|
76
|
+
name: ruby3-0_rails6-0
|
|
77
|
+
ruby_version: 3.0.5
|
|
78
|
+
rails_version: 6.0.6
|
|
69
79
|
|
|
70
80
|
- bundle_and_test:
|
|
71
|
-
name: ruby2-
|
|
72
|
-
ruby_version: 2.
|
|
73
|
-
rails_version: 6.1.
|
|
74
|
-
- bundle_and_test:
|
|
75
|
-
name: ruby2-5_rails6-0
|
|
76
|
-
ruby_version: 2.5.8
|
|
77
|
-
rails_version: 6.0.3.1
|
|
81
|
+
name: ruby2-7_rails6-1
|
|
82
|
+
ruby_version: 2.7.7
|
|
83
|
+
rails_version: 6.1.7
|
|
78
84
|
- bundle_and_test:
|
|
79
|
-
name: ruby2-
|
|
80
|
-
ruby_version: 2.
|
|
81
|
-
rails_version:
|
|
85
|
+
name: ruby2-7_rails6-0
|
|
86
|
+
ruby_version: 2.7.7
|
|
87
|
+
rails_version: 6.0.6
|
|
82
88
|
- bundle_and_test:
|
|
83
|
-
name: ruby2-
|
|
84
|
-
ruby_version: 2.
|
|
85
|
-
rails_version: 5.1
|
|
89
|
+
name: ruby2-7_rails5-2
|
|
90
|
+
ruby_version: 2.7.7
|
|
91
|
+
rails_version: 5.2.8.1
|
|
86
92
|
|
|
87
|
-
- bundle_and_test:
|
|
88
|
-
name: ruby2-4_rails5-2
|
|
89
|
-
ruby_version: 2.4.10
|
|
90
|
-
rails_version: 5.2.4.3
|
|
91
|
-
- bundle_and_test:
|
|
92
|
-
name: ruby2-4_rails5-1
|
|
93
|
-
ruby_version: 2.4.10
|
|
94
|
-
rails_version: 5.1.7
|
data/CONTRIBUTING.md
CHANGED
|
@@ -67,15 +67,22 @@ further details.
|
|
|
67
67
|
|
|
68
68
|
* Fork the repository on GitHub
|
|
69
69
|
* Create a topic branch from where you want to base your work.
|
|
70
|
-
* This is usually the
|
|
71
|
-
* To quickly create a topic branch based on
|
|
72
|
-
* Then checkout the new branch with `git checkout fix/
|
|
73
|
-
* Please avoid working directly on the `
|
|
70
|
+
* This is usually the `main` branch.
|
|
71
|
+
* To quickly create a topic branch based on `main`; `git branch fix/main/my_contribution main`
|
|
72
|
+
* Then checkout the new branch with `git checkout fix/main/my_contribution`.
|
|
73
|
+
* Please avoid working directly on the `main` branch.
|
|
74
|
+
* Please do not create a branch called `master`. (See note below.)
|
|
74
75
|
* You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
|
|
75
76
|
* Make sure you have added sufficient tests and documentation for your changes.
|
|
76
77
|
* Test functionality with RSpec; Test features / UI with Capybara.
|
|
77
78
|
* Run _all_ the tests to assure nothing else was accidentally broken.
|
|
78
79
|
|
|
80
|
+
NOTE: This repository follows the [Samvera Community Code of Conduct](https://samvera.atlassian.net/wiki/spaces/samvera/pages/405212316/Code+of+Conduct)
|
|
81
|
+
and [language recommendations](#language).
|
|
82
|
+
Please ***do not*** create a branch called `master` for this repository or as part of
|
|
83
|
+
your pull request; the branch will either need to be removed or renamed before it can
|
|
84
|
+
be considered for inclusion in the code base and history of this repository.
|
|
85
|
+
|
|
79
86
|
### Documenting Code
|
|
80
87
|
|
|
81
88
|
* All new public methods, modules, and classes should include inline documentation in [YARD](http://yardoc.org/).
|
|
@@ -131,15 +138,15 @@ further details.
|
|
|
131
138
|
### Submitting Changes
|
|
132
139
|
|
|
133
140
|
* Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
|
|
134
|
-
* Make sure your branch is up to date with its parent branch (i.e.
|
|
135
|
-
* `git checkout
|
|
141
|
+
* Make sure your branch is up to date with its parent branch (i.e. main)
|
|
142
|
+
* `git checkout main`
|
|
136
143
|
* `git pull --rebase`
|
|
137
144
|
* `git checkout <your-branch>`
|
|
138
|
-
* `git rebase
|
|
145
|
+
* `git rebase main`
|
|
139
146
|
* It is a good idea to run your tests again.
|
|
140
147
|
* If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
|
|
141
148
|
* [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
|
|
142
|
-
* `git rebase --interactive
|
|
149
|
+
* `git rebase --interactive main` ([See Github help](https://help.github.com/articles/interactive-rebase))
|
|
143
150
|
* Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
|
|
144
151
|
* Push your changes to a topic branch in your fork of the repository.
|
|
145
152
|
* Submit a pull request from your fork to the project.
|
|
@@ -149,12 +156,14 @@ further details.
|
|
|
149
156
|
We adopted [Github's Pull Request Review](https://help.github.com/articles/about-pull-request-reviews/) for our repositories.
|
|
150
157
|
Common checks that may occur in our repositories:
|
|
151
158
|
|
|
152
|
-
1.
|
|
153
|
-
2.
|
|
159
|
+
1. [CircleCI](https://circleci.com/gh/samvera) - where our automated tests are running
|
|
160
|
+
2. RuboCop/Bixby - where we check for style violations
|
|
161
|
+
3. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
|
|
162
|
+
4. CodeClimate - is our code remaining healthy (at least according to static code analysis)
|
|
154
163
|
|
|
155
164
|
If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
|
|
156
165
|
|
|
157
|
-
*Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (
|
|
166
|
+
*Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (CI tests are usually the culprit), so he does not merge the pull request. Eventually, all of the checks pass. At this point, Carolyn or anyone else may merge the pull request.*
|
|
158
167
|
|
|
159
168
|
#### Things to Consider When Reviewing
|
|
160
169
|
|
|
@@ -171,7 +180,7 @@ This is your chance for a mentoring moment of another developer. Take time to gi
|
|
|
171
180
|
* Do new or changed methods, modules, and classes have documentation?
|
|
172
181
|
* Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
|
|
173
182
|
* Does the description of the new/changed specs match your understanding of what the spec is doing?
|
|
174
|
-
* Did the
|
|
183
|
+
* Did the Continuous Integration tests complete successfully?
|
|
175
184
|
|
|
176
185
|
If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
|
|
177
186
|
|
data/README.md
CHANGED
|
@@ -1,10 +1,18 @@
|
|
|
1
1
|
# Noid::Rails
|
|
2
2
|
|
|
3
|
-
Code:
|
|
3
|
+
Code:
|
|
4
|
+
[](http://badge.fury.io/rb/noid-rails)
|
|
5
|
+
[](https://circleci.com/gh/samvera/noid-rails)
|
|
6
|
+
[](https://coveralls.io/github/samvera/noid-rails?branch=main)
|
|
7
|
+
[](https://codeclimate.com/github/samvera/noid-rails/maintainability)
|
|
4
8
|
|
|
5
|
-
Docs:
|
|
9
|
+
Docs:
|
|
10
|
+
[](./CONTRIBUTING.md)
|
|
11
|
+
[](./LICENSE)
|
|
12
|
+
[](http://rubydoc.info/gems/noid-rails)
|
|
13
|
+
[](https://inch-ci.org/github/samvera/noid-rails)
|
|
6
14
|
|
|
7
|
-
|
|
15
|
+
Community Support: [](http://slack.samvera.org/)
|
|
8
16
|
|
|
9
17
|
# What is noid-rails?
|
|
10
18
|
|
|
@@ -14,11 +22,13 @@ This gem mints identifiers for models in your Rails-based application with opaqu
|
|
|
14
22
|
|
|
15
23
|
## Product Owner & Maintenance
|
|
16
24
|
|
|
17
|
-
|
|
25
|
+
`noid-rails` was a Core Component of the Samvera Community. Given a decline in available labor required for maintenance, this project no longer has a dedicated Product Owner. The documentation for what this means can be found [here](http://samvera.github.io/core_components.html#requirements-for-a-core-component).
|
|
18
26
|
|
|
19
27
|
### Product Owner
|
|
20
28
|
|
|
21
|
-
|
|
29
|
+
**Vacant**
|
|
30
|
+
|
|
31
|
+
_Until a Product Owner has been identified, we ask that you please direct all requests for support, bug reports, and general questions to the [`#dev` Channel on the Samvera Slack](https://samvera.slack.com/app_redirect?channel=dev)._
|
|
22
32
|
|
|
23
33
|
## Table of Contents
|
|
24
34
|
|
|
@@ -219,6 +229,12 @@ end
|
|
|
219
229
|
|
|
220
230
|
And the service will delegate minting and validating to an instance of your customized minter class.
|
|
221
231
|
|
|
232
|
+
## Contributing
|
|
233
|
+
|
|
234
|
+
If you're working on PR for this project, create a feature branch off of `main`.
|
|
235
|
+
|
|
236
|
+
This repository follows the [Samvera Community Code of Conduct](https://samvera.atlassian.net/wiki/spaces/samvera/pages/405212316/Code+of+Conduct) and [language recommendations](https://github.com/samvera/maintenance/blob/master/templates/CONTRIBUTING.md#language). Please ***do not*** create a branch called `master` for this repository or as part of your pull request; the branch will either need to be removed or renamed before it can be considered for inclusion in the code base and history of this repository.
|
|
237
|
+
|
|
222
238
|
## Releasing
|
|
223
239
|
|
|
224
240
|
1. `bundle install`
|
data/lib/noid/rails/version.rb
CHANGED
data/noid-rails.gemspec
CHANGED
|
@@ -18,11 +18,11 @@ Gem::Specification.new do |spec|
|
|
|
18
18
|
spec.test_files = spec.files.grep(%r{^spec/})
|
|
19
19
|
spec.require_paths = ['lib']
|
|
20
20
|
|
|
21
|
-
spec.add_dependency 'actionpack', '>= 5.0.0', '< 7'
|
|
21
|
+
spec.add_dependency 'actionpack', '>= 5.0.0', '< 7.1'
|
|
22
22
|
spec.add_dependency 'noid', '~> 0.9'
|
|
23
23
|
|
|
24
|
-
spec.add_development_dependency 'bixby', '~>
|
|
25
|
-
spec.add_development_dependency 'bundler', '>= 1
|
|
24
|
+
spec.add_development_dependency 'bixby', '~> 5.0.0'
|
|
25
|
+
spec.add_development_dependency 'bundler', '>= 2.1'
|
|
26
26
|
spec.add_development_dependency 'engine_cart', '~> 2.2'
|
|
27
27
|
spec.add_development_dependency 'rake', '>= 11'
|
|
28
28
|
spec.add_development_dependency 'rspec', '~> 3.8'
|
metadata
CHANGED
|
@@ -1,14 +1,14 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: noid-rails
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 3.0
|
|
4
|
+
version: 3.1.0
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Michael J. Giarlo
|
|
8
|
-
autorequire:
|
|
8
|
+
autorequire:
|
|
9
9
|
bindir: bin
|
|
10
10
|
cert_chain: []
|
|
11
|
-
date:
|
|
11
|
+
date: 2023-01-13 00:00:00.000000000 Z
|
|
12
12
|
dependencies:
|
|
13
13
|
- !ruby/object:Gem::Dependency
|
|
14
14
|
name: actionpack
|
|
@@ -19,7 +19,7 @@ dependencies:
|
|
|
19
19
|
version: 5.0.0
|
|
20
20
|
- - "<"
|
|
21
21
|
- !ruby/object:Gem::Version
|
|
22
|
-
version: '7'
|
|
22
|
+
version: '7.1'
|
|
23
23
|
type: :runtime
|
|
24
24
|
prerelease: false
|
|
25
25
|
version_requirements: !ruby/object:Gem::Requirement
|
|
@@ -29,7 +29,7 @@ dependencies:
|
|
|
29
29
|
version: 5.0.0
|
|
30
30
|
- - "<"
|
|
31
31
|
- !ruby/object:Gem::Version
|
|
32
|
-
version: '7'
|
|
32
|
+
version: '7.1'
|
|
33
33
|
- !ruby/object:Gem::Dependency
|
|
34
34
|
name: noid
|
|
35
35
|
requirement: !ruby/object:Gem::Requirement
|
|
@@ -50,28 +50,28 @@ dependencies:
|
|
|
50
50
|
requirements:
|
|
51
51
|
- - "~>"
|
|
52
52
|
- !ruby/object:Gem::Version
|
|
53
|
-
version:
|
|
53
|
+
version: 5.0.0
|
|
54
54
|
type: :development
|
|
55
55
|
prerelease: false
|
|
56
56
|
version_requirements: !ruby/object:Gem::Requirement
|
|
57
57
|
requirements:
|
|
58
58
|
- - "~>"
|
|
59
59
|
- !ruby/object:Gem::Version
|
|
60
|
-
version:
|
|
60
|
+
version: 5.0.0
|
|
61
61
|
- !ruby/object:Gem::Dependency
|
|
62
62
|
name: bundler
|
|
63
63
|
requirement: !ruby/object:Gem::Requirement
|
|
64
64
|
requirements:
|
|
65
65
|
- - ">="
|
|
66
66
|
- !ruby/object:Gem::Version
|
|
67
|
-
version: '1
|
|
67
|
+
version: '2.1'
|
|
68
68
|
type: :development
|
|
69
69
|
prerelease: false
|
|
70
70
|
version_requirements: !ruby/object:Gem::Requirement
|
|
71
71
|
requirements:
|
|
72
72
|
- - ">="
|
|
73
73
|
- !ruby/object:Gem::Version
|
|
74
|
-
version: '1
|
|
74
|
+
version: '2.1'
|
|
75
75
|
- !ruby/object:Gem::Dependency
|
|
76
76
|
name: engine_cart
|
|
77
77
|
requirement: !ruby/object:Gem::Requirement
|
|
@@ -195,7 +195,7 @@ homepage: https://github.com/samvera/noid-rails
|
|
|
195
195
|
licenses:
|
|
196
196
|
- Apache2
|
|
197
197
|
metadata: {}
|
|
198
|
-
post_install_message:
|
|
198
|
+
post_install_message:
|
|
199
199
|
rdoc_options: []
|
|
200
200
|
require_paths:
|
|
201
201
|
- lib
|
|
@@ -210,8 +210,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
|
|
|
210
210
|
- !ruby/object:Gem::Version
|
|
211
211
|
version: '0'
|
|
212
212
|
requirements: []
|
|
213
|
-
rubygems_version: 3.
|
|
214
|
-
signing_key:
|
|
213
|
+
rubygems_version: 3.1.6
|
|
214
|
+
signing_key:
|
|
215
215
|
specification_version: 4
|
|
216
216
|
summary: Noid identifier services for Rails-based applications
|
|
217
217
|
test_files:
|