nobspw 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 50bde3af21d4ae1a914fdf29d97c7cd4636f9045d12053b19b03b10562432200
-  data.tar.gz: bb15b53c7660e771fd4d0d430be1882186d11515662d1ffe9f221478f4df0013
+  metadata.gz: a69bacd3f3f32acf44341c98cc21d7680a46638d6404b62e51ebe1ec09170a26
+  data.tar.gz: 84cf94ef83bad08505f3563f54fe3f1cebb8b87ef7583f26a47e525b2d6a2baf
 SHA512:
-  metadata.gz: f8688c43975ea97d01f0bb39d8213dd221f7e4ec1022cba7b068e079c7e6213a826dc36949b90582ca2e3e8a23b9f7e9388904357c2166deaf5ef614ea646f83
-  data.tar.gz: 1c2f2a8835ab93d53bcb187bc7eb86123280d2c831114a7c5f26822708ee44ac1d20ac41c797a8a9b0d57543a44a0de3c3bcb1104a6f4cbea2c8c4033e9db871
+  metadata.gz: a3b89294eb061d12bbce3d2e69554598993c84e61fd54e352a16cbaaf298df86d3755e05ab2acaa52d19525f4580d72db947dacbc34cbb17f3e215a8bd8f560b
+  data.tar.gz: 9c5d5c21fcf1dbdbbab22081e0cd263d5acd0949dc32216c5d2aae3d60e6aea65f0b16729b29ad4011d49ad7cb9a693c76deb70cbb4cefce7fd897da0774ed6e

data/README.md

@@ -70,7 +70,7 @@ Optionally, you can configure some options:
 I included `PasswordValidator` for Rails. Validating passwords in your model couldn't be easier:
 
 ```ruby
-validates :password, presence: true, password: true, if: -> { new_record? || changes[:password] }
+validates :password, presence: true, password: true, if: -> { new_record? || changes[:password] || changes[:password_digest] }
 ```
 
 PasswordValidator will try to guess the correct field name for each `PasswordChecker` argument as follow:
@@ -84,7 +84,7 @@ If you have field names different than above, you can tell `PasswordValidator` w
 ```ruby
 validates :password, password: { :name => :customer_name,
                                  :email => :electronic_address },
-          if: -> { new_record? || changes[:password] }
+          if: -> { new_record? || changes[:password] || changes[:password_digest] }
 ```
 
 ## Validations

data/lib/nobspw/password_checker.rb

@@ -1,3 +1,5 @@
+require 'shellwords'
+
 module NOBSPW
   class PasswordChecker
     include NOBSPW::ValidationMethods
@@ -37,7 +39,8 @@ module NOBSPW
     end
 
     def grep_command(path)
-      "#{NOBSPW.configuration.grep_path} '^#{@password}$' #{path}"
+      escaped_pw = Shellwords.escape(@password)
+      "#{NOBSPW.configuration.grep_path} '^#{escaped_pw}$' #{path}"
     end
   end
 end

data/lib/nobspw/version.rb

@@ -1,3 +1,3 @@
 module NOBSPW
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 end

data/misc/grep_benchmark.rb

@@ -0,0 +1,23 @@
+#! /usr/bin/env ruby
+
+require 'benchmark'
+require 'shellwords'
+
+password = 'swordfish'
+dictionary_path = File.join(File.dirname(__FILE__), '..', 'lib/db/dictionary.txt')
+
+def shell_grep(password, dictionary)
+  password = Shellwords.escape(password)
+	"/usr/bin/grep '^#{password}$' #{dictionary}"
+  $?.exitstatus == 0
+end
+
+Benchmark.bm do |benchmark|
+  benchmark.report("Ruby") do
+    25.times { File.open(dictionary_path).grep(/^#{password}$/) }
+  end
+
+  benchmark.report("Shell") do
+    25.times { shell_grep(password, dictionary_path) }
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nobspw
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Carl Mercier
@@ -189,6 +189,7 @@ files:
 - lib/nobspw/password_checker.rb
 - lib/nobspw/validation_methods.rb
 - lib/nobspw/version.rb
+- misc/grep_benchmark.rb
 - nobspw.gemspec
 homepage: https://github.com/cmer/nobspw
 licenses: