nintendo_eshop 0.1.0.alpha2 → 0.1.0.alpha3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c16722724063cfd735832cc6a1e058bbeb6023b87c6856421c7f20887eee90db
-  data.tar.gz: 6877920b5fd9c9a4dc4fbedeb12e6284212becb77c616631754eaedb306a64f4
+  metadata.gz: 9e94ec5b299a5682fbc2cbb5cd3657515dd88ddd20b6b1102da17bb9386d8149
+  data.tar.gz: ee16d11185eac66b1cf8c7ae802f6f971e41154bd83f14b10ed307c67938e9b8
 SHA512:
-  metadata.gz: fc2c84062048e4a562cc0809e805175c2cff2ba134ad1d213522859c849d694c9764bf41e3af74d1ac2796d3ed92562df96e0a278624ceceb101944c5b799431
-  data.tar.gz: cf726caaac49676c462818ea3f7b8facb51ae3e1968ccd27230ea546d1a3d4b469a4bb969f1a74838c846c6b9148ea62a0e70a48f44c25fcef7a08d794ef599e
+  metadata.gz: 1e87038f95f781ac0d4dabf85d57ba78d2e2570d4e7f39a7db8bf6f09e8531900ae0ff0c511ae09250b3fa26f4e2d8a6bc70bb969bed176d301c827ed15bbd97
+  data.tar.gz: 21747be84dda661be38463d61c8f0780fd2ac29dcdb405ce70b9ca966ec8a083555862864ba615f9bb4fb99cd7d4c9f64c804a6eee406bdca8d285cbc6d640c7

data/.rspec_status

@@ -1,5 +1,7 @@
-example_id                                | status | run_time        |
------------------------------------------ | ------ | --------------- |
-./spec/nintendo_eshop/game_spec.rb[1:1:1] | passed | 0.00568 seconds |
-./spec/nintendo_eshop/game_spec.rb[1:1:2] | passed | 0.0112 seconds  |
-./spec/nintendo_eshop_spec.rb[1:1]        | passed | 0.00086 seconds |
+example_id                                             | status | run_time        |
+------------------------------------------------------ | ------ | --------------- |
+./spec/acceptance/retrieve_a_valid_record_spec.rb[1:1] | passed | 0.11786 seconds |
+./spec/nintendo_eshop/game_spec.rb[1:1:1]              | passed | 0.00419 seconds |
+./spec/nintendo_eshop/game_spec.rb[1:1:2]              | passed | 0.00606 seconds |
+./spec/nintendo_eshop/game_spec.rb[1:1:3]              | passed | 0.00398 seconds |
+./spec/nintendo_eshop_spec.rb[1:1]                     | passed | 0.00083 seconds |

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nintendo_eshop (0.1.0.alpha2)
+    nintendo_eshop (0.1.0.alpha3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -62,6 +62,16 @@ game.title # "Sonic Forces"
 game.url # "/games/detail/sonic-forces-switch"
 ```
 
+## Errors
+
+Error handling is still a work in progress
+
+```ruby
+game = NintendoEshop::Game.retrieve("invalid id")
+
+# => NintendoEshop::InvalidRequestError
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -80,7 +90,14 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 CircleCi is used to push releases to rubygems.org
 
-To release, edit the version.rb file to the version you want to publish, commit that to your master branch, then create and push a git tag with the same name as your version:
+To release
+
+* Edit the version.rb file
+* `bundle`
+* Commit that to your master branch
+* Create and push a git tag with the same name as your version
+
+Example
 
 ```
 git tag -a 0.1.0

data/lib/nintendo_eshop/api_client.rb

@@ -0,0 +1,21 @@
+module NintendoEshop
+  class APIClient
+    class << self
+      def post(uri, json: {})
+        http = setup_http(uri)
+        req = Net::HTTP::Post.new(uri)
+        req.add_field "Accept", "application/json"
+        req.add_field "Content-Type", "application/json"
+        req.body = JSON.dump(json)
+        http.request(req)
+      end
+
+      def setup_http(uri)
+        http = Net::HTTP.new(uri.host, uri.port)
+        http.use_ssl = true
+        http.verify_mode = OpenSSL::SSL::VERIFY_PEER
+        http
+      end
+    end
+  end
+end

data/lib/nintendo_eshop/api_request.rb

@@ -7,26 +7,17 @@ module NintendoEshop
     def request(method, to_json: {})
       case method
       when :post
-        post(to_json: to_json)
+        post(json: to_json)
       end
     end
 
-    def post(to_json: {})
+    def post(json: {})
       uri = URI("#{NintendoEshop.base_url}#{self.class::RESOURCE_PATH}?#{url_params}")
-      http = setup_http(uri)
-      req = Net::HTTP::Post.new(uri)
-      req.add_field "Accept", "application/json"
-      req.add_field "Content-Type", "application/json"
-      req.body = JSON.dump(to_json)
-      res = http.request(req)
-      JSON.parse(res.body, symbolize_names: true)
-    end
+      response = NintendoEshop.client.post(uri, json: json)
+      parsed_response = JSON.parse(response.body, symbolize_names: true)
+      raise InvalidRequestError, "ID not found" if parsed_response.dig(:nbHits).zero?
 
-    def setup_http(uri)
-      http = Net::HTTP.new(uri.host, uri.port)
-      http.use_ssl = true
-      http.verify_mode = OpenSSL::SSL::VERIFY_PEER
-      http
+      parsed_response
     end
 
     def url_params

data/lib/nintendo_eshop/version.rb

@@ -1,3 +1,3 @@
 module NintendoEshop
-  VERSION = "0.1.0.alpha2".freeze
+  VERSION = "0.1.0.alpha3".freeze
 end

data/lib/nintendo_eshop.rb

@@ -4,6 +4,7 @@ rescue StandardError; end # rubocop:disable Lint/HandleExceptions
 require "json"
 require "net/http"
 
+require_relative "nintendo_eshop/api_client"
 require_relative "nintendo_eshop/api_request"
 require_relative "nintendo_eshop/game"
 require_relative "nintendo_eshop/version"
@@ -13,7 +14,14 @@ module NintendoEshop
     attr_accessor :api_key
     attr_accessor :app_id
     attr_accessor :base_url
+
+    attr_writer :client
+
+    def client
+      @client ||= NintendoEshop::APIClient
+    end
   end
 
   class Error < StandardError; end
+  class InvalidRequestError < Error; end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nintendo_eshop
 version: !ruby/object:Gem::Version
-  version: 0.1.0.alpha2
+  version: 0.1.0.alpha3
 platform: ruby
 authors:
 - Rick Peyton
@@ -189,6 +189,7 @@ files:
 - bin/console
 - bin/setup
 - lib/nintendo_eshop.rb
+- lib/nintendo_eshop/api_client.rb
 - lib/nintendo_eshop/api_request.rb
 - lib/nintendo_eshop/game.rb
 - lib/nintendo_eshop/version.rb